historiographer 1.3.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2d85a348f2e7196cccef533c9562b53c9449df6a0dde03509a1d48a5d66c490
-  data.tar.gz: f3b9f822e53fdadc04d20a0f4066b8b47e019c11333d9dccc0140ea1e9f12991
+  metadata.gz: e2c323e0b16003b066c298e281147b86e810ee0f2b7cc5bc859bfad1c861795b
+  data.tar.gz: 04b81492d7a2a24a8aa46935f64874f77521884dec9cd9aa2fd568785b399847
 SHA512:
-  metadata.gz: 5011fe73d7a09abd888f362b1e3923436c5f29068f9b46650ac4e39f09ab3226d7f2d66072293d9908dc37693a7afc5b73f73c2db2c1f6f1b0e9119c153c511b
-  data.tar.gz: ccca124547a124739d68183b9374ddd1b8fc452ed29b568da485981abb37cab8f055384065b00016981ea3844177c5e7e050d0fb6e5f8faef7844e5835387591
+  metadata.gz: 8716822fb73b440fedb427ea732d87e15a4ffb4bc3ca902bfa57e4cbf5e9303fbc6a25482eadcbc9d00830eede9664685db8d05b05438a5fe08c32fa79c8e3ee
+  data.tar.gz: 86ce1d84a483a5384aea9e0d043911edc0f1cb3f3bf6f970d1dccee22d3369a2ef6437f65e2de6e46f9df4ec68a76b189411805ba98cca4874b39513c1162b69

data/VERSION

@@ -1 +1 @@
-1.3.1
+1.4.0

data/historiographer.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: historiographer 1.3.1 ruby lib
+# stub: historiographer 1.4.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "historiographer".freeze
-  s.version = "1.3.1"
+  s.version = "1.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/lib/historiographer/relation.rb

@@ -15,35 +15,42 @@ module Historiographer
         super(updates)
       else
         updates.symbolize_keys!
+        model_changes = updates.except(:history_user_id)
 
         ActiveRecord::Base.transaction do
-          super(updates.except(:history_user_id))
-          now = UTC.now
-          records = self.reload
-          history_class = records.klass.history_class
-
-          records.new.send(:history_user_absent_action) if updates[:history_user_id].nil?
-          history_user_id = updates[:history_user_id]
-
-          new_histories = records.map do |record|
-            attrs         = record.attributes.clone
-            foreign_key   = history_class.history_foreign_key
-      
-            now = UTC.now
-            attrs.merge!(foreign_key => attrs["id"], history_started_at: now, history_user_id: history_user_id)
-      
-            attrs = attrs.except("id")
-
-            record.histories.build(attrs)
+          changed_records = select do |record|
+            !(record.attributes.symbolize_keys >= model_changes)
           end
 
-          current_histories = history_class.current.where("#{history_class.history_foreign_key} IN (?)", records.map(&:id))
+          super(model_changes)
+          bulk_record_history(self.reload.where(id: changed_records.pluck(:id)), updates)
+        end
+      end
+    end
 
-          current_histories.update_all(history_ended_at: now)
+    def bulk_record_history(records, updates = {})
+      now = UTC.now
+      history_class = self.klass.history_class
 
-          history_class.import new_histories
-        end
+      records.new.send(:history_user_absent_action) if updates[:history_user_id].nil?
+      history_user_id = updates[:history_user_id]
+
+      new_histories = records.map do |record|
+        attrs         = record.attributes.clone
+        foreign_key   = history_class.history_foreign_key
+  
+        attrs.merge!(foreign_key => attrs["id"], history_started_at: now, history_user_id: history_user_id)
+  
+        attrs = attrs.except("id")
+
+        record.histories.build(attrs)
       end
+
+      current_histories = history_class.current.where("#{history_class.history_foreign_key} IN (?)", records.map(&:id))
+
+      current_histories.update_all(history_ended_at: now)
+
+      history_class.import new_histories
     end
 
     def delete_all_without_history
@@ -91,4 +98,4 @@ module Historiographer
       records.each { |r| r.destroy(history_user_id: history_user_id) }.tap { reset }
     end
   end
-end
+end

data/spec/historiographer_spec.rb

@@ -164,9 +164,14 @@ describe Historiographer do
           expect(posts.second.current_history.title).to eq "My New Post Title"
           expect(posts.third.current_history.title).to eq "Brett's Post"
 
+          # It does not update histories if nothing changed
+          Post.all.update_all(title: "Brett's Post", history_user_id: 1)
+          posts = Post.all.reload.order(:id)
+          expect(posts.map(&:histories).map(&:count)).to all(eq 3)
+
           posts.update_all_without_history(title: "Untracked")
           expect(posts.first.histories.count).to eq 3
-          expect(posts.second.histories.count).to eq 2
+          expect(posts.second.histories.count).to eq 3
           expect(posts.third.histories.count).to eq 3
 
           thing1 = ThingWithoutHistory.create(name: "Thing 1")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: historiographer
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.0
 platform: ruby
 authors:
 - brettshollenberger