hipchat 0.2.2 → 0.3.0

data/Rakefile

@@ -11,7 +11,8 @@ begin
     gem.homepage = "http://github.com/david/hipchat"
     gem.authors = ["david"]
     gem.add_dependency "httparty"
-    gem.add_development_dependency "rspec", ">= 1.2.9"
+    gem.add_development_dependency "rspec", "~> 2.0"
+    gem.add_development_dependency "rr", "~> 1.0"
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
   end
   Jeweler::GemcutterTasks.new

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.3.0

data/hipchat.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{hipchat}
-  s.version = "0.2.2"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["david"]
-  s.date = %q{2011-06-11}
+  s.date = %q{2011-07-06}
   s.description = %q{Ruby library to interact with HipChat}
   s.email = %q{dgleal@gmail.com}
   s.extra_rdoc_files = [
@@ -41,14 +41,17 @@ Gem::Specification.new do |s|
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<httparty>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, [">= 1.2.9"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.0"])
+      s.add_development_dependency(%q<rr>, ["~> 1.0"])
     else
       s.add_dependency(%q<httparty>, [">= 0"])
-      s.add_dependency(%q<rspec>, [">= 1.2.9"])
+      s.add_dependency(%q<rspec>, ["~> 2.0"])
+      s.add_dependency(%q<rr>, ["~> 1.0"])
     end
   else
     s.add_dependency(%q<httparty>, [">= 0"])
-    s.add_dependency(%q<rspec>, [">= 1.2.9"])
+    s.add_dependency(%q<rspec>, ["~> 2.0"])
+    s.add_dependency(%q<rr>, ["~> 1.0"])
   end
 end
 

data/lib/hipchat.rb

@@ -2,10 +2,14 @@ require 'httparty'
 require 'ostruct'
 
 module HipChat
+  class UnknownRoom         < StandardError; end
+  class Unauthorized        < StandardError; end
+  class UnknownResponseCode < StandardError; end
+
   class Client
     include HTTParty
 
-    base_uri 'http://api.hipchat.com/v1/rooms'
+    base_uri 'https://api.hipchat.com/v1/rooms'
     format :json
 
     def initialize(token)
@@ -18,15 +22,14 @@ module HipChat
     end
 
     def [](name)
-      rooms.find { |r| r.name == name }
+      Room.new(@token, :room_id => name)
     end
   end
 
   class Room < OpenStruct
     include HTTParty
 
-    base_uri 'http://api.hipchat.com/v1/rooms'
-    format :json
+    base_uri 'https://api.hipchat.com/v1/rooms'
 
     def initialize(token, params)
       @token = token
@@ -35,14 +38,21 @@ module HipChat
     end
 
     def send(from, message, notify = false)
-      self.class.post('/message',
-           :query => { :auth_token => @token },
-           :body => {
-             :room_id => room_id,
-             :from => from,
-             :message => message,
-             :notify => notify ? 1 : 0
-           })
+      response = self.class.post('/message',
+                                 :query => { :auth_token => @token },
+                                 :body => {:room_id => room_id,
+                                           :from => from,
+                                           :message => message,
+                                           :notify => notify ? 1 : 0})
+
+      case response.code
+      when 200; # weee
+      when 404; raise UnknownRoom,  "Unknown room: `#{room_id}'"
+      when 401; raise Unauthorized, "Access denied to room `#{room_id}'"
+      else      raise UnknownResponseCode, "Unexpected #{response.code} for " <<
+                                           "room `#{room_id}'"
+
+      end
     end
   end
 end

data/spec/hipchat_spec.rb

@@ -1,7 +1,47 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe "Hipchat" do
-  it "fails" do
-    fail "hey buddy, you should probably rename this file and start specing for real"
+describe HipChat do
+  subject { HipChat::Client.new("blah") }
+
+  let(:room) { subject["Hipchat"] }
+
+  describe "sends a message to a room" do
+    it "successfully" do
+      mock(HipChat::Room).post("/message",
+                               :query => {:auth_token => "blah"},
+                               :body  => {:room_id => "Hipchat",
+                                          :from    => "Dude",
+                                          :message => "Hello world",
+                                          :notify  => 0}) {
+        OpenStruct.new(:code => 200)
+      }
+
+      room.send "Dude", "Hello world"
+    end
+
+    it "but fails when the room doesn't exist" do
+      mock(HipChat::Room).post(anything, anything) {
+        OpenStruct.new(:code => 404)
+      }
+
+      lambda { room.send "", "" }.should raise_error(HipChat::UnknownRoom)
+    end
+
+    it "but fails when we're not allowed to do so" do
+      mock(HipChat::Room).post(anything, anything) {
+        OpenStruct.new(:code => 401)
+      }
+
+      lambda { room.send "", "" }.should raise_error(HipChat::Unauthorized)
+    end
+
+    it "but fails if we get an unknown response code" do
+      mock(HipChat::Room).post(anything, anything) {
+        OpenStruct.new(:code => 403)
+      }
+
+      lambda { room.send "", "" }.
+        should raise_error(HipChat::UnknownResponseCode)
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,9 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'hipchat'
-require 'spec'
-require 'spec/autorun'
+require 'rspec'
+require 'rspec/autorun'
 
-Spec::Runner.configure do |config|
-  
+RSpec.configure do |config|
+  config.mock_with :rr
 end

metadata

@@ -5,9 +5,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 2
-  - 2
-  version: 0.2.2
+  - 3
+  - 0
+  version: 0.3.0
 platform: ruby
 authors: 
 - david
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-11 00:00:00 +01:00
+date: 2011-07-06 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -38,16 +38,30 @@ dependencies:
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 13
+        hash: 3
         segments: 
-        - 1
         - 2
-        - 9
-        version: 1.2.9
+        - 0
+        version: "2.0"
   type: :development
   version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: rr
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 15
+        segments: 
+        - 1
+        - 0
+        version: "1.0"
+  type: :development
+  version_requirements: *id003
 description: Ruby library to interact with HipChat
 email: dgleal@gmail.com
 executables: []