hikki 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b2946645f8620fbc6f5780dd8be60be4e4624cb1
-  data.tar.gz: e30ff8be81ff55d2edbe949dd7c4fb1ede094630
+  metadata.gz: 3bffa4f8ad357c4095b1b2919fe7ee3e63ec4040
+  data.tar.gz: cc74e1cb2323c79bd3aac03190aadb5580cd72dd
 SHA512:
-  metadata.gz: 56f839f488246485328d00ec650d30bb720c8c860d146df178c2223434fef9027be042ba96c2abc1e7a95e4c43e74cb5cd24e864751a97b18253d0539bf6e019
-  data.tar.gz: 7189fff3b10d0819a6af42337ceb7c59787eb291037d8fdd38d5c5dd4a0e63d1726260579ba4fc3a61ed3ad53531962e413599dadea90ed12837b51ebca194e0
+  metadata.gz: 6afe248085889633e25f2ab5c08ba8f0b7255e8d8e7012a6d8e3aee32dae6ce9ee57f5df2c4c55bf77b784d8830800a5d9fab142ef2ff748a9401afffc01b189
+  data.tar.gz: 98aa16735f64e879a5abebf3c059d9d5354574e308dc0f27b3e2ed5f18112eba934488c0b1766dcd441090ec2c4d7c7256c60cedb17463b45a9e14e0a4c12e27

data/README.md

@@ -61,7 +61,8 @@ repository.remove_all :people
 ```
 
 Hikki supports repositories with multiple adapters for reading and writing.
-It will write to all specified writers and read from the specified readers until a non-empty result is found.
+It will write to all specified writers and read from the specified readers until a non-empty result is found. Since adapters each have their own `id` generation method, you should put the writer
+in charge of generating the `id` first in the list.
 
 ```ruby
 redis = Hikki::Adapters::RedisAdapter.new

data/lib/hikki/repository.rb

@@ -5,13 +5,14 @@ module Hikki
 
     def initialize(writers=[], readers=[])
       @writers = Array(writers)
-      @writers << Hikki::Adapters::MemoryAdapter.new if @writers == []
+      @writers << Hikki::Adapters::MemoryAdapter.new if @writers.empty?
       @readers = Array(readers)
-      @readers << @writers.first if @readers == []
+      @readers << @writers.first if @readers.empty?
     end
 
     def save(collection, data)
-      writers.reduce({}) { |result, writer| writer.save(collection, data) }
+      head, *tail = *writers
+      tail.reduce(head.save(collection, data)) { |result, writer| writer.save(collection, result) }
     end
 
     def index(collection, field)

data/lib/hikki/version.rb

@@ -1,3 +1,3 @@
 module Hikki
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/hikki/repository_spec.rb

@@ -5,11 +5,12 @@ module Hikki
     subject(:repository) { Repository.new(writers, readers) }
     let(:writers) { [writer] }
     let(:readers) { [reader] }
-    let(:writer) { double :writer, save: data, index: true, remove: true, remove_all: true }
-    let(:another_writer) { double :writer, save: data, index: true, remove: true, remove_all: true }
+    let(:writer) { double :writer, save: mod_data, index: true, remove: true, remove_all: true }
+    let(:another_writer) { double :writer, save: mod_data, index: true, remove: true, remove_all: true }
     let(:reader) { double :reader }
     let(:collection) { 'collection' }
-    let(:data) { { id: '1' } }
+    let(:data) { { name: 'test' } }
+    let(:mod_data) { { 'id' => '1', 'name' => 'test' } }
 
     describe '.new' do
       context 'with no readers specified' do
@@ -40,16 +41,20 @@ module Hikki
       end
 
       it 'returns the data' do
-        expect(repository.save(collection, data)).to eq data
+        expect(repository.save(collection, data)).to eq mod_data
       end
 
       context 'with a second writer' do
         before { repository.writers << another_writer }
 
         it 'calls save on both of the writers' do
+          expect(writer).to receive(:save).with(collection, data).and_return(mod_data)
           repository.save(collection, data)
-          expect(writer).to have_received(:save).with(collection, data)
-          expect(another_writer).to have_received(:save).with(collection, data)
+          expect(another_writer).to have_received(:save).with(collection, mod_data)
+        end
+
+        it 'returns the data' do
+          expect(repository.save(collection, data)).to eq mod_data
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hikki
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - alexpeachey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-25 00:00:00.000000000 Z
+date: 2014-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler