highrise 3.2.1 → 3.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 71cd31f6f19cdaccbfee0fe9d620698930bdb284
-  data.tar.gz: 17e30e6d078c224e3c4b0d664e3a24fd2dfc1932
+  metadata.gz: bb615e43912e24c36c1e3ff4a5b70a5b787aca23
+  data.tar.gz: 46d52dfc726248c0811895def78caa5d26b2142b
 SHA512:
-  metadata.gz: 8bbd1dfa7c07273b73c00d078f98f405c209f3fa77b6eefa0dbd44afb57ab63bdf2d919b359356f0e13f8327dd6cc5224b51de2277f7fafec1e3f94ccaa14b09
-  data.tar.gz: 53891509f8ede23d45abe6e9f78de34c2784162c8fffd414a3d068ec5677234e722efbe0f5f5ee55d5344dd169c5b957c579baad21963f04b52b36b026e2c196
+  metadata.gz: 35d74823407a77440e4e357a4deba5b52209ac8db186e87c107be959dd5dbf25c5e8c2c477176f20ac056f92dcae1aa9405aecbd0aadebf13481bbc98eb99ad1
+  data.tar.gz: 0cbe9933253d038deca5fac73a4310b54aff4b7cc55e5707c53d64cc9c866d0e1c92bfecf73a3a1693991c280d14d269a7835ca4e755a497310e913883ccc391

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    highrise (3.2.1)
+    highrise (3.2.2)
       activeresource (>= 3.2.13)
 
 GEM
@@ -37,6 +37,7 @@ GEM
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.13.0)
     thread_safe (0.3.2)
+    thread_safe (0.3.2-java)
     tzinfo (0.3.39)
 
 PLATFORMS

data/highrise.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rspec"
   s.add_development_dependency "rake"
 
-  s.files         = [".gitignore", ".ruby-version", ".travis.yml", "Gemfile", "Gemfile.lock", "MIT-LICENSE", "README.md", "Rakefile", "autotest/discover.rb", "certs/gem-public_cert.pem", "examples/config_initializers_highrise.rb", "examples/extending.rb", "examples/sample.rb", "highrise.gemspec", "highrise.gemspec.erb", "lib/highrise.rb", "lib/highrise/account.rb", "lib/highrise/base.rb", "lib/highrise/comment.rb", "lib/highrise/company.rb", "lib/highrise/deal.rb", "lib/highrise/deal_category.rb", "lib/highrise/email.rb", "lib/highrise/group.rb", "lib/highrise/kase.rb", "lib/highrise/membership.rb", "lib/highrise/note.rb", "lib/highrise/pagination.rb", "lib/highrise/party.rb", "lib/highrise/person.rb", "lib/highrise/recording.rb", "lib/highrise/searchable.rb", "lib/highrise/subject.rb", "lib/highrise/subject_data.rb", "lib/highrise/subject_field.rb", "lib/highrise/tag.rb", "lib/highrise/taggable.rb", "lib/highrise/task.rb", "lib/highrise/task_category.rb", "lib/highrise/user.rb", "lib/highrise/version.rb", "spec/highrise/account_spec.rb", "spec/highrise/base_spec.rb", "spec/highrise/comment_spec.rb", "spec/highrise/company_spec.rb", "spec/highrise/deal_category_spec.rb", "spec/highrise/deal_spec.rb", "spec/highrise/email_spec.rb", "spec/highrise/group_spec.rb", "spec/highrise/kase_spec.rb", "spec/highrise/membership_spec.rb", "spec/highrise/note_spec.rb", "spec/highrise/pagination_behavior.rb", "spec/highrise/pagination_spec.rb", "spec/highrise/party_spec.rb", "spec/highrise/person_spec.rb", "spec/highrise/recording_spec.rb", "spec/highrise/searchable_behavior.rb", "spec/highrise/searchable_spec.rb", "spec/highrise/subject_data_spec.rb", "spec/highrise/subject_field_spec.rb", "spec/highrise/subject_spec.rb", "spec/highrise/tag_spec.rb", "spec/highrise/taggable_behavior.rb", "spec/highrise/taggable_spec.rb", "spec/highrise/task_category_spec.rb", "spec/highrise/task_spec.rb", "spec/highrise/user_spec.rb", "spec/spec_helper.rb"]
+  s.files         = [".gitignore", ".ruby-version", ".travis.yml", "Gemfile", "Gemfile.lock", "MIT-LICENSE", "README.md", "Rakefile", "autotest/discover.rb", "certs/gem-public_cert.pem", "examples/config_initializers_highrise.rb", "examples/extending.rb", "examples/sample.rb", "highrise.gemspec", "highrise.gemspec.erb", "lib/highrise.rb", "lib/highrise/account.rb", "lib/highrise/base.rb", "lib/highrise/comment.rb", "lib/highrise/company.rb", "lib/highrise/custom_fields.rb", "lib/highrise/deal.rb", "lib/highrise/deal_category.rb", "lib/highrise/email.rb", "lib/highrise/group.rb", "lib/highrise/kase.rb", "lib/highrise/membership.rb", "lib/highrise/note.rb", "lib/highrise/pagination.rb", "lib/highrise/party.rb", "lib/highrise/person.rb", "lib/highrise/recording.rb", "lib/highrise/searchable.rb", "lib/highrise/subject.rb", "lib/highrise/subject_data.rb", "lib/highrise/subject_field.rb", "lib/highrise/tag.rb", "lib/highrise/taggable.rb", "lib/highrise/task.rb", "lib/highrise/task_category.rb", "lib/highrise/user.rb", "lib/highrise/version.rb", "spec/highrise/account_spec.rb", "spec/highrise/base_spec.rb", "spec/highrise/comment_spec.rb", "spec/highrise/company_spec.rb", "spec/highrise/deal_category_spec.rb", "spec/highrise/deal_spec.rb", "spec/highrise/email_spec.rb", "spec/highrise/group_spec.rb", "spec/highrise/kase_spec.rb", "spec/highrise/membership_spec.rb", "spec/highrise/note_spec.rb", "spec/highrise/pagination_behavior.rb", "spec/highrise/pagination_spec.rb", "spec/highrise/party_spec.rb", "spec/highrise/person_spec.rb", "spec/highrise/recording_spec.rb", "spec/highrise/searchable_behavior.rb", "spec/highrise/searchable_spec.rb", "spec/highrise/subject_data_spec.rb", "spec/highrise/subject_field_spec.rb", "spec/highrise/subject_spec.rb", "spec/highrise/tag_spec.rb", "spec/highrise/taggable_behavior.rb", "spec/highrise/taggable_spec.rb", "spec/highrise/task_category_spec.rb", "spec/highrise/task_spec.rb", "spec/highrise/user_spec.rb", "spec/spec_helper.rb"]
   s.test_files    = ["examples/config_initializers_highrise.rb", "examples/extending.rb", "examples/sample.rb", "spec/highrise/account_spec.rb", "spec/highrise/base_spec.rb", "spec/highrise/comment_spec.rb", "spec/highrise/company_spec.rb", "spec/highrise/deal_category_spec.rb", "spec/highrise/deal_spec.rb", "spec/highrise/email_spec.rb", "spec/highrise/group_spec.rb", "spec/highrise/kase_spec.rb", "spec/highrise/membership_spec.rb", "spec/highrise/note_spec.rb", "spec/highrise/pagination_behavior.rb", "spec/highrise/pagination_spec.rb", "spec/highrise/party_spec.rb", "spec/highrise/person_spec.rb", "spec/highrise/recording_spec.rb", "spec/highrise/searchable_behavior.rb", "spec/highrise/searchable_spec.rb", "spec/highrise/subject_data_spec.rb", "spec/highrise/subject_field_spec.rb", "spec/highrise/subject_spec.rb", "spec/highrise/tag_spec.rb", "spec/highrise/taggable_behavior.rb", "spec/highrise/taggable_spec.rb", "spec/highrise/task_category_spec.rb", "spec/highrise/task_spec.rb", "spec/highrise/user_spec.rb", "spec/spec_helper.rb"]
   s.require_paths = ["lib"]
 

data/lib/highrise.rb

@@ -2,6 +2,7 @@ require 'highrise/base'
 require 'highrise/pagination'
 require 'highrise/taggable'
 require 'highrise/searchable'
+require 'highrise/custom_fields'
 require 'highrise/subject'
 require 'highrise/comment'
 require 'highrise/company'

data/lib/highrise/company.rb

@@ -3,6 +3,7 @@ module Highrise
     include Pagination
     include Taggable
     include Searchable
+    include CustomFields
 
     def people
       Person.find_all_across_pages(:from => "/companies/#{id}/people.xml")

data/lib/highrise/custom_fields.rb

@@ -0,0 +1,66 @@
+module Highrise
+  module CustomFields
+    def field(field_label)
+      custom_fields = attributes["subject_datas"] ||= []
+      field = custom_fields.detect do |field|
+        field.subject_field_label == field_label
+      end
+      field ? field.value : nil
+    end
+
+    def new_subject_data(field, value)
+      Highrise::SubjectData.new(:subject_field_id => field.id, :subject_field_label => field.label, :value => value)
+    end
+
+    def set_field_value(field_label, new_value)
+      custom_fields = attributes["subject_datas"] ||= []
+      custom_fields.each do |field|
+        return field.value = new_value if field.subject_field_label == field_label
+      end
+
+      SubjectField.find(:all).each do |custom_field|
+        if custom_field.label == field_label
+          return attributes["subject_datas"] << new_subject_data(custom_field, new_value)
+        end
+      end
+    end
+
+    def transform_subject_field_label field_label
+      field_label.downcase.tr(' ', '_')
+    end
+
+    def convert_method_to_field_label method
+      custom_fields = attributes["subject_datas"] ||= []
+      custom_fields.each do |field|
+        method_name_from_field = transform_subject_field_label(field.subject_field_label)
+        return field if method_name_from_field == method
+      end
+      nil
+    end
+
+    def method_missing(method_symbol, *args)
+      method_name = method_symbol.to_s
+
+      if method_name[-1,1] == "="
+        attribute_name = method_name[0...-1]
+        field = convert_method_to_field_label(attribute_name)
+        return set_field_value(field.subject_field_label, args[0]) if field
+
+        return super if attributes[attribute_name]
+
+        subject_fields = SubjectField.find(:all)
+        unless subject_fields.nil?
+          subject_fields.each do |custom_field|
+            if transform_subject_field_label(custom_field.label) == attribute_name
+              return attributes["subject_datas"] << new_subject_data(custom_field, args[0])
+            end
+          end
+        end
+      else
+        field = convert_method_to_field_label(method_name)
+        return field(field.subject_field_label) if field
+      end
+      super
+    end
+  end
+end

data/lib/highrise/deal.rb

@@ -1,8 +1,9 @@
 module Highrise
   class Deal < Subject
+    include Pagination
     def update_status(status)
       raise ArgumentError, "status must be one of 'pending', 'won', or 'lost'" unless %w[pending won lost].include?(status)
       self.put(:status, :status => {:name => status})
     end
   end
-end
+end

data/lib/highrise/person.rb

@@ -3,6 +3,7 @@ module Highrise
     include Pagination
     include Taggable
     include Searchable
+    include CustomFields
 
     def company
       Company.find(company_id) if company_id
@@ -20,71 +21,16 @@ module Highrise
       contact_data.web_addresses.first
     end
 
-    def label
-      'Party'
-    end
-    
-    def field(field_label)
-      custom_fields = attributes["subject_datas"] ||= []
-      field = custom_fields.detect do |field|
-        field.subject_field_label == field_label
-      end
-      field ? field.value : nil
-    end
-    
-    def new_subject_data(field, value)
-      Highrise::SubjectData.new(:subject_field_id => field.id, :subject_field_label => field.label, :value => value)
-    end
-    
-    def set_field_value(field_label, new_value)
-      custom_fields = attributes["subject_datas"] ||= []
-      custom_fields.each do |field|
-        return field.value = new_value if field.subject_field_label== field_label
-      end
-  
-      SubjectField.find(:all).each do |custom_field| 
-        if custom_field.label == field_label
-          return attributes["subject_datas"] << new_subject_data(custom_field, new_value)
-        end
-      end
+    def email_addresses
+      contact_data.email_addresses.collect { |address| address.address } rescue []
     end
 
-    def transform_subject_field_label field_label
-      field_label.downcase.tr(' ', '_')
+    def phone_numbers
+      contact_data.phone_numbers.collect { |phone_number| phone_number.number } rescue []
     end
-    
-    def convert_method_to_field_label method
-      custom_fields = attributes["subject_datas"] ||= []
-      custom_fields.each do |field|
-        method_name_from_field = transform_subject_field_label(field.subject_field_label)
-        return field if method_name_from_field == method
-      end
-      nil
+
+    def label
+      'Party'
     end
-    
-    def method_missing(method_symbol, *args)
-      method_name = method_symbol.to_s
-      
-      if method_name[-1,1] == "="
-        attribute_name = method_name[0...-1]
-        field = convert_method_to_field_label(attribute_name)
-        return set_field_value(field.subject_field_label, args[0]) if field
-        
-        return super if attributes[attribute_name]        
-        
-        subject_fields = SubjectField.find(:all)
-        unless subject_fields.nil?
-          subject_fields.each do |custom_field| 
-            if transform_subject_field_label(custom_field.label) == attribute_name
-              return attributes["subject_datas"] << new_subject_data(custom_field, args[0])
-            end
-          end
-        end
-      else
-        field = convert_method_to_field_label(method_name)
-        return field(field.subject_field_label) if field
-      end
-      super
-    end    
   end
 end

data/lib/highrise/subject.rb

@@ -1,7 +1,8 @@
 module Highrise
   class Subject < Base
-    def notes
-      Note.find_all_across_pages(:from => "/#{self.class.collection_name}/#{id}/notes.xml")
+    def notes(options={})
+      options.merge!(:from => "/#{self.class.collection_name}/#{id}/notes.xml")
+      Note.find_all_across_pages(options)
     end
 
     def add_note(attrs={})
@@ -16,12 +17,14 @@ module Highrise
       Task.create attrs
     end
 
-    def emails
-      Email.find_all_across_pages(:from => "/#{self.class.collection_name}/#{id}/emails.xml")
+    def emails(options={})
+      options.merge!(:from => "/#{self.class.collection_name}/#{id}/emails.xml")
+      Email.find_all_across_pages(options)
     end
 
-    def upcoming_tasks
-      Task.find(:all, :from => "/#{self.class.collection_name}/#{id}/tasks.xml")
+    def upcoming_tasks(options={})
+      options.merge!(:from => "/#{self.class.collection_name}/#{id}/tasks.xml")
+      Task.find(:all, options)
     end
     
     def label

data/lib/highrise/taggable.rb

@@ -1,12 +1,17 @@
 module Highrise
-  module Taggable        
+  module Taggable
+
     def tags
-      self.attributes.has_key?("tags") ? self.attributes["tags"] : self.get(:tags)
+      unless self.attributes.has_key?("tags")
+        person_or_company = self.class.find(id)
+        self.attributes["tags"] = person_or_company.attributes.has_key?("tags") ? person_or_company.tags : []
+      end
+      self.attributes["tags"]
     end
 
     def tag!(tag_name)
       self.post(:tags, :name => tag_name) unless tag_name.blank?
-    end    
+    end
 
     def untag!(tag_name)
       to_delete = self.tags.find{|tag| tag.attributes['name'] == tag_name} unless tag_name.blank?

data/lib/highrise/version.rb

@@ -1,3 +1,3 @@
 module Highrise
-  VERSION = "3.2.1"
+  VERSION = "3.2.3"
 end

data/spec/highrise/company_spec.rb

@@ -12,6 +12,72 @@ describe Highrise::Company do
     Highrise::Person.should_receive(:find_all_across_pages).with(:from=>"/companies/1/people.xml").and_return("people")
     subject.people.should == "people"
   end
-  
+
+  describe "Custom fields" do
+
+    before (:each) do
+      @fruit_company = Highrise::Company.new({ :company => {
+                        :id => 1,
+                        :name => "John Doe & Co.",
+                        :subject_datas => [{
+                          :subject_field_label => "Fruit Banana",
+                          :value => "Yellow"
+                        }, {
+                          :subject_field_label => "Fruit Grape",
+                          :value => "Green"
+                        }]
+                      }
+                    })
+      @subject_field_blueberry = Highrise::SubjectField.new ({:id => 1, :label => "Fruit Blueberry"})
+      @subject_field_papaya = Highrise::SubjectField.new ({:id => 2, :label => "Fruit Papaya"})
+    end
+
+    it "Can get the value of a custom field via the field method" do
+      @fruit_company.field("Fruit Banana").should== "Yellow"
+    end
+
+    it "Can get the value of a custom field using a custom method call" do
+      @fruit_company.fruit_grape.should== "Green"
+    end
+
+    it "Will raise an exception on an unknown field" do
+      expect {@fruit_company.unknown_fruit}.to raise_exception(NoMethodError)
+    end
+
+    it "Can set the value of a custom field via the field method" do
+      @fruit_company.set_field_value("Fruit Grape", "Red")
+      @fruit_company.field("Fruit Grape").should== "Red"
+    end
+
+    it "Can set the value of a custom field" do
+      @fruit_company.fruit_grape= "Red"
+      @fruit_company.field("Fruit Grape").should== "Red"
+    end
+
+    it "Assignment just returns the arguments (like ActiveResource base does)" do
+      Highrise::SubjectField.should_receive(:find).with(:all).and_return []
+      (@fruit_company.unknown_fruit = 10).should== 10
+    end
+
+    it "Can deal with the find returning nil (which is a bit ugly in the ActiveResource API)" do
+      Highrise::SubjectField.should_receive(:find).with(:all).and_return nil
+      (@fruit_company.unknown_fruit = 10).should== 10
+    end
+
+    it "Can set the value of a custom field that wasn't there via the field method, but that was defined (happens on new Person)" do
+      Highrise::SubjectField.should_receive(:find).with(:all).and_return([@subject_field_papaya, @subject_field_blueberry])
+      @fruit_company.set_field_value("Fruit Blueberry", "Purple")
+      @fruit_company.field("Fruit Blueberry").should== "Purple"
+      @fruit_company.attributes["subject_datas"][2].subject_field_id.should == 1
+    end
+
+    it "Can still set and read the usual way of reading attrivutes" do
+      @fruit_company.name = "Jacob"
+      @fruit_company.name.should== "Jacob"
+
+    end
+
+  end
+
   it { subject.label.should == 'Party' }
 end

data/spec/highrise/person_spec.rb

@@ -29,6 +29,68 @@ describe Highrise::Person do
     subject.name.should == "Marcos Tapajós"
   end
 
+  describe "#email_addresses" do
+    it "returns an empty array when there are none set" do
+      subject.email_addresses.should == []
+    end
+
+    it "returns all email_addresses as string in an array" do
+      subject = Highrise::Person.new(:id => 1,
+                                     :contact_data => {
+        :email_addresses => [{
+          :email_address => {
+            :address => "important@person.com"
+          }
+        }]
+      })
+      subject.email_addresses.should == ["important@person.com"]
+    end
+  end
+
+  describe "#phone_numbers" do
+    it "returns an empty array when there is none set" do
+      subject.phone_numbers.should== []
+    end
+
+    it "returns all phone numbers as a string aray" do
+      subject = Highrise::Person.new(:id => 1,
+                                     :contact_data => {
+        :phone_numbers => [{
+          :phone_number => {
+            :number => "123456789"
+          }
+        }]
+      })
+      subject.phone_numbers.should== [ "123456789" ]
+    end
+  end
+
+  describe "#tags" do
+
+    let(:person_tags) { [
+        {'id' => "414578", 'name' => "cliente"},
+        {'id' => "414580", 'name' => "ged"},
+        {'id' => "414579", 'name' => "iepc"} ]
+    }
+
+    let(:person_john_doe) { { :id => 1, :first_name => "John", :last_name => "Doe" } }
+    let(:person_john_doe_request){ ActiveResource::Request.new(:get, '/people/1.xml', nil, {"Authorization"=>"Bearer OAUTH_TOKEN", "Accept"=>"application/xml"}) }
+    let(:person_john_doe_request_pair){ {person_john_doe_request => ActiveResource::Response.new(person_john_doe.to_xml, 200, {})} }
+
+    it "should return the tags as a Highrise::Tag" do
+      person_john_doe[:tags] = person_tags
+      ActiveResource::HttpMock.respond_to(person_john_doe_request_pair)
+      tags = person_tags.collect {|tag| Highrise::Tag.new(tag)}
+      subject.tags.should == tags
+    end
+
+    it "should return an empty collection when there are no tags" do
+      ActiveResource::HttpMock.respond_to(person_john_doe_request_pair)
+      subject.tags.should == []
+    end
+  end
+
+
   describe "#tags" do
     before(:each) do
       (@tags = []).tap do
@@ -42,13 +104,13 @@ describe Highrise::Person do
       subject.tags.should == @tags
     }
   end
-  
+
   describe "Custom fields" do
-    
+
     before (:each) do
-      @fruit_person = Highrise::Person.new({ :person => { 
-                        :id => 1, 
-                        :first_name => "John", 
+      @fruit_person = Highrise::Person.new({ :person => {
+                        :id => 1,
+                        :first_name => "John",
                         :last_name => "Doe",
                         :subject_datas => [{
                           :subject_field_label => "Fruit Banana",
@@ -61,53 +123,53 @@ describe Highrise::Person do
                     })
       @subject_field_blueberry = Highrise::SubjectField.new ({:id => 1, :label => "Fruit Blueberry"})
       @subject_field_papaya = Highrise::SubjectField.new ({:id => 2, :label => "Fruit Papaya"})
-    end    
-    
+    end
+
     it "Can get the value of a custom field via the field method" do
       @fruit_person.field("Fruit Banana").should== "Yellow"
     end
-    
+
     it "Can get the value of a custom field using a custom method call" do
       @fruit_person.fruit_grape.should== "Green"
     end
-    
+
     it "Will raise an exception on an unknown field" do
       expect {@fruit_person.unknown_fruit}.to raise_exception(NoMethodError)
     end
-    
+
     it "Can set the value of a custom field via the field method" do
       @fruit_person.set_field_value("Fruit Grape", "Red")
       @fruit_person.field("Fruit Grape").should== "Red"
     end
-    
+
     it "Can set the value of a custom field" do
       @fruit_person.fruit_grape= "Red"
       @fruit_person.fruit_grape.should== "Red"
     end
-    
+
     it "Assignment just returns the arguments (like ActiveResource base does)" do
       Highrise::SubjectField.should_receive(:find).with(:all).and_return []
       (@fruit_person.unknown_fruit = 10).should== 10
     end
-    
+
     it "Can deal with the find returning nil (which is a bit ugly in the ActiveResource API)" do
       Highrise::SubjectField.should_receive(:find).with(:all).and_return nil
-      (@fruit_person.unknown_fruit = 10).should== 10      
+      (@fruit_person.unknown_fruit = 10).should== 10
     end
-    
+
     it "Can set the value of a custom field that wasn't there via the field method, but that was defined (happens on new Person)" do
       Highrise::SubjectField.should_receive(:find).with(:all).and_return([@subject_field_papaya, @subject_field_blueberry])
       @fruit_person.set_field_value("Fruit Blueberry", "Purple")
       @fruit_person.field("Fruit Blueberry").should== "Purple"
       @fruit_person.attributes["subject_datas"][2].subject_field_id.should == 1
     end
-    
+
     it "Can still set and read the usual way of reading attrivutes" do
       @fruit_person.first_name = "Jacob"
       @fruit_person.first_name.should== "Jacob"
-    
+
     end
-    
+
   end
 
   it { subject.label.should == 'Party' }

data/spec/highrise/subject_spec.rb

@@ -29,6 +29,28 @@ describe Highrise::Subject do
     Highrise::Task.should_receive(:find).with(:all, {:from=>"/subjects/1/tasks.xml"}).and_return("tasks")
     subject.upcoming_tasks.should == "tasks"
   end
+
+  context 'finding with since param' do
+    before(:each) do
+      @utc_time_str = "20090114174311"
+    end
+
+    it "#notes" do
+      Highrise::Note.should_receive(:find_all_across_pages).with({:from=>"/subjects/1/notes.xml", :params=>{:since=>@utc_time_str}}).and_return("notes")
+      subject.notes(:params=>{:since=>@utc_time_str}).should == "notes"
+    end
+
+    it "#emails" do
+      Highrise::Email.should_receive(:find_all_across_pages).with({:from=>"/subjects/1/emails.xml", :params=>{:since=>@utc_time_str}}).and_return("emails")
+      subject.emails(:params=>{:since=>@utc_time_str}).should == "emails"
+    end
+
+
+    it "#tasks" do
+      Highrise::Task.should_receive(:find).with(:all, {:from=>"/subjects/1/tasks.xml", :params=>{:since=>@utc_time_str}}).and_return("tasks")
+      subject.upcoming_tasks(:params=>{:since=>@utc_time_str}).should == "tasks"
+    end
+  end
   
   it { subject.label.should == "Subject" }
 end

data/spec/highrise/taggable_behavior.rb

@@ -1,6 +1,6 @@
 shared_examples_for "a taggable class" do
   before(:each) do
-    (@tags = []).tap do 
+    (@tags = []).tap do
       @tags << Highrise::Tag.new(:name => "cliente", :id => 414578)
       @tags << Highrise::Tag.new(:name => "ged", :id => 414580)
       @tags << Highrise::Tag.new(:name => "iepc", :id => 414579)
@@ -9,19 +9,14 @@ shared_examples_for "a taggable class" do
 
   it { subject.class.included_modules.should include(Highrise::Taggable) }
 
-  it "#tags" do
-    subject.should_receive(:get).with(:tags).and_return(@tags)
-    subject.tags.should == @tags
-  end
-  
   it "#tag!(tag_name)" do
     subject.should_receive(:post).with(:tags, :name => "client" ).and_return(true)
     subject.tag!("client").should be_true
   end
-  
+
   it "#untag!(tag_name)" do
-    subject.should_receive(:get).with(:tags).and_return(@tags)
+    subject.should_receive(:tags).and_return(@tags)
     subject.should_receive(:delete).with("tags/414578").and_return(true)
     subject.untag!("cliente").should be_true
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: highrise
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.2.3
 platform: ruby
 authors:
 - Marcos Tapajós
@@ -9,48 +9,48 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-11 00:00:00.000000000 Z
+date: 2016-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.13
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.13
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: "    Based on the original API module from DHH, http://developer.37signals.com/highrise/,
@@ -64,9 +64,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .ruby-version
-- .travis.yml
+- ".gitignore"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - MIT-LICENSE
@@ -84,6 +84,7 @@ files:
 - lib/highrise/base.rb
 - lib/highrise/comment.rb
 - lib/highrise/company.rb
+- lib/highrise/custom_fields.rb
 - lib/highrise/deal.rb
 - lib/highrise/deal_category.rb
 - lib/highrise/email.rb
@@ -142,17 +143,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper around Highrise API
@@ -188,3 +189,4 @@ test_files:
 - spec/highrise/task_spec.rb
 - spec/highrise/user_spec.rb
 - spec/spec_helper.rb
+has_rdoc: