highline 1.2.8 → 1.2.9

data/CHANGELOG

@@ -2,6 +2,11 @@
 
 Below is a complete listing of changes for each revision of HighLine.
 
+== 1.2.9
+
+* Additional work on the backspacing issue. (patch by Jeremy Hinegardner)
+* Fixed Readline prompt bug. (patch by Jeremy Hinegardner)
+
 == 1.2.8
 
 * Fixed backspacing past the prompt and interrupting a prompt bugs.

data/lib/highline.rb

@@ -29,7 +29,7 @@ require "abbrev"
 #
 class HighLine
   # The version of the installed library.
-  VERSION = "1.2.8".freeze
+  VERSION = "1.2.9".freeze
   
   # An internal HighLine error.  User code does not need to trap this.
   class QuestionError < StandardError
@@ -204,9 +204,11 @@ class HighLine
     @question ||= Question.new(question, answer_type, &details)
     
     return gather if @question.gather
-    
-    # readline() needs to handle it's own output
-    say(@question) unless @question.readline
+  
+    # readline() needs to handle it's own output, but readline only supports 
+    # full line reading.  Therefore if @question.echo is anything but true, 
+    # the prompt will not be issued. And we have to account for that now.
+    say(@question) unless (@question.readline and @question.echo == true)
     begin
       @answer = @question.answer_or_default(get_response)
       unless @question.valid_answer?(@answer)
@@ -624,7 +626,7 @@ class HighLine
               backspace_limit -= 1
             else
               line << character.chr
-              backspace_limit += 1
+              backspace_limit = line.size
             end
             # looking for carriage return (decimal 13) or
             # newline (decimal 10) in raw input

data/test/tc_highline.rb

@@ -143,6 +143,17 @@ class TestHighLine < Test::Unit::TestCase
       assert_equal("Please enter your password: \n",@output.string)
   end
   
+  def test_readline_on_non_echo_question_has_prompt
+    @input << "you can't see me"
+    @input.rewind
+    answer = @terminal.ask("Please enter some hidden text: ") do |q|
+      q.readline = true
+      q.echo = "*"
+    end
+    assert_equal("you can't see me", answer)
+    assert_equal("Please enter some hidden text: ****************\n",@output.string)
+  end
+  
   def test_character_reading
     # WARNING:  This method does NOT cover Unix and Windows savvy testing!
     @input << "12345"

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: highline
 version: !ruby/object:Gem::Version 
-  version: 1.2.8
-date: 2007-06-20 00:00:00 -05:00
+  version: 1.2.9
+date: 2007-06-21 00:00:00 -05:00
 summary: HighLine is a high-level command-line IO library.
 require_paths: 
 - lib