highline 1.2.7 → 1.2.8

data/CHANGELOG

@@ -2,6 +2,11 @@
 
 Below is a complete listing of changes for each revision of HighLine.
 
+== 1.2.8
+
+* Fixed backspacing past the prompt and interrupting a prompt bugs.
+  (patch by Jeremy Hinegardner)
+
 == 1.2.7
 
 * Fixed the stty indent bug.

data/lib/highline.rb

@@ -29,7 +29,7 @@ require "abbrev"
 #
 class HighLine
   # The version of the installed library.
-  VERSION = "1.2.7".freeze
+  VERSION = "1.2.8".freeze
   
   # An internal HighLine error.  User code does not need to trap this.
   class QuestionError < StandardError
@@ -614,21 +614,31 @@ class HighLine
         raw_no_echo_mode if stty = CHARACTER_MODE == "stty"
         
         line = ""
+        backspace_limit = 0
         begin
+
           while character = (stty ? @input.getc : get_character(@input))
             # honor backspace and delete
             if character == 127 or character == 8
               line.slice!(-1, 1)
+              backspace_limit -= 1
             else
               line << character.chr
+              backspace_limit += 1
             end
             # looking for carriage return (decimal 13) or
             # newline (decimal 10) in raw input
             break if character == 13 or character == 10 or
                      (@question.limit and line.size == @question.limit)
             if @question.echo != false
-              if character == 127 or character == 8
-                @output.print("\b#{ERASE_CHAR}")
+              if character == 127 or character == 8 
+                  # only backspace if we have characters on the line to
+                  # eliminate, otherwise we'll tromp over the prompt
+                  if backspace_limit >= 0 then
+                    @output.print("\b#{ERASE_CHAR}")
+                  else 
+                      # do nothing
+                  end
               else
                 @output.print(@question.echo)
               end

data/lib/highline/system_extensions.rb

@@ -103,7 +103,7 @@ class HighLine
         # 
         def raw_no_echo_mode
           @state = `stty -g`
-          system "stty raw -echo cbreak"
+          system "stty raw -echo cbreak isig"
         end
         
         #

data/test/tc_highline.rb

@@ -132,6 +132,16 @@ class TestHighLine < Test::Unit::TestCase
     assert_equal(2, answer)
     assert_equal("Select an option (1, 2 or 3):  *\n", @output.string)
   end
+
+  def test_backspace_does_not_enter_prompt
+      @input << "\b\b"
+      @input.rewind
+      answer = @terminal.ask("Please enter your password: ") do |q| 
+          q.echo = "*" 
+      end
+      assert_equal("", answer)
+      assert_equal("Please enter your password: \n",@output.string)
+  end
   
   def test_character_reading
     # WARNING:  This method does NOT cover Unix and Windows savvy testing!
@@ -143,7 +153,7 @@ class TestHighLine < Test::Unit::TestCase
     end
     assert_equal(1, answer)
   end
-  
+
   def test_color
     @terminal.say("This should be <%= BLUE %>blue<%= CLEAR %>!")
     assert_equal("This should be \e[34mblue\e[0m!\n", @output.string)

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.1
+rubygems_version: 0.9.4
 specification_version: 1
 name: highline
 version: !ruby/object:Gem::Version 
-  version: 1.2.7
-date: 2007-01-31 00:00:00 -06:00
+  version: 1.2.8
+date: 2007-06-20 00:00:00 -05:00
 summary: HighLine is a high-level command-line IO library.
 require_paths: 
 - lib
@@ -39,12 +39,12 @@ files:
 - examples/password.rb
 - examples/trapping_eof.rb
 - examples/using_readline.rb
-- lib/highline.rb
 - lib/highline/color_scheme.rb
 - lib/highline/import.rb
 - lib/highline/menu.rb
 - lib/highline/question.rb
 - lib/highline/system_extensions.rb
+- lib/highline.rb
 - test/tc_color_scheme.rb
 - test/tc_highline.rb
 - test/tc_import.rb