high_voltage 1.2.0 → 1.2.1

data/.travis.yml

@@ -4,6 +4,6 @@ rvm:
   - 1.9.2
   - 1.9.3
 gemfile:
-  - gemfiles/rails-3.0.12.gemfile
-  - gemfiles/rails-3.1.4.gemfile
-  - gemfiles/rails-3.2.3.gemfile
+  - gemfiles/rails-3.0.15.gemfile
+  - gemfiles/rails-3.1.6.gemfile
+  - gemfiles/rails-3.2.6.gemfile

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    high_voltage (1.2.0)
+    high_voltage (1.2.1)
 
 GEM
   remote: http://rubygems.org/

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2010 thoughtbot, inc.
+Copyright 2010-2012 thoughtbot, inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,4 +1,4 @@
-# High Voltage [![Build Status](http://travis-ci.org/thoughtbot/high_voltage.png)](http://travis-ci.org/thoughtbot/high_voltage)
+# High Voltage [![Build Status](https://travis-ci.org/thoughtbot/high_voltage.png)](http://travis-ci.org/thoughtbot/high_voltage)
 
 Rails engine for static pages.
 
@@ -57,26 +57,59 @@ In that case, you'd need an app/views/pages/home.html.erb file.
 
 Generally speaking, you need to route to the 'show' action with an :id param of the view filename.
 
-High Voltage will generate a named route method of `page_path` which you can use, as well.  If you 
-want to generate a named route (with the :as routing option) for some route which will be handled 
-by High Voltage, make sure not to use :page as the name, because that will conflict with the named 
-route generated by High Voltage itself.  For example, this will work for top-level routes (we will 
+High Voltage will generate a named route method of `page_path` which you can use, as well.  If you
+want to generate a named route (with the :as routing option) for some route which will be handled
+by High Voltage, make sure not to use :page as the name, because that will conflict with the named
+route generated by High Voltage itself.
+
+For example, this will work for top-level routes (we will
 get a named route called `static_path` which does not conflict with the generated `page_path` method):
 
     match '/:id' => 'high_voltage/pages#show', :as => :static, :via => :get
 
+#### Specifying a root path
+
 You can route the root url to a high voltage page like this:
 
     root :to => 'high_voltage/pages#show', :id => 'home'
 
 Which will render a homepage from app/views/pages/home.html.erb
 
+#### Enabling root domain routes
+
+You can remove the directory `pages` from the URL path and serve up routes from 
+the root of the domain path:
+
+    http://www.example.com/about
+    http://www.example.com/company
+
+Would look for corresponding files:
+
+    app/views/pages/about.html.erb
+    app/views/pages/company.html.erb
+
+This is accomplished by changing the `HighVoltage.route_drawer` to `HighVoltage::RouteDrawers::Root`
+
+    # config/initializers/high_voltage.rb
+    HighVoltage.route_drawer = HighVoltage::RouteDrawers::Root
+
+Note: This is not a catchall route. It will check the `HighVoltage.content_path` 
+(by default this is `app/views/pages`) and validate the view exists.
+
+#### Disabling routes
+
+The default routes can be completely removed by changing the
+`HighVoltage.routes` to `false`
+
+    # config/initializers/high_voltage.rb
+    HighVoltage.routes = false
+
 Customize
 --------
 
 High Voltage uses a default path and folder of 'pages', i.e. 'url.com/pages/contact' , 'app/views/pages'
 
-You can change this in an initializer: 
+You can change this in an initializer:
 
     HighVoltage.content_path = "site/"
 
@@ -115,25 +148,58 @@ Then modify it to subclass from High Voltage, adding whatever you need:
         end
     end
 
+Custom finding
+--------------
+
+You can further control the algorithm used to find pages by overriding
+the `page_finder_factory` method:
+
+    class PagesController < HighVoltage::PagesController
+      private
+
+      def page_finder_factory
+        Rot13PageFinder
+      end
+    end
+
+The easiest thing is to subclass `HighVoltage::PageFinder`, which
+provides you with `page_id`:
+
+    class Rot13PageFinder < HighVoltage::PageFinder
+      def find
+        paths = super.split('/')
+        directory = paths[0..-2]
+        filename = paths[-1].tr('a-z','n-za-m')
+
+        File.join(*directory, filename)
+      end
+    end
+
+Use this to create a custom file mapping, clean filenames for your file
+system, A/B test, and so on.
+
 Testing
 -------
 
-Just a suggestion, but you can test your pages using Shoulda pretty easily:
-
-    class PagesControllerTest < ActionController::TestCase
-      tests PagesController
+You can test your static pages using [RSpec](https://github.com/rspec/rspec-rails) 
+and [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers):
 
+    # spec/controllers/pages_controller_spec.rb
+    describe PagesController, '#show' do
       %w(earn_money screencast about contact).each do |page|
-        context "on GET to /pages/#{page}" do
-          setup { get :show, :id => page }
+        context 'on GET to /pages/#{page}' do
+          before do
+            get :show, :id => page
+          end
 
-          should_respond_with :success
-          should_render_template page
+          it { should respond_with(:success) }
+          it { should render_template(page) }
         end
       end
     end
 
-If you're not using a custom PagesController be sure to test <code>HighVoltage::PagesController</code> instead.
+If you're not using a custom PagesController be sure to test
+`HighVoltage::PagesController` instead.
 
 Enjoy!
 
@@ -156,4 +222,5 @@ The names and logos for thoughtbot are trademarks of thoughtbot, inc.
 License
 -------
 
-High Voltage is Copyright © 2009-2011 thoughtbot. It is free software, and may be redistributed under the terms specified in the MIT-LICENSE file.
+High Voltage is Copyright © 2009-2012 thoughtbot. It is free software, and may
+be redistributed under the terms specified in the MIT-LICENSE file.

data/app/controllers/high_voltage/pages_controller.rb

@@ -1,11 +1,9 @@
 class HighVoltage::PagesController < ApplicationController
-  VALID_CHARACTERS = "a-zA-Z0-9~!@$%^&*()#`_+-=<>\"{}|[];',?".freeze
-
   unloadable
   layout Proc.new { |_| HighVoltage.layout }
 
   rescue_from ActionView::MissingTemplate do |exception|
-    if exception.message =~ %r{Missing template #{content_path}}
+    if exception.message =~ %r{Missing template #{page_finder.content_path}}
       raise ActionController::RoutingError, "No such page: #{params[:id]}"
     else
       raise exception
@@ -16,22 +14,17 @@ class HighVoltage::PagesController < ApplicationController
     render :template => current_page
   end
 
-  protected
-
-    def current_page
-      "#{content_path}#{clean_path}"
-    end
+  private
 
-    def clean_path
-      path = Pathname.new("/#{clean_id}")
-      path.cleanpath.to_s[1..-1]
-    end
+  def current_page
+    page_finder.find
+  end
 
-    def content_path
-      HighVoltage.content_path
-    end
+  def page_finder
+    page_finder_factory.new(params[:id])
+  end
 
-    def clean_id
-      params[:id].tr("^#{VALID_CHARACTERS}", '')
-    end
+  def page_finder_factory
+    HighVoltage::PageFinder
+  end
 end

data/config/routes.rb

@@ -1,4 +1,5 @@
 Rails.application.routes.draw do
-  match "/#{HighVoltage.content_path}*id" => 'high_voltage/pages#show', :as => :page, :format => false
-
+  if HighVoltage.routes
+    get HighVoltage.route_drawer.match_attributes
+  end
 end

data/lib/high_voltage.rb

@@ -1,11 +1,21 @@
 require 'high_voltage/version'
+require 'high_voltage/constraints/root_route'
+require 'high_voltage/page_finder'
+require 'high_voltage/route_drawers/default'
+require 'high_voltage/route_drawers/root'
 
 module HighVoltage
   mattr_accessor :layout
-  @@layout = "application"
+  @@layout = 'application'
 
   mattr_accessor :content_path
-  @@content_path = "pages/"
+  @@content_path = 'pages/'
+
+  mattr_accessor :route_drawer
+  @@route_drawer = HighVoltage::RouteDrawers::Default
+
+  mattr_accessor :routes
+  @@routes = true
 
   def self.setup
     yield self

data/lib/high_voltage/constraints/root_route.rb

@@ -0,0 +1,24 @@
+module HighVoltage
+  module Constraints
+    # Routing constraint to validate request.path has a corresponding view
+    class RootRoute
+      VIEW_EXTENSIONS = 'html.erb,html.haml,html'
+
+      def self.matches?(request)
+        pattern = file_pattern(request.path)
+
+        Dir.glob(pattern).any?
+      end
+
+      private
+
+      def self.file_pattern(page_id)
+        "#{content_path}#{page_id}.{#{VIEW_EXTENSIONS}}"
+      end
+
+      def self.content_path
+        Rails.root.join('app', 'views', HighVoltage.content_path).to_s
+      end
+    end
+  end
+end

data/lib/high_voltage/engine.rb

@@ -1,6 +1,4 @@
 module HighVoltage
-
   class Engine < Rails::Engine
   end
-
 end

data/lib/high_voltage/page_finder.rb

@@ -0,0 +1,37 @@
+module HighVoltage
+  # A command for finding pages by id. This encapsulates the concepts of
+  # mapping page names to file names.
+  class PageFinder
+    VALID_CHARACTERS = "a-zA-Z0-9~!@$%^&*()#`_+-=<>\"{}|[];',?".freeze
+
+    def initialize(page_id)
+      @page_id = page_id
+    end
+
+    # Produce a template path to the page, in a format understood by
+    # `render :template => find`
+    def find
+      "#{content_path}#{clean_path}"
+    end
+
+    def content_path
+      HighVoltage.content_path
+    end
+
+    protected
+
+    # The raw page id passed in by the user
+    attr_reader :page_id
+
+    private
+
+    def clean_path
+      path = Pathname.new("/#{clean_id}")
+      path.cleanpath.to_s[1..-1]
+    end
+
+    def clean_id
+      @page_id.tr("^#{VALID_CHARACTERS}", '')
+    end
+  end
+end

data/lib/high_voltage/route_drawers/default.rb

@@ -0,0 +1,15 @@
+module HighVoltage
+  module RouteDrawers
+    # Matches routes in the HighVoltage.content_path directory. By default this looks
+    # for /pages/id. e.g. http://www.example.com/pages/about_us
+    class Default
+      def self.match_attributes
+        {
+          "/#{HighVoltage.content_path}*id" => 'high_voltage/pages#show',
+          :as => :page,
+          :format => false
+        }
+      end
+    end
+  end
+end

data/lib/high_voltage/route_drawers/root.rb

@@ -0,0 +1,16 @@
+module HighVoltage
+  module RouteDrawers
+    # Matches routes from root of the domain e.g. http://www.example.com/about_us
+    # Uses HighVoltage::Constraints::RootRoute to validate view exists.
+    class Root
+      def self.match_attributes
+        {
+          "/*id" => 'high_voltage/pages#show',
+          :as => :page,
+          :format => false,
+          :constraints => HighVoltage::Constraints::RootRoute
+        }
+      end
+    end
+  end
+end

data/lib/high_voltage/version.rb

@@ -1,3 +1,3 @@
 module HighVoltage
-  VERSION = '1.2.0'.freeze
+  VERSION = '1.2.1'.freeze
 end

data/spec/constraints/root_route_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe HighVoltage::Constraints::RootRoute, '.matches?' do
+  context 'view file exists' do
+    it 'should return true' do
+      request = stub(:path => 'index')
+      Dir.stub!(:glob).and_return(['about.html.erb'])
+
+      HighVoltage::Constraints::RootRoute.matches?(request).should be_true
+    end
+  end
+
+  context 'view file does not exist' do
+    it 'should return false' do
+      request = stub(:path => 'index')
+      File.stub!(:glob).and_return([])
+
+      HighVoltage::Constraints::RootRoute.matches?(request).should be_false
+    end
+  end
+end

data/spec/controllers/alternative_finder_controller_spec.rb

@@ -0,0 +1,12 @@
+require 'spec_helper'
+
+describe AlternativeFinderController do
+  render_views
+
+  it 'renders the file from the alternative directory' do
+    get :show, :id => 'ebg13'
+
+    response.should be_success
+    response.should render_template('rot13')
+  end
+end

data/spec/controllers/pages_controller_spec.rb

@@ -1,112 +1,128 @@
 # encoding: UTF-8
-
 require 'spec_helper'
 
 describe HighVoltage::PagesController do
-
   render_views
 
-  context "using default configuration" do
-
-    describe "on GET to /pages/exists" do
+  context 'using default configuration' do
+    describe 'on GET to /pages/exists' do
       before { get :show, :id => 'exists' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('exists')
       end
 
-      it "should use the default layout used by ApplicationController" do
-        response.should render_template("layouts/application")
+      it 'should use the default layout used by ApplicationController' do
+        response.should render_template('layouts/application')
       end
     end
 
-    describe "on GET to /pages/dir/nested" do
+    describe 'on GET to /pages/dir/nested' do
       before { get :show, :id => 'dir/nested' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('pages/dir/nested')
       end
     end
 
-    it "should raise a routing error for an invalid page" do
-      lambda { get :show, :id => "invalid" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for an invalid page' do
+      lambda {
+        get :show,
+        :id => 'invalid'
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise a routing error for a page in another directory" do
-      lambda { get :show, :id => "../other/wrong" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for a page in another directory' do
+      lambda {
+        get :show,
+        :id => '../other/wrong'
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise missing template error for valid page with invalid partial" do
-      lambda { get :show, :id => "exists_but_references_nonexistent_partial" }.should raise_error(ActionView::MissingTemplate)
+    it 'should raise missing template error for valid page with invalid partial' do
+      lambda {
+        get :show,
+        :id => 'exists_but_references_nonexistent_partial'
+      }.should raise_error(ActionView::MissingTemplate)
     end
   end
 
-  context "using custom layout" do
+  context 'using custom layout' do
     before(:all) do
       @original_layout = HighVoltage.layout
-      HighVoltage.layout = "alternate"
+      HighVoltage.layout = 'alternate'
     end
 
     after(:all) do
       HighVoltage.layout = @original_layout
     end
 
-    describe "on GET to /pages/exists" do
-      before { get :show, :id => "exists" }
-      
-      it "should use the custom configured layout" do
-        response.should_not render_template("layouts/application")
-        response.should render_template("layouts/alternate")
+    describe 'on GET to /pages/exists' do
+      before { get :show, :id => 'exists' }
+
+      it 'should use the custom configured layout' do
+        response.should_not render_template('layouts/application')
+        response.should render_template('layouts/alternate')
       end
     end
   end
 
-  context "using custom content path" do
+  context 'using custom content path' do
     before(:all) do
       @original_content_path = HighVoltage.content_path
-      HighVoltage.content_path = "other_pages/"
+      HighVoltage.content_path = 'other_pages/'
     end
 
     after(:all) do
       HighVoltage.content_path = @original_content_path
     end
 
-    describe "on GET to /other_pages/also_exists" do
+    describe 'on GET to /other_pages/also_exists' do
       before { get :show, :id => 'also_exists' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('other_pages/also_exists')
       end
     end
 
-    describe "on GET to /other_pages/also_dir/nested" do
+    describe 'on GET to /other_pages/also_dir/nested' do
       before { get :show, :id => 'also_dir/also_nested' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('other_pages/also_dir/also_nested')
       end
     end
 
-    it "should raise a routing error for an invalid page" do
-      lambda { get :show, :id => "also_invalid" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for an invalid page' do
+      lambda { 
+        get :show, 
+        :id => 'also_invalid' 
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise a routing error for a page in another directory" do
-      lambda { get :show, :id => "../other/wrong" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for a page in another directory' do
+      lambda {
+        get :show,
+        :id => '../other/wrong' 
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise a routing error for a page in another directory when using a Unicode exploit" do
-      lambda { get :show, :id => "/\\../other/wrong" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for a page in another directory when using a Unicode exploit' do
+      lambda { 
+        get :show,
+        :id => '/\\../other/wrong'
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise missing template error for valid page with invalid partial" do
-      lambda { get :show, :id => "also_exists_but_references_nonexistent_partial" }.should raise_error(ActionView::MissingTemplate)
+    it 'should raise missing template error for valid page with invalid partial' do
+      lambda {
+        get :show,
+        :id => 'also_exists_but_references_nonexistent_partial'
+      }.should raise_error(ActionView::MissingTemplate)
     end
   end
-
-
 end

data/spec/controllers/subclassed_pages_controller_spec.rb

@@ -1,41 +1,40 @@
 require 'spec_helper'
 
 describe SubclassedPagesController do
-
   render_views
 
-  describe "on GET to /subclassed_pages/also_exists" do
+  describe 'on GET to /subclassed_pages/also_exists' do
     before { get :show, :id => 'also_exists' }
 
-    it "should respond with success and render template" do
+    it 'should respond with success and render template' do
       response.should be_success
       response.should render_template('also_exists')
     end
 
-    it "should use the custom configured layout" do
-      response.should_not render_template("layouts/application")
+    it 'should use the custom configured layout' do
+      response.should_not render_template('layouts/application')
       response.should render_template('layouts/alternate')
     end
   end
 
-  describe "on GET to /subclassed_pages/also_dir/nested" do
-    before { get :show, :id => 'also_dir/also_nested' }
-
-    it "should respond with success and render template" do
-      response.should be_success
-      response.should render_template('other_pages/also_dir/also_nested')
-    end
-  end
-
-  it "should raise a routing error for an invalid page" do
-    lambda { get :show, :id => "invalid" }.should raise_error(ActionController::RoutingError)
+  it 'should raise a routing error for an invalid page' do
+    lambda {
+      get :show,
+      :id => 'invalid'
+    }.should raise_error(ActionController::RoutingError)
   end
 
-  it "should raise a routing error for a page in another directory" do
-    lambda { get :show, :id => "../other/wrong" }.should raise_error(ActionController::RoutingError)
+  it 'should raise a routing error for a page in another directory' do
+    lambda {
+      get :show,
+      :id => '../other/wrong'
+    }.should raise_error(ActionController::RoutingError)
   end
 
-  it "should raise missing template error for valid page with invalid partial" do
-    lambda { get :show, :id => "also_exists_but_references_nonexistent_partial" }.should raise_error(ActionView::MissingTemplate)
+  it 'should raise missing template error for valid page with invalid partial' do
+    lambda {
+      get :show,
+      :id => 'also_exists_but_references_nonexistent_partial'
+    }.should raise_error(ActionView::MissingTemplate)
   end
 end

data/spec/dummy/app/controllers/alternative_finder_controller.rb

@@ -0,0 +1,14 @@
+class AlternativeFinderController < HighVoltage::PagesController
+  private
+
+  def page_finder_factory
+    Rot13PageFinder
+  end
+
+  class Rot13PageFinder < HighVoltage::PageFinder
+    def find
+      paths = super.split('/')
+      "#{paths[0..-2].join('/')}/#{paths[-1].tr('a-z','n-za-m')}"
+    end
+  end
+end

data/spec/dummy/app/controllers/subclassed_pages_controller.rb

@@ -1,7 +1,3 @@
 class SubclassedPagesController < HighVoltage::PagesController
   layout 'alternate'
-
-  def content_path
-    'other_pages/'
-  end
 end

data/spec/dummy/app/views/pages/also_dir/also_nested.html.erb

@@ -0,0 +1 @@
+hello <%= 'world' %> from a nested dir

data/spec/dummy/app/views/pages/also_exists.html.erb

@@ -0,0 +1 @@
+hello <%= 'world' %>

data/spec/dummy/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb

@@ -0,0 +1,2 @@
+hello <%= 'world' %>
+<%= render 'nonexistent' %>

data/spec/dummy/app/views/pages/rot13.html.erb

@@ -0,0 +1 @@
+alternative

data/spec/dummy/config/application.rb

@@ -3,7 +3,6 @@ require File.expand_path('../boot', __FILE__)
 require "active_model/railtie"
 require "action_controller/railtie"
 require "action_view/railtie"
-require "action_mailer/railtie"
 
 Bundler.require
 require "high_voltage"

data/spec/dummy/config/environments/test.rb

@@ -20,11 +20,6 @@ Dummy::Application.configure do
   # Disable request forgery protection in test environment
   config.action_controller.allow_forgery_protection    = false
 
-  # Tell Action Mailer not to deliver emails to the real world.
-  # The :test delivery method accumulates sent emails in the
-  # ActionMailer::Base.deliveries array.
-  config.action_mailer.delivery_method = :test
-
   # Use SQL instead of Active Record's schema dumper when creating the test database.
   # This is necessary if your schema can't be completely dumped by the schema dumper,
   # like if you have constraints or database-specific column types

data/spec/dummy/config/routes.rb

@@ -1,3 +1,4 @@
 Dummy::Application.routes.draw do
   match "/subclassed_pages/*id" => 'subclassed_pages#show', :format => false
+  match "/alternative_finder/*id" => 'alternative_finder#show', :format => false
 end

data/spec/high_voltage/page_finder_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe HighVoltage::PageFinder do
+  it 'produces the name of an existing template' do
+    find('existing').should eq 'pages/existing'
+  end
+
+  it 'produces the name of a nested template' do
+    find('dir/nested').should eq 'pages/dir/nested'
+  end
+
+  it 'uses a custom content path' do
+    with_content_path('other_pages/') do
+      find('also_exists').should eq 'other_pages/also_exists'
+    end
+  end
+
+  it 'exposes the content path' do
+    with_content_path('another_thing/') do
+      page_finder.content_path.should eq 'another_thing/'
+    end
+  end
+
+  it 'provides the page_id' do
+    subclass = Class.new(HighVoltage::PageFinder) do
+      def page_name
+        "the page is #{page_id}"
+      end
+    end
+
+    subclass.new('sweet page').page_name.should eq 'the page is sweet page'
+  end
+
+  private
+
+  def find(page_id)
+    page_finder(page_id).find
+  end
+
+  def page_finder(page_id = 'whatever')
+    HighVoltage::PageFinder.new(page_id)
+  end
+
+  def with_content_path(path)
+    original_content_path = HighVoltage.content_path
+    HighVoltage.content_path = path
+
+    yield
+
+    HighVoltage.content_path = original_content_path
+  end
+end

data/spec/high_voltage_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe HighVoltage do
-  it "should be valid" do
+  it 'should be valid' do
     HighVoltage.should be_a(Module)
   end
-end
+end

data/spec/integration/navigation_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe "Navigation" do
+describe 'Navigation' do
   include Capybara::DSL
-  
-  it "should be a valid app" do
+
+  it 'should be a valid app' do
     ::Rails.application.should be_a(Dummy::Application)
   end
 end

data/spec/routing/routes_spec.rb

@@ -1,68 +1,150 @@
 require 'spec_helper'
-describe 'routes' do
-  context "using default configuration" do
 
-    it "should generate normal resource route with id" do
-      page_path(:id => "one").should == "/pages/one"
+describe 'routes' do
+  context 'using default configuration' do
+    it 'should generate normal resource route with id' do
+      page_path(:id => 'one').should eq '/pages/one'
     end
 
-    it "should generate normal resource route with string" do
-      page_path("one").should == "/pages/one"
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/pages/one'
     end
 
-    it "should generate nested route with string" do
-      page_path("one/two").should == "/pages/one/two"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/pages/one/two'
     end
 
-    it "should recognize nested route" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one/two" }, "/pages/one/two")
+    it 'should recognize nested route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one/two'
+        },
+        '/pages/one/two'
+      )
     end
 
-    it "should recognize normal route" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one" }, "/pages/one")
+    it 'should recognize normal route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one'
+        },
+        '/pages/one'
+      )
     end
 
-    it "should recognize normal route with dots" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one.two.three" }, "/pages/one.two.three")
+    it 'should recognize normal route with dots' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one.two.three'
+        },
+        '/pages/one.two.three'
+      )
     end
   end
 
-  context "using a custom content_path" do
+  context 'using root routing configuration' do
+    around do |example|
+      cached_high_voltage_route_drawer = HighVoltage.route_drawer
+      HighVoltage.route_drawer = HighVoltage::RouteDrawers::Root
+      Rails.application.reload_routes!
+
+      example.run
 
-    before(:all) do
-      @original_content_path = HighVoltage.content_path
-      HighVoltage.content_path = "other_pages/"
+      HighVoltage.route_drawer = cached_high_voltage_route_drawer
       Rails.application.reload_routes!
     end
 
-    after(:all) do
-      HighVoltage.content_path = @original_content_path
+    it 'should generate normal resource route with id' do
+      page_path(:id => 'one').should eq '/one'
+    end
+
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/one'
+    end
+
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/one/two'
+    end
+  end
+
+  context 'using a custom content_path' do
+    around do |example|
+      cached_high_voltage_content_path = HighVoltage.content_path
+      HighVoltage.content_path = 'other_pages/'
+      Rails.application.reload_routes!
+
+      example.run
+
+      HighVoltage.content_path = cached_high_voltage_content_path
       Rails.application.reload_routes!
     end
 
-    it "should generate normal resource route with id" do
-      page_path(:id => "one").should == "/other_pages/one"
+    it 'should generate normal resource route with id' do
+      page_path(:id => 'one').should eq '/other_pages/one'
     end
 
-    it "should generate normal resource route with string" do
-      page_path("one").should == "/other_pages/one"
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/other_pages/one'
     end
 
-    it "should generate nested route with string" do
-      page_path("one/two").should == "/other_pages/one/two"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/other_pages/one/two'
     end
 
-    it "should recognize nested route" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one/two"}, "/other_pages/one/two")
+    it 'should recognize nested route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one/two'
+        },
+        '/other_pages/one/two'
+      )
     end
 
-    it "should recognize normal route" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one"}, "/other_pages/one")
+    it 'should recognize normal route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one'
+        },
+        '/other_pages/one'
+      )
     end
 
-    it "should recognize normal route with dots" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one.two.three"}, "/other_pages/one.two.three")
+    it 'should recognize normal route with dots' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one.two.three'
+        },
+        '/other_pages/one.two.three'
+      )
     end
   end
 
+  context 'with default configuration disabled' do
+    around do |example|
+      cached_high_voltage_routes = HighVoltage.routes
+      HighVoltage.routes = false
+      Rails.application.reload_routes!
+
+      example.run
+
+      HighVoltage.routes = cached_high_voltage_routes
+      Rails.application.reload_routes!
+    end
+
+    it 'should not recognize routes' do
+      { :get => '/pages/one/two' }.should_not be_routable
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,30 +1,18 @@
-# Configure Rails Envinronment
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
-require "rails/test_help"
-require "rspec/rails"
-
-ActionMailer::Base.delivery_method = :test
-ActionMailer::Base.perform_deliveries = true
-ActionMailer::Base.default_url_options[:host] = "test.com"
+require 'rails/test_help'
+require 'rspec/rails'
+require 'capybara/rails'
 
 Rails.backtrace_cleaner.remove_silencers!
-
-# Configure capybara for integration testing
-require "capybara/rails"
 Capybara.default_driver   = :rack_test
 Capybara.default_selector = :css
 
-# Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
-  # Remove this line if you don't want RSpec's should and should_not
-  # methods or matchers
   require 'rspec/expectations'
   config.include RSpec::Matchers
-
-  # == Mock Framework
   config.mock_with :rspec
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: high_voltage
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-27 00:00:00.000000000 Z
+date: 2012-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -106,11 +106,18 @@ files:
 - gemfiles/rails-3.2.6.gemfile
 - high_voltage.gemspec
 - lib/high_voltage.rb
+- lib/high_voltage/constraints/root_route.rb
 - lib/high_voltage/engine.rb
+- lib/high_voltage/page_finder.rb
+- lib/high_voltage/route_drawers/default.rb
+- lib/high_voltage/route_drawers/root.rb
 - lib/high_voltage/version.rb
+- spec/constraints/root_route_spec.rb
+- spec/controllers/alternative_finder_controller_spec.rb
 - spec/controllers/pages_controller_spec.rb
 - spec/controllers/subclassed_pages_controller_spec.rb
 - spec/dummy/Rakefile
+- spec/dummy/app/controllers/alternative_finder_controller.rb
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/subclassed_pages_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
@@ -120,9 +127,13 @@ files:
 - spec/dummy/app/views/other_pages/also_dir/also_nested.html.erb
 - spec/dummy/app/views/other_pages/also_exists.html.erb
 - spec/dummy/app/views/other_pages/also_exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/also_dir/also_nested.html.erb
+- spec/dummy/app/views/pages/also_exists.html.erb
+- spec/dummy/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb
 - spec/dummy/app/views/pages/dir/nested.html.erb
 - spec/dummy/app/views/pages/exists.html.erb
 - spec/dummy/app/views/pages/exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/rot13.html.erb
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
@@ -149,6 +160,7 @@ files:
 - spec/dummy/public/javascripts/rails.js
 - spec/dummy/public/stylesheets/.gitkeep
 - spec/dummy/script/rails
+- spec/high_voltage/page_finder_spec.rb
 - spec/high_voltage_spec.rb
 - spec/integration/navigation_spec.rb
 - spec/routing/routes_spec.rb
@@ -167,7 +179,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2706060558663144713
+      hash: 4008834492193111030
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -176,11 +188,64 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2706060558663144713
+      hash: 4008834492193111030
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Simple static page rendering controller
-test_files: []
+test_files:
+- spec/constraints/root_route_spec.rb
+- spec/controllers/alternative_finder_controller_spec.rb
+- spec/controllers/pages_controller_spec.rb
+- spec/controllers/subclassed_pages_controller_spec.rb
+- spec/dummy/Rakefile
+- spec/dummy/app/controllers/alternative_finder_controller.rb
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/subclassed_pages_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/views/layouts/alternate.html.erb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/other/wrong.html.erb
+- spec/dummy/app/views/other_pages/also_dir/also_nested.html.erb
+- spec/dummy/app/views/other_pages/also_exists.html.erb
+- spec/dummy/app/views/other_pages/also_exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/also_dir/also_nested.html.erb
+- spec/dummy/app/views/pages/also_exists.html.erb
+- spec/dummy/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/dir/nested.html.erb
+- spec/dummy/app/views/pages/exists.html.erb
+- spec/dummy/app/views/pages/exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/rot13.html.erb
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/dummy/public/javascripts/application.js
+- spec/dummy/public/javascripts/controls.js
+- spec/dummy/public/javascripts/dragdrop.js
+- spec/dummy/public/javascripts/effects.js
+- spec/dummy/public/javascripts/prototype.js
+- spec/dummy/public/javascripts/rails.js
+- spec/dummy/public/stylesheets/.gitkeep
+- spec/dummy/script/rails
+- spec/high_voltage/page_finder_spec.rb
+- spec/high_voltage_spec.rb
+- spec/integration/navigation_spec.rb
+- spec/routing/routes_spec.rb
+- spec/spec_helper.rb