hierarchical_graph 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 501ca870e56fee37c942917a8471f238c82cac2c84a9eecb06ae4fb9440f0f9a
-  data.tar.gz: b5a59a609d92864e3132bb0f5d86154b1ec082f3697fdf97f07d02c2ebb37302
+  metadata.gz: a6c1ce470102ca17f36f40fe0f861c221c18237b46fa07d066baed98895501c8
+  data.tar.gz: '08cf95bf13e8217262973a222cb213de9559777170253460acfb6b9856316f1d'
 SHA512:
-  metadata.gz: 20ab16944cc5455d6f62278e291426d4e10c66f21e4be0cc6c0491cdd540872163a224bdfd9bf8d161f65b59e7a32bec7a8311aa4ff5ad3970248761d035eca4
-  data.tar.gz: 43f9f1e3cbe70fe4f2df57f326fa116f44c7c0d928025aae98c4dd00fea12c1be0554cd5d20432e983ea914459ef83a7be9238ad73675bf563b39ae8cea685d1
+  metadata.gz: 8e14241d62a3ffac4fa02fcf4c0ed37f7456658510a0e26ef17c63155dd5f9368fbe21dedd03c52182d86189523ef98df0cd4e1018c770f971e2b2e2077c1258
+  data.tar.gz: 97ed130cabcd32d51266c9fe5bcf7c606c11577746c87a5ba2e169b756b4abd7f9002def04e9bc0218ca8e7df838a0c9e843c634e90fde72ce6cbb771cebbf8b

data/lib/hierarchical_graph.rb

@@ -31,6 +31,8 @@ class HierarchicalGraph
   end
 
   def add_node(id, attributes={})
+    validate_not_present! id
+
     clear_cache
     parent_to_children[id] = Set.new
     child_to_parents[id] = Set.new
@@ -38,7 +40,7 @@ class HierarchicalGraph
   end
 
   def remove_node(id)
-    validate! id
+    validate_present! id
 
     parent_to_children[id].each { |child_id| child_to_parents[child_id].delete id }
     child_to_parents[id].each { |parent_id| parent_to_children[parent_id].delete id }
@@ -53,7 +55,7 @@ class HierarchicalGraph
   end
 
   def add_relation(parent_id:, child_id:)
-    validate! parent_id, child_id
+    validate_present! parent_id, child_id
 
     clear_cache
     parent_to_children[parent_id] << child_id
@@ -63,7 +65,7 @@ class HierarchicalGraph
   end
 
   def remove_relation(parent_id:, child_id:)
-    validate! parent_id, child_id
+    validate_present! parent_id, child_id
 
     clear_cache
     parent_to_children[parent_id].delete child_id
@@ -73,20 +75,28 @@ class HierarchicalGraph
   end
 
   def parents_of(id)
+    validate_present! id
+
     child_to_parents[id].map { |node_id| nodes[node_id] }
   end
 
   def children_of(id)
+    validate_present! id
+
     parent_to_children[id].map { |node_id| nodes[node_id] }
   end
 
   def ancestors_of(id)
+    validate_present! id
+
     ancestors_cache[id] ||= parents_of(id).flat_map do |parent|
       ancestors_of(parent.id) + [parent]
     end.uniq(&:id)
   end
 
   def descendants_of(id)
+    validate_present! id
+
     children_of(id).flat_map do |child|
       [child] + descendants_of(child.id)
     end.uniq(&:id)
@@ -101,9 +111,14 @@ class HierarchicalGraph
 
   attr_reader :nodes, :parent_to_children, :child_to_parents, :ancestors_cache, :descendants_cache
 
-  def validate!(*ids)
+  def validate_present!(*ids)
     invalid_ids = ids.reject { |id| nodes.key? id }
-    raise "Invalid nodes: #{invalid_ids.join(', ')}" if invalid_ids.any?
+    raise "Nodes not found: #{invalid_ids.join(', ')}" if invalid_ids.any?
+  end
+
+  def validate_not_present!(*ids)
+    invalid_ids = ids.select { |id| nodes.key? id }
+    raise "Nodes already exist: #{invalid_ids.join(', ')}" if invalid_ids.any?
   end
 
   def clear_cache

data/lib/hierarchical_graph/version.rb

@@ -1,3 +1,3 @@
 class HierarchicalGraph
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/hierarchical_graph_spec.rb

@@ -17,6 +17,15 @@ describe HierarchicalGraph do
     graph.count.must_equal 1
   end
 
+  it 'Add duplicated node' do
+    graph = HierarchicalGraph.new
+
+    graph.add_node 1
+
+    error = proc { graph.add_node 1 }.must_raise RuntimeError
+    error.message.must_equal "Nodes already exist: 1"
+  end
+
   it 'Remove node' do
     graph = HierarchicalGraph.new
     graph.add_node 1
@@ -31,7 +40,7 @@ describe HierarchicalGraph do
     graph = HierarchicalGraph.new
 
     error = proc { graph.remove_node 1 }.must_raise RuntimeError
-    error.message.must_equal "Invalid nodes: 1"
+    error.message.must_equal "Nodes not found: 1"
   end
 
   it 'Add relation' do
@@ -52,7 +61,7 @@ describe HierarchicalGraph do
     graph = HierarchicalGraph.new
 
     error = proc { graph.add_relation parent_id: 1, child_id: 2 }.must_raise RuntimeError
-    error.message.must_equal "Invalid nodes: 1, 2"
+    error.message.must_equal "Nodes not found: 1, 2"
   end
 
   it 'Remove relation' do
@@ -102,7 +111,7 @@ describe HierarchicalGraph do
     graph = HierarchicalGraph.new
 
     error = proc { graph.remove_relation parent_id: 1, child_id: 2 }.must_raise RuntimeError
-    error.message.must_equal "Invalid nodes: 1, 2"
+    error.message.must_equal "Nodes not found: 1, 2"
   end
 
   it 'Roots' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hierarchical_graph
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Gabriel Naiman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-27 00:00:00.000000000 Z
+date: 2020-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake