hexabat 0.0.1 → 0.0.2

data/README.md

@@ -1,4 +1,4 @@
-# Hexabat [![Build Status](https://secure.travis-ci.org/jacegu/hexabat.png?branch=master)](http://travis-ci.org/jacegu/hexabat)  [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/jacegu/hexabat)
+# Hexabat [![Build Status](https://secure.travis-ci.org/path11/hexabat.png?branch=master)](http://travis-ci.org/path11/hexabat)  [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/path11/hexabat)
 
 **Hexabat is a Github issues importer tool for Ruby.**
 
@@ -26,14 +26,14 @@ time. You will need to query page by page and get open and closed issues
 separately.
 
 Also, if you want to find out the total number of issues, there is no easy way
-of doing it. You can't find out the amount of open issues through the
+of doing it. You can find out the amount of open issues through the
 [repositories API](http://developer.github.com/v3/repos/#get)
 but, where are the closed ones?
 
 
 ## Features
 
-Hexabat tackles those two problems by providing  an easy way of importing
+Hexabat tackles those two problems by providing an easy way of importing
 the issues of a Github repository:
 
 ```ruby
@@ -56,14 +56,17 @@ That means that Hexabat will allow you to:
 
 * **Find out the total number of issues** (both open and closed) of the repository.
 * **Do something with the data of every issue in the repository** (i.e. store it in a database).
-* **Handle importing errors properly** (i.e. store the error reason in a database)
+  You can check the JSON returned by github on the
+  [github api documentation](http://developer.github.com/v3/issues/#list-issues-for-a-repository).
+  The only thing Hexabat does is parsing this JSON and yield the issues to the
+  callback one by one.
+* **Handle importing errors properly** (i.e. store the error reason in a database).
 
 You don't need set every single callback if you don't want to. You can setup only one
 callback if that's what you need. We also provide a default `errback` that will
 print to `STDERR` a message with the failure (pretty similar to the example above).
 
 
-
 ###Authentication
 
 If you are importing a public repository's issues you don't need to authenticate:
@@ -97,7 +100,6 @@ end
 
 Hexabat will start the event loop for you if you call it outside a running one.
 
-
 ### Does Hexabat stop the event loop?
 
 No it doesn't. Given that Hexabat doesn't know the work you are going to do

data/hexabat.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |gem|
   gem.email         = %w{alberto@path11.com ecomba@path11.com javier@path11.com sebastian@path11.com}
   gem.description   = %q{A Github issues importing tool}
   gem.summary       = %q{Importing all the issues of a Github repository is a complex task: the Github API does not provide an easy way of doing it. Hexabat will help you with that. It will allow you to find out the total number of issues (counting both open and closed ones) and to perform an action with each one of them.}
-  gem.homepage      = ""
+  gem.homepage      = "http://github.com/path11/hexabat"
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
@@ -23,4 +23,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'webmock'
+  gem.add_development_dependency 'simplecov'
+  gem.add_development_dependency 'yard'
 end

data/lib/hexabat/client.rb

@@ -30,7 +30,7 @@ module Hexabat
     def on(event_callback)
       event = event_callback.keys.first
       raise_unknown_event_error event unless known? event
-      callbacks.merge! event_callback
+      callbacks.merge! event_callback unless event_callback[event].nil?
     end
 
     def known_events

data/lib/hexabat/version.rb

@@ -1,3 +1,3 @@
 module Hexabat
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/hexabat/client_spec.rb

@@ -19,6 +19,12 @@ describe Hexabat::Client do
     expect { subject.on unknown_event: a_callback}.to raise_error ArgumentError
   end
 
+  it 'ignores attemts to set a callback to nil' do
+    subject.callbacks[:error].should_not be nil
+    subject.on error: nil
+    subject.callbacks[:error].should_not be nil
+  end
+
   it 'starts Event Machine if it is not running' do
     EM.stub(:reactor_running?).and_return(false)
     EM.should_receive(:run)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hexabat
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-01 00:00:00.000000000 Z
+date: 2012-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -123,6 +123,38 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Github issues importing tool
 email:
 - alberto@path11.com
@@ -162,7 +194,7 @@ files:
 - spec/hexabat/page_request_buider_spec.rb
 - spec/hexabat/page_response_processor_spec.rb
 - spec/hexabat_spec.rb
-homepage: ''
+homepage: http://github.com/path11/hexabat
 licenses: []
 post_install_message: 
 rdoc_options: []
@@ -174,18 +206,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2707408037992863866
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2707408037992863866
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24