heroku_san 4.0.6 → 4.0.7

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change log (curated)
 
+## v4.0.7
+
+  * Closes #114 & #111
+  * Closes #115
+
 ## v4.0.5
 
   * Remove ActiveSupport dependency

data/lib/git.rb

@@ -2,6 +2,8 @@ require 'rake'
 require 'rake/dsl_definition'
 
 module Git
+  class NoTagFoundError < Exception; end
+
   include Rake::DSL
   
   def git_clone(repos, dir)
@@ -34,7 +36,7 @@ module Git
 
   def git_tag(glob)
     return nil if glob.nil?
-    %x{git tag -l '#{glob}'}.split("\n").last
+    %x{git tag -l '#{glob}'}.split("\n").last || (raise NoTagFoundError, "No tag found [#{glob}]")
   end
   
   def git_revision(repo)

data/lib/heroku_san.rb

@@ -1,4 +1,4 @@
-require 'railtie' if defined?(Rails) && Rails::VERSION::MAJOR >= 3
+require File.join(File.dirname(__FILE__), 'railtie.rb') if defined?(Rails) && Rails::VERSION::MAJOR >= 3
 require 'git'
 require 'heroku_san/stage'
 require 'heroku_san/project'

data/lib/heroku_san/version.rb

@@ -1,3 +1,3 @@
 module HerokuSan
-  VERSION = "4.0.6"
+  VERSION = "4.0.7"
 end

data/spec/git_spec.rb

@@ -32,11 +32,13 @@ describe GitTest do
       subject.should_receive("`").with("git tag -l 'pattern*'") { "x\n\y\n\z\n" }
       subject.git_tag('pattern*').should == "z"
     end
-    it "returns nil if no tags match the pattern" do
+    it "raises exception if no tags match the pattern" do
       subject.should_receive("`").with("git tag -l 'pattern*'") { "\n" }
-      subject.git_tag('pattern*').should == nil
+      expect {
+        subject.git_tag('pattern*')
+      }.to raise_error(Git::NoTagFoundError)
     end
-    it "returns nil for a nil tag" do
+    it "returns nil for a nil glob" do
       subject.should_not_receive("`").with("git tag -l ''") { "\n" }
       subject.git_tag(nil).should == nil
     end

data/spec/heroku_san/stage_spec.rb

@@ -79,7 +79,8 @@ describe HerokuSan::Stage do
 
   describe "#push" do
     it "deploys to heroku" do
-      subject.should_receive(:git_push).with(git_parsed_tag(subject.tag), subject.repo, [])
+      subject.should_receive(:git_parsed_tag).with(nil) {'tag'}
+      subject.should_receive(:git_push).with('tag', subject.repo, [])
       subject.push
     end
     
@@ -89,7 +90,8 @@ describe HerokuSan::Stage do
     end
     
     it "deploys with --force" do
-      subject.should_receive(:git_push).with(git_parsed_tag(subject.tag), subject.repo, %w[--force])
+      subject.should_receive(:git_parsed_tag).with(nil) {'tag'}
+      subject.should_receive(:git_push).with('tag', subject.repo, %w[--force])
       subject.push(nil, :force)
     end
     

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: heroku_san
 version: !ruby/object:Gem::Version
-  version: 4.0.6
+  version: 4.0.7
   prerelease: 
 platform: ruby
 authors:
@@ -239,7 +239,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2142218432852007923
+      hash: 3672813808786714588
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: