heracles-wrapper 0.0.2 → 0.0.3

data/README.md

@@ -28,9 +28,9 @@ Once installed in your application use rails generate:
 
     Heracles::Wrapper.service(
       :create_job,
-      :workflow_name => 'RabbitWarren',
+      :workflow_name => <WORKFLOW_NAME>,
       :parameters => {
-        :callback_url => 'http://google.com'
+        :notification_url => 'http://google.com'
       }
     )
 
@@ -43,9 +43,9 @@ Once installed in your application use rails generate:
       let(:service) {
         Heracles::Wrapper.service(
           :create_job,
-          :workflow_name => 'RabbitWarren',
+          :workflow_name => <WORKFLOW_NAME>,
           :parameters => {
-            :callback_url => 'http://google.com'
+            :notification_url => 'http://google.com'
           }
         )
       }

data/lib/heracles-wrapper/notification_response.rb

@@ -1,3 +1,4 @@
+require 'active_support/core_ext/hash/indifferent_access'
 require 'method_decorators'
 require 'method_decorators/decorators/precondition'
 
@@ -19,8 +20,9 @@ class Heracles::Wrapper::NotificationResponse
     params[:job_status] &&
     params[:notification_payload].respond_to?(:to_hash)
   }
-  def initialize(params)
-    @notification_payload = params.fetch(:notification_payload).to_hash
+  def initialize(raw_params)
+    params = HashWithIndifferentAccess.new(raw_params)
+    @notification_payload = HashWithIndifferentAccess.new(params.fetch(:notification_payload))
     @job_id = params.fetch(:job_id).to_i
     @job_status = params.fetch(:job_status).to_sym
     @one_time_notification_key = params.fetch(:one_time_notification_key, nil)

data/lib/heracles-wrapper/request/create_job.rb

@@ -44,22 +44,25 @@ class Heracles::Wrapper::Request::CreateJob
   # Hits a given URL
   # Syncrhonously waits for response.
   def call
-    decorate_response(
-      RestClient.post(
-        url.to_s,
-        as_json,
-        {
-          :content_type => :json,
-          :accept => :json,
-          :verify_ssl => OpenSSL::SSL::VERIFY_NONE
-        }
-      )
-    )
+    request_decorator.call(make_request)
   rescue RestClient::Exception => e
     raise Heracles::Wrapper::RequestFailure.new(e.response)
   end
   protected
-  def decorate_response(response)
-    Heracles::Wrapper::RequestSuccess.new(response)
+
+  def make_request
+    RestClient.post(
+      url.to_s,
+      as_json,
+      {
+        :content_type => :json,
+        :accept => :json,
+        :verify_ssl => OpenSSL::SSL::VERIFY_NONE
+      }
+    )
+  end
+
+  def request_decorator
+    Heracles::Wrapper::RequestSuccess.method(:new)
   end
 end

data/lib/heracles-wrapper/version.rb

@@ -1,5 +1,5 @@
 module Heracles
   module Wrapper
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/rails/generators/heracles/wrapper/notification_response/templates/notification_response.rb.erb

@@ -10,8 +10,7 @@ class <%= class_name %> < DelegateClass(Heracles::Wrapper::NotificationResponse)
     # The following two lines are logically equivalent
     #   @pid = fetch(:pid)
     #   @pid = params.fetch(:notification_payload).fetch(:pid)
-    #
-    # You may also want to define, at the class level the following:
-    #   attr_reader :pid
   end
+  # You may also want to define, at the class level the following:
+  #   attr_reader :pid
 end

data/lib/rails/generators/heracles/wrapper/notification_response/templates/notification_response_spec.rb.erb

@@ -25,7 +25,9 @@ describe <%= class_name %> do
     end
     it 'should behave as a the :notification_payload hash' do
       subject[:hello].should == params[:notification_payload][:hello]
+      subject['hello'].should == params[:notification_payload][:hello]
       subject.fetch(:hello).should == params[:notification_payload][:hello]
+      subject.fetch('hello').should == params[:notification_payload][:hello]
     end
   end
 end

data/spec/heracles-wrapper/notification_response_spec.rb

@@ -8,10 +8,12 @@ describe Heracles::Wrapper::NotificationResponse do
   describe 'well formed response' do
     let(:expected_job_status) { 'ok'}
     let(:expected_job_id) { '1234' }
+    let(:expected_one_time_notification_key) { '1234' }
     let(:params) {
       {
         :job_id => expected_job_id,
         :job_status => expected_job_status,
+        :one_time_notification_key => expected_one_time_notification_key,
         :notification_payload => {
           :hello => { :world => [{:foo => 1},{:foo => 2},{:bar => 3}]}
         }
@@ -20,8 +22,11 @@ describe Heracles::Wrapper::NotificationResponse do
 
     it 'should extract methods based on keys' do
       subject.must_respond_to :fetch
+      subject.fetch('hello').must_equal(subject.fetch(:hello))
       subject.fetch(:hello).must_equal(
-        params.fetch(:notification_payload).fetch(:hello)
+        HashWithIndifferentAccess.new(
+          params.fetch(:notification_payload).fetch(:hello)
+        )
       )
     end
 
@@ -32,7 +37,7 @@ describe Heracles::Wrapper::NotificationResponse do
       subject.job_id.must_equal expected_job_id.to_i
     end
 
-    it 'should have #one_time_key' do
+    it 'should have #one_time_notification_key' do
       subject.must_respond_to :one_time_notification_key
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: heracles-wrapper
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-09 00:00:00.000000000 Z
+date: 2012-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -193,7 +193,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3196260337063136150
+      hash: -1695767987685687120
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -202,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3196260337063136150
+      hash: -1695767987685687120
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24