henkei 1.23.0 → 1.23.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9ebc4be4691020c72328134a33a9ffe6b4fb79a939ddc9ce833c56551abb86d
-  data.tar.gz: 17402ba43e9840b59090a82f1cd39e79e594ca3d36c763b958f9243174990f8e
+  metadata.gz: 7cecb124ea7a00d6a004491e8ab4a335ec5fbc465f5b55216b918257bd5f8759
+  data.tar.gz: 80861060efee0b5cabb8523dd578be9c67e20a6b55c2d5cab88c63a423123226
 SHA512:
-  metadata.gz: 74dcf4d6f2ce5f99b77b3c1fdd34a271220c58e8aae167b40cde35eef2166570d3c4de7b94f91d98158fe3cc384ec7a7688cf98812e378607e31f8d24e06420f
-  data.tar.gz: aa210ee582d56592932684216eb93cd3f91ea7ba95e3b1d4bc672ed09bdc9605008e7f6f21472ca291c574cb1050b18eb6bdb47aa5caa03341ae393cbb0b9939
+  metadata.gz: e6018c46475c3e5bef9f4c2482c05dffd6151d5fbb288f05d4bccd0a1503a26ffeba22784ebf5e731e23120da53f170edb37f310260e9d708bc2e70c79d438e1
+  data.tar.gz: 7a8d21850552eda6b27f85dacdc9e360c0962ee08e8ed4bd45a704002f6837142953a47333642ec56ee842e0ee406b56d7f3f3b48dacbad4c4935455b1521bd8

data/.travis.yml

@@ -1,6 +1,9 @@
 env:
   global:
     - CC_TEST_REPORTER_ID=bb96c1ff9dc66724c38fb4eb54486dd72dc88a7fd6e727c034b9cf8d747d069e
+  jobs:
+    - INCLUDE_RAILS=false
+    - INCLUDE_RAILS=true
 
 language: ruby
 rvm:

data/henkei.gemspec

@@ -25,6 +25,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'mime-types', '>= 1.23', '< 4'
 
   spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'rails', '~> 5.0'
   spec.add_development_dependency 'rake', '~> 12.3'
   spec.add_development_dependency 'rspec', '~> 3.7'
   spec.add_development_dependency 'rubocop', '~> 0.71'

data/lib/henkei.rb

@@ -226,7 +226,7 @@ class Henkei # rubocop:disable Metrics/ClassLength
   # Internal helper for calling to Tika library directly
   #
   def self.client_read(type, data)
-    Open3.capture2(tika_command(type), stdin_data: data).first
+    Open3.capture2(tika_command(type), stdin_data: data, binmode: true).first
   end
   private_class_method :client_read
 

data/lib/henkei/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Henkei
-  VERSION = '1.23.0'
+  VERSION = '1.23.1'
 end

data/spec/henkei_spec.rb

@@ -3,6 +3,9 @@
 require 'helper.rb'
 require 'henkei'
 
+# Some of the tests have been known to fail in weird and wonderful ways when `rails` is included
+require 'rails' if ENV['INCLUDE_RAILS'] == 'true'
+
 describe Henkei do
   let(:data) { File.read 'spec/samples/sample.docx' }
 
@@ -152,7 +155,7 @@ describe Henkei do
         expect(henkei.html).to include '<meta name="tiff:ImageWidth" content="792"/>'
       end
 
-      it '#mimetype returns an empty result' do
+      it '#mimetype returns `image/png`' do
         expect(henkei.mimetype.content_type).to eq 'image/png'
       end
     end
@@ -184,6 +187,18 @@ describe Henkei do
     end
   end
 
+  context 'when source is a remote PDF' do
+    let(:henkei) { Henkei.new 'https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf' }
+
+    specify '#text reads text' do
+      expect(henkei.text).to include 'Dummy PDF file'
+    end
+
+    specify '#metadata reads metadata' do
+      expect(henkei.metadata['Content-Type']).to eq 'application/pdf'
+    end
+  end
+
   context 'working as server mode' do
     specify '#starts and kills server' do
       begin

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: henkei
 version: !ruby/object:Gem::Version
-  version: 1.23.0
+  version: 1.23.1
 platform: ruby
 authors:
 - Erol Fornoles
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-26 00:00:00.000000000 Z
+date: 2020-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -65,6 +65,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement