henkei 1.22.0 → 1.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6f2128fb621a465d981a99a0c5198208ef9bc245f7d955799892d41e3f1118d
-  data.tar.gz: 6e6bc03ed962ade5d3e93aff358820ba26eb0b758cf65a3fb6e61de4634704ca
+  metadata.gz: f9ebc4be4691020c72328134a33a9ffe6b4fb79a939ddc9ce833c56551abb86d
+  data.tar.gz: 17402ba43e9840b59090a82f1cd39e79e594ca3d36c763b958f9243174990f8e
 SHA512:
-  metadata.gz: 894dfe43478258980edcdabd464ae6903793c7eb6c0b03661e1548af2b99701e9f320b5dca0e237925c9ef3a1f7b0bd9bfbeb80b6d8ce47c766ca601b23c380b
-  data.tar.gz: 813774141e6acc2d1343aea110cd40d84c12482c0d7d769e54e11914eeba28e62cf1c15390407594e92b0d3b4ca6366cc279651d3239b3e0cd5c67cc11ae3caa
+  metadata.gz: 74dcf4d6f2ce5f99b77b3c1fdd34a271220c58e8aae167b40cde35eef2166570d3c4de7b94f91d98158fe3cc384ec7a7688cf98812e378607e31f8d24e06420f
+  data.tar.gz: aa210ee582d56592932684216eb93cd3f91ea7ba95e3b1d4bc672ed09bdc9605008e7f6f21472ca291c574cb1050b18eb6bdb47aa5caa03341ae393cbb0b9939

data/.rubocop.yml

@@ -1,10 +1,10 @@
+Layout/LineLength:
+  Max: 120
+
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
 
-Metrics/LineLength:
-  Max: 120
-
 Metrics/MethodLength:
   Max: 15
 

data/bin/console

@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'henkei'
+
+require 'irb'
+IRB.start

data/lib/henkei.rb

@@ -11,10 +11,12 @@ require 'json'
 require 'socket'
 require 'stringio'
 
+require 'open3'
+
 # Read text and metadata from files and documents using Apache Tika toolkit
 class Henkei # rubocop:disable Metrics/ClassLength
   GEM_PATH = File.dirname(File.dirname(__FILE__))
-  JAR_PATH = File.join(Henkei::GEM_PATH, 'jar', 'tika-app-1.22.jar')
+  JAR_PATH = File.join(Henkei::GEM_PATH, 'jar', 'tika-app-1.23.jar')
   CONFIG_PATH = File.join(Henkei::GEM_PATH, 'jar', 'tika-config.xml')
   DEFAULT_SERVER_PORT = 9293 # an arbitrary, but perfectly cromulent, port
 
@@ -224,11 +226,7 @@ class Henkei # rubocop:disable Metrics/ClassLength
   # Internal helper for calling to Tika library directly
   #
   def self.client_read(type, data)
-    IO.popen tika_command(type), 'r+' do |io|
-      io.write data
-      io.close_write
-      io.read
-    end
+    Open3.capture2(tika_command(type), stdin_data: data).first
   end
   private_class_method :client_read
 

data/lib/henkei/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Henkei
-  VERSION = '1.22.0'
+  VERSION = '1.23.0'
 end

data/spec/henkei_spec.rb

@@ -40,6 +40,16 @@ describe Henkei do
       )
       expect(mimetype.extensions).to include 'docx'
     end
+
+    context 'when passing in the `pipe-error.png` test file' do
+      let(:data) { File.read 'spec/samples/pipe-error.png' }
+
+      it 'returns an empty result' do
+        text = Henkei.read :text, data
+
+        expect(text).to eq ''
+      end
+    end
   end
 
   describe '.new' do
@@ -129,6 +139,23 @@ describe Henkei do
     specify '#metadata reads metadata' do
       expect(henkei.metadata['Content-Type']).to eq %w[application/vnd.apple.pages application/vnd.apple.pages]
     end
+
+    context 'when passing in the `pipe-error.png` test file' do
+      let(:henkei) { Henkei.new 'spec/samples/pipe-error.png' }
+
+      it '#text returns an empty result' do
+        expect(henkei.text).to eq ''
+      end
+
+      it '#html returns an empty body' do
+        expect(henkei.html).to include '<body/>'
+        expect(henkei.html).to include '<meta name="tiff:ImageWidth" content="792"/>'
+      end
+
+      it '#mimetype returns an empty result' do
+        expect(henkei.mimetype.content_type).to eq 'image/png'
+      end
+    end
   end
 
   context 'initialized with a given URI' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: henkei
 version: !ruby/object:Gem::Version
-  version: 1.22.0
+  version: 1.23.0
 platform: ruby
 authors:
 - Erol Fornoles
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-30 00:00:00.000000000 Z
+date: 2019-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -125,7 +125,8 @@ description: Read text and metadata from files and documents using Apache Tika t
 email:
 - erol.fornoles@gmail.com
 - a.bromwich@gmail.com
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
@@ -138,14 +139,16 @@ files:
 - NOTICE.txt
 - README.md
 - Rakefile
+- bin/console
 - henkei.gemspec
-- jar/tika-app-1.22.jar
+- jar/tika-app-1.23.jar
 - jar/tika-config.xml
 - lib/henkei.rb
 - lib/henkei/version.rb
 - lib/henkei/yomu.rb
 - spec/helper.rb
 - spec/henkei_spec.rb
+- spec/samples/pipe-error.png
 - spec/samples/sample filename with spaces.pages
 - spec/samples/sample-metadata-values-with-colons.doc
 - spec/samples/sample.docx
@@ -169,8 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Read text and metadata from files and documents (.doc, .docx, .pages, .odt,
@@ -178,6 +180,7 @@ summary: Read text and metadata from files and documents (.doc, .docx, .pages, .
 test_files:
 - spec/helper.rb
 - spec/henkei_spec.rb
+- spec/samples/pipe-error.png
 - spec/samples/sample filename with spaces.pages
 - spec/samples/sample-metadata-values-with-colons.doc
 - spec/samples/sample.docx