hello_sign 1.3.0 → 1.3.1

data/lib/hello_sign/connection.rb

@@ -1,11 +1,12 @@
+require 'hello_sign/version'
 require 'hello_sign/response'
 require 'faraday'
 require 'faraday_middleware'
 
 module HelloSign
   class Connection
-    API_ENDPOINT = 'https://api.hellosign.com'
-    API_VERSION  = '3'
+    API_ENDPOINT = 'https://api.hellosign.com'.freeze
+    API_VERSION  = '3'.freeze
 
     attr_reader :auth_configuration
 

data/lib/hello_sign/error.rb

@@ -2,6 +2,31 @@ module HelloSign
   class Error < StandardError
     attr_reader :message, :status_code
 
+    def self.from_error_name(error_name)
+      case error_name
+      when 'bad_request'
+        BadRequest
+      when 'unauthorized'
+        Unauthorized
+      when 'forbidden'
+        Forbidden
+      when 'not_found'
+        NotFound
+      when 'unknown'
+        Unknown
+      when 'team_invite_failed'
+        TeamInviteFailed
+      when 'invalid_recipient'
+        InvalidRecipient
+      when 'convert_failed'
+        ConvertFailed
+      when 'signature_request_cancel_failed'
+        SignatureRequestCancelFailed
+      else
+        Error
+      end
+    end
+
     def initialize(message = nil, status_code = nil)
       @message, @status_code = message, status_code
     end

data/lib/hello_sign/middleware/raise_error.rb

@@ -1,46 +1,19 @@
-require 'hello_sign/error'
-
 require 'faraday'
+require 'hello_sign/error'
 
 module HelloSign
   module Middleware
     class RaiseError < Faraday::Response::Middleware
 
       def on_complete(env)
-        body = env[:body] or return
-
-        return unless body.is_a?(Hash)
+        body = env[:body] and body.is_a?(Hash) or return
 
         error = body[:error] and begin
-          exception = begin
-            case error[:error_name]
-            when 'bad_request'
-              HelloSign::Error::BadRequest
-            when 'unauthorized'
-              HelloSign::Error::Unauthorized
-            when 'forbidden'
-              HelloSign::Error::Forbidden
-            when 'not_found'
-              HelloSign::Error::NotFound
-            when 'unknown'
-              HelloSign::Error::Unknown
-            when 'team_invite_failed'
-              HelloSign::Error::TeamInviteFailed
-            when 'invalid_recipient'
-              HelloSign::Error::InvalidRecipient
-            when 'convert_failed'
-              HelloSign::Error::ConvertFailed
-            when 'signature_request_cancel_failed'
-              HelloSign::Error::SignatureRequestCancelFailed
-            else
-              HelloSign::Error
-            end
-          end
-
+          exception   = Error.from_error_name(error[:error_name])
           message     = error[:error_msg]
           status_code = env[:response][:status]
 
-          raise exception.new(message, status_code)
+          fail exception.new(message, status_code)
         end
       end
 

data/lib/hello_sign/parameters/reusable_form_signature_request.rb

@@ -1,14 +1,18 @@
 module HelloSign
   module Parameters
     class ReusableFormSignatureRequest
-      attr_accessor :reusable_form_id, :title, :subject, :message, :test_mode
-      private :reusable_form_id, :title, :subject, :message, :test_mode
+      attr_accessor :test_mode, :reusable_form_id, :title, :subject, :message
+      private :test_mode, :reusable_form_id, :title, :subject, :message
 
       attr_writer :ccs, :signers, :custom_fields
 
+      def initialize
+        @test_mode, @ccs, @signers, @custom_fields = 0, nil, nil, nil
+      end
+
       def formatted
         {
-          test_mode:        test_mode || 0,
+          test_mode:        test_mode,
           reusable_form_id: reusable_form_id,
           title:            title,
           subject:          subject,

data/lib/hello_sign/parameters/signature_request.rb

@@ -7,7 +7,11 @@ module HelloSign
       attr_accessor :title, :subject, :message, :ccs, :test_mode
       private :title, :subject, :message, :ccs, :test_mode
 
-      attr_writer :signers, :files, :form_fields_per_document, :test_mode
+      attr_writer :signers, :files, :form_fields_per_document
+
+      def initialize
+        @signers, @files, @form_fields_per_document = nil, nil, nil
+      end
 
       def formatted
         {

data/lib/hello_sign/proxy/team.rb

@@ -24,11 +24,11 @@ module HelloSign
       end
 
       def add_member(params = {})
-        client.post("/team/add_member", body: params)
+        client.post('/team/add_member', body: params)
       end
 
       def remove_member(params = {})
-        client.post("/team/remove_member", body: params)
+        client.post('/team/remove_member', body: params)
       end
 
     end

data/lib/hello_sign/version.rb

@@ -1,3 +1,3 @@
 module HelloSign
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/spec/unit/client_spec.rb

@@ -51,10 +51,6 @@ describe HelloSign::Client do
   end
 
   context "when a hash is passed to the constructor" do
-    subject(:hs_client) do
-      HelloSign::Client.new(email_address: email_address, password: password)
-    end
-
     it "raises an exception if an email address is not provided" do
       expect { HelloSign::Client.new(password: 'space') }.to(
         raise_error ArgumentError

data/spec/unit/error_spec.rb

@@ -2,6 +2,39 @@ require 'helper'
 require 'hello_sign/error'
 
 describe HelloSign::Error do
+  describe ".from_error_name" do
+    %w(
+      bad_request
+      unauthorized
+      forbidden
+      not_found
+      unknown
+      team_invite_failed
+      invalid_recipient
+      convert_failed
+      signature_request_cancel_failed
+    ).each do |error_name|
+      context "when the error name is #{error_name}" do
+        it "returns the proper exception" do
+          expect(HelloSign::Error.from_error_name(error_name)).to(
+            be(
+              HelloSign::Error.const_get(
+                error_name.split('_').map(&:capitalize).join
+              )
+            )
+          )
+        end
+      end
+    end
+
+    context "when the error name is unknown" do
+      it "returns a generic exception" do
+        expect(HelloSign::Error.from_error_name('no_such_error'))
+          .to be HelloSign::Error
+      end
+    end
+  end
+
   specify do
     expect { raise HelloSign::Error }.to(
       raise_error StandardError

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hello_sign
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-11 00:00:00.000000000 Z
+date: 2014-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -182,15 +182,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 772753378671627303
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 772753378671627303
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: A Ruby interface to the HelloSign API
@@ -224,4 +230,3 @@ test_files:
 - spec/unit/proxy/team_spec.rb
 - spec/unit/proxy/unclaimed_draft_spec.rb
 - spec/unit/upload_io_spec.rb
-has_rdoc: