hello_sign 1.1.1 → 1.2.0

data/lib/hello_sign.rb

@@ -33,7 +33,8 @@ module HelloSign
     private
 
     def credentials_match?
-      @client && client_credentials.hash == provided_credentials.hash
+      instance_variable_defined?(:@client) &&
+        client_credentials.hash == provided_credentials.hash
     end
 
     def client_credentials

data/lib/hello_sign/file.rb

@@ -5,7 +5,8 @@ module HelloSign
   class File
     DEFAULT_MIME_TYPE = MIME_TYPES.fetch('txt')
 
-    attr_reader :filename, :io_object, :mime_type
+    attr_reader :filename, :io_object
+    private :filename, :io_object
 
     def initialize(file_data)
       @filename  = file_data[:filename]

data/lib/hello_sign/parameters/reusable_form_signature_request.rb

@@ -1,8 +1,10 @@
 module HelloSign
   module Parameters
     class ReusableFormSignatureRequest
-      attr_writer :reusable_form_id, :title, :subject, :message, :ccs, :signers,
-        :custom_fields
+      attr_accessor :reusable_form_id, :title, :subject, :message
+      private :reusable_form_id, :title, :subject, :message
+
+      attr_writer :ccs, :signers, :custom_fields
 
       def formatted
         {
@@ -18,8 +20,6 @@ module HelloSign
 
       private
 
-      attr_reader :reusable_form_id, :title, :subject, :message
-
       def formatted_ccs
         ccs.each_with_object({}) do |cc, parameter|
           parameter[cc[:role]] = {email_address: cc[:email_address]}

data/lib/hello_sign/parameters/signature_request.rb

@@ -3,23 +3,25 @@ require 'hello_sign/file'
 module HelloSign
   module Parameters
     class SignatureRequest
-      attr_writer :title, :subject, :message, :ccs, :signers, :files
+      attr_accessor :title, :subject, :message, :ccs, :form_fields_per_document
+      private :title, :subject, :message, :ccs, :form_fields_per_document
+
+      attr_writer :signers, :files
 
       def formatted
         {
-          title:              title,
-          subject:            subject,
-          message:            message,
-          cc_email_addresses: ccs,
-          signers:            formatted_signers,
-          file:               formatted_files
+          title:                    title,
+          subject:                  subject,
+          message:                  message,
+          cc_email_addresses:       ccs,
+          signers:                  formatted_signers,
+          file:                     formatted_files,
+          form_fields_per_document: form_fields_per_document
         }
       end
 
       private
 
-      attr_reader :title, :subject, :message, :ccs
-
       def formatted_signers
         signers.each_with_index.each_with_object({}) do |(signer, i), parameter|
           parameter[i] = {

data/lib/hello_sign/proxy/settings.rb

@@ -1,5 +1,3 @@
-require 'hello_sign/client'
-
 module HelloSign
   module Proxy
     class Settings

data/lib/hello_sign/version.rb

@@ -1,3 +1,3 @@
 module HelloSign
-  VERSION = '1.1.1'
+  VERSION = '1.2.0'
 end

data/spec/integration/signature_request_spec.rb

@@ -24,6 +24,21 @@ describe HelloSign do
             {filename: 'spec/fixtures/test.jpg'},
             {io: image_io, mime: 'image/jpeg'}
           ]
+          request.form_fields_per_document = [
+            [],
+            [
+              {
+                type:     'text',
+                x:        112,
+                y:        328,
+                width:    100,
+                height:   16,
+                required: true,
+                signer:   1
+              }
+            ]
+          ]
+
         end
 
         expect(a_post_with_auth('/signature_request/send')

data/spec/unit/hello_sign_spec.rb

@@ -10,6 +10,12 @@ describe HelloSign do
     HelloSign.password      = password
   end
 
+  after do
+    if HelloSign.instance_variable_defined?(:@client)
+      HelloSign.send(:remove_instance_variable, :@client)
+    end
+  end
+
   describe "::client" do
     let(:client) { double('client') }
 
@@ -36,8 +42,6 @@ describe HelloSign do
         HelloSign.client
       end
 
-      after { HelloSign.instance_variable_set(:@client, nil) }
-
       its(:client) { should be client }
 
       context "and the credentials change" do
@@ -56,8 +60,6 @@ describe HelloSign do
 
     before { allow(HelloSign::Client).to receive(:new).and_return(client) }
 
-    after { HelloSign.instance_variable_set(:@client, nil) }
-
     describe "::account" do
       before do
         allow(client).to receive(:account)

data/spec/unit/middleware/raise_error_spec.rb

@@ -36,7 +36,7 @@ describe HelloSign::Middleware::RaiseError do
             ).merge(response_headers)
           )
         rescue HelloSign::Error::BadRequest => e
-          expect("#{e}").to match /#{Regexp.escape("[Status code: 418] I'm a teapot")}/
+          expect("#{e}").to match(/#{Regexp.escape("[Status code: 418] I'm a teapot")}/)
         end
       end
     end

data/spec/unit/parameters/signature_request_spec.rb

@@ -18,7 +18,21 @@ describe HelloSign::Parameters::SignatureRequest do
             0 => {name: 'Jack', email_address: 'jack@hill.com', order: 0},
             1 => {name: 'Jill', email_address: 'jill@hill.com', order: 1}
           },
-          file: {1 => text_file, 2 => image_file}
+          file: {1 => text_file, 2 => image_file},
+          form_fields_per_document: [
+            [],
+            [
+              {
+                type:     'text',
+                x:        112,
+                y:        328,
+                width:    100,
+                height:   16,
+                required: true,
+                signer:   1
+              }
+            ]
+          ]
         }
       end
 
@@ -35,6 +49,20 @@ describe HelloSign::Parameters::SignatureRequest do
           @file_data_1 = {filename: 'test.txt', io: 'text file IO object', mime: 'text/plain'},
           @file_data_2 = {filename: 'test.jpg', io: 'image file IO object', mime: 'image/jpeg'}
         ]
+        request_parameters.form_fields_per_document = [
+          [],
+          [
+            {
+              type:     'text',
+              x:        112,
+              y:        328,
+              width:    100,
+              height:   16,
+              required: true,
+              signer:   1
+            }
+          ]
+        ]
 
         allow(HelloSign::File).to(
           receive(:new).with(@file_data_1).and_return(text_file)
@@ -55,12 +83,13 @@ describe HelloSign::Parameters::SignatureRequest do
     context "when required parameters are omitted" do
       let(:expected) do
         {
-          title:              nil,
-          subject:            nil,
-          message:            nil,
-          cc_email_addresses: nil,
-          signers:            {},
-          file:               {}
+          title:                    nil,
+          subject:                  nil,
+          message:                  nil,
+          cc_email_addresses:       nil,
+          signers:                  {},
+          file:                     {},
+          form_fields_per_document: nil
         }
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hello_sign
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-06 00:00:00.000000000 Z
+date: 2013-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -32,17 +32,17 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -130,7 +130,7 @@ files:
 - spec/unit/proxy/team_spec.rb
 - spec/unit/proxy/unclaimed_draft_spec.rb
 - spec/unit/upload_io_spec.rb
-homepage: http://www.github.com/craiglittle/hello_sign
+homepage: https://github.com/craiglittle/hello_sign
 licenses:
 - MIT
 post_install_message: 
@@ -143,18 +143,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1499078184543381550
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1499078184543381550
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25
@@ -191,3 +185,4 @@ test_files:
 - spec/unit/proxy/team_spec.rb
 - spec/unit/proxy/unclaimed_draft_spec.rb
 - spec/unit/upload_io_spec.rb
+has_rdoc: