hello_sign 0.4.0 → 0.5.0

data/lib/hello_sign/client.rb

@@ -10,11 +10,11 @@ module HelloSign
     API_ENDPOINT = 'https://api.hellosign.com'
     API_VERSION  = '/v3'
 
-    attr_reader :email, :password
+    attr_reader :email_address, :password
 
-    def initialize(email, password)
-      @email    = email
-      @password = password
+    def initialize(email_address, password)
+      @email_address = email_address
+      @password      = password
     end
 
     def get(path, options = {})
@@ -29,7 +29,7 @@ module HelloSign
 
     def request(method, path, options)
       base_connection do |connection|
-        connection.request :basic_auth, email, password unless options[:auth_not_required]
+        connection.request :basic_auth, email_address, password unless options[:auth_not_required]
       end.send(method) do |request|
         request.url  "#{API_VERSION}#{path}", options[:params]
         request.body = options[:body]

data/lib/hello_sign/parameters/reusable_form_signature_request.rb

@@ -6,14 +6,14 @@ module HelloSign
 
       def ccs
         @ccs.inject({}) do |parameter, cc|
-          parameter[cc[:role]] = {:email_address => cc[:email]}
+          parameter[cc[:role]] = {:email_address => cc[:email_address]}
           parameter
         end
       end
 
       def signers
         @signers.inject({}) do |parameter, signer|
-          parameter[signer[:role]] = {:name => signer[:name], :email_address => signer[:email]}
+          parameter[signer[:role]] = {:name => signer[:name], :email_address => signer[:email_address]}
           parameter
         end
       end

data/lib/hello_sign/parameters/signature_request.rb

@@ -7,10 +7,10 @@ module HelloSign
       attr_writer :signers, :files
 
       def signers
-        @signers.each_with_index.inject({}) do |parameter, (signer, index)|
+        (@signers || {}).each_with_index.inject({}) do |parameter, (signer, index)|
           signer = {
             :name          => signer[:name],
-            :email_address => signer[:email],
+            :email_address => signer[:email_address],
             :order         => index
           }
           parameter[index] = signer
@@ -19,7 +19,7 @@ module HelloSign
       end
 
       def files
-        @files.each_with_index.inject({}) do |parameter, (file, index)|
+        (@files || {}).each_with_index.inject({}) do |parameter, (file, index)|
           parameter[index + 1] = upload_io.new(file[:io], file[:mime], file[:name])
           parameter
         end

data/lib/hello_sign/proxy/account.rb

@@ -10,14 +10,8 @@ module HelloSign
         @client = client
       end
 
-      def create(credentials)
-        email    = credentials.fetch(:email)
-        password = credentials.fetch(:password)
-
-        client.post('/account/create',
-          :body => {:email_address => email, :password => password},
-          :auth_not_required => true
-        )
+      def create(params = {})
+        client.post('/account/create', :body => params, :auth_not_required => true)
       end
 
       def settings

data/lib/hello_sign/proxy/reusable_form.rb

@@ -8,7 +8,6 @@ module HelloSign
       end
 
       def list(params = {})
-        params = {:page => 1}.merge(params)
         client.get('/reusable_form/list', :params => params)
       end
 
@@ -17,23 +16,11 @@ module HelloSign
       end
 
       def grant_access(form_id, params = {})
-        client.post("/reusable_form/add_user/#{form_id}", :body => body(params))
+        client.post("/reusable_form/add_user/#{form_id}", :body => params)
       end
 
       def revoke_access(form_id, params = {})
-        client.post("/reusable_form/remove_user/#{form_id}", :body => body(params))
-      end
-
-      private
-
-      def body(params)
-        if email = params[:email]
-          {:email_address => email}
-        elsif account_id = params[:account_id]
-          {:account_id => account_id}
-        else
-          raise ArgumentError, 'An email address or account ID must be provided.'
-        end
+        client.post("/reusable_form/remove_user/#{form_id}", :body => params)
       end
 
     end

data/lib/hello_sign/proxy/settings.rb

@@ -13,8 +13,8 @@ module HelloSign
         client.get('/account')
       end
 
-      def update(attributes)
-        client.post('/account', :body => attributes)
+      def update(params = {})
+        client.post('/account', :body => params)
       end
 
     end

data/lib/hello_sign/proxy/signature_request.rb

@@ -23,10 +23,7 @@ module HelloSign
         else
           yield request_parameters
 
-          client.post(
-            '/signature_request/send',
-            :body => request_parameters.formatted
-          )
+          client.post('/signature_request/send', :body => request_parameters.formatted)
         end
       end
 
@@ -41,12 +38,9 @@ module HelloSign
       end
 
       def remind(request_id, params = {})
-        email = params.fetch(:email) { raise ArgumentError, 'An email address must be provided.' }
+        params = {:email_address => params.delete(:email)}.merge(params)
 
-        client.post(
-          "/signature_request/remind/#{request_id}",
-          :body => {:email_address => email}
-        )
+        client.post("/signature_request/remind/#{request_id}", :body => params)
       end
 
       def cancel(request_id)

data/lib/hello_sign/proxy/team.rb

@@ -7,41 +7,28 @@ module HelloSign
         @client = client
       end
 
-      def create(params)
-        name = params.fetch(:name)
-        client.post('/team/create', :body => {:name => name})
+      def create(params = {})
+        client.post('/team/create', :body => params)
       end
 
       def show
         client.get('/team')
       end
 
-      def update(attributes)
-        client.post('/team', :body => attributes)
+      def update(params = {})
+        client.post('/team', :body => params)
       end
 
       def destroy
         client.post('/team/destroy')
       end
 
-      def add_member(params)
-        client.post("/team/add_member", :body => body_by_identifier(params))
+      def add_member(params = {})
+        client.post("/team/add_member", :body => params)
       end
 
-      def remove_member(params)
-        client.post("/team/remove_member", :body => body_by_identifier(params))
-      end
-
-      private
-
-      def body_by_identifier(params)
-        if email = params[:email]
-          {:email_address => email}
-        elsif account_id = params[:account_id]
-          {:account_id => account_id}
-        else
-          raise ArgumentError, 'An email address or account ID must be provided.'
-        end
+      def remove_member(params = {})
+        client.post("/team/remove_member", :body => params)
       end
 
     end

data/lib/hello_sign/version.rb

@@ -1,3 +1,3 @@
 module HelloSign
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/lib/hello_sign.rb

@@ -7,13 +7,13 @@ module HelloSign
   class << self
     extend Forwardable
 
-    attr_accessor :email, :password
+    attr_accessor :email_address, :password
 
     delegate [:account, :signature_request, :reusable_form, :team,
       :unclaimed_draft] => :client
 
     def client
-      @client = Client.new(email, password) unless credentials_match?
+      @client = Client.new(email_address, password) unless credentials_match?
       @client
     end
 
@@ -24,7 +24,7 @@ module HelloSign
     private
 
     def credentials_match?
-      @client && [@client.email, @client.password].hash == [email, password].hash
+      @client && [@client.email_address, @client.password].hash == [email_address, password].hash
     end
 
   end

data/spec/integration/account_spec.rb

@@ -2,12 +2,11 @@ require 'integration/helper'
 
 describe HelloSign do
   context "when creating an account" do
-    before do
-      stub_post('/account/create')
-      HelloSign.account.create(:email => 'david@bowman.com', :password => 'foobar')
-    end
+    before { stub_post('/account/create') }
 
     it "sends an account creation request to the HelloSign API" do
+      HelloSign.account.create(:email_address => 'david@bowman.com', :password => 'foobar')
+
       expect(a_post('/account/create')
         .with(:body => {:email_address => 'david@bowman.com', :password => 'foobar'}))
         .to have_been_made
@@ -15,23 +14,21 @@ describe HelloSign do
   end
 
   context "when accessing an account's settings" do
-    before do
-      stub_get_with_auth('/account')
-      HelloSign.account.settings.show
-    end
+    before { stub_get_with_auth('/account') }
 
     it "fetches the account's settings from the HelloSign API" do
+      HelloSign.account.settings.show
+
       expect(a_get_with_auth('/account')).to have_been_made
     end
   end
 
   context "when updating an account's settings" do
-    before do
-      stub_post_with_auth('/account')
-      HelloSign.account.settings.update(:callback_url => 'http://callmemaybe.com')
-    end
+    before { stub_post_with_auth('/account') }
 
     it "sends an update account request to the HelloSign API" do
+      HelloSign.account.settings.update(:callback_url => 'http://callmemaybe.com')
+
       expect(a_post_with_auth('/account')
         .with(:body => {:callback_url => 'http://callmemaybe.com'}))
         .to have_been_made

data/spec/integration/helper.rb

@@ -4,8 +4,8 @@ require 'webmock/rspec'
 require 'json'
 
 HelloSign.configure do |hs|
-  hs.email    = 'david@bowman.com'
-  hs.password = 'foobar'
+  hs.email_address = 'david@bowman.com'
+  hs.password      = 'foobar'
 end
 
 def stub_get(path)

data/spec/integration/reusable_form_spec.rb

@@ -3,12 +3,12 @@ require 'integration/helper'
 describe HelloSign do
   context "when getting a list of reusable forms" do
     before do
-      stub_get_with_auth('/reusable_form/list?page=1')
+      stub_get_with_auth('/reusable_form/list')
       HelloSign.reusable_form.list
     end
 
     it "fetches a list of reusable forms from the HelloSign API" do
-      expect(a_get_with_auth('/reusable_form/list?page=1')).to have_been_made
+      expect(a_get_with_auth('/reusable_form/list')).to have_been_made
     end
   end
 
@@ -26,7 +26,7 @@ describe HelloSign do
   context "when giving a user access to a reusable form" do
     before do
       stub_post_with_auth('/reusable_form/add_user/form_id')
-      HelloSign.reusable_form.grant_access('form_id', :email => 'john@johnson.com')
+      HelloSign.reusable_form.grant_access('form_id', :email_address => 'john@johnson.com')
     end
 
     it "sends a request to grant form access to the HelloSign API" do
@@ -39,7 +39,7 @@ describe HelloSign do
   context "when taking away a user's access to a reusable form" do
     before do
       stub_post_with_auth('/reusable_form/remove_user/form_id')
-      HelloSign.reusable_form.revoke_access('form_id', :email => 'john@johnson.com')
+      HelloSign.reusable_form.revoke_access('form_id', :email_address => 'john@johnson.com')
     end
 
     it "sends a request to grant form access to the HelloSign API" do

data/spec/integration/signature_request_spec.rb

@@ -14,8 +14,8 @@ describe HelloSign do
           request.message = 'You must sign this.'
           request.ccs     = ['lawyer@lawfirm.com', 'spouse@family.com']
           request.signers = [
-            {:name => 'Jack', :email => 'jack@hill.com'},
-            {:name => 'Jill', :email => 'jill@hill.com'}
+            {:name => 'Jack', :email_address => 'jack@hill.com'},
+            {:name => 'Jill', :email_address => 'jill@hill.com'}
           ]
           request.files   = [
             {:name => 'test.txt', :io => text_file_io, :mime => 'text/plain'},
@@ -39,12 +39,12 @@ describe HelloSign do
           request.subject       = 'Sign this'
           request.message       = 'You must sign this.'
           request.ccs           = [
-            {:email => 'lawyer@lawfirm.com', :role => 'lawyer'},
-            {:email => 'accountant@llc.com', :role => 'accountant'}
+            {:email_address => 'lawyer@lawfirm.com', :role => 'lawyer'},
+            {:email_address => 'accountant@llc.com', :role => 'accountant'}
           ]
           request.signers       = [
-            {:name => 'Jack', :email => 'jack@hill.com', :role => 'consultant'},
-            {:name => 'Jill', :email => 'jill@hill.com', :role => 'client'}
+            {:name => 'Jack', :email_address => 'jack@hill.com', :role => 'consultant'},
+            {:name => 'Jill', :email_address => 'jill@hill.com', :role => 'client'}
           ]
           request.custom_fields = [
             {:name => 'cost', :value => '$20,000'},

data/spec/unit/client_spec.rb

@@ -5,8 +5,8 @@ require 'shared_examples/proxy'
 describe HelloSign::Client do
   subject(:hs_client) { HelloSign::Client.new('david@bowman.com', 'space') }
 
-  its(:email)    { should eq 'david@bowman.com' }
-  its(:password) { should eq 'space' }
+  its(:email_address) { should eq 'david@bowman.com' }
+  its(:password)      { should eq 'space' }
 
   it_behaves_like 'a proxy' do
     let(:client) { hs_client }

data/spec/unit/hello_sign_spec.rb

@@ -3,12 +3,12 @@ require 'hello_sign'
 
 describe HelloSign do
   before do
-    HelloSign.email    = 'hal@jupiter.com'
-    HelloSign.password = 'human_domination'
+    HelloSign.email_address = 'hal@jupiter.com'
+    HelloSign.password      = 'human_domination'
   end
 
-  its(:email)    { should eq 'hal@jupiter.com' }
-  its(:password) { should eq 'human_domination' }
+  its(:email_address) { should eq 'hal@jupiter.com' }
+  its(:password)      { should eq 'human_domination' }
 
   describe "::client" do
     context "when it has not previously been called" do
@@ -26,13 +26,13 @@ describe HelloSign do
 
       context "and the email and password changes" do
         before do
-          HelloSign.email    = 'bob@earth.com'
-          HelloSign.password = 'being_human'
+          HelloSign.email_address = 'bob@earth.com'
+          HelloSign.password      = 'being_human'
         end
 
         it "creates a new client with the new credentials" do
           expect(HelloSign.client).to_not be @client
-          expect(HelloSign.client.email).to eq 'bob@earth.com'
+          expect(HelloSign.client.email_address).to eq 'bob@earth.com'
           expect(HelloSign.client.password).to eq 'being_human'
         end
       end

data/spec/unit/parameters/reusable_form_signature_request_spec.rb

@@ -31,12 +31,12 @@ describe HelloSign::Parameters::ReusableFormSignatureRequest do
       request_parameters.subject = 'Sign this'
       request_parameters.message = 'You must sign this.'
       request_parameters.ccs     = [
-        {:email => 'lawyer@lawfirm.com', :role => 'lawyer'},
-        {:email => 'accountant@llc.com', :role => 'accountant'}
+        {:email_address => 'lawyer@lawfirm.com', :role => 'lawyer'},
+        {:email_address => 'accountant@llc.com', :role => 'accountant'}
       ]
       request_parameters.signers = [
-        {:name => 'Jack', :email => 'jack@hill.com', :role => 'consultant'},
-        {:name => 'Jill', :email => 'jill@hill.com', :role => 'client'}
+        {:name => 'Jack', :email_address => 'jack@hill.com', :role => 'consultant'},
+        {:name => 'Jill', :email_address => 'jill@hill.com', :role => 'client'}
       ]
       request_parameters.custom_fields = [
         {:name => 'cost', :value => '$20,000'},

data/spec/unit/parameters/signature_request_spec.rb

@@ -6,40 +6,59 @@ describe HelloSign::Parameters::SignatureRequest do
     let(:request_parameters) { HelloSign::Parameters::SignatureRequest.new }
     let(:text_file)          { double('text file') }
     let(:image_file)         { double('image file') }
-    let(:expected) do
-      {
-        :title => 'Lease',
-        :subject =>'Sign this',
-        :message =>'You must sign this.',
-        :cc_email_addresses => ['lawyer@lawfirm.com', 'spouse@family.com'], # BUGBUG: should have explicit indexes
-        :signers => {
-          0 => {:name => 'Jack', :email_address => 'jack@hill.com', :order => 0}, 
-          1 => {:name => 'Jill', :email_address => 'jill@hill.com', :order => 1}
-        },
-        :file => {1 => text_file, 2 => image_file}
-      }
-    end
+    context "when all required arguments are set" do
+      let(:expected) do
+        {
+          :title => 'Lease',
+          :subject => 'Sign this',
+          :message => 'You must sign this.',
+          :cc_email_addresses => ['lawyer@lawfirm.com', 'spouse@family.com'], # BUGBUG: should have explicit indexes
+          :signers => {
+            0 => {:name => 'Jack', :email_address => 'jack@hill.com', :order => 0}, 
+            1 => {:name => 'Jill', :email_address => 'jill@hill.com', :order => 1}
+          },
+          :file => {1 => text_file, 2 => image_file}
+        }
+      end
+
+      before do
+        request_parameters.title   = 'Lease'
+        request_parameters.subject = 'Sign this'
+        request_parameters.message = 'You must sign this.'
+        request_parameters.ccs     = ['lawyer@lawfirm.com', 'spouse@family.com']
+        request_parameters.signers = [
+          {:name => 'Jack', :email_address => 'jack@hill.com'},
+          {:name => 'Jill', :email_address => 'jill@hill.com'}
+        ]
+        request_parameters.files   = [
+          {:name => 'test.txt', :io => 'text file IO object', :mime => 'text/plain'},
+          {:name => 'test.jpg', :io => 'image file IO object', :mime => 'image/jpeg'}
+        ]
+      end
 
-    before do
-      Faraday::UploadIO.should_receive(:new).with('text file IO object', 'text/plain', 'test.txt').and_return(text_file)
-      Faraday::UploadIO.should_receive(:new).with('image file IO object', 'image/jpeg', 'test.jpg').and_return(image_file)
+      it "returns formatted parameters" do
+        Faraday::UploadIO.should_receive(:new).with('text file IO object', 'text/plain', 'test.txt').and_return(text_file)
+        Faraday::UploadIO.should_receive(:new).with('image file IO object', 'image/jpeg', 'test.jpg').and_return(image_file)
 
-      request_parameters.title   = 'Lease'
-      request_parameters.subject = 'Sign this'
-      request_parameters.message = 'You must sign this.'
-      request_parameters.ccs     = ['lawyer@lawfirm.com', 'spouse@family.com']
-      request_parameters.signers = [
-        {:name => 'Jack', :email => 'jack@hill.com'},
-        {:name => 'Jill', :email => 'jill@hill.com'}
-      ]
-      request_parameters.files   = [
-        {:name => 'test.txt', :io => 'text file IO object', :mime => 'text/plain'},
-        {:name => 'test.jpg', :io => 'image file IO object', :mime => 'image/jpeg'}
-      ]
+        expect(request_parameters.formatted).to eq expected
+      end
     end
 
-    it "returns formatted parameters" do
-      expect(request_parameters.formatted).to eq expected
+    context "when required parameters are omitted" do
+      let(:expected) do
+        {
+          :title              => nil,
+          :subject            => nil,
+          :message            => nil,
+          :cc_email_addresses => nil,
+          :signers            => {},
+          :file               => {}
+        }
+      end
+
+      it "sets default parameters" do
+        expect(request_parameters.formatted).to eq expected
+      end
     end
   end
 end

data/spec/unit/proxy/account_spec.rb

@@ -3,49 +3,56 @@ require 'hello_sign/proxy/account'
 
 describe HelloSign::Proxy::Account do
   let(:client)            { double('client') }
+  let(:api_response)      { double('API response') }
   subject(:account_proxy) { HelloSign::Proxy::Account.new(client) }
 
   its(:client) { should eq client }
 
   describe "#create" do
-    context "when passed the proper parameters" do
-      let(:api_response) { double('API response') }
-
-      before { client.stub(:post).and_return(api_response) }
-
-      it "sends an account creation request" do
-        client.should_receive(:post)
-          .with(
-            '/account/create',
-            :body => {:email_address => 'david@bowman.com', :password => 'space'},
-            :auth_not_required => true
-          )
-        account_proxy.create(:email => 'david@bowman.com', :password => 'space')
-      end
-
-      it "returns the API response" do
-        expect(account_proxy.create(:email => 'david@bowman.com', :password => 'space')). to eq api_response
-      end
+
+    let(:email_address) { 'david@bowman.com' }
+    let(:password)      { 'password' }
+
+    before { client.stub(:post).and_return(api_response) }
+
+    it "sends a request to create an account" do
+      client.should_receive(:post).with(
+        '/account/create',
+        :body => {:email_address => 'david@bowman.com', :password => 'space'},
+        :auth_not_required => true
+      )
+      account_proxy.create(
+        :email_address => 'david@bowman.com',
+        :password      => 'space'
+      )
     end
 
-    context "when not passed the proper parameters" do
-      it "raises an exception" do
-        expect { account_proxy.create(:email => 'david@bowman.com') }.to raise_error
-      end
+    it "returns the API response" do
+      expect(
+        account_proxy.create(
+          :email_address => 'david@bowman.com',
+          :password      => 'space'
+        )
+      ). to eq api_response
     end
+
   end
 
   describe "#settings" do
+
     let(:settings_proxy_source) { double('settings proxy source') }
     let(:settings_proxy)        { double('settings proxy') }
 
     before do
       account_proxy.settings_proxy_source = settings_proxy_source
-      settings_proxy_source.should_receive(:new).with(client).and_return(settings_proxy)
     end
 
     it "returns a signature request proxy" do
+      settings_proxy_source.should_receive(:new)
+        .with(client)
+        .and_return(settings_proxy)
       expect(account_proxy.settings).to be settings_proxy
     end
+
   end
 end

data/spec/unit/proxy/reusable_form_spec.rb

@@ -2,110 +2,60 @@ require 'helper'
 require 'hello_sign/proxy/reusable_form'
 
 describe HelloSign::Proxy::ReusableForm do
-  let(:client)       { double('client') }
-  let(:api_response) { double('API response') }
-  let(:form_id)      { 'form_id' }
-  subject(:rf_proxy) { HelloSign::Proxy::ReusableForm.new(client) }
-
-  describe "#client" do
-    it "returns the client" do
-      expect(rf_proxy.client).to be client
-    end
+  let(:client)        { double('client') }
+  let(:api_response)  { double('API response') }
+  let(:form_id)       { 'form_id' }
+  let(:email_address) { 'bob@example.com' }
+  subject(:rf_proxy)  { HelloSign::Proxy::ReusableForm.new(client) }
+
+  before do
+    client.stub(:get).and_return(api_response)
+    client.stub(:post).and_return(api_response)
   end
 
-  describe "#list" do
-    context "when called without options" do
-      before { client.should_receive(:get).with('/reusable_form/list', :params => {:page => 1}).and_return(api_response) }
+  its(:client) { should eq client }
 
-      it "fetches the first page of reusable forms and returns the result" do
-        expect(rf_proxy.list).to eq api_response
-      end
+  describe "#list" do
+    it "sends a request to fetch the list of reusable forms" do
+      client.should_receive(:get).with('/reusable_form/list', :params => {:page => 10})
+      rf_proxy.list(:page => 10)
     end
 
-    context "when called with a page number" do
-      before { client.should_receive(:get).with('/reusable_form/list', :params => {:page => 10}).and_return(api_response) }
-
-      it "fetches a list of reusable forms for the passed page number and returns the result" do
-        expect(rf_proxy.list(:page => 10)).to eq api_response
-      end
+    it "returns the API response" do
+      expect(rf_proxy.list).to eq api_response
     end
   end
 
   describe "#show" do
-    before { client.should_receive(:get).with('/reusable_form/form_id').and_return(api_response) }
+    it "sends a request to fetch the details of a reusable form" do
+      client.should_receive(:get).with("/reusable_form/#{form_id}")
+      rf_proxy.show(form_id)
+    end
 
-    it "fetches the reusable form details and returns the result" do
+    it "returns the API response" do
       expect(rf_proxy.show(form_id)).to eq api_response
     end
   end
 
   describe "#grant_access" do
-    let(:email)      { 'john@johnson.com' }
-    let(:account_id) { '15' }
-
-    before { client.stub(:post).and_return(api_response) }
-
-    context "when called with an email address" do
-      it "grants access to account tied to the email address" do
-        client.should_receive(:post).with('/reusable_form/add_user/form_id', :body => {:email_address => email})
-        rf_proxy.grant_access(form_id, :email => email)
-      end
-
-      it "returns the API response" do
-        expect(rf_proxy.grant_access(form_id, :email => email)).to eq api_response
-      end
+    it "sends a request to grant access" do
+      client.should_receive(:post).with("/reusable_form/add_user/#{form_id}", :body => {:email_address => email_address})
+      rf_proxy.grant_access(form_id, :email_address => email_address)
     end
 
-    context "when called with an account ID" do
-      it "grants access to account tied to the account ID" do
-        client.should_receive(:post).with('/reusable_form/add_user/form_id', :body => {:account_id => account_id})
-        rf_proxy.grant_access(form_id, :account_id => account_id)
-      end
-
-      it "returns the API response" do
-        expect(rf_proxy.grant_access(form_id, :account_id => account_id)).to eq api_response
-      end
-    end
-
-    context "when called without proper parameters" do
-      it "raises an argument error exception" do
-        expect { rf_proxy.grant_access(form_id) }.to raise_error ArgumentError
-      end
+    it "returns the API response" do
+      expect(rf_proxy.grant_access(form_id, :email => email_address)).to eq api_response
     end
   end
 
   describe "#revoke_access" do
-    let(:email)      { 'john@johnson.com' }
-    let(:account_id) { '15' }
-
-    before { client.stub(:post).and_return(api_response) }
-
-    context "when called with an email address" do
-      it "revokes access to account tied to the email address" do
-        client.should_receive(:post).with('/reusable_form/remove_user/form_id', :body => {:email_address => email})
-        rf_proxy.revoke_access(form_id, :email => email)
-      end
-
-      it "returns the API response" do
-        expect(rf_proxy.revoke_access(form_id, :email => email)).to eq api_response
-      end
-    end
-
-    context "when called with an account ID" do
-      it "revokes access to account tied to the account ID" do
-        client.should_receive(:post).with('/reusable_form/remove_user/form_id', :body => {:account_id => account_id})
-        rf_proxy.revoke_access(form_id, :account_id => account_id)
-      end
-
-      it "returns the API response" do
-        expect(rf_proxy.revoke_access(form_id, :account_id => account_id)).to eq api_response
-      end
+    it "sends a request to revoke access" do
+      client.should_receive(:post).with("/reusable_form/remove_user/#{form_id}", :body => {:email_address => email_address})
+      rf_proxy.revoke_access(form_id, :email_address => email_address)
     end
 
-    context "when called without proper parameters" do
-      it "raises an argument error exception" do
-        expect { rf_proxy.revoke_access(form_id) }.to raise_error ArgumentError
-      end
+    it "returns the API response" do
+      expect(rf_proxy.revoke_access(form_id, :email_address => email_address)).to eq api_response
     end
   end
 end

data/spec/unit/proxy/signature_request_spec.rb

@@ -113,12 +113,6 @@ describe HelloSign::Proxy::SignatureRequest do
       client.stub(:post).and_return(api_response)
       expect(sr_proxy.remind(request_id, :email => email)).to eq api_response
     end
-
-    context "when called without an email address" do
-      it "raises an exception" do
-        expect { sr_proxy.remind(request_id) }.to raise_error ArgumentError
-      end
-    end
   end
 
   describe "#cancel" do

data/spec/unit/proxy/team_spec.rb

@@ -11,35 +11,26 @@ describe HelloSign::Proxy::Team do
     client.stub(:post).and_return(api_response)
   end
 
-  describe "#client" do
-    it "returns the client" do
-      expect(team_proxy.client).to be client
-    end
-  end
+  its(:client) { should eq client }
 
   describe "#create" do
-    let(:name) { 'The Browncoats' }
 
-    context "when called with the proper parameters" do
-      it "sends a team creation request" do
-        client.should_receive(:post).with('/team/create', :body => {:name => name})
-        team_proxy.create(:name => name)
-      end
+    let(:name) { 'The Browncoats' }
 
-      it "returns the API response" do
-        expect(team_proxy.create(:name => name)).to eq api_response
-      end
+    it "sends a request to create a team" do
+      client.should_receive(:post).with('/team/create', :body => {:name => name})
+      team_proxy.create(:name => name)
     end
 
-    context "when called without the proper parameters" do
-      it "raises an exception" do
-        expect { team_proxy.create }.to raise_error
-      end
+    it "returns the API response" do
+      expect(team_proxy.create(:name => name)).to eq api_response
     end
+
   end
 
   describe "#show" do
-    it "fetches the team information" do
+
+    it "sends a request to fetch the team information" do
       client.should_receive(:get).with('/team')
       team_proxy.show
     end
@@ -47,12 +38,14 @@ describe HelloSign::Proxy::Team do
     it "returns the API response" do
       expect(team_proxy.show).to eq api_response
     end
+
   end
 
   describe "#update" do
+
     let(:new_name) { 'The Bluecoats' }
 
-    it "sends a team update request" do
+    it "sends a request to update the team information" do
       client.should_receive(:post).with('/team', :body => {:name => new_name})
       team_proxy.update(:name => new_name)
     end
@@ -60,10 +53,12 @@ describe HelloSign::Proxy::Team do
     it "returns the API response" do
       expect(team_proxy.update(:name => new_name)).to eq api_response
     end
+
   end
 
   describe "#destroy" do
-    it "sends a team destroy request" do
+
+    it "sends a request to destroy the team" do
       client.should_receive(:post).with('/team/destroy')
       team_proxy.destroy
     end
@@ -71,71 +66,36 @@ describe HelloSign::Proxy::Team do
     it "returns the API response" do
       expect(team_proxy.destroy).to eq api_response
     end
+
   end
 
   describe "#add_member" do
-    let(:email)      { 'john@johnson.com' }
-    let(:account_id) { '15' }
-
-    context "when called with an email address" do
-      it "adds the user with the email address to the team" do
-        client.should_receive(:post).with('/team/add_member', :body => {:email_address => email})
-        team_proxy.add_member(:email => email)
-      end
-
-      it "returns the API response" do
-        expect(team_proxy.add_member(:email => email)).to eq api_response
-      end
-    end
 
-    context "when called with an account ID" do
-      it "adds the user with the account ID to the team" do
-        client.should_receive(:post).with('/team/add_member', :body => {:account_id => account_id})
-        team_proxy.add_member(:account_id => account_id)
-      end
+    let(:email_address) { 'john@johnson.com' }
 
-      it "returns the API response" do
-        expect(team_proxy.add_member(:account_id => account_id)).to eq api_response
-      end
+    it "sends a request to add the member to the team" do
+      client.should_receive(:post).with('/team/add_member', :body => {:email_address => email_address})
+      team_proxy.add_member(:email_address => email_address)
     end
 
-    context "when called without proper parameters" do
-      it "raises an argument error exception" do
-        expect { team_proxy.add_member }.to raise_error ArgumentError
-      end
+    it "returns the API response" do
+      expect(team_proxy.add_member(:email_address => email_address)).to eq api_response
     end
+
   end
 
   describe "#remove_member" do
-    let(:email)      { 'john@johnson.com' }
-    let(:account_id) { '15' }
-
-    context "when called with an email address" do
-      it "removes the user with the email address from the team" do
-        client.should_receive(:post).with('/team/remove_member', :body => {:email_address => email})
-        team_proxy.remove_member(:email => email)
-      end
-
-      it "returns the API response" do
-        expect(team_proxy.remove_member(:email => email)).to eq api_response
-      end
-    end
 
-    context "when called with an account ID" do
-      it "removes the user with the account ID from the team" do
-        client.should_receive(:post).with('/team/remove_member', :body => {:account_id => account_id})
-        team_proxy.remove_member(:account_id => account_id)
-      end
+    let(:email_address) { 'john@johnson.com' }
 
-      it "returns the API response" do
-        expect(team_proxy.remove_member(:account_id => account_id)).to eq api_response
-      end
+    it "sends a request to remove the member from the team" do
+      client.should_receive(:post).with('/team/remove_member', :body => {:email_address => email_address})
+      team_proxy.remove_member(:email_address => email_address)
     end
 
-    context "when called without proper parameters" do
-      it "raises an argument error exception" do
-        expect { team_proxy.remove_member }.to raise_error ArgumentError
-      end
+    it "returns the API response" do
+      expect(team_proxy.remove_member(:email_address => email_address)).to eq api_response
     end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hello_sign
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-05 00:00:00.000000000 Z
+date: 2013-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -75,6 +75,22 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.9.0
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 10.0.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 10.0.3
 description: A Ruby interface to the HelloSign API.
 email:
 - craiglttl@gmail.com
@@ -130,12 +146,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3035616681847644249
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3035616681847644249
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23