health_inspector 0.2.1 → 0.3.0

data/HISTORY.md

@@ -1,3 +1,7 @@
+## 0.3.0 ( 2012-09-26 )
+
+* Add new check for cookbooks: checksum comparison for each file
+
 ## 0.2.1 ( 2012-09-26 )
 
 * Fix 1.8.7 incompatibility introduced in last release (String#prepend).

data/lib/health_inspector.rb

@@ -11,6 +11,8 @@ require "health_inspector/checklists/data_bag_items"
 require "health_inspector/checklists/environments"
 require "health_inspector/checklists/roles"
 require "health_inspector/cli"
+require 'chef/rest'
+require 'chef/checksum_cache'
 require "json"
 
 module HealthInspector

data/lib/health_inspector/checklists/base.rb

@@ -30,7 +30,7 @@ module HealthInspector
       def run
         banner "Inspecting #{self.class.title}"
 
-        items.each do |item|
+        each_item do |item|
           failures = run_checks(item)
 
           if failures.empty?
@@ -77,6 +77,11 @@ module HealthInspector
         end
       end
 
+      def chef_rest 
+        @rest ||= Chef::REST.new(@context.configure[:chef_server_url], @context.configure[:node_name],
+                                 @context.configure[:client_key])
+      end
+
       def run_check(check, item)
         check_context = CheckContext.new(check, item, @context)
         check_context.call

data/lib/health_inspector/checklists/cookbooks.rb

@@ -13,7 +13,7 @@ module HealthInspector
 
       add_check "versions" do
         if item.local_version && item.server_version &&
-           item.local_version != item.server_version
+          item.local_version != item.server_version
           failure "chef server has #{item.server_version} but local version is #{item.local_version}"
         end
       end
@@ -38,7 +38,15 @@ module HealthInspector
         end
       end
 
-      class Cookbook < Struct.new(:name, :path, :server_version, :local_version)
+      add_check "changes on the server not in the repo" do
+        if item.server_version == item.local_version && !item.bad_files.empty?
+          fail_message = "has a checksum mismatch between server and repo in\n"
+          fail_message << item.bad_files.map { |f| "    #{f}" }.join("\n")
+          failure fail_message 
+        end
+      end
+
+      class Cookbook < Struct.new(:name, :path, :server_version, :local_version, :bad_files)
         def git_repo?
           self.path && File.exist?("#{self.path}/.git")
         end
@@ -46,18 +54,21 @@ module HealthInspector
 
       title "cookbooks"
 
-      def items
+      def each_item
         server_cookbooks   = cookbooks_on_server
         local_cookbooks    = cookbooks_in_repo
         all_cookbook_names = ( server_cookbooks.keys + local_cookbooks.keys ).uniq.sort
 
-        all_cookbook_names.map do |name|
-          Cookbook.new.tap do |cookbook|
+        all_cookbook_names.each do |name|
+          item = Cookbook.new.tap do |cookbook|
             cookbook.name           = name
             cookbook.path           = cookbook_path(name)
             cookbook.server_version = server_cookbooks[name]
             cookbook.local_version  = local_cookbooks[name]
+            cookbook.bad_files      = checksum_compare(name, cookbook.server_version)
           end
+
+          yield item
         end
       end
 
@@ -76,18 +87,43 @@ module HealthInspector
           select { |path| File.exists?("#{path}/metadata.rb") }.
           inject({}) do |hsh, path|
 
-          name    = File.basename(path)
-          version = (`grep '^version' #{path}/metadata.rb`).split.last[1...-1]
+            name    = File.basename(path)
+            version = (`grep '^version' #{path}/metadata.rb`).split.last[1...-1]
 
-          hsh[name] = version
-          hsh
-        end
+            hsh[name] = version
+            hsh
+          end
       end
 
       def cookbook_path(name)
         path = @context.cookbook_path.find { |f| File.exist?("#{f}/#{name}") }
         path ? File.join(path, name) : nil
       end
+
+      def checksum_compare(name,version)
+        begin
+          cookbook = chef_rest.get_rest("/cookbooks/#{name}/#{version}")
+        rescue Net::HTTPServerException => e
+          return ["Could not find cookbook #{name} on the server"]
+        end
+
+        cookbook.manifest.inject([]) do |memo, (key,value)|
+          if value.kind_of? Array
+            value.each do |file|
+              path = cookbook_path("#{name}/#{file["path"]}")
+
+              if path
+                checksum = Chef::ChecksumCache.generate_md5_checksum_for_file(path)
+                memo << "#{file['path']}" if checksum != file['checksum']
+              else
+                memo << "#{file['path']} does not exist in the repo"
+              end
+            end
+          end
+          memo
+        end
+      end
+
     end
   end
 end

data/lib/health_inspector/checklists/data_bag_items.rb

@@ -22,17 +22,19 @@ module HealthInspector
 
       DataBagItem = Struct.new(:name, :server, :local)
 
-      def items
+      def each_item
         server_data_bag_items   = data_bag_items_on_server
         local_data_bag_items    = data_bag_items_in_repo
         all_data_bag_item_names = ( server_data_bag_items + local_data_bag_items ).uniq.sort
 
-        all_data_bag_item_names.map do |name|
-          DataBagItem.new.tap do |data_bag_item|
+        all_data_bag_item_names.each do |name|
+          item = DataBagItem.new.tap do |data_bag_item|
             data_bag_item.name   = name
             data_bag_item.server = load_item_from_server(name)
             data_bag_item.local  = load_item_from_local(name)
           end
+
+          yield item
         end
       end
 

data/lib/health_inspector/checklists/data_bags.rb

@@ -15,17 +15,19 @@ module HealthInspector
 
       DataBag = Struct.new(:name, :exists_on_server, :exists_locally)
 
-      def items
+      def each_item
         server_data_bags   = data_bags_on_server
         local_data_bags    = data_bags_in_repo
         all_data_bag_names = ( server_data_bags + local_data_bags ).uniq.sort
 
-        all_data_bag_names.map do |name|
-          DataBag.new.tap do |data_bag|
+        all_data_bag_names.each do |name|
+          item = DataBag.new.tap do |data_bag|
             data_bag.name = name
             data_bag.exists_on_server = data_bags_on_server.include?(name)
             data_bag.exists_locally = data_bags_in_repo.include?(name)
           end
+
+          yield item
         end
       end
 

data/lib/health_inspector/checklists/environments.rb

@@ -22,17 +22,19 @@ module HealthInspector
 
       Environment = Struct.new(:name, :server, :local)
 
-      def items
+      def each_item
         server_items   = items_on_server
         local_items    = items_in_repo
         all_item_names = ( server_items + local_items ).uniq.sort
 
-        all_item_names.map do |name|
-          Environment.new.tap do |item|
+        all_item_names.each do |name|
+          item = Environment.new.tap do |item|
             item.name   = name
             item.server = load_item_from_server(name)
             item.local  = load_item_from_local(name)
           end
+
+          yield item
         end
       end
 

data/lib/health_inspector/checklists/roles.rb

@@ -24,17 +24,19 @@ module HealthInspector
 
       Role = Struct.new(:name, :server, :local)
 
-      def items
+      def each_item
         server_items   = items_on_server
         local_items    = items_in_repo
         all_item_names = ( server_items + local_items ).uniq.sort
 
-        all_item_names.map do |name|
-          Role.new.tap do |item|
+        all_item_names.each do |name|
+          item = Role.new.tap do |item|
             item.name   = name
             item.server = load_item_from_server(name)
             item.local  = load_item_from_local(name)
           end
+
+          yield item
         end
       end
 

data/lib/health_inspector/version.rb

@@ -1,3 +1,3 @@
 module HealthInspector
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: health_inspector
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70151008460860 !ruby/object:Gem::Requirement
+  requirement: &70140548345560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70151008460860
+  version_requirements: *70140548345560
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70151008459940 !ruby/object:Gem::Requirement
+  requirement: &70140548344640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70151008459940
+  version_requirements: *70140548344640
 - !ruby/object:Gem::Dependency
   name: thor
-  requirement: &70151008459400 !ruby/object:Gem::Requirement
+  requirement: &70140548344100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70151008459400
+  version_requirements: *70140548344100
 - !ruby/object:Gem::Dependency
   name: chef
-  requirement: &70151008458860 !ruby/object:Gem::Requirement
+  requirement: &70140548343560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '10.14'
   type: :runtime
   prerelease: false
-  version_requirements: *70151008458860
+  version_requirements: *70140548343560
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70151008458440 !ruby/object:Gem::Requirement
+  requirement: &70140548343140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70151008458440
+  version_requirements: *70140548343140
 description: A tool to inspect your chef repo as is compares to what is on your chef
   server
 email: