headless-rails 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21b0f92d77e15c80aa132104b24364189c1767e7
-  data.tar.gz: e1699ab35cbaabba74f93524a13bc4a3ee48952e
+  metadata.gz: 3430eeda993cfbe14e78e0db458e45ffcff310f7
+  data.tar.gz: aaacaea9451a308e118149656d1b7b7bf7e994f2
 SHA512:
-  metadata.gz: 1e08d9016ae46c03000e48464df75dd2a22c53d361eaf96bae8031914b23b57c823b98ca654c28ed7806603e43f9eb11a48e11f6a8e55f0d7445d62d2553a488
-  data.tar.gz: b4b5a0fb24e46b1eeaeecb52b5599b0a7a251d8e5c195a43212e4262efccec92d3601e5792aa55f18ada4f6c6fb6517bc2e9cddad99bf6663c0d5429848e69b9
+  metadata.gz: f15c29d05d3386ef1c52c9212d20d938958afc61014b6db81f87941d978e5d7eb890b4580112d1e08074418a9cd1f86aa27fd54b8a675258749dbb247d74d616
+  data.tar.gz: 366451b773dd444f436e02af981271c39bcc5e0a9489c8c69fb8c6cc71abcd1a3005b22cdb6e7df70d2937dbb214e0c8d38c638b93dfea81b2400cea21db0a97

data/lib/headless/api_client.rb

@@ -1,5 +1,5 @@
+require "headless/api_response"
 require "rest_client"
-require "json"
 
 module Headless
   class APIClient
@@ -9,20 +9,7 @@ module Headless
     end
 
     def crawl(url)
-      APIResponse.new(get("/api/crawl", :url => url))
-    end
-
-    class APIResponse < Struct.new(:response)
-
-      def content
-        parsed_response["content"]
-      end
-
-      private
-
-      def parsed_response
-        @parsed_response ||= ::JSON.parse(response)
-      end
+      ::Headless::APIResponse.new(get("/api/crawl", :url => url))
     end
 
     private

data/lib/headless/api_response.rb

@@ -0,0 +1,20 @@
+require "json"
+
+module Headless
+  class APIResponse < Struct.new(:response)
+
+    def success?
+      parsed_response["success"]
+    end
+
+    def content
+      parsed_response["content"]
+    end
+
+    private
+
+    def parsed_response
+      @parsed_response ||= ::JSON.parse(response)
+    end
+  end
+end

data/lib/headless/rails/version.rb

@@ -1,5 +1,5 @@
 module Headless
   module Rails
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/lib/headless/rails.rb

@@ -9,9 +9,9 @@ module Headless
 
     def respond_to_ajax_crawlers
       if params.has_key?(ESCAPED_FRAGMENT_KEY)
-        url = EscapedFragmentExtractor.call(request)
+        url = ::Headless::Rails::EscapedFragmentExtractor.call(request)
         crawled = ::Headless::APIClient.crawl(url)
-        render text: crawled.content
+        render text: crawled.content if crawled.success?
       end
     end
 

data/spec/headless/ap_response_spec.rb

@@ -0,0 +1,42 @@
+require "spec_helper"
+
+RSpec.describe Headless::APIResponse do
+
+  let(:successful) do
+    {
+      "success" => true,
+      "status"  => "success",
+      "url"     => "http://example.com",
+      "title"   => "Title",
+      "content" => "<h1>Title</h1>",
+    }
+  end
+
+  let(:failed) do
+    {"success"=>false, "status"=>"fail"}
+  end
+
+  context "success" do
+    subject do
+      Headless::APIResponse.new(JSON.dump(successful))
+    end
+
+    it "parses the content" do
+      expect(subject.content).to eq("<h1>Title</h1>")
+    end
+
+    it "returns true for success?" do
+      expect(subject.success?).to be_true
+    end
+  end
+
+  context "failure" do
+    subject do
+      Headless::APIResponse.new(JSON.dump(failed))
+    end
+
+    it "returns false for success?" do
+      expect(subject.success?).to be_false
+    end
+  end
+end

data/spec/headless/rails_spec.rb

@@ -14,7 +14,7 @@ RSpec.describe Headless::Rails do
   end
 
   let(:request) { double(:request) }
-  let(:headless_response)  { double(:headless_response, :content => :headless_content) }
+  let(:headless_response) { double(:headless_response, :success? => true, :content => :headless_content) }
 
   describe "respond_to_ajax_crawlers" do
     before do
@@ -41,15 +41,28 @@ RSpec.describe Headless::Rails do
     context "with an escaped fragment" do
       before do
         controller.stub(:params).and_return({"_escaped_fragment_" => "something"})
-      end
 
-      it "extracts the fragment, fetches content from the api, and renders its" do
         expect(Headless::Rails::EscapedFragmentExtractor).to receive(:call).with(request).and_return(:a_url)
         expect(Headless::APIClient).to receive(:crawl).with(:a_url).and_return(headless_response)
+      end
+
+      it "extracts the fragment, fetches content from the api, and renders its" do
         expect(controller).to receive(:render).with(:text => :headless_content)
 
         controller.respond_to_ajax_crawlers
       end
+
+      context "failure" do
+        before do
+          headless_response.stub(:success?).and_return(false)
+        end
+
+        it "doesn't render" do
+          expect(controller).to_not receive(:render)
+
+          controller.respond_to_ajax_crawlers
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: headless-rails
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Matthew Rudy Jacobs
@@ -110,9 +110,11 @@ files:
 - Rakefile
 - headless-rails.gemspec
 - lib/headless/api_client.rb
+- lib/headless/api_response.rb
 - lib/headless/rails.rb
 - lib/headless/rails/escaped_fragment_extractor.rb
 - lib/headless/rails/version.rb
+- spec/headless/ap_response_spec.rb
 - spec/headless/api_client_spec.rb
 - spec/headless/rails/escaped_fragment_extractor_spec.rb
 - spec/headless/rails_spec.rb
@@ -142,6 +144,7 @@ signing_key:
 specification_version: 4
 summary: API wrapper for the HeadlessApp.com
 test_files:
+- spec/headless/ap_response_spec.rb
 - spec/headless/api_client_spec.rb
 - spec/headless/rails/escaped_fragment_extractor_spec.rb
 - spec/headless/rails_spec.rb