headhunter 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9acc395e6576fd41f9ede3d985187bfc42cff0a2
-  data.tar.gz: e7590478bf881f12db6e86abf20039cc86481f1e
+  metadata.gz: df58d59328c6942d9153f49b22765fbef1aa7c62
+  data.tar.gz: 4e7c82703bb398fbb1a08f3d8b33e80f4793621e
 SHA512:
-  metadata.gz: 13182c041fb24380c6de42231b16fa14fdfa7cc55e41fb192d0029c582c9ca59d1fe9f0e255f833f15fbe94dda83363aa12deaabdc6da78d61ff8ce83d5b6e26
-  data.tar.gz: edb48f438b106be756cd332fc053c726a5f21f1cd939aad731d587406cb91ff27798a44ee2d6c5d3a41b7a20496a8fcf653dbaf815d970589db9147d91d19b3c
+  metadata.gz: 68c02e914808c4fababacc1edea8d50d5c7576522154d023434edf6b54fe46fe4026998a57e7991b24848de0eac634b2a85da8105c844a1389fdf6f790dd0922
+  data.tar.gz: 5b93567d530e2e222476b825f5e0f53f33d3c1f8bb05f90571c06ead976462f3a61741ed9ed32d93135023a2a87aa2a1f9d806dcaad7d56d51562ff062ce12d0

data/Gemfile.lock

@@ -1,34 +1,37 @@
 PATH
   remote: .
   specs:
-    headhunter (0.0.9)
+    headhunter (0.1.3)
       colorize
-      css_parser (~> 1.2.6)
+      css_parser (>= 1.2.6)
       html_validation
       nokogiri
-      rspec
 
 GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.3.5)
+    awesome_print (1.2.0)
+    coderay (1.1.0)
     colorize (0.6.0)
-    css_parser (1.2.6)
+    coolline (0.4.3)
+    css_parser (1.3.5)
       addressable
-      rdoc
     diff-lcs (1.2.5)
     fuubar (1.3.2)
       rspec (>= 2.14.0, < 3.1.0)
       ruby-progressbar (~> 1.3)
     gem-release (0.7.1)
     html_validation (1.0.0)
-    json (1.8.1)
+    method_source (0.8.2)
     mini_portile (0.5.2)
     nokogiri (1.6.1)
       mini_portile (~> 0.5.0)
+    pry (0.9.12.6)
+      coderay (~> 1.0)
+      method_source (~> 0.8)
+      slop (~> 3.4)
     rake (10.1.1)
-    rdoc (4.1.1)
-      json (~> 1.4)
     rspec (2.14.1)
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
@@ -38,13 +41,17 @@ GEM
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.14.4)
     ruby-progressbar (1.4.0)
+    slop (3.4.7)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  awesome_print
+  coolline
   fuubar
   gem-release
   headhunter!
+  pry
   rake
   rspec (>= 2.0)

data/README.md

@@ -5,8 +5,9 @@
 [![Gem Version](https://badge.fury.io/rb/headhunter.png)](http://badge.fury.io/rb/headhunter)
 [![Code Climate](https://codeclimate.com/github/jmuheim/headhunter.png)](https://codeclimate.com/github/jmuheim/headhunter)
 [![Travis CI](https://api.travis-ci.org/jmuheim/headhunter.png)](https://travis-ci.org/jmuheim/headhunter)
+[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/jmuheim/headhunter/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
 
-Headhunter is an HTML and CSS validation tool that injects itself into your Rails feature tests and auto**magic**ally checks all your generated HTML and CSS for validity.
+Headhunter is an HTML and CSS validation tool that injects itself into your Rails feature tests and auto<strong>magic</strong>ally checks all your generated HTML and CSS for validity.
 
 In addition, it also looks out for unused (and therefore superfluous) CSS selectors.
 
@@ -32,28 +33,7 @@ $ HEADHUNTER=true cucumber
 
 Headhunter doesn't keep your tests from passing if invalid HTML or unused CSS is found. Instead it displays a short statistic after the tests are run.
 
-    $ rake HEADHUNTER=true
-
-    Precompiling assets for Headhunter... done!
-
-    30/30 |============================= 100 ==============================>| Time: 00:00:02
-
-    Finished in 2.65 seconds
-    30 examples, 0 failures
-
-    Validated 42 HTML pages.
-    41 pages are valid.
-    1 page is invalid.
-    Open .validation/results.html to view full results.
-
-    Validated 1 stylesheets.
-    1 stylesheet is invalid.
-      application.css:
-      - Line 1: Property bla doesn't exist
-
-    Found 23 CSS selectors.
-    20 selectors are in use.
-    3 selectors are not in use: a img, #flash.failure, input[type='file']
+![Headhunter output](docs/screenshot.png)
 
 ## How it works
 
@@ -65,7 +45,7 @@ For being able to validate CSS, `rake assets:precompile` is triggered at the beg
 
 ## Requirements
 
-**[Tidy HTML](http://tidy.sourceforge.net/)** should be installed on a typical OSX and Linux installation already. You're not developing on a Windows machine, are you?! If you want to validate HTML5 (and you should want to!), install the HTML5 version like described here: [homebrew tidy html5](http://techblog.willshouse.com/2013/10/21/homebrew-tidy-html5/).
+**[Tidy HTML](http://tidy.sourceforge.net/)** should be installed on a typical OSX and Linux installation already - you're not developing on a Windows machine, are you?! If you want to validate HTML5 (and you should want to!), install the HTML5 version like described here: [homebrew tidy html5](http://techblog.willshouse.com/2013/10/21/homebrew-tidy-html5/).
 
 You need a **Java Runtime Environment** to run CSS validation. This should normally already be available on OSX and Linux machines, too. A local copy ([`css-validator.jar`](http://jigsaw.w3.org/css-validator/DOWNLOAD.html)) of the [W3 CSS Validation Service](http://jigsaw.w3.org/css-validator/) is used.
 
@@ -79,6 +59,8 @@ You need a **Java Runtime Environment** to run CSS validation. This should norma
 - In feature tests, the same views are getting rendered again and again. These same sources shouldn't be validated over and over again!
 - More configuration options needed! CSS1, CSS2, CSS2.1, CSS3! XHTML, HTML5, etc.
 - Better output needed! With context lines, etc.
+- Look out for multiple used IDs on the same page and raise error!
+- Look out for invalid tags and raise error (tidy doesn't seem to do this?!)!
 
 ## Disclaimer
 

data/lib/headhunter/css_hunter.rb

@@ -21,11 +21,11 @@ module Headhunter
     end
 
     def report
-      log.puts "Found #{@used_selectors.size + @unused_selectors.size + @error_selectors.size} CSS selectors.".yellow
-      log.puts "#{@used_selectors.size} selectors are in use.".green if @used_selectors.size > 0
-      log.puts "#{@unused_selectors.size} selectors are not in use: #{@unused_selectors.sort.join(', ').red}".red if @unused_selectors.size > 0
-      log.puts "#{@error_selectors.size} selectors could not be parsed: #{@error_selectors.sort.join(', ').red}".red if @unused_selectors.size > 0
-      log.puts
+      puts "Found #{@used_selectors.size + @unused_selectors.size + @error_selectors.size} CSS selectors.".yellow
+      puts "#{@used_selectors.size} selectors are in use.".green if @used_selectors.size > 0
+      puts "#{@unused_selectors.size} selectors are not in use: #{@unused_selectors.sort.join(', ').red}".red if @unused_selectors.size > 0
+      puts "#{@error_selectors.size} selectors could not be parsed: #{@error_selectors.sort.join(', ').red}".red if @unused_selectors.size > 0
+      puts
     end
 
     private

data/lib/headhunter/css_validator.rb

@@ -24,12 +24,16 @@ module Headhunter
   class CssValidator
     USE_LOCAL_VALIDATOR = true
 
-    def initialize(stylesheets)
+    def initialize(stylesheets = [])
       @profile = 'css3' # TODO: Option for profile css1 and css21
       @stylesheets = stylesheets
       @messages_per_stylesheet = {}
     end
 
+    def add_stylesheet(stylesheet)
+      @stylesheets << stylesheet
+    end
+
     def process!
       @stylesheets.each do |stylesheet|
         css = fetch(stylesheet)
@@ -43,17 +47,17 @@ module Headhunter
     end
 
     def report
-      log.puts "Validated #{@stylesheets.size} stylesheets.".yellow
-      log.puts "#{x_stylesheets_be(@stylesheets.size - @messages_per_stylesheet.size)} valid.".green if @messages_per_stylesheet.size < @stylesheets.size
-      log.puts "#{x_stylesheets_be(@messages_per_stylesheet.size)} invalid.".red if @messages_per_stylesheet.size > 0
+      puts "Validated #{@stylesheets.size} stylesheets.".yellow
+      puts "#{x_stylesheets_be(@stylesheets.size - @messages_per_stylesheet.size)} valid.".green if @messages_per_stylesheet.size < @stylesheets.size
+      puts "#{x_stylesheets_be(@messages_per_stylesheet.size)} invalid.".red if @messages_per_stylesheet.size > 0
 
       @messages_per_stylesheet.each_pair do |stylesheet, messages|
-        log.puts "  #{extract_filename(stylesheet)}:".red
+        puts "  #{extract_filename(stylesheet)}:".red
 
-        messages.each { |message| log.puts "  - #{message}".red }
+        messages.each { |message| puts "  - #{message}".red }
       end
 
-      log.puts
+      puts
     end
 
     private

data/lib/headhunter/html_validator.rb

@@ -34,11 +34,11 @@ module Headhunter
     end
 
     def report
-      log.puts "Validated #{@valid_results.size + @invalid_results.size} HTML pages.".yellow
-      log.puts "#{x_pages_be(@valid_results.size)} valid.".green if @valid_results.size > 0
-      log.puts "#{x_pages_be(@invalid_results.size)} invalid.".red if @invalid_results.size > 0
-      log.puts 'Open .validation/results.html to view full results.'
-      log.puts
+      puts "Validated #{@valid_results.size + @invalid_results.size} HTML pages.".yellow
+      puts "#{x_pages_be(@valid_results.size)} valid.".green if @valid_results.size > 0
+      puts "#{x_pages_be(@invalid_results.size)} invalid.".red if @invalid_results.size > 0
+      puts 'Open .validation/results.html to view full results.'
+      puts
     end
 
     private

data/lib/headhunter/local_response.rb

@@ -0,0 +1,20 @@
+require 'rexml/document'
+
+module Headhunter
+  class LocalResponse
+    attr_reader :body
+
+    def initialize(body)
+      @body = body
+      @headers = {'x-w3c-validator-status' => valid?}
+    end
+
+    def [](key)
+      @headers[key]
+    end
+
+    def valid?
+      REXML::Document.new(@body).root.each_element('//m:validity') { |e| return e.text == 'true' }
+    end
+  end
+end

data/lib/headhunter/runner.rb

@@ -13,9 +13,9 @@ module Headhunter
       precompile_assets!
 
       @html_validator = HtmlValidator.new
-      @css_validator  = CssValidator.new(stylesheets)
       @css_hunter     = CssHunter.new(stylesheets)
 
+      @css_validator = CssValidator.new(stylesheets)
       @css_validator.process!
     end
 
@@ -25,9 +25,9 @@ module Headhunter
     end
 
     def clean_up!
-      log.print "Headhunter is removing precompiled assets...".yellow
+      print "Headhunter is removing precompiled assets...".yellow
       remove_assets!
-      log.puts " done!".yellow
+      puts " done!".yellow
     end
 
     def report
@@ -41,16 +41,16 @@ module Headhunter
     private
 
     def precompile_assets!
-      log.print "Headhunter is removing eventually existing assets...".yellow
+      print "Headhunter is removing eventually existing assets...".yellow
       remove_assets! # Remove existing assets! This seems to be necessary to make sure that they don't exist twice, see http://stackoverflow.com/questions/20938891
       sleep 1
-      log.puts " done!".yellow
+      puts " done!".yellow
 
       sleep 1
 
-      log.print "Headhunter is precompiling assets...".yellow
+      print "Headhunter is precompiling assets...".yellow
       system 'rake assets:precompile HEADHUNTER=false &> /dev/null'
-      log.puts " done!\n".yellow
+      puts " done!\n".yellow
     end
 
     def remove_assets!

data/lib/headhunter/version.rb

@@ -1,3 +1,3 @@
 module Headhunter
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: headhunter
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Joshua Muheim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-22 00:00:00.000000000 Z
+date: 2014-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -28,14 +28,14 @@ dependencies:
   name: css_parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.2.6
 - !ruby/object:Gem::Dependency
@@ -73,7 +73,7 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -94,6 +94,48 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coolline
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: awesome_print
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: gem-release
   requirement: !ruby/object:Gem::Requirement
@@ -153,6 +195,7 @@ files:
 - lib/headhunter/css_hunter.rb
 - lib/headhunter/css_validator.rb
 - lib/headhunter/html_validator.rb
+- lib/headhunter/local_response.rb
 - lib/headhunter/rack/capturing_middleware.rb
 - lib/headhunter/rails.rb
 - lib/headhunter/runner.rb
@@ -166,6 +209,7 @@ files:
 - README.md
 - docs/headhunter.png
 - docs/money.png
+- docs/screenshot.png
 homepage: http://github.com/jmuheim/headhunter
 licenses:
 - MIT