headdesk 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62c7f436a234501a6af9f675f3ae62fa6a8d8d8d31a3260ce131657723cdbcd6
-  data.tar.gz: 299ca0df2da4633faef31dde2067ea1605c9a5056ff51baf22d4817e5e26b994
+  metadata.gz: 5b515a8aecb49ea64462548ee2ae36181b1d106a78d3ea396235bf24ff2ef87d
+  data.tar.gz: 594961e4633d5bfcb7e4af07f6e90cfc94e5f03f0f82507c4ac2580cfbce8be7
 SHA512:
-  metadata.gz: d1c9a45990430accfd2d59d4dd11f1d6359c95155b596e2a8305a698e095d8c5136dec385e06ea9164e5262c6d5998f850414b4a86547ae2ca9b1b49fa0efb5d
-  data.tar.gz: c8e713e2d40e996c3f11abfd6735a7c4cac731f74bbc4652ee8495e75127c99afb68559846bc42ca4065af13a752a5df97fcfce96871ce2a475f6d5aa304baef
+  metadata.gz: 2c04f5d7f6ec81360149cb165a3f801f619a71c8f5f7fb93427be3547bcdc1733024cb77194acd08ca4431121ebfab2b96772e4d08ecb29ec8dd947868f1e766
+  data.tar.gz: 83c0724e4bae5cf7fc234b740504e4450ebd64df81ed8ef63ff11453a50bda6f44d6c630f5c6d83094b167400511beed04494011ed2a32fe0d2caad0a1e2b8a1

data/.gitignore

@@ -6,6 +6,7 @@
 /pkg/
 /spec/reports/
 /tmp/
+/vendor/
 
 coverage
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    headdesk (0.13.0)
+    headdesk (0.14.0)
       awesome_print (~> 1.8)
       gems (~> 1.1)
       nokogiri (~> 1.10)
@@ -35,7 +35,7 @@ GEM
     json (2.1.0)
     kwalify (0.7.2)
     mini_portile2 (2.4.0)
-    nokogiri (1.10.3)
+    nokogiri (1.10.4)
       mini_portile2 (~> 2.4.0)
     oily_png (1.2.1)
       chunky_png (~> 1.3.7)

data/README.md

@@ -17,9 +17,9 @@ This is output from the check that ensures that the version of the Facebook SDK
 `headdesk` can also output to JSON.
 
 ## Checks
-* [api26](docs/api26.md)
 * [facebook](docs/facebook.md)
 * [receiver](docs/receiver.md)
+* [target_sdk_version](docs/target_sdk_version.md)
 * [teak/api21_icon](docs/teak/api21_icon.md)
 * [teak/configuration](docs/teak/configuration.md)
 

data/Rakefile

@@ -2,3 +2,7 @@
 
 require 'bundler/gem_tasks'
 task default: :spec
+
+task :facebook do
+  sh 'bundle exec bin/facebook_sdk_versions'
+end

data/bin/facebook_sdk_versions

@@ -6,19 +6,35 @@ require 'nokogiri'
 require 'open-uri'
 require 'yaml'
 
-html_doc = Nokogiri::HTML(open('https://developers.facebook.com/docs/android/change-log-4x'))
+@facebook_sdk_versions = {}
 
-facebook_sdk_versions = html_doc.xpath('//h2')
-                                .select { |h2| h2.attributes['id'].value =~ /^\d+_\d+_\d+$/ }
-                                .collect do |h2|
-  major, minor, patch, date = h2.text.match(/^(\d+)\.(\d+)\.?(\d+)? \- (.*)$/).captures
-  {
+def add_version(str, matcher)
+  major, minor, patch, date = str.match(matcher).captures
+  version_string = "#{major.to_i || 0}.#{minor.to_i || 0}.#{patch.to_i || 0}"
+  @facebook_sdk_versions[version_string] = {
     major: major.to_i || 0,
     minor: minor.to_i || 0,
     patch: patch.to_i || 0,
-    version: "#{major.to_i || 0}.#{minor.to_i || 0}.#{patch.to_i || 0}",
+    version: version_string,
     date: Date.parse(date)
   }
 end
 
-File.write(Headdesk::FACEBOOK_SDK_VERSIONS_YAML, facebook_sdk_versions.to_yaml)
+html_doc = Nokogiri::HTML(open('https://developers.facebook.com/docs/android/change-log-4x'))
+
+html_match = /^(\d+)\.(\d+)\.?(\d+)? \- (.*)$/
+html_doc.xpath('//h2')
+        .select { |h2| html_match.match?(h2.text) }
+        .collect do |h2|
+  add_version(h2.text, html_match)
+end
+
+changelog_md = open('https://raw.githubusercontent.com/facebook/facebook-android-sdk/master/CHANGELOG.md') { |f| f.read }
+
+markdown_match = /^## \[(\d+)\.(\d+)\.?(\d+)?\] \- (.*)$/
+changelog_md.each_line.select { |line| markdown_match.match?(line) }
+                      .collect do |line|
+  add_version(line, markdown_match)
+end
+
+File.write(Headdesk::FACEBOOK_SDK_VERSIONS_YAML, @facebook_sdk_versions.values.to_yaml)

data/docs/target_sdk_version.md

@@ -0,0 +1,14 @@
+# target_sdk_version
+Ensures that the APK is built with `targetSdkVersion` at least 28.
+
+## Will Fail If
+* `targetSdkVersion` is less than 28.
+
+## Exports
+None.
+
+## Reason
+As of November 1, 2019 Google Play requires that all apps, and app updates, target Android 9 (API 28).
+
+## Resolution
+Target API 28 or higher.

data/lib/headdesk/checks/target_sdk_version.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Headdesk
+  module Checks
+    #
+    # APKs should all target API 26+
+    #
+    # :reek:UncommunicativeModuleName
+    class TargetSdkVersion
+      include Check::APK
+
+      check_name 'target_sdk_version'
+      describe 'targetSdkVersion must be at least 28'
+      def call
+        fail_check unless: -> { apk.targets_sdk 28 }
+      end
+    end
+  end
+end

data/lib/headdesk/data/facebook_sdk_versions.yaml

@@ -8,12 +8,12 @@
   :minor: 40
   :patch: 0
   :version: 4.40.0
-  :date: 2019-01-22
+  :date: 2019-01-17
 - :major: 4
   :minor: 39
   :patch: 0
   :version: 4.39.0
-  :date: 2018-12-05
+  :date: 2018-12-03
 - :major: 4
   :minor: 38
   :patch: 1
@@ -294,3 +294,93 @@
   :patch: 0
   :version: 4.0.0
   :date: 2015-03-25
+- :major: 5
+  :minor: 13
+  :patch: 0
+  :version: 5.13.0
+  :date: 2019-12-11
+- :major: 5
+  :minor: 12
+  :patch: 1
+  :version: 5.12.1
+  :date: 2019-12-08
+- :major: 5
+  :minor: 12
+  :patch: 0
+  :version: 5.12.0
+  :date: 2019-12-03
+- :major: 5
+  :minor: 11
+  :patch: 2
+  :version: 5.11.2
+  :date: 2019-11-21
+- :major: 5
+  :minor: 11
+  :patch: 1
+  :version: 5.11.1
+  :date: 2019-11-21
+- :major: 5
+  :minor: 11
+  :patch: 0
+  :version: 5.11.0
+  :date: 2019-11-14
+- :major: 5
+  :minor: 9
+  :patch: 0
+  :version: 5.9.0
+  :date: 2019-10-28
+- :major: 5
+  :minor: 8
+  :patch: 0
+  :version: 5.8.0
+  :date: 2019-10-08
+- :major: 5
+  :minor: 5
+  :patch: 2
+  :version: 5.5.2
+  :date: 2019-10-04
+- :major: 5
+  :minor: 5
+  :patch: 1
+  :version: 5.5.1
+  :date: 2019-09-05
+- :major: 5
+  :minor: 5
+  :patch: 0
+  :version: 5.5.0
+  :date: 2019-08-30
+- :major: 5
+  :minor: 4
+  :patch: 0
+  :version: 5.4.0
+  :date: 2019-08-15
+- :major: 5
+  :minor: 2
+  :patch: 0
+  :version: 5.2.0
+  :date: 2019-07-29
+- :major: 5
+  :minor: 1
+  :patch: 1
+  :version: 5.1.1
+  :date: 2019-07-21
+- :major: 5
+  :minor: 1
+  :patch: 0
+  :version: 5.1.0
+  :date: 2019-06-21
+- :major: 5
+  :minor: 0
+  :patch: 2
+  :version: 5.0.2
+  :date: 2019-06-07
+- :major: 5
+  :minor: 0
+  :patch: 1
+  :version: 5.0.1
+  :date: 2019-05-16
+- :major: 5
+  :minor: 0
+  :patch: 0
+  :version: 5.0.0
+  :date: 2019-04-30

data/lib/headdesk/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Headdesk
-  VERSION = '0.14.0'
+  VERSION = '0.15.0'
   APKTOOL_VERSION = '2.3.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: headdesk
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Pat Wilson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-18 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -213,10 +213,10 @@ files:
 - bin/facebook_sdk_versions
 - bin/setup
 - docs/activity_alias.md
-- docs/api26.md
 - docs/facebook.md
 - docs/firebase_messaging_event.md
 - docs/receiver.md
+- docs/target_sdk_version.md
 - docs/teak/api21_icon.md
 - docs/teak/configuration.md
 - exe/headdesk
@@ -232,10 +232,10 @@ files:
 - lib/headdesk/apktool.rb
 - lib/headdesk/check.rb
 - lib/headdesk/checks/activity_alias.rb
-- lib/headdesk/checks/api26.rb
 - lib/headdesk/checks/facebook.rb
 - lib/headdesk/checks/firebase_messaging_event.rb
 - lib/headdesk/checks/receiver.rb
+- lib/headdesk/checks/target_sdk_version.rb
 - lib/headdesk/checks/teak.rb
 - lib/headdesk/checks/teak/api21_icon.rb
 - lib/headdesk/checks/teak/teak.rb

data/docs/api26.md

@@ -1,17 +0,0 @@
-# api26
-Ensures that the APK is built with `targetSdkVersion` at least 26.
-
-## Will Fail If
-* `targetSdkVersion` is less than 26.
-
-## Exports
-None.
-
-## Reason
-As of November 1, 2018 Google Play requires that all apps, and app updates, target Android 8 (API 26).
-
-> Google Play will require that new apps target at least Android 8.0 (API level 26) from August 1, 2018, and that app updates target Android 8.0 from November 1, 2018.
-Source: https://developer.android.com/distribute/best-practices/develop/target-sdk
-
-## Resolution
-Target API 26 or higher.

data/lib/headdesk/checks/api26.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module Headdesk
-  module Checks
-    #
-    # APKs should all target API 26+
-    #
-    # :reek:UncommunicativeModuleName
-    class Api26
-      include Check::APK
-
-      check_name 'api26'
-      describe 'targetSdkVersion must be at least 26'
-      def call
-        fail_check unless: -> { apk.targets_sdk 26 }
-
-        klass_def = 'android/support/v4/app/NotificationCompat$Builder'
-        skip_check unless: -> { apk.class?(klass_def) }
-        klass = apk.find_class(klass_def)
-
-        describe 'support-v4 version is 26.1+'
-        fail_check unless: -> { klass.method?('setChannelId') }
-
-        # TODO: AndroidX/JetPack
-      end
-    end
-  end
-end