hbci 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d8863eaee26a37c3a6abe14db9196ffdded7a0c556ba1f16e96b9359b7c208a
-  data.tar.gz: 2384b7d356861ba1100e0ffe94da7818d209e06d380882a11b25e6e6c6b7c340
+  metadata.gz: 561835270d94e66ef6062e37eb5636086adcb8d8ed0b88740bf9fb88716a1508
+  data.tar.gz: 36f7ba79371222b6d91fa1754052ea89f5bc72d9657f2c7cf1111c867efa70fe
 SHA512:
-  metadata.gz: 6aa8166bb31112f62d23eeca4f43df2d3fe700885559b613444459f07d0efca42d091e5612b87f2b44394b652cc9a4fcbd7e5e4421744077a86ff80f5f1a02ac
-  data.tar.gz: 5e18b33710be68bba1b1688c02ad86ee2e46aba6a807671c9227d8f80c7137738c189260bfc4fe782ed3d6831217e0c111d78f7b208e781989bb0c0166098647
+  metadata.gz: cffbfa1831358127ecffcea548e79243a484e216a045566ddb92345f0a7da69de932b8da39befcdb148f875566bfb862ea89de1b321caf40074e142945166f14
+  data.tar.gz: 219ac32f77934db6916cd024eeb1c201c49f4cacc597726d346c82dfb103bdd2fbd4b951fe73814579f17a8b9491f38ef4dfb007d59bf7ac00c4084ec82dfb2f

data/.rubocop.yml

@@ -12,8 +12,7 @@ Metrics/ModuleLength:
 
 Metrics/LineLength:
   Exclude:
-    - spec/support/message_stubs.rb
-    - spec/support/request_stubs.rb
+    - spec/**/*
 
 Metrics/AbcSize:
   Exclude: 
@@ -24,3 +23,7 @@ Metrics/ParameterLists:
     - spec/support/message_stubs.rb
     - spec/support/request_stubs.rb
 
+
+Lint/UnusedMethodArgument:
+  Exclude:
+    - spec/support/*

data/.rubocop_todo.yml

@@ -23,4 +23,4 @@ Metrics/MethodLength:
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 117
+  Max: 150

data/examples/get_transactions.rb

@@ -14,4 +14,3 @@ Hbci::Connector.open(@credentials) do |connector|
     end
   end
 end
-

data/hbci.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'bank_credentials'
-  spec.add_runtime_dependency 'cmxl', '~> 1.1'
+  spec.add_runtime_dependency 'cmxl', '~> 1.2'
   spec.add_runtime_dependency 'httparty', '~> 0.16'
   spec.add_runtime_dependency 'ibanizator', '~> 0.3'
   spec.add_runtime_dependency 'monetize', ['>=1.8', '<2.0.0']
@@ -29,8 +29,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'byebug', '~> 10.0'
   spec.add_development_dependency 'rake', '~> 12.3'
-  spec.add_development_dependency 'rspec',  '~> 3.7'
-  spec.add_development_dependency 'rubocop', '~> 0.57'
+  spec.add_development_dependency 'rspec', '~> 3.8'
+  spec.add_development_dependency 'rubocop', '~> 0.60'
   spec.add_development_dependency 'timecop', '~> 0.9'
   spec.add_development_dependency 'webmock', '~> 3.4'
 end

data/lib/hbci/connector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hbci
   class Connector
     attr_accessor :message_number
@@ -16,6 +18,7 @@ module Hbci
 
     def credentials=(credentials)
       raise ArgumentError, "#{self.class.name}#initialize expects a BankCredentials::Hbci object" unless credentials.is_a?(BankCredentials::Hbci)
+
       credentials.validate!
       @credentials = credentials
     end
@@ -28,6 +31,7 @@ module Hbci
       req = HTTParty.post(@credentials.url, body: request_message.to_base64)
       @message_number += 1
       raise "Error in https communication with bank: #{req.response.inspect}" unless req.success?
+
       Base64.decode64(req.response.body)
     end
   end

data/lib/hbci/element_group.rb

@@ -66,6 +66,7 @@ module Hbci
       index = index_for_element(potential_element_name)
       if index
         return set_element(potential_element_name, args.first) if is_writer && args.count == 1
+
         return get_element(potential_element_name)
       end
 

data/lib/hbci/message.rb

@@ -19,7 +19,7 @@ module Hbci
     end
 
     def compile
-      @segments.each_with_index do |segment, index|
+      @segments.each_with_index do |segment, _index|
         segment.compile
         unless segment.head.position
           segment.head.position = @next_position

data/lib/hbci/message_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hbci
   module MessageFactory
     def self.build(connector, dialog)

data/lib/hbci/parser.rb

@@ -31,7 +31,7 @@ module Hbci
     #     )                        end of look-ahead
     # ------------------------------------------------------------------------
     #   )                        end of \1
-    ELEMENT_REGEX           = /(.*?(?=(?<!\?)[:+']))/
+    ELEMENT_REGEX           = /(.*?(?=(?<!\?)[:+']))/.freeze
 
     # Binary Elements may contain unescaped delimiters. Thus they are not
     # terminated by regular delimiters. But their content is preceeded with
@@ -40,7 +40,7 @@ module Hbci
     # '@6@mydata' or '@12@mydatamydata'
     #
     # The BINARY_ELEMENT_LENGTH_REGEx matches only the length.
-    BINARY_ELEMENT_LENGTH_REGEX = /@(\d+)@/
+    BINARY_ELEMENT_LENGTH_REGEX = /@(\d+)@/.freeze
 
     def self.parse(string)
       new(string).parse
@@ -76,6 +76,7 @@ module Hbci
     def parse_delimiter
       delimiter = scanner.getch
       return if scanner.eos?
+
       if delimiter == ELEMENT_GROUP_DELIMITER
         add_element_group
       elsif delimiter == SEGMENT_DELIMITER

data/lib/hbci/response.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 module Hbci
@@ -15,7 +14,7 @@ module Hbci
     end
 
     def find_all(segment_type)
-      @raw_segments.select { |sd| sd[0][0] == segment_type }.map{ |sd| Hbci::SegmentFactory.build(sd) }
+      @raw_segments.select { |sd| sd[0][0] == segment_type }.map { |sd| Hbci::SegmentFactory.build(sd) }
     end
 
     def to_s

data/lib/hbci/segment.rb

@@ -46,8 +46,7 @@ module Hbci
       define_element_groups
     end
 
-    def compile
-    end
+    def compile; end
 
     def to_s
       element_groups.join('+').gsub(/\+*$/, '') << '\''

data/lib/hbci/segments/hirmg.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hbci
   module Segments
     class HIRMGv2 < Segment

data/lib/hbci/segments/hisyn.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hbci
   module Segments
     class HISYNv4 < Segment

data/lib/hbci/segments/hkidn.rb

@@ -13,7 +13,7 @@ module Hbci
       element :state, default: 1
 
       def compile
-        self.bank.code = request_message.connector.credentials.bank_code
+        bank.code = request_message.connector.credentials.bank_code
         self.user_id = request_message.connector.credentials.user_id
         self.system_id = request_message.dialog ? request_message.dialog.system_id : 0
       end

data/lib/hbci/segments/hksyn.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hbci
   module Segments
     class HKSYNv3 < Segment

data/lib/hbci/segments/hnshk.rb

@@ -63,8 +63,8 @@ module Hbci
 
       def compile
         self.security_reference = request_message.sec_ref
-        self.security_identification_details.party_identification = request_message.dialog ? request_message.dialog.system_id : 0
-        self.tan_mechanism = request_message.dialog.tan_mechanism if request_message.dialog && request_message.dialog.tan_mechanism
+        security_identification_details.party_identification = request_message.dialog ? request_message.dialog.system_id : 0
+        self.tan_mechanism = request_message.dialog.tan_mechanism if request_message.dialog&.tan_mechanism
         set_credentials
       end
 

data/lib/hbci/segments/hnvsd.rb

@@ -22,7 +22,7 @@ module Hbci
 
       def find_all(segment_type)
         @raw_segments = Parser.parse(content)
-        @raw_segments.select { |sd| sd[0][0] == segment_type }.map{ |sd| Hbci::SegmentFactory.build(sd) }
+        @raw_segments.select { |sd| sd[0][0] == segment_type }.map { |sd| Hbci::SegmentFactory.build(sd) }
       end
 
       def add_segment(segment)

data/lib/hbci/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hbci
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hbci
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Roman Lehnert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-01 00:00:00.000000000 Z
+date: 2018-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bank_credentials
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -169,28 +169,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.57'
+        version: '0.60'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.57'
+        version: '0.60'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement