haveapi 0.28.0 → 0.28.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4dc49769be220f91aa34770fa280e1507a3eef56ad97f1cdda575a4d42f42ad0
-  data.tar.gz: '09177e0cf827dbed3e8a31290c2f0088a7e7857bab9c4cbd2d3953a55a84747e'
+  metadata.gz: 57ff88678f46548f5a2717e7aae799df778723b95b0384471e873b17b0791669
+  data.tar.gz: 2062ffb0fef65373b74d7ecef1eae40c0cf16433eef60d3d28c52c3b8b4c7e9e
 SHA512:
-  metadata.gz: 0bbac0d82fcfcba37da6874b54b667036cac326aead8da3e573ce1fac77a986fe191d3e6fb1c1754d65cb0fc5f7fb4d7c7d1d7f5fe329e0135a019fb00100561
-  data.tar.gz: d031c935fffbb7ccd5f4262598fae87e93b8055d393576336d4afd5f4b14a3e19c77d024dcfede042d1e37ac72f8a5d79fc84e96dd94f2a5e0e74ca9984840d9
+  metadata.gz: 5c9d3bc013ac270b3de0b411838a69ac20c920eef8d11cf7552da3e9a852328ab493a5642fc3d4490e7d126d8114f6eda38269b06da2ad3f32a711fa673cbdb3
+  data.tar.gz: 3deaf826dbc931825edd8babd1b453faf9521015bf07450d24e2c290bd37cbd0f47cf2dbde90e2245cf5cefa4c673723c97283c1c836f0826cd517117ad44500

data/haveapi.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= #{File.read('../../.ruby-version').strip}"
 
   s.add_dependency 'activesupport', '>= 7.1'
-  s.add_dependency 'haveapi-client', '~> 0.28.0'
+  s.add_dependency 'haveapi-client', '~> 0.28.1'
   s.add_dependency 'json'
   s.add_dependency 'mail'
   s.add_dependency 'nesty', '~> 1.0'

data/lib/haveapi/action.rb

@@ -287,7 +287,9 @@ module HaveAPI
         params = {}
 
         path_param_names(path).each do |name|
-          params[name] = values.shift.to_s
+          value = values.shift.to_s
+          params[name] = value
+          params[name.to_sym] = value
         end
 
         params

data/lib/haveapi/version.rb

@@ -1,4 +1,4 @@
 module HaveAPI
   PROTOCOL_VERSION = '2.0'.freeze
-  VERSION = '0.28.0'.freeze
+  VERSION = '0.28.1'.freeze
 end

data/spec/action/runtime_spec.rb

@@ -430,6 +430,13 @@ describe HaveAPI::Action do
       action_hooks[:listeners] = original
     end
 
+    it 'builds path params with string and symbol keys' do
+      expect(action_class(:show).path_params('/tests/{test_id}', 123)).to eq({
+        'test_id' => '123',
+        test_id: '123'
+      })
+    end
+
     it '_meta.no suppresses metadata' do
       action_class(:echo).calls.clear
 

data/spec/model_adapters/active_record_spec.rb

@@ -113,7 +113,7 @@ describe HaveAPI::ModelAdapters::ActiveRecord do
         end
 
         def prepare
-          group = self.class.model.find(params['group_id'])
+          group = self.class.model.find(params[:group_id])
           error!('access denied') if group.note == 'PRIVATE_GROUP_NOTE'
         end
 
@@ -533,6 +533,19 @@ describe HaveAPI::ModelAdapters::ActiveRecord do
     expect(group_data[:environment]).not_to have_key(:note)
   end
 
+  it 'passes symbol path params to associated show prepare when included' do
+    group = ARAdapterSpec::Group.create!(label: 'grp', note: 'GROUP_NOTE')
+    user = create_user(name: 'user', group: group)
+
+    get "/v1/users/#{user.id}", { _meta: { includes: 'group' } }, input: ''
+
+    expect(last_response.status).to eq(200)
+    expect(api_response).to be_ok
+    group_data = api_response[:user][:group]
+    expect(group_data[:_meta][:resolved]).to be(true)
+    expect(group_data).to include(id: group.id, label: 'grp', note: 'GROUP_NOTE')
+  end
+
   it 'applies associated show output restrictions when included' do
     group = ARAdapterSpec::Group.create!(label: 'grp', note: 'GROUP_SECRET')
     user = create_user(name: 'user', group: group)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: haveapi
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.28.1
 platform: ruby
 authors:
 - Jakub Skokan
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.28.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.28.1
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement