hasoffers 0.1.8 → 0.1.9

data/CHANGELOG

@@ -1,3 +1,9 @@
+== Version 0.1.9
+* Fix adding errors in has_offers_model that supports Rails 3.2 and above
+
+== Version 0.1.8
+* Unescape query string before gsubbing
+
 == Version 0.1.6
 * Fix issues with error hash on Response object
 * Fix issues that occur when sending GET requests over a proxy, switched

data/Gemfile.lock

@@ -1,17 +1,27 @@
 PATH
   remote: .
   specs:
-    hasoffers (0.1.8)
+    hasoffers (0.1.9)
+      activemodel (~> 3.2)
       crack
       yajl-ruby
 
 GEM
   remote: http://rubygems.org/
   specs:
+    activemodel (3.2.18)
+      activesupport (= 3.2.18)
+      builder (~> 3.0.0)
+    activesupport (3.2.18)
+      i18n (~> 0.6, >= 0.6.4)
+      multi_json (~> 1.0)
+    builder (3.0.4)
     crack (0.4.2)
       safe_yaml (~> 1.0.0)
+    i18n (0.6.9)
+    multi_json (1.10.0)
     rake (0.9.2)
-    safe_yaml (1.0.1)
+    safe_yaml (1.0.3)
     yajl-ruby (1.2.0)
 
 PLATFORMS

data/Rakefile

@@ -4,5 +4,5 @@ Bundler::GemHelper.install_tasks
 require 'rake/testtask'
 
 Rake::TestTask.new do |t|
-  t.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
+  t.test_files = Dir.glob("{test,spec,features}/**/*")
 end

data/hasoffers.gemspec

@@ -21,5 +21,6 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
   s.add_dependency 'crack'
   s.add_dependency 'yajl-ruby'
+  s.add_dependency 'activemodel', '~> 3.2'
   s.add_development_dependency 'rake'
 end

data/lib/has_offers_model.rb

@@ -40,16 +40,21 @@ module HasOffersModel
         define_method("check_for_errors") do |response|
           unless response.success?
             response.error_messages.each do |error_message|
-              self.errors.add_to_base "HasOffers API Error: #{error_message}" 
+              new_error_message = "HasOffers API Error: #{error_message}"
+              if self.errors.respond_to?(:add_to_base)
+                self.errors.add_to_base new_error_message
+              else
+                self.errors.add :base, new_error_message
+              end
             end
           end
           response.success?
         end
 
       end
-    
+
     end
-    
+
   end
-  
-end
+
+end

data/lib/hasoffers/version.rb

@@ -1,3 +1,3 @@
 module Hasoffers
-  VERSION = "0.1.8"
+  VERSION = "0.1.9"
 end

data/test/has_offers_model_test.rb

@@ -0,0 +1,34 @@
+require File.expand_path(File.dirname(__FILE__) + '/test_helper')
+require 'has_offers_model'
+
+class DummyModel
+  include ActiveModel::Validations
+  include HasOffersModel
+  has_offers_model "Affiliate"
+end
+
+class HasOffersModelTest < Test::Unit::TestCase
+
+  def create_model
+    DummyModel.new
+  end
+
+  def failed_response
+    OpenStruct.new :success? => false,
+                   :error_messages => ["All your fault"]
+  end
+
+  def test_instantiating_a_new_has_offers_model
+    assert_nothing_raised do
+      create_model
+    end
+  end
+
+  def test_adding_errors
+    model = create_model
+    model.check_for_errors failed_response
+    assert model.errors[:base].include?("HasOffers API Error: All your fault"),
+      "HasOffers error was not applied!"
+  end
+
+end

data/test/test_helper.rb

@@ -1,7 +1,9 @@
 require "test/unit"
 require "rubygems"
+require "active_model"
+require 'active_support/all'
 require "hasoffers"
 
 def assert_success(response)
   assert response.success?, "Failed with error messages: #{response.error_messages}"
-end
+end

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: hasoffers
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
+  prerelease: 
 platform: ruby
 authors:
 - Luke Ludwig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-06 00:00:00.000000000 Z
+date: 2014-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -27,6 +30,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -34,13 +38,31 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -48,6 +70,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -87,32 +110,40 @@ files:
 - test/affiliate_test.rb
 - test/base_test.rb
 - test/conversion_test.rb
+- test/has_offers_model_test.rb
 - test/offer_test.rb
 - test/report_test.rb
 - test/test_helper.rb
 homepage: https://github.com/sportngin/hasoffers
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3236966753044289822
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -3236966753044289822
 requirements: []
 rubyforge_project: hasoffers
-rubygems_version: 2.0.14
+rubygems_version: 1.8.23.2
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Implementation of the HasOffers API for affiliate advertising.
 test_files:
 - test/advertiser_test.rb
@@ -120,6 +151,7 @@ test_files:
 - test/affiliate_test.rb
 - test/base_test.rb
 - test/conversion_test.rb
+- test/has_offers_model_test.rb
 - test/offer_test.rb
 - test/report_test.rb
 - test/test_helper.rb

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OGMyYjZmYTRlOTZmZjVlOThmMDc4NWMxODI4ZTdlMDUzZDc5MzljZQ==
-  data.tar.gz: !binary |-
-    NjYyZTY2N2E1ZmZjOWEwZTQxZTdkZjU0MzExYTViMzZjYzUxZTI4Nw==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    YWViNGIyZGRlM2I4MWFkOWJjZGE4YmQzZGJmNmMxYTVlMTI3ODBiNzViYmU0
-    NmQzN2ExMjgzZGM5ZDA0NTA0YjFlMzAwNzU0Nzk4ZTliNjgwYThjNjlmNTJi
-    NTFmNThlNjBkZmIyN2U4YTlkMWViNjJlMmQ1M2FjOTJhZTJjYWQ=
-  data.tar.gz: !binary |-
-    MzkwN2Y1MTg1ZGZkYzVkYWZmY2I2YjRkYmQ1OTUzZTA1YjFiMDM2MWM4YTY3
-    MmEyNmM1ZmMxOTU3YzFhMTM1MDg0ZWRhNWQ0MzkyZjc1MTNkNjNhMDNhMTkz
-    ZjQ3MzMwZjc0ZDA5MTUyMGQyZDI5NTFkOWM0OTFhNzgwYzhlZTU=