hashme 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eeb34cad001a9e72ba6e9bd7a7f1ea26df382bc0
-  data.tar.gz: 84add3cad188a7a7ef18966416a1a5e5bbd96230
+  metadata.gz: 6f661ccdfd584ab3c1da7e2b5681a16d65063680
+  data.tar.gz: c50294da6a1433fdf17b24896a4fc1c6eafe3cff
 SHA512:
-  metadata.gz: 3169335c642413fc0ab103c962419e2c3c2ae6bd5202a5aae0cd8995b86fe23df891bc39ec0be59f7475321b0160697c0297a353c249c1769905f335c9ec31d4
-  data.tar.gz: 57d07bc8e59fad1f67315c2276d654a371c76076699140f65c8edd971f7458e298032f228704b291063a042b91bb425570c7d59b2bc5e452a5d3340d2077500f
+  metadata.gz: ac96d51a4764a70037e5b693fc27ebbb08463363ce0d626b7382efbdf0b9ab16e1af12cb94be200595a26fbac7fb272125741e0921876b20dca9954f27dd0b38
+  data.tar.gz: 6104d65c1741d731405f492bafb59aeb4b57189b4d18096928b75272f91558dbb126304e01c27ba6dc5ffcd6e95f3fc5ab58680bc7be6986e0729e840c71741f

data/README.md

@@ -118,6 +118,10 @@ u.errors.first     # [:email, "can't be blank"]
 
 ## History
 
+### 0.2.4 - 2016-06-03
+
+ * Removing `casted_by` property, due to lack of use case and complication it causes.
+
 ### 0.2.3 - 2016-06-03
 
  * Fixing bug with validation on CastedArrays

data/lib/hashme.rb

@@ -12,7 +12,6 @@ require "active_support/json"
 # Local dependencies
 
 require "hashme/attributes"
-require "hashme/castable"
 require "hashme/casted_array"
 require "hashme/properties"
 require "hashme/property"
@@ -26,7 +25,6 @@ module Hashme
   include Validations
 
   included do
-    include Castable
     include Attributes
     include Properties
   end

data/lib/hashme/casted_array.rb

@@ -10,7 +10,8 @@ module Hashme
   #
   class CastedArray
     extend Forwardable
-    include Castable
+
+    attr_reader :property
 
     def_delegators :@_array,
       :to_a, :==, :eql?, :size,
@@ -22,8 +23,7 @@ module Hashme
 
     def initialize(property, owner, values = [])
       @_array = []
-      self.casted_by = owner
-      self.casted_by_property = property
+      @property = property
       if values.respond_to?(:each)
         values.each do |value|
           self.push(value)
@@ -54,7 +54,7 @@ module Hashme
     protected
 
     def instantiate_and_build(obj)
-      casted_by_property.build(self, obj)
+      property.build(self, obj)
     end
 
   end

data/lib/hashme/property_casting.rb

@@ -18,11 +18,7 @@ module Hashme
       elsif CASTABLE_TYPES.include?(type)
         send('typecast_to_'+type.to_s.downcase, value)
       else
-        # Complex objects we don't know how to cast
-        type.new(value).tap do |obj|
-          obj.casted_by = owner if obj.respond_to?(:casted_by=)
-          obj.casted_by_property = property if obj.respond_to?(:casted_by_property=)
-        end
+        type.new(value)
       end
     end
 

data/lib/hashme/version.rb

@@ -1,3 +1,3 @@
 module Hashme
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/spec/hashme/casted_array_spec.rb

@@ -25,9 +25,8 @@ describe Hashme::CastedArray do
       expect(@obj.length).to eql(1)
     end
 
-    it "should set owner and property" do
-      expect(@obj.casted_by).to eql(owner)
-      expect(@obj.casted_by_property).to eql(property)
+    it "should set property" do
+      expect(@obj.property).to eql(property)
     end
 
     it "should instantiate and cast each value" do
@@ -49,9 +48,6 @@ describe Hashme::CastedArray do
       expect(subject.last.class).to eql(submodel)
       expect(subject.first.name).to eql('test')
       expect(subject.last.name).to eql('test2')
-
-      expect(subject.last.casted_by).to be(subject)
-      expect(subject.last.casted_by_property).to eql(property)
     end
 
   end

data/spec/hashme/property_spec.rb

@@ -60,13 +60,6 @@ describe Hashme::Property do
         expect(obj.class).to eql(Time)
         expect(obj).to eql(Time.utc(2013, 6, 2, 12, 0, 0))
       end
-
-      it "should assign casted by and property" do
-        prop = subject.new(:item, submodel)
-        obj = prop.build(owner, {:name => 'test'})
-        expect(obj.casted_by).to eql(owner)
-        expect(obj.casted_by_property).to eql(prop)
-      end
     end
 
     context "with an array" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hashme
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Sam Lown
@@ -82,7 +82,6 @@ files:
 - hashme.gemspec
 - lib/hashme.rb
 - lib/hashme/attributes.rb
-- lib/hashme/castable.rb
 - lib/hashme/casted_array.rb
 - lib/hashme/properties.rb
 - lib/hashme/property.rb

data/lib/hashme/castable.rb

@@ -1,10 +0,0 @@
-module Hashme
-  module Castable
-    extend ActiveSupport::Concern
-
-    included do
-      attr_accessor :casted_by
-      attr_accessor :casted_by_property
-    end
-  end
-end