hash-proxy 0.1.0 → 0.1.1

data/History.txt

@@ -1,3 +1,9 @@
+# == Version 0.1.1 / 2012-06-12
+# * Work around weird behavior when using [] method
+#   to access keys which are methods defined on Kernel,
+#   like Kernel#format. TODO: inherit from BasicObject to
+#   avoid this?
+#
 # == Version 0.1.0 / 2012-06-12
 # * include Enumerable in Proxy
 # * Add some hash-like semantics to Proxy

data/lib/hash_proxy/proxy.rb

@@ -56,7 +56,14 @@ module HashProxy
     # @param [Object] key The value to look up
     # @return [Object] The object associated with the key
     def [](key)
-      self.send(key)
+      # Return the value if it has already been converted
+      if @converted.has_key?(key)
+        @converted[key]
+      else
+        # Move the value from the original hash to the converted hash.
+        # Support both symbol or string keys
+        self.move_value(key)
+      end
     end
 
     # Sets a value after converting it to a Proxy if necessary
@@ -64,7 +71,7 @@ module HashProxy
     # @param [Object] key The key of the value to set
     # @param [Object] value The value to set
     def []=(key, value)
-      self.send("#{key}=", value)
+      @converted[key] = convert_value(value)
     end
 
     # Turns arbitrary method invocations into
@@ -74,19 +81,12 @@ module HashProxy
       if name_str.end_with?(EQUALS)
         # Handle edge case (self.send(:"=", 'foo') ? why would someone do this)
         if name_str != EQUALS
-          @converted[name_str[0..-2].to_sym] = convert_value(args.first)
+          self[name_str[0..-2].to_sym] = args.first
         else
           super
         end
       else
-        # Return the value if it has already been converted
-        if @converted.has_key?(name)
-          @converted[name]
-        else
-          # Move the value from the original hash to the converted hash.
-          # Support both symbol or string keys
-          self.move_value(name, name_str)
-        end
+        self[name]
       end
     end
 

data/spec/hash_proxy_spec.rb

@@ -2,6 +2,12 @@
 require File.expand_path('../spec_helper', __FILE__)
 
 describe HashProxy do
+  it "does not get confused by methods defined on Kernel" do
+    proxy = HashProxy::Proxy.new({})
+    lambda { proxy[:format] }.should_not raise_error
+    proxy[:format].should be_nil
+  end
+
   it "supports enumerable" do
     hash = {foo: 'bar', baz: 'bip', smee: 'cree'}
     proxy = HashProxy::Proxy.new(hash)

data/version.txt

@@ -1 +1 @@
-0.1.0
+0.1.1

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hash-proxy
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors: