has_unique_slug 0.1.6 → 0.1.7

data/README.md

@@ -1,4 +1,6 @@
 # Has Unique Slug
+[![Build Status](https://secure.travis-ci.org/HuffMoody/has_unique_slug.png)](http://travis-ci.org/HuffMoody/has_unique_slug)
+
 Generates a unique slug for use as a drop-in replacement for ids Ruby on Rails Active Record
 
 ## Install
@@ -57,9 +59,27 @@ All the standard url helper methods will still work since `to_param`  is overrid
 
 If you are adding this to an existing project that already contains records, perform the necessary setup then run something like `Post.all.each {|p| p.save }` in the rails console to populate the slug columns.
 
+## Active Admin
+
+Due to the way inherited resources work, this gem will not work with Active Admin out of the box.  You can easily get around this however by adding the following line to your resource admin file:
+
+    controller do
+      defaults :finder => :find_by_slug
+    end
+
 ## TODO:
 
 - Add support for scopes
 - Add support for database versioning
 - Consider optimizing the method to ensure a unique slug
-- Add rake task for rebuildings slugs
+- Add rake task for rebuildings slugs
+
+## License
+
+Copyright (c) 2012 Brendan Stennett
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/Rakefile

@@ -1 +1,6 @@
 require "bundler/gem_tasks"
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec

data/has_unique_slug.gemspec

@@ -18,10 +18,9 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  # specify any dependencies here; for example:
   s.add_development_dependency "rspec"
   s.add_development_dependency "activerecord"
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "rake"
-  # s.add_runtime_dependency "rest-client"
+
 end

data/lib/has_unique_slug/version.rb

@@ -1,3 +1,3 @@
 module HasUniqueSlug
-  VERSION = "0.1.6"
+  VERSION = "0.1.7"
 end

data/lib/has_unique_slug.rb

@@ -8,7 +8,12 @@ module HasUniqueSlug
   # Builds a slug from the subject_column unless a block is specified.
   # If a block is specified, the result of the block is returned.
   def build_slug(record, subject_column)
-    ( subject_column.is_a?(Proc) ? subject_column.call(record) : record[subject_column] ).parameterize
+    if subject_column.is_a?(Proc)
+      slug = subject_column.call(record)
+    else
+      slug = record[subject_column]
+    end
+    slug.try(:parameterize) || '-'
   end
   
   module ClassMethods
@@ -58,13 +63,6 @@ module HasUniqueSlug
         end
       EOV
       
-      # # Add find method to override ActiveRecord::Base.find.  
-      # # Note: find_by_id will still work to search for record by their database id.
-      # instance_eval do
-      #   def find(*args)
-      #     args.length == 1 ? where(slug_column => args.first).first : where(slug_column => args)
-      #   end
-      # end
     end
     
   end
@@ -81,4 +79,4 @@ end
 
 class ActiveRecord::Base
   include HasUniqueSlug
-end
+end

data/spec/has_unique_slug_spec.rb

@@ -59,6 +59,37 @@ describe HasUniqueSlug do
       r.slug.should == "sample-record-#{i}"
     end
   end
+
+  it "should allow a slug to be changed and updated" do
+    r = Standard.create! :title => "Sample Record"
+    r.slug = "another-slug"
+    r.save
+    r.slug.should == "another-slug"
+  end
+
+  it "should be able to manually set a slug and ensure it is unique for new records" do
+    r1 = Standard.create! :title => "Sample Record", slug: "another-slug"
+    r1.reload
+    r1.slug.should == "another-slug"
+
+    r2 = Standard.create! :title => "Sample Record", slug: "another-slug"
+    r2.reload
+    r2.slug.should == "another-slug-2"
+  end
+
+  it "should be able to manually set a slug and ensure it is unique for existing records" do
+    r1 = Standard.create! :title => "Sample Record"
+    r1.slug = "another-slug"
+    r1.save
+    r1.reload
+    r1.slug.should == "another-slug"
+
+    r2 = Standard.create! :title => "Sample Record"
+    r2.slug = "another-slug"
+    r2.save
+    r2.reload
+    r2.slug.should == "another-slug-2"
+  end
   
   it "should not increment the slug if the duplicate is itself" do
     r = Standard.create! :title => "Sample Record"
@@ -108,5 +139,10 @@ describe HasUniqueSlug do
     r = StandardWithScope.create! :title => "Sample Record", :some_scope => 1
     r.slug.should == "sample-record-2"
   end
+
+  it "will not raise an exception if subject column is blank" do
+    r = Standard.create! :title => nil
+    expect { r.valid? }.to_not raise_error
+  end
   
-end
+end

data/spec/spec_helper.rb

@@ -5,7 +5,7 @@ require 'active_record'
 gem 'sqlite3'
 require 'sqlite3'
 
-require 'has_unique_slug' # and any other gems you need
+require 'has_unique_slug'
 
 RSpec.configure do |config|
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_unique_slug
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-28 00:00:00.000000000Z
+date: 2013-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70256493008000 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256493008000
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70256493007320 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256493007320
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70256493006540 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256493006540
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70256493005660 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +69,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256493005660
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Generates a unique slug for use as a drop-in replacement for ids.
 email:
 - brendan@unknowncollective.com
@@ -86,7 +106,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4480308170059512738
+      hash: 2032112713944694544
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -95,10 +115,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4480308170059512738
+      hash: 2032112713944694544
 requirements: []
 rubyforge_project: has_unique_slug
-rubygems_version: 1.8.10
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Generates a unique slug for use as a drop-in replacement for ids.