has_settings 0.0.3 → 0.0.4

data/VERSION

@@ -1 +1 @@
-0.0.3
+0.0.4

data/has_settings.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{has_settings}
-  s.version = "0.0.3"
+  s.version = "0.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Morten Primdahl"]

data/lib/has_settings/active_record_extension.rb

@@ -9,7 +9,7 @@ module HasSettings
 
           def build(*setting_names)
             setting_names.each do |setting_name|
-              self << settings_class.new(:name => setting_name)
+              self << proxy_reflection.klass.new(:name => setting_name)
             end
           end
 

data/lib/has_settings/setting.rb

@@ -51,7 +51,7 @@ module HasSettings
       @owner_class_sym = owner_class.name.underscore.to_sym
       belongs_to              owner_class_sym
       validates_presence_of   owner_class_sym
-      validates_uniqueness_of :type, :scope => owner_class_key_sym
+      validates_uniqueness_of :name, :scope => owner_class_key_sym
 
       if owner_class.table_exists? && owner_class.column_names.include?('updated_at')
         before_create   :update_owner_timestamp

data/test/test_has_settings.rb

@@ -69,5 +69,20 @@ class TestHasSettings < ActiveSupport::TestCase
       assert !a.settings.archive?
       assert a.settings.ssl?
     end
+    
+    should "be able to build multiple settings in one go" do
+      a = Account.create(:name => 'name')
+      assert a.settings.empty?
+      a.settings.build('archive', 'ssl')
+      assert a.settings.size == 2
+    end
+    
+    should "validate uniqueness of settings" do
+      a = Account.create(:name => 'name')
+      AccountSetting.create!(:account => a, :name => 'fish')
+      assert_raise ActiveRecord::RecordInvalid do
+        AccountSetting.create!(:account => a, :name => 'fish')
+      end
+    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: has_settings
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: false
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Morten Primdahl