has_secure_attribute 0.4.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e61ec31351c820eaab8299f6114e7b714e5f7620
-  data.tar.gz: 65bf16cba90c646c29aeb7d5d75dcf80e1d4715c
+  metadata.gz: 25c15b3f643163f6c2fb3c464a2ec2b6742d08f0
+  data.tar.gz: 167c75e4c3749f77884640e9b4540093c0b115bd
 SHA512:
-  metadata.gz: 723227ddf282925dfa763c6f0efcd40d5422fef98b1532c0995815249eb4012a74879967cad67738079aa631ab751eaba1f8c7d7c36618ea23b6320ed211ab24
-  data.tar.gz: 89a734102051452f9226178e6779c7107cc41c5121ee2ba976b766ca0a2b6ee33f34a2a0e911d2152bfacf7e20c6d85dfbddbd1dc6aa73730d103e81d400c5e8
+  metadata.gz: fe0c64a7b25fdb7b7d64a680214c576bfd50054d2878c62cef4af43520c4f74d4fdc0c87387ea4e288b5265193ad1c5762a98156934411f879ac0d5b0dbe0f0b
+  data.tar.gz: 6c8d535bdf3f7c12531cd94fee7a0e96c14d3cb27eb48da655dfc5f10c8879c89a827221a17211bb011d36158cf5c546ea758e2858452b85d8db4c5fbfc8e0b5

data/README.md

@@ -34,9 +34,9 @@ or
 
 In the above example:
 
-* Your should have a `users` table that has one column: `security_answer_digest`.
+* You should have a `users` table that has one column: `security_answer_digest`.
 * It creates a reader: `security_answer`.
-* It creates a writer: `security_answer=(value)` which basically saves the security answer given into the database on column `security_answer_digest` but is saves it encrypted.
+* It creates a writer: `security_answer=(value)` which basically saves the security answer given into the database on column `security_answer_digest` but it saves it encrypted.
 * It adds some validations (if you want to avoid having these validations: `has_secure_security_answer validations: false`).
   * It creates a confirmation validation on `security_answer` but only if `security_answer` is given (for confirmation validations see [this](http://http://guides.rubyonrails.org/active_record_validations.html#confirmation)).
   * It creates a presence validation on `security_answer` but only on create.

data/lib/has_secure_attribute/version.rb

@@ -1,3 +1,3 @@
 module HasSecureAttribute
-  VERSION = "0.4.0"
+  VERSION = "1.0.0"
 end

data/spec/config/database.yml

@@ -6,7 +6,6 @@ development:
   pool: 5
   username: root
   password:
-  socket: /var/run/mysqld/mysqld.sock
 
 # Warning: The database defined as "test" will be erased and
 # re-generated from your development database when you run "rake".
@@ -19,7 +18,6 @@ test:
   pool: 5
   username: root
   password:
-  socket: /var/run/mysqld/mysqld.sock
 
 production:
   adapter: mysql2
@@ -29,5 +27,4 @@ production:
   pool: 5
   username: root
   password:
-  socket: /var/run/mysqld/mysqld.sock
 

data/spec/db/migrate/create_test_model_with_attributes.rb

@@ -1,4 +1,4 @@
-class CreateTestModelWithAttributes < ActiveRecord::Migration
+class CreateTestModelWithAttributes < ActiveRecord::Migration[5.1]
   def up
     HasSecureAttribute::DbHelper.new.connect_to_database
     return if ActiveRecord::Base.connection.table_exists? :test_model_with_attributes
@@ -21,4 +21,4 @@ class CreateTestModelWithAttributes < ActiveRecord::Migration
   end
 
 
-end
+end

data/spec/db/migrate/db_helper.rb

@@ -1,3 +1,5 @@
+require 'yaml'
+
 module HasSecureAttribute
   class DbHelper
     def connect_to_database
@@ -12,4 +14,4 @@ module HasSecureAttribute
       ActiveRecord::Base.establish_connection database_settings['test'].delete_if{|k,v| 'database' == k}
     end
   end
-end
+end

data/spec/factories/test_model_with_attributes.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :test_model_with_attribute do
     username 'username'
     password 'password'
@@ -41,4 +41,4 @@ FactoryGirl.define do
     security_question 'question'
     security_answer 'answer'
   end
-end
+end

data/spec/models/has_secure_attribute_spec.rb

@@ -1,64 +1,64 @@
 require 'spec_helper'
 
 describe TestModelWithAttribute do
-  it { should respond_to(:security_answer)               }
-  it { should respond_to(:security_answer=)              }
-  it { should respond_to(:security_answer_confirmation)  }
-  it { should respond_to(:security_answer_confirmation=) }
-  it { should respond_to(:authenticate_security_answer)  }
+  it { expect(subject).to respond_to(:security_answer)               }
+  it { expect(subject).to respond_to(:security_answer=)              }
+  it { expect(subject).to respond_to(:security_answer_confirmation)  }
+  it { expect(subject).to respond_to(:security_answer_confirmation=) }
+  it { expect(subject).to respond_to(:authenticate_security_answer)  }
 
   it 'should confirm security answer' do
     subject.security_answer = 'hello there'
     subject.security_answer_confirmation = 'there hello'
     subject.valid?
-    subject.errors[:security_answer_confirmation].should include("doesn't match Security answer")
+    expect(subject.errors[:security_answer_confirmation]).to include("doesn't match Security answer")
   end
 
   it 'should not confirm security answer if not given' do
     subject.security_answer = nil
     subject.security_answer_confirmation = 'there hello'
     subject.valid?
-    subject.errors[:security_answer_confirmation].should be_blank
+    expect(subject.errors[:security_answer_confirmation]).to be_blank
   end
 
   it 'should require security answer on create' do
-    subject.should be_new_record
+    expect(subject).to be_new_record
     subject.security_answer = nil
     subject.valid?
-    subject.errors[:security_answer].should include("can't be blank")
+    expect(subject.errors[:security_answer]).to include("can't be blank")
   end
 
   it 'should require security answer confirmation if security answer given ' do
     subject.security_answer = 'hello there'
     subject.valid?
-    subject.errors[:security_answer_confirmation].should include "can't be blank"
+    expect(subject.errors[:security_answer_confirmation]).to include("can't be blank")
   end
 
   it 'should not require security answer confirmation if security answer is not given' do
     subject.security_answer = ''
     subject.valid?
-    subject.errors[:security_answer_confirmation].should be_blank
+    expect(subject.errors[:security_answer_confirmation]).to be_blank
   end
 
   it 'should require security answer digest on create' do
-    subject = FactoryGirl.build :test_model_with_attribute
-    subject.should be_new_record
+    subject = FactoryBot.build :test_model_with_attribute
+    expect(subject).to be_new_record
 
     # change the security_answer_digest to verify the test
     subject.security_answer_digest = ''
-    lambda do
+    expect do
       begin
         subject.save!
       rescue Exception => ex
-        ex.message.should include("security_answer_digest missing on new record")
+        expect(ex.message).to include("security_answer_digest missing on new record")
         raise
       end
-    end.should raise_error RuntimeError
+    end.to raise_error RuntimeError
   end
 
   it 'should not require security answer digest on update' do
-    subject = FactoryGirl.build :test_model_with_attribute
-    subject.should be_new_record
+    subject = FactoryBot.build :test_model_with_attribute
+    expect(subject).to be_new_record
 
     subject.save!
 
@@ -68,72 +68,72 @@ describe TestModelWithAttribute do
     subject.save!
 
     subject.reload
-    subject.security_answer_digest.should be_blank
+    expect(subject.security_answer_digest).to be_blank
   end
 
   it 'should allow to call security answer digest directly if protect setter for digest is not given as option' do
-    lambda do
+    expect do
       subject.security_answer_digest = 'hello'
-    end.should_not raise_error
+    end.not_to raise_error
   end
 
   describe "#security_answer=" do
     it 'should set the security answer and save it encrypted' do
-      tmwa = FactoryGirl.create :test_model_with_attribute, security_answer: 'old answer', security_answer_confirmation: 'old answer'
-      tmwa.security_answer_digest.should_not be_blank
+      tmwa = FactoryBot.create :test_model_with_attribute, security_answer: 'old answer', security_answer_confirmation: 'old answer'
+      expect(tmwa.security_answer_digest).not_to be_blank
       old_security_answer_digest = tmwa.security_answer_digest
 
       tmwa.security_answer = 'new answer'
       tmwa.security_answer_confirmation = 'new answer'
-      tmwa.instance_variable_get(:@security_answer).should == 'new answer'
+      expect(tmwa.instance_variable_get(:@security_answer)).to eq('new answer')
       tmwa.save!
-      tmwa.security_answer_digest.should_not be_blank
-      tmwa.security_answer_digest.should_not == old_security_answer_digest
+      expect(tmwa.security_answer_digest).not_to be_blank
+      expect(tmwa.security_answer_digest).not_to eq(old_security_answer_digest)
     end
   end
 
   describe '#authenticate_security_answer' do
     it 'should return subject if security answer given matches the one stored' do
-      tmwa = FactoryGirl.create :test_model_with_attribute, security_answer: 'some answer', security_answer_confirmation: 'some answer'
-      tmwa.authenticate_security_answer('some answer').should eq tmwa
+      tmwa = FactoryBot.create :test_model_with_attribute, security_answer: 'some answer', security_answer_confirmation: 'some answer'
+      expect(tmwa.authenticate_security_answer('some answer')).to eq(tmwa)
     end
 
     it 'should return false if security answer given does not match the one stored' do
-      tmwa = FactoryGirl.create :test_model_with_attribute, security_answer: 'some answer', security_answer_confirmation: 'some answer'
-      tmwa.authenticate_security_answer('some other answer').should be_false
+      tmwa = FactoryBot.create :test_model_with_attribute, security_answer: 'some answer', security_answer_confirmation: 'some answer'
+      expect(tmwa.authenticate_security_answer('some other answer')).to eq(false)
     end
   end
 end
 
 describe TestModelWithAttributeNoValidation do
-  it { should respond_to(:security_answer)               }
-  it { should respond_to(:security_answer=)              }
-  it { should_not respond_to(:security_answer_confirmation)  }
-  it { should_not respond_to(:security_answer_confirmation=) }
-  it { should respond_to(:authenticate_security_answer)  }
+  it { expect(subject).to respond_to(:security_answer)               }
+  it { expect(subject).to respond_to(:security_answer=)              }
+  it { expect(subject).to_not respond_to(:security_answer_confirmation)  }
+  it { expect(subject).to_not respond_to(:security_answer_confirmation=) }
+  it { expect(subject).to respond_to(:authenticate_security_answer)  }
 
   it 'should not require security answer on create' do
-    subject.should be_new_record
+    expect(subject).to be_new_record
     subject.security_answer = nil
     subject.valid?
-    subject.errors[:security_answer].should be_blank
+    expect(subject.errors[:security_answer]).to be_blank
   end
 
   it 'should not require security answer confirmation if security answer given ' do
     subject.security_answer = 'hello there'
     subject.valid?
-    subject.errors[:security_answer_confirmation].should be_blank
+    expect(subject.errors[:security_answer_confirmation]).to be_blank
   end
 
   it 'should not require security answer confirmation if security answer is not given' do
     subject.security_answer = ''
     subject.valid?
-    subject.errors[:security_answer_confirmation].should be_blank
+    expect(subject.errors[:security_answer_confirmation]).to be_blank
   end
 
   it 'should not require security answer digest on create' do
-    subject = FactoryGirl.build :test_model_with_attribute_no_validation
-    subject.should be_new_record
+    subject = FactoryBot.build :test_model_with_attribute_no_validation
+    expect(subject).to be_new_record
 
     # change the security_answer_digest to verify the test
     subject.security_answer_digest = ''
@@ -141,8 +141,8 @@ describe TestModelWithAttributeNoValidation do
   end
 
   it 'should not require security answer digest on update' do
-    subject = FactoryGirl.build :test_model_with_attribute_no_validation
-    subject.should be_new_record
+    subject = FactoryBot.build :test_model_with_attribute_no_validation
+    expect(subject).to be_new_record
 
     subject.save!
 
@@ -152,49 +152,49 @@ describe TestModelWithAttributeNoValidation do
     subject.save!
 
     subject.reload
-    subject.security_answer_digest.should be_blank
+    expect(subject.security_answer_digest).to be_blank
   end
 end
 
 describe TestModelWithAttributeProtectSetterForDigest do
   it 'should not allow to call security answer digest directly' do
-    lambda do
+    expect do
       subject.security_answer_digest = 'hello'
-    end.should raise_error NoMethodError
+    end.to raise_error NoMethodError
   end
 end
 
 describe TestModelWithAttributeWithCaseSensitive do
   it 'should authenticate even if answer is of different case' do
-    t = FactoryGirl.create :test_model_with_attribute_with_case_sensitive, security_answer: 'Answer', security_answer_confirmation: 'Answer'
+    t = FactoryBot.create :test_model_with_attribute_with_case_sensitive, security_answer: 'Answer', security_answer_confirmation: 'Answer'
 
-    t.authenticate_security_answer('answer').should eq t
+    expect(t.authenticate_security_answer('answer')).to eq t
   end
 end
 
 describe TestModelWithAttributeDisableConfirmation do
-  it { should_not respond_to(:security_answer_confirmation)  }
-  it { should_not respond_to(:security_answer_confirmation=) }
+  it { expect(subject).to_not respond_to(:security_answer_confirmation)  }
+  it { expect(subject).to_not respond_to(:security_answer_confirmation=) }
   it 'should allow to create and save without any confirmation on security answer' do
-    t = FactoryGirl.create :test_model_with_attribute_disable_confirmation, security_answer: 'Answer'
+    t = FactoryBot.create :test_model_with_attribute_disable_confirmation, security_answer: 'Answer'
     t.save!
-    t.authenticate_security_answer('another answer').should be_false
-    t.authenticate_security_answer('Answer').should eq t
+    expect(t.authenticate_security_answer('another answer')).to eq(false)
+    expect(t.authenticate_security_answer('Answer')).to eq(t)
   end
 end
 
 describe TestModelWithAlternativeSyntax do
-  it { should respond_to(:username)               }
-  it { should respond_to(:username=)              }
-  it { should respond_to(:username_confirmation)  }
-  it { should respond_to(:username_confirmation=) }
-  it { should respond_to(:authenticate_username)  }
+  it { expect(subject).to respond_to(:username)               }
+  it { expect(subject).to respond_to(:username=)              }
+  it { expect(subject).to respond_to(:username_confirmation)  }
+  it { expect(subject).to respond_to(:username_confirmation=) }
+  it { expect(subject).to respond_to(:authenticate_username)  }
 
   context "with no validation" do
-    it { should respond_to(:security_answer)               }
-    it { should respond_to(:security_answer=)              }
-    it { should_not respond_to(:security_answer_confirmation)  }
-    it { should_not respond_to(:security_answer_confirmation=) }
-    it { should respond_to(:authenticate_security_answer)  }
+    it { expect(subject).to respond_to(:security_answer)               }
+    it { expect(subject).to respond_to(:security_answer=)              }
+    it { expect(subject).to_not respond_to(:security_answer_confirmation)  }
+    it { expect(subject).to_not respond_to(:security_answer_confirmation=) }
+    it { expect(subject).to respond_to(:authenticate_security_answer)  }
   end
 end

data/spec/spec_helper.rb

@@ -11,8 +11,8 @@ require File.expand_path("../models/test_model_with_attribute_with_case_sensitiv
 require File.expand_path("../models/test_model_with_attribute_disable_confirmation", __FILE__)
 require File.expand_path("../models/test_model_with_alternative_syntax", __FILE__)
 
-require 'factory_girl'
-FactoryGirl.find_definitions
+require 'factory_bot'
+FactoryBot.find_definitions
 require 'database_cleaner'
 
 RSpec.configure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: has_secure_attribute
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Panayotis Matsinopoulos
@@ -14,100 +14,112 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
   name: bcrypt-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.0
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.8'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.8.0
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.6.0
 description: Does what `has_secure_password` does, but for any attribute that you
   want. It does not have to be a `password` attribute. It may be for example `security_answer`
 email:
@@ -116,23 +128,23 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- MIT
+- README.md
 - lib/active_model/secure_attribute/has_secure_attribute.rb
 - lib/has_secure_attribute.rb
 - lib/has_secure_attribute/version.rb
-- spec/spec_helper.rb
-- spec/factories/test_model_with_attributes.rb
 - spec/config/database.yml
+- spec/db/migrate/create_test_model_with_attributes.rb
+- spec/db/migrate/db_helper.rb
+- spec/factories/test_model_with_attributes.rb
 - spec/models/has_secure_attribute_spec.rb
-- spec/models/test_model_with_attribute_no_validation.rb
-- spec/models/test_model_with_attribute_protect_setter_for_digest.rb
 - spec/models/test_model_with_alternative_syntax.rb
-- spec/models/test_model_with_attribute_disable_confirmation.rb
 - spec/models/test_model_with_attribute.rb
+- spec/models/test_model_with_attribute_disable_confirmation.rb
+- spec/models/test_model_with_attribute_no_validation.rb
+- spec/models/test_model_with_attribute_protect_setter_for_digest.rb
 - spec/models/test_model_with_attribute_with_case_sensitive.rb
-- spec/db/migrate/db_helper.rb
-- spec/db/migrate/create_test_model_with_attributes.rb
-- README.md
-- MIT
+- spec/spec_helper.rb
 homepage: https://github.com/pmatsinopoulos/has_secure_attribute
 licenses:
 - MIT
@@ -143,17 +155,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Allows an ActiveRecord::Base class to declare an attribute that will be saved