has_phone_numbers 0.0.5 → 0.1.0

data/CHANGELOG.rdoc

@@ -1,5 +1,9 @@
 == master
 
+== 0.1.0 / 2008-12-14
+
+* Remove the PluginAWeek namespace
+
 == 0.0.5 / 2008-10-26
 
 * Change how the base module is included to prevent namespacing conflicts

data/Rakefile

@@ -5,7 +5,7 @@ require 'rake/contrib/sshpublisher'
 
 spec = Gem::Specification.new do |s|
   s.name              = 'has_phone_numbers'
-  s.version           = '0.0.5'
+  s.version           = '0.1.0'
   s.platform          = Gem::Platform::RUBY
   s.summary           = 'Demonstrates a reference implementation for handling phone numbers.'
   

data/lib/has_phone_numbers.rb

@@ -1,17 +1,15 @@
-module PluginAWeek #:nodoc:
-  # Adds a generic implementation for dealing with phone numbers
-  module HasPhoneNumbers
-    module MacroMethods
-      # Creates the following association:
-      # * +phone_number+ - All phone numbers associated with the current record.
-      def has_phone_numbers
-        has_many  :phone_numbers,
-                    :as => :phoneable
-      end
+# Adds a generic implementation for dealing with phone numbers
+module HasPhoneNumbers
+  module MacroMethods
+    # Creates the following association:
+    # * +phone_number+ - All phone numbers associated with the current record.
+    def has_phone_numbers
+      has_many  :phone_numbers,
+                  :as => :phoneable
     end
   end
 end
 
 ActiveRecord::Base.class_eval do
-  extend PluginAWeek::HasPhoneNumbers::MacroMethods
+  extend HasPhoneNumbers::MacroMethods
 end

data/test/unit/phone_number_test.rb

@@ -33,33 +33,33 @@ class PhoneNumberTest < Test::Unit::TestCase
   end
   
   def test_should_require_a_phoneable_id
-    phone_number = new_phone_number(:phoneable_id => nil)
+    phone_number = new_phone_number(:phoneable => nil, :phoneable_id => nil)
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:phoneable_id)).size
+    assert phone_number.errors.invalid?(:phoneable_id)
   end
   
   def test_should_require_a_phoneable_type
-    phone_number = new_phone_number(:phoneable_type => nil)
+    phone_number = new_phone_number(:phoneable => nil, :phoneable_type => nil)
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:phoneable_type)).size
+    assert phone_number.errors.invalid?(:phoneable_type)
   end
   
   def test_should_require_a_country_code
     phone_number = new_phone_number(:country_code => nil)
     assert !phone_number.valid?
-    assert_equal 3, Array(phone_number.errors.on(:country_code)).size
+    assert phone_number.errors.invalid?(:country_code)
   end
   
   def test_should_require_country_code_be_a_number
     phone_number = new_phone_number(:country_code => 'a')
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:country_code)).size
+    assert phone_number.errors.invalid?(:country_code)
   end
   
   def test_should_require_country_codes_be_between_1_and_3_numbers
     phone_number = new_phone_number(:country_code => '')
     assert !phone_number.valid?
-    assert_equal 3, Array(phone_number.errors.on(:country_code)).size
+    assert phone_number.errors.invalid?(:country_code)
     
     phone_number.country_code += '1'
     assert phone_number.valid?
@@ -69,32 +69,32 @@ class PhoneNumberTest < Test::Unit::TestCase
     
     phone_number.country_code += '1'
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:country_code)).size
+    assert phone_number.errors.invalid?(:country_code)
   end
   
   def test_should_require_a_number
     phone_number = new_phone_number(:number => nil)
     assert !phone_number.valid?
-    assert_equal 3, Array(phone_number.errors.on(:number)).size
+    assert phone_number.errors.invalid?(:number)
   end
   
   def test_should_require_number_be_a_number
     phone_number = new_phone_number(:number => 'a' * 10)
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:number)).size
+    assert phone_number.errors.invalid?(:number)
   end
   
   def test_should_require_number_be_exactly_10_numbers
     phone_number = new_phone_number(:number => '1' * 9)
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:number)).size
+    assert phone_number.errors.invalid?(:number)
     
     phone_number.number += '1'
     assert phone_number.valid?
     
     phone_number.number += '1'
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:number)).size
+    assert phone_number.errors.invalid?(:number)
   end
   
   def test_should_not_require_an_extension
@@ -111,7 +111,7 @@ class PhoneNumberTest < Test::Unit::TestCase
     
     phone_number.extension += '1'
     assert !phone_number.valid?
-    assert_equal 1, Array(phone_number.errors.on(:extension)).size
+    assert phone_number.errors.invalid?(:extension)
   end
   
   def test_should_protect_attributes_from_mass_assignment

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: has_phone_numbers
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-10-26 00:00:00 -04:00
+date: 2008-12-14 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -27,22 +27,22 @@ files:
 - db/migrate
 - db/migrate/001_create_phone_numbers.rb
 - lib/has_phone_numbers.rb
-- test/app_root
-- test/app_root/app
-- test/app_root/app/models
-- test/app_root/app/models/person.rb
-- test/app_root/config
-- test/app_root/config/environment.rb
-- test/app_root/db
-- test/app_root/db/migrate
-- test/app_root/db/migrate/001_create_people.rb
-- test/app_root/db/migrate/002_migrate_has_phone_numbers_to_version_1.rb
+- test/factory.rb
+- test/test_helper.rb
 - test/functional
 - test/functional/has_phone_numbers_test.rb
-- test/test_helper.rb
-- test/factory.rb
 - test/unit
 - test/unit/phone_number_test.rb
+- test/app_root
+- test/app_root/db
+- test/app_root/db/migrate
+- test/app_root/db/migrate/002_migrate_has_phone_numbers_to_version_1.rb
+- test/app_root/db/migrate/001_create_people.rb
+- test/app_root/config
+- test/app_root/config/environment.rb
+- test/app_root/app
+- test/app_root/app/models
+- test/app_root/app/models/person.rb
 - CHANGELOG.rdoc
 - init.rb
 - LICENSE