has_handle_fallback 0.0.10 → 0.0.11

data/Rakefile

@@ -10,8 +10,9 @@ begin
     gem.email = "seamus@abshere.net"
     gem.homepage = "http://github.com/seamusabshere/has_handle_fallback"
     gem.authors = ["Seamus Abshere"]
+    gem.add_dependency 'activesupport', '>=2.3.4'
     gem.add_dependency 'activerecord', '>=2.3.4'
-    gem.add_dependency 'validates_decency_of', '>=1.5.0'
+    gem.add_dependency 'validates_decency_of', '>=1.5.1'
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
   end
   Jeweler::GemcutterTasks.new

data/VERSION

@@ -1 +1 @@
-0.0.10
+0.0.11

data/lib/has_handle_fallback.rb

@@ -1,3 +1,6 @@
+require 'active_support'
+begin; require 'active_support/core_ext/string/inflections'; rescue MissingSourceFile; end
+require 'active_record'
 require 'validates_decency_of'
 
 module HasHandleFallback
@@ -8,9 +11,11 @@ module HasHandleFallback
   RECORD_ID_REGEXP = /\A\d+\z/
   
   def self.str2handle(str)
-    str = str.to_s.gsub ANTI_REGEXP, ''
+    str = str.to_s.dup
+    str.gsub! ANTI_REGEXP, ''
+    str = str.underscore
     str << ('_' * (LENGTH_RANGE.min - str.length)) if str.length < LENGTH_RANGE.min
-    str
+    str[0, LENGTH_RANGE.max]
   end
   
   module ActiveRecordBaseMethods

data/test/test_has_handle_fallback.rb

@@ -38,7 +38,7 @@ class TestHasHandleFallback < Test::Unit::TestCase
   
   def test_can_use_alternate_columns
     pierre = Cat.new :name => 'Pierre Bourdieu'
-    assert_equal 'PierreBourdieu', pierre.handle
+    assert_equal 'pierre_bourdieu', pierre.handle
   end
   
   def test_can_in_fact_require_handle
@@ -54,7 +54,11 @@ class TestHasHandleFallback < Test::Unit::TestCase
   def test_validates_uniqueness_ignoring_case
     Person.create!(:email => 'pierre.bourdieu@example.com', :handle => 'Pierre-Bourdieu_99')
     b = Person.create(:email => 'pierre.bourdieu@example.com', :handle => 'PIERRE-BOURDIEU_99')
-    assert_equal "isn't unique", b.errors.on(:handle)
+    if ActiveRecord::VERSION::MAJOR == 2
+      assert_equal "isn't unique", b.errors.on(:handle)
+    else
+      assert_equal "isn't unique", b.errors[:handle].first
+    end
   end
   
   def test_can_have_nil_handle

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 10
-  version: 0.0.10
+  - 11
+  version: 0.0.11
 platform: ruby
 authors: 
 - Seamus Abshere
@@ -14,11 +14,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-02 00:00:00 -04:00
+date: 2010-04-07 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: activerecord
+  name: activesupport
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
@@ -32,19 +32,33 @@ dependencies:
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
-  name: validates_decency_of
+  name: activerecord
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 3
+        - 4
+        version: 2.3.4
+  type: :runtime
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: validates_decency_of
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
         segments: 
         - 1
         - 5
-        - 0
-        version: 1.5.0
+        - 1
+        version: 1.5.1
   type: :runtime
-  version_requirements: *id002
+  version_requirements: *id003
 description: Make it easy to use handles (callsigns/monikers/usernames) in URLs, even if they might be blank. Provides sensible validations and a find_by_id_or_handle method.
 email: seamus@abshere.net
 executables: []