hardmock 1.3.3 → 1.3.4

data/CHANGES

@@ -1,3 +1,7 @@
+Hardmock 1.3.4
+
+* Prevents accidental stubbing and mocking on NilClasses
+
 Hardmock 1.3.3
  
 * stubs! and expects! no longer require that their target methods exist in reality (this used to prevent you from stubbing methods that "exist" by virtue of "method_missing"

data/Rakefile

@@ -1,7 +1,7 @@
 require 'rake'
 require 'rubygems'
 
-HARDMOCK_VERSION = "1.3.3"
+HARDMOCK_VERSION = "1.3.4"
 
 Dir["rake_tasks/*.rake"].each { |f| load f }
 

data/lib/hardmock/errors.rb

@@ -2,16 +2,19 @@ module Hardmock
   # Raised when:
   # * Unexpected method is called on a mock object
   # * Bad arguments passed to an expected call
-  class ExpectationError < StandardError; end
+  class ExpectationError < StandardError #:nodoc:#
+  end 
 
   # Raised for methods that should no longer be called.  Hopefully, the exception message contains helpful alternatives.
-  class DeprecationError < StandardError; end
+  class DeprecationError < StandardError #:nodoc:#
+  end 
 
   # Raised when stubbing fails
-  class StubbingError < StandardError; end
+  class StubbingError < StandardError #:nodoc:#
+  end
 
   # Raised when it is discovered that an expected method call was never made.
-  class VerifyError < StandardError
+  class VerifyError < StandardError #:nodoc:#
     def initialize(msg,unmet_expectations)
       super("#{msg}:" + unmet_expectations.map { |ex| "\n * #{ex.to_s}" }.join)
     end

data/lib/hardmock/stubbing.rb

@@ -52,7 +52,7 @@ module Hardmock
     # Exists only for documentation 
   end
 
-  class ReplacedMethod
+  class ReplacedMethod #:nodoc:#
     attr_reader :target, :method_name
 
     def initialize(target, method_name)
@@ -151,6 +151,24 @@ module Hardmock
 
   end
 
+  class ::NilClass
+    # Use this only if you really mean it
+    alias_method :intentionally_stubs!, :stubs!
+    
+    # Use this only if you really mean it
+    alias_method :intentionally_expects!, :expects!
+
+    # Overridden to protect against accidental nil reference self delusion 
+    def stubs!(mname)
+      raise StubbingError, "Cannot stub #{mname} method on nil.  (If you really mean to, try 'intentionally_stubs!')"
+    end
+
+    # Overridden to protect against accidental nil reference self delusion 
+    def expects!(mname, *args)
+      raise StubbingError, "Cannot mock #{mname} method on nil.  (If you really mean to, try 'intentionally_expects!')"
+    end
+  end
+
   class << self
     def track_replaced_method(replaced_method)
       all_replaced_methods << replaced_method

data/test/functional/stubbing_test.rb

@@ -320,6 +320,34 @@ class StubbingTest < Test::Unit::TestCase
     end
   end
 
+  it "does not allow stubbing on nil objects" do
+    [ nil, @this_is_nil ].each do |nil_obj|
+      assert_error Hardmock::StubbingError, /cannot/i, /nil/i, /intentionally/ do
+        nil_obj.stubs!(:wont_work)
+      end
+    end
+  end
+
+  it "does not allow concrete method mocking on nil objects" do
+    [ nil, @this_is_nil ].each do |nil_obj|
+      assert_error Hardmock::StubbingError, /cannot/i, /nil/i, /intentionally/ do
+        nil_obj.expects!(:wont_work)
+      end
+    end
+  end
+
+  it "provides an alternate method for stubbing on nil objects" do
+    @this_is_nil.intentionally_stubs!(:bogus).returns('output')
+    assert_equal 'output', @this_is_nil.bogus
+  end
+
+  it "provides an alternate method for mocking concreate methods on nil objects" do
+    @this_is_nil.intentionally_expects!(:bogus).returns('output')
+    assert_error Hardmock::VerifyError, /unmet expectations/i, /NilClass.bogus/ do
+      verify_mocks
+    end
+  end
+
   #
   # HELPERS
   #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: hardmock
 version: !ruby/object:Gem::Version 
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors: 
 - David Crosby
@@ -9,7 +9,7 @@ autorequire: hardmock
 bindir: bin
 cert_chain: []
 
-date: 2007-12-05 00:00:00 -05:00
+date: 2007-12-06 00:00:00 -05:00
 default_executable: 
 dependencies: []