harbinger 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41674176d795f9d3ac2fbcb2d24bfacecd07566a
-  data.tar.gz: eac7b7fe3cf0729dcc8e264a0d73210d19ebffb2
+  metadata.gz: b0bea4c48dcc7229a5fad10890156d7bd4f2eacd
+  data.tar.gz: ca2757f4f3c39c94d1dc2729627f51b9d169026a
 SHA512:
-  metadata.gz: 8a72f34ec36870117d26b5194a8c269b59e63d038dba7c73e140f17efd3e5c14aea004e6966b35c83c3707b3f0ea9e8c667ee9b8dc1f65a663a9e1fe9d624afa
-  data.tar.gz: 46912c4dc3094163fcbb201ad8b4fa7808cc9405ef23bebd046ccb6b7993d9445d6752bc99d1d19834d6158947e2f2cd397e8cb3b0d67257ff6acfc694f58e57
+  metadata.gz: b2d294197b4351ebb4e5f8cedb0dccd755848b85070415134ad9c9ffce602145e67e92be2fd48069b909ecccdce7b64b43ea3e79b4e3ba29fadd1e40a9098570
+  data.tar.gz: 72e24439e10044ccc947a137b6fc682b598558fc8a81469cad0daa5a175fdd01b4a3b95c5da913d737c0d4fb14f2117ffb3995dca6c6dde82efeb4e5143a91d3

data/app/views/harbinger/messages/index.html.erb

@@ -17,8 +17,6 @@
   </fieldset>
 <% end %>
 
-<%= paginate messages %>
-
 <table>
   <caption>Messages</caption>
   <thead>

data/lib/harbinger.rb

@@ -107,4 +107,19 @@ module Harbinger
     configuration.database_storage
   end
 
+
+  # As per an isolated_namespace Rails engine.
+  # But the isolated namespace creates issues.
+  # @api private
+  def table_name_prefix
+    'harbinger_'
+  end
+
+  # Because I am not using isolate_namespace for Orcid::Engine
+  # I need this for the application router to find the appropriate routes.
+  # @api private
+  def use_relative_model_naming?
+    true
+  end
+
 end

data/lib/harbinger/reporters/request_reporter.rb

@@ -5,7 +5,7 @@ module Harbinger
       private :method_names
       def initialize(request, config = {})
         @request = request
-        @method_names = config.fetch(:method_names) { ['path', 'params', 'user_agent'] }
+        @method_names = config.fetch(:method_names) { ['path', 'user_agent'] }
       end
 
       def accept(message)

data/lib/harbinger/version.rb

@@ -1,3 +1,3 @@
 module Harbinger
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/lib/harbinger/reporters/request_reporter_spec.rb

@@ -15,7 +15,6 @@ module Harbinger::Reporters
 
       When { reporter.accept(message) }
       Then { expect(message).to have_received(:append).with('request', 'path', request.path) }
-      And { expect(message).to have_received(:append).with('request', 'params', request.params) }
       And { expect(message).to have_received(:append).with('request', 'user_agent', request.user_agent) }
 
     end

data/spec/lib/harbinger_spec.rb

@@ -18,7 +18,6 @@ describe Harbinger do
     Then do expect(message.attributes).to eq(
         'user.username' => [user.username],
         'request.path' => [request.path],
-        'request.params' => [request.params],
         'request.user_agent' => [request.user_agent]
       )
     end
@@ -31,7 +30,6 @@ describe Harbinger do
     Then do expect(message.attributes).to eq(
         'user.username' => [user.username],
         'request.path' => [request.path],
-        'request.params' => [request.params],
         'request.user_agent' => [request.user_agent]
       )
     end

data/spec/routing/harbinger/messages_routing_spec.rb

@@ -12,5 +12,13 @@ module Harbinger
       expect(message_path('1')).to eq('/harbinger/messages/1')
     end
 
+    it 'should route actions based on namespace' do
+      expect(
+        url_for(
+          { action: "index", controller: "harbinger/messages", page: nil, only_path: true }
+        )
+      ).to eq('/harbinger/messages')
+    end
+
   end
 end

data/spec/views/harbinger/messages/index.html.erb_spec.rb

@@ -16,7 +16,7 @@ describe 'harbinger/messages/index.html.erb', type: :view do
   end
   let(:harbinger) { double("Engine", message_path: true, messages_path: '/messages/') }
   it 'renders the object and fieldsets' do
-    expect(view).to receive(:paginate).with([message])
+    expect(view).to_not receive(:paginate).with([message])
     expect(harbinger).to receive(:message_path).with(message.to_param).and_return("/messages/#{message.to_param}")
     render template: "harbinger/messages/index.html.erb", locals: { messages: [message], harbinger: harbinger }
     expect(rendered).to have_tag('.search-form') do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: harbinger
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Jeremy Friesen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-19 00:00:00.000000000 Z
+date: 2014-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kaminari