happi 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9dbbe19b69447b59fcdffc793300f8058b61d87e
-  data.tar.gz: 1551a9532ba36b03ead3746239880e90eee83ccb
+SHA256:
+  metadata.gz: 8af047b2bd93ef7975d0d19cac03998a5ffaba9e07932e68d3935d34d3d665f2
+  data.tar.gz: e235a40250203d1bc42d441354d59a1c648b121c41a328c1091bbbf0b03bd864
 SHA512:
-  metadata.gz: 7812c0d9fc728a44e021a95914be86d03dce8e65136748258e3620c4e916d2916796a068e1f7eb947a49b897daac60cd2fc58cb9eb1ba68f866a31bad0c9e40e
-  data.tar.gz: b34a4009a5fed72e54209ae705ef770ada24d74cd07c83aff7074252b45953ab37a7501a472e6cd9501470d5bdd6def8f0965918471422318e4fae2272b5d701
+  metadata.gz: 801e1f3019493f895448e75a509198c3e1d5ef486fff29d6666104a46ff6f981c7c74c743fd78f051e36924d871338aafca83141829fd7f71d5e99a335a092b5
+  data.tar.gz: eeee30b92a62a9f18effa0050b024d05bc3142467d2b8fc41c5c77e8b3e4a537d28ee860a49f3e961ee8bf8086417f674ea1bea0adfc4dd6b8f42c72930be79d

data/.gitignore

@@ -1,5 +1,6 @@
 *.gem
 *.rbc
+.DS_Store
 .bundle
 .config
 .yardoc

data/.ruby-version

@@ -0,0 +1 @@
+3.4.8

data/CHANGELOG.md

@@ -0,0 +1,90 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+## [1.0.0] - 2026-08-12
+Supersedes the `1.0.0-rc` and `1.0.0-rc2` pre-releases; everything below is relative
+to 0.6.0.
+
+### Changed
+- **BREAKING**: OAuth2 tokens are sent only as an `Authorization` header. `FaradayMiddleware::OAuth2`
+  defaulted to its `'param'` token type, which appended the token as an `access_token` query string
+  parameter *and* set an `Authorization: Token token="…"` header; that applied whenever `token_type`
+  was unset or explicitly `'param'`. Servers reading the token from the query string will no longer
+  receive it. The scheme now defaults to `Bearer` and is overridden by `token_type`; no header is set
+  when `oauth_token` is blank.
+- **BREAKING**: `token_type` has changed meaning. It was a mode selector for
+  `FaradayMiddleware::OAuth2` accepting `'param'` or `'bearer'`; it is now interpolated verbatim as
+  the `Authorization` scheme. Two consequences for 0.6.0 consumers:
+  - `token_type: 'param'` produces the malformed header `Authorization: param <token>` and no query
+    parameter. There is no replacement for the query-string mode in 1.0.0 — remove the setting and
+    have the server read the token from the `Authorization` header. Tokens in query strings end up
+    in access logs, proxy caches and `Referer` headers, which is why the mode is gone.
+  - `token_type: 'bearer'` now emits `bearer <token>` where 0.6.0 normalised it to `Bearer <token>`.
+    Scheme names are case-insensitive per RFC 7235 §2.1, so conforming servers are unaffected.
+- **BREAKING**: Removed the `oauth2`, `multi_json`, `faraday-follow_redirects` and `faraday-http`
+  dependencies. Applications using these directly must add them to their own Gemfile.
+- **BREAKING**: Minimum Ruby is now 3.2.0.
+- Replaced `activemodel` with `activesupport` - only ActiveSupport features were used.
+- Widened `faraday` to `>= 1.10.0` and `mime-types` to `>= 2.4.0`. Faraday 1.10 is the earliest
+  release that registers the `:json` request/response middleware this gem relies on.
+- Packaged gem now contains only runtime files. Specs (and their 2MB fixture), research notes and
+  CI/editor config are no longer shipped, taking the gem from ~2.1MB to ~14KB. The deprecated
+  `spec.test_files` directive was removed along with them.
+
+### Removed
+- **BREAKING**: `Happi::Client#connection_options`. It built an options hash for
+  `FaradayMiddleware::OAuth2` and has had no callers since that middleware was dropped —
+  `#connection` never consulted it. Subclasses that overrode it were already having no effect.
+- All `FaradayMiddleware` usage. The gem was never compatible with Faraday 2.x and was not a
+  declared dependency of Happi.
+- Travis and Buildkite CI configuration, superseded by the GitHub Actions workflow (Buildkite
+  still provisioned Ruby 2.1.5).
+
+### Fixed
+- Requests no longer fail with `NoMethodError: undefined method 'new' for JSON:Module`. The
+  connection passed the `::JSON` module itself to `f.use` as response middleware; it now uses
+  Faraday's built-in `:json` response middleware.
+- `Happi::Client` requires `logger` itself rather than relying on Faraday to load it, which
+  raised `NameError: uninitialized constant Logger` under Faraday 1.x.
+- JSON responses are parsed regardless of `use_json`, restoring 0.6.0 behaviour where
+  `ParseJson` was registered unconditionally. `use_json` selects the request encoding only -
+  JSON body versus multipart/url-encoded. In `1.0.0-rc2` response parsing was moved inside the
+  `use_json` branch, so clients on the default `use_json: false` received an unparsed `String`
+  body and raised `NoMethodError` on `with_indifferent_access`.
+
+### Added
+- GitHub Actions workflow running the suite against Ruby 3.2, 3.3, 3.4 and 4.0.
+- Dev container definition for local development.
+- Substantially expanded specs covering the error hierarchy, file handling, configuration
+  isolation between base and derived clients, and round trips that exercise the real Faraday
+  middleware stack rather than a stubbed connection.
+- Contributor documentation (`CLAUDE.md`, Copilot instructions) and Faraday 2.x migration notes
+  under `context/`.
+
+## [0.6.0] - 2024-11-13
+### Added
+- Adds support for Ruby 3.2
+
+
+## [0.4.0] - 2019-03-05
+### Added
+- Set original file names for multipart Happi files
+
+[Unreleased]: https://github.com/rdytech/happi/compare/v1.0.0...HEAD
+[1.0.0]: https://github.com/rdytech/happi/compare/v0.6.0...v1.0.0
+[0.6.0]: https://github.com/rdytech/happi/compare/v0.4.0...v0.6.0
+[0.4.0]: https://github.com/rdytech/happi/compare/v0.3.0...v0.4.0
+
+
+## [0.3.0] - 2018-02-23
+### Added
+- Ability to set `token_type` in configuration and pass this into `FaradayMiddleware::OAuth2` to avoid `faraday_middleware` 0.11.0 warning about using the default token type. Set `token_type: 'bearer'` to only pass the oauth token as an Authorization header instead of both a header and query string parameter.
+- This CHANGELOG.
+
+[Unreleased]: https://github.com/rdytech/happi/compare/v0.3.0...HEAD
+[0.3.0]: https://github.com/rdytech/happi/compare/v0.2.0...v0.3.0

data/CLAUDE.md

@@ -0,0 +1,108 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## What this is
+
+`happi` is a small Ruby gem (~200 LOC in `lib/`) wrapping Faraday for RESTful APIs whose
+URLs look like `https://host/api/v1/resource`. It is a library, not an app — there is
+nothing to run, only specs.
+
+## Commands
+
+```bash
+bundle install
+bundle exec rspec                      # full suite
+bundle exec rake spec                  # what CI runs
+bundle exec rspec spec/client_spec.rb          # single file
+bundle exec rspec spec/client_spec.rb:105      # single example by line
+gem build happi.gemspec                # build the .gem
+```
+
+Ruby 3.4.8 (`.ruby-version`); gemspec requires >= 3.2.0; GitHub Actions matrix covers
+3.2 / 3.3 / 3.4 / 4.0. Note the system `ruby` on macOS is 2.6 and will fail — use a
+version manager or the devcontainer (`mcr.microsoft.com/devcontainers/ruby:1-3.4-bullseye`).
+
+No linter is wired up. `cane` is a dev dependency but has no rake task and no config.
+SimpleCov runs automatically from `spec/spec_helper.rb` and writes to `coverage/` (gitignored).
+
+`.buildkite/pipeline.yml` is dead — its script pins rbenv 2.1.5. CI of record is
+`.github/workflows/ruby.yml`.
+
+## Architecture
+
+Five files, loaded in order by `lib/happi.rb`: `version`, `error`, `configuration`,
+`client`, `file`.
+
+### Config resolution is class-ivar based, and does NOT inherit
+
+`Happi::Client.config` memoizes into `@global_config`, a **class-level instance variable**.
+Subclasses get their own `@global_config`, initialized from `Happi::Configuration.defaults`
+— they do *not* copy the parent's configured values. `Happi::Client#config` is
+`self.class.config.dup` (shallow), so per-instance overrides via
+`MyClient.new(host: ..., oauth_token: ...)` never leak back to the class.
+
+Consequence, and the reason README leads with it: configuring `Happi::Client` itself is
+global state shared by every consumer that hasn't subclassed. Always subclass. The
+isolation matrix in `spec/client_spec.rb` (base vs derived × class vs instance) exists to
+pin this down — preserve it when touching `config`.
+
+### Request path
+
+`get/post/patch/delete` → `param_check(params)` → `call` → `connection.send(method, ...)`
+→ raise on mapped status → `.body.with_indifferent_access`.
+
+- `url(resource)` hardcodes the `/api/#{config.version}/` prefix. Callers pass only the
+  resource path.
+- `param_check` recurses hashes and swaps any value responding to `#multipart` for
+  `value.multipart` — this is the sole hook that turns a `Happi::File` into a
+  `Faraday::UploadIO`. Duck-typed on purpose; don't narrow it to `is_a?(Happi::File)`.
+- `connection` is memoized per instance. Mutating `client.config` after the first request
+  has no effect.
+
+### Faraday 2 migration (recent, load-bearing)
+
+`FaradayMiddleware` is gone as of 1.0.0-rc2 — it was never compatible with Faraday 2.x and
+was never actually a declared dependency. The OAuth2 Authorization header is now set by
+hand in `connection`, only when `config.oauth_token.present?`, as
+`"#{config.token_type.presence || 'Bearer'} #{config.oauth_token}"`. JSON uses Faraday's
+built-in `:json` request/response middleware. `oauth2`, `multi_json`,
+`faraday-follow_redirects`, and `faraday-http` were dropped; `activemodel` became
+`activesupport`. Do not reintroduce `faraday_middleware`.
+
+`token_type` is now interpolated verbatim as the auth scheme. In 0.6.0 it was a *mode*
+selector for `FaradayMiddleware::OAuth2`, where `'param'` meant "send the token as an
+`access_token` query parameter plus a `Token token="…"` header". That mode is gone —
+`token_type: 'param'` now just emits the malformed header `Authorization: param <token>`.
+Restoring it was considered for 1.0.0 and deliberately rejected; the breaking change is
+documented in `CHANGELOG.md` for consumers to absorb. `context/TOKEN_TYPE_PARAM.md` is the
+research behind that decision, not a work order.
+
+`context/` holds the research notes from that migration (`faraday_2.x.md`,
+`oauth2.md`, `FARADAY_2_COMPATIBILITY_REPORT.md`). Background reading, not specs.
+
+## Known traps
+
+- **`config.port` and `config.timeout` are inert.** `connection` calls
+  `Faraday.new(config.host)` with no options hash. Port must be embedded in `host`.
+- **Response parsing is gated on an exact `application/json` content type.** `connection`
+  registers `f.response :json, content_type: 'application/json'` unconditionally — that
+  part is not affected by `use_json`, which selects the *request* encoding only. But the
+  match is string equality against the bare type, so a server answering
+  `application/vnd.api+json`, `text/json`, or no `Content-Type` leaves the body a `String`,
+  and `String` has no `with_indifferent_access` — every `get`/`post`/`patch`/`delete` then
+  raises `NoMethodError`. Widen the `content_type:` option rather than reaching for
+  `use_json`.
+- **Error messages are static.** `Happi::Error` subclasses override `#message` with fixed
+  strings, discarding the API body passed to `new`. The real payload is only reachable via
+  `error.response`. Also `TooManyRequests` (429) is nested under `ServerError`, not
+  `ClientError`.
+- **`Happi::Error::ServiceableErrors` is unreachable code.** `included` references
+  `::NestedError` (top-level) while the class is defined at
+  `ServiceableErrors::NestedError`, and its `initialize` defaults `original` to `$1`.
+  Nothing includes it; leave it alone unless deliberately fixing it.
+- **`.github/copilot-instructions.md` is stale.** It still documents `oauth2`,
+  `activemodel`, and `FaradayMiddleware::OAuth2` as current. Prefer this file and the
+  gemspec.
+- `Gemfile.lock` is gitignored (library gem) though present locally. `Gemfile.rails32` /
+  `Gemfile.rails41` are historical and unusable on the supported Ruby versions.

data/happi.gemspec

@@ -10,22 +10,25 @@ Gem::Specification.new do |spec|
   spec.email         = ["john.dagostino@gmail.com"]
   spec.description   = %q{Simple faraday client preconfigured}
   spec.summary       = %q{Simple faraday client wrapper preconfigured for specific usecase}
-  spec.homepage      = "http://github.com/jobready/happi"
+  spec.homepage      = "https://github.com/rdytech/happi"
   spec.license       = "MIT"
+  spec.required_ruby_version = '>= 3.2.0'
 
-  spec.files         = `git ls-files`.split($/)
+  # Ship only what a consumer needs at runtime. Specs (and their 2MB fixture),
+  # research notes and CI/editor config stay in the repo but out of the gem.
+  excluded_prefixes = %w[spec/ context/ .github/ .devcontainer/]
+  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+    f.start_with?(*excluded_prefixes) || f.end_with?('.gem')
+  end
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'faraday', '~> 0.9'
-  spec.add_dependency 'faraday_middleware', '~> 0.9'
-  spec.add_dependency 'activemodel', '>= 3.2'
-  spec.add_dependency 'oauth2', '~> 1.0'
-  spec.add_dependency 'mime-types', '>= 1.1.6'
-  spec.add_dependency 'multi_json', '~> 1.3'
+  spec.add_dependency 'faraday', '>= 1.10.0'
+  spec.add_dependency 'faraday-multipart', '~> 1.1'
+  spec.add_dependency 'activesupport', '>= 6.0'
+  spec.add_dependency 'mime-types', '>= 2.4.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'bundler', '>= 2.0'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'cane'
   spec.add_development_dependency 'rake'

data/lib/happi/client.rb

@@ -1,5 +1,6 @@
+require 'logger'
 require 'faraday'
-require 'faraday_middleware'
+require 'faraday/multipart'
 require 'active_support/core_ext/string/inflections'
 require 'active_support/core_ext/hash'
 
@@ -94,13 +95,19 @@ class Happi::Client
 
   def connection
     @connection ||= Faraday.new(config.host) do |f|
-      f.use FaradayMiddleware::OAuth2, config.oauth_token
-      f.use FaradayMiddleware::ParseJson, content_type: 'application/json'
+      # Set OAuth2 Authorization header
+      if config.oauth_token.present?
+        token_type = config.token_type.presence || 'Bearer'
+        f.headers['Authorization'] = "#{token_type} #{config.oauth_token}"
+      end
+
+      # Responses are parsed regardless of use_json, matching the unconditional
+      # FaradayMiddleware::ParseJson of 0.6.0. use_json only selects the request
+      # encoding - JSON body vs multipart/url-encoded.
+      f.response :json, content_type: 'application/json'
 
       if self.config.use_json
-        f.use FaradayMiddleware::EncodeJson
         f.request :json
-        f.response :json
       else
         f.request :multipart
         f.request :url_encoded

data/lib/happi/configuration.rb

@@ -1,16 +1,23 @@
 class Happi::Configuration
   def self.defaults
-     {
-    host: 'http://localhost:8080',
-    port: 443,
-    timeout: 60,
-    version: 'v1',
-    use_json: false,
-    log_level: :info
+    {
+      host: 'http://localhost:8080',
+      port: 443,
+      timeout: 60,
+      version: 'v1',
+      use_json: false,
+      log_level: :info
     }
   end
 
-  attr_accessor :oauth_token, :host, :port, :timeout, :version, :use_json, :log_level
+  attr_accessor :oauth_token,
+                :host,
+                :port,
+                :timeout,
+                :version,
+                :use_json,
+                :log_level,
+                :token_type
 
   def initialize(options = {})
     self.class.defaults.merge(options).each do |key, value|

data/lib/happi/file.rb

@@ -1,8 +1,11 @@
 require 'mime/types'
+require 'base64'
+require 'faraday/multipart'
 
 class Happi::File
   attr_accessor :file_name
   attr_accessor :mime_type
+  attr_accessor :original_filename
 
   def initialize(file)
     if file.is_a?(String)
@@ -11,15 +14,16 @@ class Happi::File
     else
       @mime_type = file.content_type
       @file_name = file.path
+      @original_filename =  file.original_filename
     end
   end
 
   def exists?
-    File.exists?(file_name)
+    File.exist?(file_name)
   end
 
   def multipart
-    Faraday::UploadIO.new(file_name, mime_type) if exists?
+    Faraday::UploadIO.new(file_name, mime_type, original_filename) if exists?
   end
 
   def encode_file

data/lib/happi/version.rb

@@ -1,3 +1,3 @@
 module Happi
-  VERSION = '0.2.0'
+  VERSION = '1.0.0'
 end

metadata

@@ -1,113 +1,84 @@
 --- !ruby/object:Gem::Specification
 name: happi
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - John D'Agostino
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-13 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: 1.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: 1.10.0
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: faraday-multipart
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
-- !ruby/object:Gem::Dependency
-  name: oauth2
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: mime-types
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.6
+        version: 2.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.6
-- !ruby/object:Gem::Dependency
-  name: multi_json
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
+        version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -186,7 +157,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".travis.yml"
+- ".ruby-version"
+- CHANGELOG.md
+- CLAUDE.md
 - Gemfile
 - Gemfile.rails32
 - Gemfile.rails41
@@ -200,18 +173,10 @@ files:
 - lib/happi/error.rb
 - lib/happi/file.rb
 - lib/happi/version.rb
-- script/buildkite.sh
-- spec/client_spec.rb
-- spec/configuration_spec.rb
-- spec/error_spec.rb
-- spec/file_spec.rb
-- spec/fixtures/award.docx
-- spec/spec_helper.rb
-homepage: http://github.com/jobready/happi
+homepage: https://github.com/rdytech/happi
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -219,23 +184,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.7
-signing_key: 
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Simple faraday client wrapper preconfigured for specific usecase
-test_files:
-- spec/client_spec.rb
-- spec/configuration_spec.rb
-- spec/error_spec.rb
-- spec/file_spec.rb
-- spec/fixtures/award.docx
-- spec/spec_helper.rb
-has_rdoc: 
+test_files: []

data/.travis.yml

@@ -1,12 +0,0 @@
-language: ruby
-rvm:
-  - 2.1.1
-  - 2.0.0
-gemfile:
-  - Gemfile.rails41
-  - Gemfile.rails32
-  - Gemfile
-branches:
-  only:
-    - develop
-    - master

data/script/buildkite.sh

@@ -1,19 +0,0 @@
-#!/bin/bash
-set -e
-
-REVISION=https://github.com/$BUILDBOX_PROJECT_SLUG/commit/$BUILDBOX_COMMIT
-
-echo '--- setting ruby version'
-rbenv local 2.1.5
-
-echo '--- bundling'
-bundle install -j $(nproc) --without development production --quiet
-
-echo '--- running specs'
-if bundle exec rspec; then
-  echo "[Successful] $BUILDBOX_PROJECT_SLUG - Build - $BUILDBOX_BUILD_URL - Commit - $REVISION" | hipchat_room_message -t $HIPCHAT_TOKEN -r $HIPCHAT_ROOM -f "Buildbox" -c "green"
-else
-  echo "[Failed] Build $BUILDBOX_PROJECT_SLUG - Build - $BUILDBOX_BUILD_URL - Commit - $REVISION" | hipchat_room_message -t $HIPCHAT_TOKEN -r $HIPCHAT_ROOM -f "Buildbox" -c "red"
-  exit 1;
-fi
-

data/spec/client_spec.rb

@@ -1,82 +0,0 @@
-require 'spec_helper'
-
-class DerivedClient < Happi::Client; end
-
-describe Happi::Client do
-  describe '.new' do
-    let(:default_port) { Happi::Configuration.defaults[:port] }
-    let(:class_level_port) { 80 }
-    let(:instance_level_port) { 8080 }
-    let(:derived_class_level_port) { 8081 }
-    let(:config_port) { described_class.new.config.port }
-    let(:derived_config_port) { DerivedClient.new.config.port }
-
-    context 'with no supplied config' do
-      it 'uses the default config for the base class' do
-        expect(config_port).to eq(default_port)
-      end
-
-      it 'uses the default config for the derived class' do
-        expect(derived_config_port).to eq(default_port)
-      end
-    end
-
-    context 'with class level config for the base class' do
-      before do
-        described_class.configure { |config| config.port = class_level_port }
-      end
-
-      it 'overrides the default config for the base class' do
-        expect(config_port).to eq(class_level_port)
-      end
-
-      it 'does not override the default config for the derived class' do
-        expect(derived_config_port).to_not eq(class_level_port)
-      end
-    end
-
-    context 'with class level config for the derived class' do
-      before do
-        DerivedClient.configure { |config| config.port = derived_class_level_port }
-      end
-
-      it 'does not affect the config for the base class' do
-        expect(config_port).to_not eq(derived_class_level_port)
-      end
-
-      it 'overrides the default config for the derived class' do
-        expect(derived_config_port).to eq(derived_class_level_port)
-      end
-    end
-
-    context 'with instance level config for the base class' do
-      before do
-        described_class.configure { |config| config.port = class_level_port }
-      end
-
-      it 'overrides the class config for only that base class instance' do
-        expect(Happi::Client.new(port: instance_level_port).config.port).to eq(instance_level_port)
-        expect(config_port).to_not eq(instance_level_port)
-      end
-
-      it 'does not affect the config for an instance of the derived class' do
-        expect(derived_config_port).to_not eq(instance_level_port)
-      end
-    end
-
-    context 'with instance level config for the derived class' do
-      before do
-        described_class.configure { |config| config.port = class_level_port }
-      end
-
-      it 'does not affect the config for an instance of the base class' do
-        expect(config_port).to_not eq(instance_level_port)
-      end
-
-      it 'overrides the class config for only that derived class instance' do
-        expect(DerivedClient.new(port: instance_level_port).config.port).to eq(instance_level_port)
-        expect(derived_config_port).to_not eq(instance_level_port)
-      end
-    end
-  end
-end

data/spec/configuration_spec.rb

@@ -1,13 +0,0 @@
-require 'spec_helper'
-
-describe Happi::Configuration do
-  describe 'options' do
-    specify { expect(Happi::Configuration.new(host: 'http://www.google.com').host).to eql('http://www.google.com') }
-    specify { expect(Happi::Configuration.new(port: 80).port).to eql(80) }
-
-    specify do
-      Happi::Client.configure { |config| config.host = 'http://localhost:3000' }
-      expect(Happi::Client.config.host).to eq 'http://localhost:3000'
-    end
-  end
-end

data/spec/error_spec.rb

@@ -1,17 +0,0 @@
-require 'spec_helper'
-
-describe Happi::Error do
-  describe '.new' do
-    context 'with 1 argument' do
-      let(:error) { Happi::Error.new('message') }
-      specify { expect(error.message).to eq('message') }
-      specify { expect(error.response).to be nil }
-    end
-
-    context 'with 2 arguments' do
-      let(:error) { Happi::Error.new('message', 'response') }
-      specify { expect(error.message).to eq('message') }
-      specify { expect(error.response).to eq('response') }
-    end
-  end
-end

data/spec/file_spec.rb

@@ -1,46 +0,0 @@
-require 'spec_helper'
-require 'rack/test'
-
-describe Happi::File do
-  context "with a file name" do
-    subject { Happi::File.new(__FILE__) }
-
-    describe '#encode_file' do
-      encoded = Base64.encode64(File.read(__FILE__))
-      specify { expect(subject.encode_file).to eql(encoded) }
-    end
-
-    describe '#mime_type' do
-      specify { expect(subject.mime_type).to eql('application/x-ruby') }
-    end
-
-    describe '#multipart' do
-      # specify { expect(subject.multipart).to }
-    end
-
-    describe '#exists?' do
-      specify { expect(subject.exists?).to eq(true) }
-    end
-  end
-
-  context "with an ActionDispatch::Http::UploadedFile" do
-    subject { Happi::File.new(Rack::Test::UploadedFile.new(__FILE__, 'application/x-ruby')) }
-
-    describe '#encode_file' do
-      encoded = Base64.encode64(File.read(__FILE__))
-      specify { expect(subject.encode_file).to eql(encoded) }
-    end
-
-    describe '#mime_type' do
-      specify { expect(subject.mime_type).to eql('application/x-ruby') }
-    end
-
-    describe '#multipart' do
-      # specify { expect(subject.multipart).to }
-    end
-
-    describe '#exists?' do
-      specify { expect(subject.exists?).to eq(true) }
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,12 +0,0 @@
-require 'simplecov'
-SimpleCov.start
-
-$LOAD_PATH.unshift File.join(File.dirname(__FILE__), *%w[.. lib])
-
-require 'rspec'
-require 'happi'
-
-Dir[File.expand_path('../../spec/support/**/*.rb', __FILE__)].map(&method(:require))
-
-RSpec.configure do |config|
-end