handler 0.8.0 → 0.9.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 4e1e6c53663ede3c98f55892c9cc63eb86ec9e78
+  data.tar.gz: 2446f113f9b31c486007e8a033cfe6529ba8f97e
+SHA512:
+  metadata.gz: 72c3cc99324f5031b926e606ccc1727d9a35d549077ee824e83418cc708da0a014873e2356dba4cc051883c738831be369aa9f453ec10565401a874b3274262f
+  data.tar.gz: 6a227d82f710b2e4d176a5dcbce4105114642984fbc2597d4891462bf57cc8c08abbb0faa1478f30dbe57fbcdfe72a4faf2fc240c14cb29bcdaa3badf8f0c642

data/CHANGELOG.rdoc

@@ -2,6 +2,9 @@
 
 Per-release changes to Handler.
 
+== 0.9.0 (2016 Sep 5)
+
+Compatibility with ActiveRecord 4+ (use new AR Query Interface).
 
 == 0.8.0 (2009 Oct 12)
 

data/README.rdoc

@@ -1,5 +1,7 @@
 = Handler
 
+<b>Handler is currently compatible with Rails 3.x, 4.x, and 5.x.</b>
+
 Handler is a Rails plugin that generates handles (filesystem- and URL-friendly names) for ActiveRecord models based on a given attribute or method. For example, in your model:
 
   handle_based_on :title

data/Rakefile

@@ -41,7 +41,7 @@ task :test => :check_dependencies
 
 task :default => :test
 
-require 'rake/rdoctask'
+require 'rdoc/task'
 Rake::RDocTask.new do |rdoc|
   if File.exist?('VERSION')
     version = File.read('VERSION')

data/VERSION

@@ -1 +1 @@
-0.8.0
+0.9.0

data/handler.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{handler}
-  s.version = "0.8.0"
+  s.version = "0.9.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alex Reisner"]
@@ -36,9 +36,13 @@ Gem::Specification.new do |s|
   s.summary = %q{Handler generates filesystem- and URL-friendly names for ActiveRecord models.}
   s.test_files = [
     "test/handler_test.rb",
-     "test/test_helper.rb"
+    "test/test_helper.rb"
   ]
 
+  s.add_dependency 'activesupport', '>= 3.0'
+  s.add_dependency 'activerecord', '>= 3.0'
+  s.add_development_dependency 'minitest'
+
   if s.respond_to? :specification_version then
     current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
     s.specification_version = 3

data/lib/handler.rb

@@ -1,16 +1,16 @@
 module Handler
-	
+
   ##
   # Included hook: extend including class.
   #
   def self.included(base)
     base.extend ClassMethods
   end
-  
+
   ##
   # Transliterate a string: change accented Unicode characters to ASCII
   # approximations. Tries several methods, attempting the best first:
-  # 
+  #
   # 1. unidecode, if installed (http://rubyforge.org/projects/unidecode)
   # 2. iconv (included with Ruby, doesn't work with all Ruby versions)
   # 3. normalize, then remove un-normalizable characters
@@ -21,7 +21,7 @@ module Handler
       transliterate_with_normalization(string) or
       string
   end
-  
+
   ##
   # Transliterate a string with the unidecode library.
   # Return nil if unsuccessful (eg, library not available).
@@ -34,7 +34,7 @@ module Handler
       nil
     end
   end
-  
+
   ##
   # Transliterate a string with the iconv library.
   # Return nil if unsuccessful (eg, library not available).
@@ -46,7 +46,16 @@ module Handler
       nil
     end
   end
-  
+
+  ##
+  # Transliterate a string using multibyte normalization,
+  # then remove remaining non-ASCII characters. Taken from
+  # <tt>ActiveSupport::Inflector.transliterate</tt>.
+  #
+  def self.transliterate_with_normalization(string)
+    string.mb_chars.normalize.gsub(/[^\x00-\x7F]+/, '').to_s
+  end
+
   ##
   # Generate a handle from a string.
   #
@@ -59,10 +68,11 @@ module Handler
     str = str.gsub('&', ' and ') # add space for, e.g., "Y&T"
     str = str.delete('.\'"')     # no space
     str = str.gsub(/\W/, ' ')    # space
+    str = str.strip
     str = str.gsub(/ +/, separator)
-    str   
+    str
   end
-  
+
   ##
   # Get the next handle in the sequence (for avoiding duplicates).
   #
@@ -73,22 +83,13 @@ module Handler
       handle + separator + "2"
     end
   end
-  
-  ##
-  # Transliterate a string using multibyte normalization,
-  # then remove remaining non-ASCII characters. Taken from
-  # <tt>ActiveSupport::Inflector.transliterate</tt>.
-  #
-  def self.transliterate_with_normalization(string)
-    string.mb_chars.normalize.gsub(/[^\x00-\x7F]+/, '').to_s
-  end
-  
+
   module ClassMethods
-  
+
     ##
     # Declare that a model generates a handle based on
     # a given attribute or method. Options include:
-    # 
+    #
     # <tt>:separator</tt> - character to place between words
     # <tt>:store</tt> - attribute in which to store handle
     # <tt>:unique</tt> - generate a handle which is unique among all records
@@ -98,22 +99,33 @@ module Handler
       options[:write_to]  ||= :handle
       options[:unique]      = true if options[:unique].nil?
 
-	    ##
-	    # Generate a URL-friendly name.
-	    #
+      ##
+      # Generate a URL-friendly name.
+      #
       define_method :generate_handle do
         h = Handler.generate_handle(send(attribute), options[:separator])
         if options[:unique]
-          
+
+          # generate a condition for finding an existing record with a
+          # given handle
+          find_dupe = lambda{ |h|
+            conds = ["#{options[:write_to]} = ?", h]
+            unless new_record?
+              conds[0] << " AND id != ?"
+              conds << id
+            end
+            conds
+          }
+
           # increase number while *other* records exist with the same handle
           # (record might be saved and should keep its handle)
-          while self.class.all(:conditions => ["#{options[:write_to]} = ? AND id != ?", h, id]).size > 0
+          while self.class.where(find_dupe.call(h)).size > 0
             h = Handler.next_handle(h, options[:separator])
           end
         end
         h
       end
-      
+
       ##
       # Assign the generated handle to the specified attribute.
       #

data/test/handler_test.rb

@@ -24,7 +24,7 @@ class HandlerTest < ActiveSupport::TestCase
       ".38 Special"                 => "38_special",
       "Guns N' Roses"               => "guns_n_roses",
       "The Rossington-Collins Band" => "the_rossington_collins_band"
-      
+
     }.each do |s,t|
       b.name = s
       assert_equal t, b.generate_handle
@@ -37,19 +37,19 @@ class HandlerTest < ActiveSupport::TestCase
       "Y&T"                    => "y_and_t",
       "Huey Lewis & the News"  => "huey_lewis_and_the_news",
       "Emerson, Lake & Palmer" => "emerson_lake_and_palmer"
-      
+
     }.each do |s,t|
       b.name = s
       assert_equal t, b.generate_handle
     end
   end
-  
+
   test "next handle" do
     assert_equal "banana_boat_2",  Handler.next_handle("banana_boat",    "_")
     assert_equal "banana-boat-3",  Handler.next_handle("banana-boat-2",  "-")
     assert_equal "banana-boat-12", Handler.next_handle("banana-boat-11", "-")
   end
-  
+
   test "unique handle generation" do
     p = Person.new
     p.name = "Captain Beefheart"
@@ -62,14 +62,17 @@ end
 class ActiveRecordSimulator
   include Handler
   attr_accessor :name
-  
+
   # simulate id method
   def id; 123; end
 
-  # simulate ActiveRecord::Base.all method;
+  # simulate new_record? method
+  def new_record?; true; end
+
+  # simulate ActiveRecord::Base.where method;
   # needed for testing whether records exist with a given handle
-  def self.all(options)
-    @existing_handles.include?(options[:conditions][1]) ? [nil, nil] : []
+  def self.where(options)
+    @existing_handles.include?(options[1]) ? [nil, nil] : []
   end
 end
 

data/test/test_helper.rb

@@ -1,7 +1,7 @@
 require 'rubygems'
 require 'active_support'
 require 'active_support/test_case'
-require 'test/unit'
+require 'minitest/autorun'
 
 # required to avoid errors
 module ActiveRecord

metadata

@@ -1,29 +1,24 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: handler
-version: !ruby/object:Gem::Version 
-  version: 0.8.0
+version: !ruby/object:Gem::Version
+  version: 0.9.0
 platform: ruby
-authors: 
+authors:
 - Alex Reisner
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2009-10-13 00:00:00 -04:00
-default_executable: 
+date: 2016-09-04 00:00:00.000000000 Z
 dependencies: []
-
-description: Handler is a Rails plugin that generates handles (filesystem- and URL-friendly names) for ActiveRecord models based on a given attribute or method.
+description: Handler is a Rails plugin that generates handles (filesystem- and URL-friendly
+  names) for ActiveRecord models based on a given attribute or method.
 email: alex@alexreisner.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
 - README.rdoc
-files: 
-- .gitignore
+files:
 - CHANGELOG.rdoc
 - LICENSE
 - README.rdoc
@@ -34,34 +29,27 @@ files:
 - lib/handler.rb
 - test/handler_test.rb
 - test/test_helper.rb
-has_rdoc: true
 homepage: http://github.com/alexreisner/handler
 licenses: []
-
+metadata: {}
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
-require_paths: 
+rdoc_options: []
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 2.5.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Handler generates filesystem- and URL-friendly names for ActiveRecord models.
-test_files: 
-- test/handler_test.rb
-- test/test_helper.rb
+test_files: []

data/.gitignore

@@ -1,5 +0,0 @@
-*.sw?
-.DS_Store
-coverage
-rdoc
-pkg