handcrafted-ebay_products 0.1.1 → 0.1.2

data/Rakefile

@@ -10,6 +10,8 @@ begin
     gem.homepage = "http://github.com/handcrafted/ebay_products"
     gem.authors = ["Josh Owens"]
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
+    gem.add_dependency('httparty', '>= 0.4.3')
+    gem.add_dependency('activesupport', '>= 2.2.2')
   end
 
 rescue LoadError

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/ebay_products.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ebay_products}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Josh Owens"]
-  s.date = %q{2009-06-26}
+  s.date = %q{2009-07-01}
   s.email = %q{joshua.owens@gmail.com}
   s.extra_rdoc_files = [
     "LICENSE",
@@ -23,6 +23,7 @@ Gem::Specification.new do |s|
      "lib/ebay_products.rb",
      "lib/ebay_products/data.rb",
      "spec/ebay_products_spec.rb",
+     "spec/samples/failure.xml",
      "spec/samples/harry_potter.xml",
      "spec/spec.opts",
      "spec/spec_helper.rb"
@@ -42,8 +43,14 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
+      s.add_runtime_dependency(%q<httparty>, [">= 0.4.3"])
+      s.add_runtime_dependency(%q<activesupport>, [">= 2.2.2"])
     else
+      s.add_dependency(%q<httparty>, [">= 0.4.3"])
+      s.add_dependency(%q<activesupport>, [">= 2.2.2"])
     end
   else
+    s.add_dependency(%q<httparty>, [">= 0.4.3"])
+    s.add_dependency(%q<activesupport>, [">= 2.2.2"])
   end
 end

data/lib/ebay_products.rb

@@ -20,7 +20,12 @@ class EbayProducts
   
   def search
     if @search.blank?
-      @search = self.class.get("/shopping", :query => options, :format => :xml)["FindProductsResponse"]["Product"]
+      response = self.class.get("/shopping", :query => options, :format => :xml)["FindProductsResponse"]
+      errors = response['Errors']
+      if errors
+        raise SearchFailure, errors['LongMessage']
+      end
+      @search = response["Product"]
       if @search.is_a? Hash
         @search = [@search]
       end
@@ -46,4 +51,6 @@ class EbayProducts
     end
     hash
   end
-end
+end
+
+class SearchFailure < RuntimeError; end

data/spec/ebay_products_spec.rb

@@ -37,6 +37,17 @@ describe "EbayProducts" do
       @ebay.products.size.should == 2
     end
     
+    context "Search failure" do
+      before(:each) do
+        FakeWeb.register_uri(:get, "http://open.api.ebay.com:80/shopping?QueryKeywords=xbox&callname=FindProducts&siteid=0&maxentries=18&appid=123abc&version=619&responseencoding=XML", :body => File.read("#{File.dirname(__FILE__)}/samples/failure.xml"))
+        @ebay = EbayProducts.new({:keywords => "xbox"}, "123abc")
+      end
+      
+      it "should throw search failure" do
+        lambda { @ebay.search }.should raise_error(SearchFailure)
+      end
+
+    end
   end
   
 end

data/spec/samples/failure.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+  <FindProductsResponse xmlns="urn:ebay:apis:eBLBaseComponents">
+   <Timestamp>2009-07-01T09:18:26.109Z</Timestamp>
+   <Ack>Failure</Ack>
+   <Errors>
+    <ShortMessage>Your query would return too many items.</ShortMessage>
+    <LongMessage>Your query would return too many items. Please define a more specific query.</LongMessage>
+    <ErrorCode>10.4</ErrorCode>
+    <SeverityCode>Error</SeverityCode>
+    <ErrorClassification>RequestError</ErrorClassification>
+   </Errors>
+   <Build>e623__Bundled_9520957_R1</Build>
+   <Version>623</Version>
+  </FindProductsResponse>
+ 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: handcrafted-ebay_products
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Josh Owens
@@ -9,10 +9,29 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-26 00:00:00 -07:00
+date: 2009-07-01 00:00:00 -07:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: httparty
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 0.4.3
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: activesupport
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 2.2.2
+    version: 
 description: 
 email: joshua.owens@gmail.com
 executables: []
@@ -33,6 +52,7 @@ files:
 - lib/ebay_products.rb
 - lib/ebay_products/data.rb
 - spec/ebay_products_spec.rb
+- spec/samples/failure.xml
 - spec/samples/harry_potter.xml
 - spec/spec.opts
 - spec/spec_helper.rb