handcrafted-ebay_products 0.0.1 → 0.1.0

data/Rakefile

@@ -5,7 +5,7 @@ begin
   require 'jeweler'
   Jeweler::Tasks.new do |gem|
     gem.name = "ebay_products"
-    gem.summary = %Q{TODO}
+    gem.summary = %Q{Wrapper for eBay web services}
     gem.email = "joshua.owens@gmail.com"
     gem.homepage = "http://github.com/handcrafted/ebay_products"
     gem.authors = ["Josh Owens"]

data/VERSION

@@ -1 +1 @@
-0.0.1
+0.1.0

data/ebay_products.gemspec

@@ -0,0 +1,49 @@
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = %q{ebay_products}
+  s.version = "0.1.0"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Josh Owens"]
+  s.date = %q{2009-06-26}
+  s.email = %q{joshua.owens@gmail.com}
+  s.extra_rdoc_files = [
+    "LICENSE",
+     "README.rdoc"
+  ]
+  s.files = [
+    ".document",
+     ".gitignore",
+     "LICENSE",
+     "README.rdoc",
+     "Rakefile",
+     "VERSION",
+     "ebay_products.gemspec",
+     "lib/ebay_products.rb",
+     "lib/ebay_products/data.rb",
+     "spec/ebay_products_spec.rb",
+     "spec/samples/harry_potter.xml",
+     "spec/spec.opts",
+     "spec/spec_helper.rb"
+  ]
+  s.homepage = %q{http://github.com/handcrafted/ebay_products}
+  s.rdoc_options = ["--charset=UTF-8"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = %q{1.3.4}
+  s.summary = %q{Wrapper for eBay web services}
+  s.test_files = [
+    "spec/ebay_products_spec.rb",
+     "spec/spec_helper.rb"
+  ]
+
+  if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
+    else
+    end
+  else
+  end
+end

data/lib/ebay_products.rb

@@ -1,6 +1,7 @@
 require 'rubygems'
 gem 'httparty'
 require 'httparty'
+require 'activesupport'
 require File.dirname(__FILE__) + '/ebay_products/data'
 
 class EbayProducts
@@ -9,18 +10,34 @@ class EbayProducts
   base_uri "open.api.ebay.com"
   default_params :responseencoding => 'XML', :callname => "FindProducts", :version => "619", :siteid => 0, :maxentries => 18
   
-  attr_reader :query, :appid
+  attr_reader :query, :appid, :product_id
   
-  def initialize(query, appid)
-    @query, @appid = query, appid
+  def initialize(args, appid)
+    @query = args[:keywords]
+    @product_id = args[:product_id]
+    @appid = appid
   end
   
   def search
-    @search ||= self.class.get("/shopping", :query => {:QueryKeywords => @query, :appid => @appid})["FindProductsResponse"]["Product"]
+    @search ||= self.class.get("/shopping", :query => options, :format => :xml)["FindProductsResponse"]["Product"]
   end
   
   def products
     @products ||= search.collect {|product| ProductInformation.new(product) }
   end
-  
+
+  def product
+    products.first
+  end
+
+  def options
+    hash = {:appid => @appid}
+    if @product_id
+      hash['ProductID.value'.to_sym] = @product_id
+      hash['ProductID.type'.to_sym] = 'Reference' # assumes product id is of type reference
+    else
+      hash[:QueryKeywords] = @query
+    end
+    hash
+  end
 end

data/lib/ebay_products/data.rb

@@ -3,7 +3,7 @@ class EbayProducts
     attr_reader :data
     
     def initialize(data)
-      @data = data
+      @data = downcase_keys(data)
     end
     
     def method_missing(method, *args)
@@ -14,10 +14,24 @@ class EbayProducts
       end
     end
     
-    # def inspect
-    #   data = @data.inject([]) { |collection, key| collection << "#{key[0]}: #{key[1]['data']}"; collection }.join("\n    ")
-    #   "#<#{self.class}:0x#{object_id}\n    #{data}>"
-    # end
+    private
+    
+    def downcase_keys(hash)
+      hash = hash.dup
+      new_hash = {}
+      hash.keys.each do |key|
+        value = hash.delete(key)
+        new_hash[downcase_key(key)] = value
+        new_hash[downcase_key(key)] = downcase_keys(value) if value.is_a?(Hash)
+        new_hash[downcase_key(key)] = value.each{|p| downcase_keys(p) if p.is_a?(Hash)} if value.is_a?(Array)
+      end
+      new_hash
+    end
+
+    def downcase_key(key)
+      key.underscore.titlecase.downcase.gsub(' ', '_')
+    end
+        
   end
   
   class ProductInformation < Data; end

data/spec/ebay_products_spec.rb

@@ -3,29 +3,38 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 describe "EbayProducts" do
     
   context "Initializing" do
-    
+
     it "should raise an error without a query and appid" do
       lambda {EbayProducts.new}.should raise_error
-      lambda {EbayProducts.new("query")}.should raise_error
+      lambda {EbayProducts.new({:keywords => "query"})}.should raise_error
     end
-    
+
     it "save the query and appid" do
-      ebay = EbayProducts.new("query", "1234")
+      ebay = EbayProducts.new({:keywords => "query"}, "1234")
       ebay.query.should == "query"
       ebay.appid.should == "1234"
     end
-    
+
   end
   
   context "Finding" do
     
     before(:each) do
-      FakeWeb.register_uri(:get, "http://open.api.ebay.com:80/shopping?QueryKeywords=harry%20potter&callname=FindProducts&siteid=0&maxentries=18&appid=123abc&version=619&responseencoding=XML", :string => File.read("#{File.dirname(__FILE__)}/samples/harry_potter.xml"))
+      FakeWeb.register_uri(:get, "http://open.api.ebay.com:80/shopping?QueryKeywords=harry%20potter&callname=FindProducts&siteid=0&maxentries=18&appid=123abc&version=619&responseencoding=XML", :body => File.read("#{File.dirname(__FILE__)}/samples/harry_potter.xml"))
+      @ebay = EbayProducts.new({:keywords => "harry potter"}, "123abc")
     end
-    
+
+    it "search should return an Array" do
+      @ebay.search.should be_an_instance_of(Array)
+    end
+
+    it "ebay products should not wipe out search results" do
+      product = @ebay.search.first
+      proc { @ebay.products }.should_not change(product, :size)
+    end
+
     it "should find the products" do
-      e = EbayProducts.new("harry potter", "123abc")
-      puts e.products
+      @ebay.products.size.should == 2
     end
     
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: handcrafted-ebay_products
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors: 
 - Josh Owens
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-06-20 00:00:00 -07:00
+date: 2009-06-26 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -29,13 +29,14 @@ files:
 - README.rdoc
 - Rakefile
 - VERSION
+- ebay_products.gemspec
 - lib/ebay_products.rb
 - lib/ebay_products/data.rb
 - spec/ebay_products_spec.rb
 - spec/samples/harry_potter.xml
 - spec/spec.opts
 - spec/spec_helper.rb
-has_rdoc: true
+has_rdoc: false
 homepage: http://github.com/handcrafted/ebay_products
 post_install_message: 
 rdoc_options: 
@@ -60,7 +61,7 @@ rubyforge_project:
 rubygems_version: 1.2.0
 signing_key: 
 specification_version: 3
-summary: TODO
+summary: Wrapper for eBay web services
 test_files: 
 - spec/ebay_products_spec.rb
 - spec/spec_helper.rb