handbrake 0.0.2 → 0.1.0

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+0.1.0
+=====
+
+- Change {HandBrake::Title#chapters} from an Array to a Hash. This is
+  consistent with {HandBrake::Titles} and obviates the need for index
+  to chapter number conversions. {HandBrake::Title#all_chapters} is
+  the equivalent of the old {HandBrake::Title#chapters} method.
+
 0.0.2
 =====
 

data/README.md

@@ -45,7 +45,7 @@ A brief sample:
     titles[1].duration            # => "01:21:18"
     titles[1].seconds             # => 4878
     titles[1].chapters.size       # => 23
-    titles[1].chapters[2].seconds # => 208
+    titles[1].chapters[3].seconds # => 208
 
     project.title(1).
       preset('Normal').
@@ -129,7 +129,8 @@ configuration chain.
 Additional resources
 --------------------
 
-* [API docs](http://rubydoc.info/gems/handbrake.rb)
+* API docs: [last release](http://rubydoc.info/gems/handbrake) or
+  [in development](http://rubydoc.info/github/rsutphin/handbrake.rb/master/frames)
 * [Continuous integration](http://travis-ci.org/#!/rsutphin/handbrake.rb)
   (note that right now this link only works when there has been a
   recent build)

data/lib/handbrake/titles.rb

@@ -136,7 +136,8 @@ module HandBrake
           detect { |c| c.name =~ /duration/ }.name.
           scan(/duration: (\d\d:\d\d:\d\d)/).first.first
         title.chapters = title_node['chapters:'].children.
-          collect { |ch_node| Chapter.from_tree(ch_node) }
+          collect { |ch_node| Chapter.from_tree(ch_node) }.
+          inject({}) { |h, ch| h[ch.number] = ch; h }
         title.main_feature = title_node.children.detect { |c| c.name =~ /Main Feature/ }
       end
     end
@@ -149,10 +150,17 @@ module HandBrake
     end
 
     ##
-    # @return [Array<Chapter>] The chapters into which the title is
-    #   divided.
+    # @return [Hash<Fixnum,Chapter>] The chapters into which the title is
+    #   divided, indexed by chapter number (a positive integer).
     def chapters
-      @chapters ||= []
+      @chapters ||= {}
+    end
+
+    ##
+    # @return [Array<Chapter>] The chapters of the title, sorted by
+    #   chapter number.
+    def all_chapters
+      chapters.keys.sort.collect { |k| chapters[k] }
     end
   end
 

data/lib/handbrake/version.rb

@@ -1,5 +1,5 @@
 module HandBrake
   ##
   # The current version
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/spec/handbrake/titles_spec.rb

@@ -69,12 +69,23 @@ module HandBrake
       title_3.seconds.should == 6234
     end
 
-    it 'has all the chapters' do
+    it 'has the right number of chapters' do
       title_3.should have(13).chapters
     end
 
+    it 'has chapters indexed by chapter number' do
+      title_3.chapters[2].tap do |c|
+        c.duration.should == '00:00:52'
+        c.number.should == 2
+      end
+    end
+
+    it 'has an array of the chapters in order' do
+      title_3.all_chapters.collect { |ch| ch.number }.should == (1..13).to_a
+    end
+
     describe 'a chapter' do
-      let(:chapter) { title_3.chapters[4] }
+      let(:chapter) { title_3.chapters[5] }
 
       it 'has the duration' do
         chapter.duration.should == '00:03:23'

metadata

@@ -1,8 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: handbrake
 version: !ruby/object:Gem::Version 
-  prerelease: 
-  version: 0.0.2
+  hash: 27
+  prerelease: false
+  segments: 
+  - 0
+  - 1
+  - 0
+  version: 0.1.0
 platform: ruby
 authors: 
 - Rhett Sutphin
@@ -10,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-14 00:00:00 -05:00
+date: 2011-06-15 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -21,6 +26,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 61
+        segments: 
+        - 0
+        - 8
+        - 1
         version: 0.8.1
   type: :runtime
   version_requirements: *id001
@@ -32,6 +42,10 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 9
+        segments: 
+        - 2
+        - 5
         version: "2.5"
   type: :development
   version_requirements: *id002
@@ -43,6 +57,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 59
+        segments: 
+        - 0
+        - 9
+        - 0
         version: 0.9.0
   type: :development
   version_requirements: *id003
@@ -54,6 +73,11 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        - 7
+        - 0
         version: 0.7.0
   type: :development
   version_requirements: *id004
@@ -102,17 +126,23 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: A ruby wrapper for HandBrakeCLI