hanami-utils 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5efcbfde57472291defc6d0461a2e481f6783549
-  data.tar.gz: aea84dd95e00df2e2a213f7af4c828bcbccea2ef
+  metadata.gz: 4cbb5f4adac5f75b2e56d9cb8bc2f2a5b91cf5e5
+  data.tar.gz: da1b1e8502a4b5fd322bfd9ee660d8b4a1c8d9c8
 SHA512:
-  metadata.gz: 8938d0f2e8a9491d8c8b4bd6752c3d820ec845dcf7b88cdfd6f7421d10b1ef9dc86b08162c0e4a7cba7134cea4d401c43ab1a623de88923072b52989e205d556
-  data.tar.gz: 64bf55cee7347ec7a8627cd8185e3e5a891a414699d00e2e9c60ea05ebe4837eea70fd1348393dd8d7a21df9deac3e1af017b3a134e793d6f720f630f7818718
+  metadata.gz: 268645d9ea4cb481333cee4315e51e466c3d1900417622d69139f02111a7a0cde5a9e36714a69ddb5c942a51c903420793d7421018a46440c0f7b483563f43ca
+  data.tar.gz: 3784235c1726f07be68e41a8f1d7ae67f0e0dbf4c760bb20f6dfaac994e2146c946042f903eb8549a742b0ce5ae94af77348bdac2dc7d86c59b12ee5089e0783

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Hanami::Utils
 Ruby core extentions and class utilities for Hanami
 
+## v0.7.2 - 2016-05-20
+### Fixed
+- [Luca Guidi] Make `Hanami::Utils::Kernel.BigDecimal` to convert negative `BigDecimal` or `BigDecimal` with negative exponent.
+
 ## v0.7.1 - 2016-02-05
 ### Fixed
 - [Yuuji Yaginuma] `Hanami::Utils::Escape`: fixed Ruby warning for `String#chars` with a block, which is deprecated. Using `String#each_char` now.

data/lib/hanami/utils/kernel.rb

@@ -4,6 +4,7 @@ require 'time'
 require 'pathname'
 require 'bigdecimal'
 require 'hanami/utils'
+require 'hanami/utils/string'
 
 # Define top level constant Boolean, so it can be easily used by other libraries
 # in coercions DSLs
@@ -25,6 +26,14 @@ module Hanami
       # @see Hanami::Utils::Kernel.Integer
       NUMERIC_MATCHER = /\A([\d\/\.\+iE]+|NaN|Infinity)\z/.freeze
 
+      # @since x.x.x
+      # @api private
+      BOOLEAN_FALSE_STRING = '0'.freeze
+
+      # @since x.x.x
+      # @api private
+      BOOLEAN_TRUE_INTEGER = 1
+
       # Coerces the argument to be an Array.
       #
       # It's similar to Ruby's Kernel.Array, but it applies further
@@ -319,7 +328,7 @@ module Hanami
       rescue ArgumentError, TypeError, NoMethodError
         begin
           case arg
-          when NilClass, ->(a) { a.respond_to?(:to_i) && a.to_s.match(NUMERIC_MATCHER) }
+          when NilClass, ->(a) { a.respond_to?(:to_i) && numeric?(a) }
             arg.to_i
           else
             raise TypeError.new "can't convert #{inspect_type_error(arg)}into Integer"
@@ -334,6 +343,7 @@ module Hanami
       # Coerces the argument to be a BigDecimal.
       #
       # @param arg [Object] the argument
+      # @param precision [Keyword] precision for Rational objects (Only JRuby).
       #
       # @return [BigDecimal] the result of the coercion
       #
@@ -406,13 +416,12 @@ module Hanami
       #   Hanami::Utils::Kernel.BigDecimal(input) # => TypeError
       def self.BigDecimal(arg)
         case arg
-        when ->(a) { a.respond_to?(:to_d) } then arg.to_d
-        when Float, Complex, Rational
+        when Numeric
           BigDecimal(arg.to_s)
-        when ->(a) { a.to_s.match(NUMERIC_MATCHER) }
-          BigDecimal.new(arg)
+        when ->(a) { a.respond_to?(:to_d) }
+          arg.to_d
         else
-          raise TypeError.new "can't convert #{inspect_type_error(arg)}into BigDecimal"
+          BigDecimal.new(arg)
         end
       rescue NoMethodError
         raise TypeError.new "can't convert #{inspect_type_error(arg)}into BigDecimal"
@@ -535,7 +544,7 @@ module Hanami
       rescue ArgumentError, TypeError
         begin
           case arg
-          when NilClass, ->(a) { a.respond_to?(:to_f) && a.to_s.match(NUMERIC_MATCHER) }
+          when NilClass, ->(a) { a.respond_to?(:to_f) && numeric?(a) }
             arg.to_f
           else
             raise TypeError.new "can't convert #{inspect_type_error(arg)}into Float"
@@ -881,9 +890,12 @@ module Hanami
       #   Hanami::Utils::Kernel.Boolean(input) # => TypeError
       def self.Boolean(arg)
         case arg
-        when Numeric     then arg > 0 && arg <= 1
-        when String, '0' then Boolean(arg.to_i)
-        when ->(a) { a.respond_to?(:to_bool) } then arg.to_bool
+        when Numeric
+          arg.to_i == BOOLEAN_TRUE_INTEGER
+        when ::String, Utils::String, BOOLEAN_FALSE_STRING
+          Boolean(arg.to_i)
+        when ->(a) { a.respond_to?(:to_bool) }
+          arg.to_bool
         else
           !!arg
         end
@@ -1001,6 +1013,18 @@ module Hanami
         raise TypeError.new "can't convert #{inspect_type_error(arg)}into Symbol"
       end
 
+      # Check if the given argument is a string representation of a number
+      #
+      # @param arg [Object] the input
+      #
+      # @return [TrueClass,FalseClass]
+      #
+      # @since x.x.x
+      # @api private
+      def self.numeric?(arg)
+        !(arg.to_s =~ NUMERIC_MATCHER).nil?
+      end
+
       # Returns the most useful type error possible
       #
       # If the object does not respond_to?(:inspect), we return the class, else we

data/lib/hanami/utils/version.rb

@@ -3,6 +3,6 @@ module Hanami
     # Defines the version
     #
     # @since 0.1.0
-    VERSION = '0.7.1'.freeze
+    VERSION = '0.7.2'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hanami-utils
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Luca Guidi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-05 00:00:00.000000000 Z
+date: 2016-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -107,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Ruby core extentions and Hanami utilities