hanami-helpers 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e1a90723c16139a6a3c5fdd84e0d85f732ed886
-  data.tar.gz: 1edccf5044d1185147cf0d0e51fe863d78467e03
+  metadata.gz: 81f2f927f612c01d961de1653cccea4c11e2ceeb
+  data.tar.gz: e41a6a6995d4d04e7e11ac893843be76967c2555
 SHA512:
-  metadata.gz: 98e536f514a1e3d152ab3f16b059592f0d8c1b7b2f83688cedf3641a397c8db506fbefd6855fc5acb9b0feeadf991501d9dc9f62e9c3e2f555837b9085f5aa6c
-  data.tar.gz: fac6a702eb642517b6e5c31d3a1bdbf784ebccf5ed7938665ed0dfb7234205074fae945f42ce2f343ebfc2b254ddb4e90fe5032f8472308378d688e303b8aefa
+  metadata.gz: 3eef23b1f56601b1977a15a754a6b1d54c120cbb4591f9e47b29b75dd7678e325f7fe953e978b8cfc9d926d98a87ce2548b4bdc8633d511cafe08d1dc75a9511
+  data.tar.gz: 1c101a9b9f88da297a32b5ed9dd957c173bfca10746c0ab80b948dbee16e177d01bb3fb8fae8afcd5f115584b0a20afc200b3ad3ef88c6012fafc51c0cc45839

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Hanami::Helpers
 View helpers for Ruby web applications
 
+## v0.5.1 - 2016-12-19
+### Fixed
+- [Alex Coles] Ensure `#form_for`'s `values:` to accept `Hanami::Entity` instances
+- [Ksenia Zalesnaya & Marion Duprey] Ensure checkboxes to check/uncheck when a boolean is passed as value
+- [Paweł Świątkowski] Ensure `#format_number` to respect given precision
+
 ## v0.5.0 - 2016-11-15
 ### Added
 - [Marion Duprey] Allow `select` form helper to generate a multiple select (via `multiple: true` option)

data/hanami-helpers.gemspec

@@ -25,4 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler',  '~> 1.6'
   spec.add_development_dependency 'rake',     '~> 11'
   spec.add_development_dependency 'minitest', '~> 5.5'
+
+  spec.add_development_dependency 'dry-struct', '~> 0.1'
 end

data/lib/hanami/helpers/form_helper/form_builder.rb

@@ -718,7 +718,7 @@ module Hanami
         #   <%=
         #     # ...
         #     values = Hash['Italy' => 'it', 'United States' => 'us']
-        #     select :stores, values
+        #     select :store, values
         #   %>
         #
         #   # Output:
@@ -737,7 +737,7 @@ module Hanami
         #   <%=
         #     # ...
         #     values = Hash['it' => 'Italy', 'us' => 'United States']
-        #     select :stores, values
+        #     select :store, values
         #   %>
         #
         #   # Output:
@@ -750,7 +750,7 @@ module Hanami
         #   <%=
         #     # ...
         #     values = Hash['it' => 'Italy', 'us' => 'United States']
-        #     select :stores, values, options: {prompt: 'Select a store'}
+        #     select :store, values, options: {prompt: 'Select a store'}
         #   %>
         #
         #   # Output:
@@ -764,7 +764,7 @@ module Hanami
         #   <%=
         #     # ...
         #     values = Hash['it' => 'Italy', 'us' => 'United States']
-        #     select :stores, values, options: {selected: book.store}
+        #     select :store, values, options: {selected: book.store}
         #   %>
         #
         #   # Output:
@@ -1030,9 +1030,7 @@ module Hanami
             value: attributes.delete(:checked_value) || DEFAULT_CHECKED_VALUE
           }.merge(attributes)
 
-          value = _value(name)
-          attributes[:checked] = CHECKED if !value.nil? &&
-                                            (value == attributes[:value] || value.include?(attributes[:value]))
+          attributes[:checked] = CHECKED if _check_box_checked?(attributes[:value], _value(name))
 
           attributes
         end
@@ -1053,6 +1051,12 @@ module Hanami
         end
         # rubocop:enable Metrics/PerceivedComplexity
         # rubocop:enable Metrics/CyclomaticComplexity
+
+        def _check_box_checked?(value, input_value)
+          !input_value.nil? &&
+            (input_value.to_s == value.to_s || input_value.is_a?(TrueClass) ||
+            input_value.is_a?(Array) && input_value.include?(value))
+        end
       end
     end
   end

data/lib/hanami/helpers/form_helper/values.rb

@@ -48,8 +48,9 @@ module Hanami
           tail.each do |k|
             break if result.nil?
 
-            result = if result.respond_to?(k) # rubocop:disable Style/IfUnlessModifier
-                       result.public_send(k)
+            result = case result
+                     when Utils::Hash, ::Hash        then result[k]
+                     when ->(r) { r.respond_to?(k) } then result.public_send(k)
                      end
           end
 

data/lib/hanami/helpers/number_formatting_helper.rb

@@ -134,7 +134,7 @@ module Hanami
           @number = number
           @delimiter = options.fetch(:delimiter, DEFAULT_DELIMITER)
           @separator = options.fetch(:separator, DEFAULT_SEPARATOR)
-          @precision = options.fetch(:precision, DEFAULT_PRECISION)
+          @precision = options.fetch(:precision, nil)
         end
 
         # Format number according to the specified options
@@ -181,7 +181,12 @@ module Hanami
         # @since 0.2.0
         # @api private
         def to_str
-          to_number.to_s
+          number = to_number
+          if precision_requested_explicitly?
+            Kernel.format("%.#{precision}f", number)
+          else
+            number.to_s
+          end
         end
 
         # Numeric coercion
@@ -203,6 +208,26 @@ module Hanami
           end
         end
 
+        # Returns precision with a fallback to default value
+        #
+        # @return [Numeric] precision
+        #
+        # @since 1.0.0
+        # @api private
+        def precision
+          @precision || DEFAULT_PRECISION
+        end
+
+        # Checks if precision was requested in options
+        #
+        # @return [TrueClass,FalseClass] the result of the check
+        #
+        # @since 1.0.0
+        # @api private
+        def precision_requested_explicitly?
+          !@precision.nil?
+        end
+
         # Round number in case we need to return a <tt>Float</tt> representation.
         # If <tt>@number</tt> doesn't respond to <tt>#round</tt> return the number as it is.
         #
@@ -212,7 +237,7 @@ module Hanami
         # @api private
         def rounded_number
           if @number.respond_to?(:round)
-            @number.round(@precision)
+            @number.round(precision)
           else
             @number
           end

data/lib/hanami/helpers/version.rb

@@ -3,6 +3,6 @@ module Hanami
     # Define version
     #
     # @since 0.1.0
-    VERSION = '0.5.0'.freeze
+    VERSION = '0.5.1'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hanami-helpers
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Luca Guidi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-15 00:00:00.000000000 Z
+date: 2016-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hanami-utils
@@ -68,6 +68,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.5'
+- !ruby/object:Gem::Dependency
+  name: dry-struct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
 description: View helpers for Ruby applications
 email:
 - me@lucaguidi.com
@@ -118,7 +132,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Hanami helpers