hanami-controller 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f54bdf6d87a22221ce3dae2d7c17ceb8b8097fcc
-  data.tar.gz: 1a7108c3fcb857a3a6f5a84055f25afb144b65af
+  metadata.gz: 94316cf20a120464d9314f31c0ea0774d8256847
+  data.tar.gz: 0d468b04cc1ae458ee3d2cb1188adfae48e63402
 SHA512:
-  metadata.gz: 41cebc4b699df51ee187a0423ae9b062299cc374f24e0511defe3ec869aab0833b04044e10aacb0b7b96ff9416b7e975e99576b1d8afd4cef535f7047d5e2f4a
-  data.tar.gz: d852c7b7c2a3de1f9fdeb2b6a21d034bed9d61efdb0e1187a38e16a2addba194a40094c31f578d0674b6b1dd30a194b2c7e33e2ffd24fa45a58e8349de4c0675
+  metadata.gz: 68a1d9c7ae87c693fa7a9ac85ae15b0736bdd1de6dc02f21a9ef320a08f6f1f9b0fc3e99b88a92186c7e1ebc5ebf48cb52b914a400f655c1699b12bdb8bbe61b
+  data.tar.gz: b49bfaff6ee7d1150f1f1e99ea335948300d519c8522b200dc0b914ddc7a0d3f7ee9c9778fdc79abfa267998987aa65216f9f2488e09db2b9c1321bb5fc2b69b

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Hanami::Controller
 Complete, fast and testable actions for Rack
 
+## v0.8.1 - 2016-12-19
+### Fixed
+- [Thorbjørn Hermansen] Don't pollute Rack env's `rack.exception` key if an exception is handled
+- [Luca Guidi] Add `flash` to the default exposures
+
 ## v0.8.0 - 2016-11-15
 ### Added
 - [Marion Duprey] Allow `BaseParams#get` to read (nested) arrays

data/README.md

@@ -60,7 +60,7 @@ class Show
   include Hanami::Action
 
   def call(params)
-    @article = ArticleRepository.find params[:id]
+    @article = ArticleRepository.new.find(params[:id])
   end
 end
 ```
@@ -82,16 +82,16 @@ Imagine how **fast** the unit test could be.
 class Show
   include Hanami::Action
 
-  def initialize(repository = ArticleRepository)
+  def initialize(repository = ArticleRepository.new)
     @repository = repository
   end
 
   def call(params)
-    @article = @repository.find params[:id]
+    @article = @repository.find(params[:id])
   end
 end
 
-action = Show.new(MemoryArticleRepository)
+action = Show.new(MemoryArticleRepository.new)
 action.call({ id: 23 })
 ```
 
@@ -314,7 +314,7 @@ class Show
 
   # `params` in the method signature is optional
   def set_article(params)
-    @article = ArticleRepository.find params[:id]
+    @article = ArticleRepository.new.find(params[:id])
   end
 end
 ```
@@ -326,7 +326,7 @@ class Show
   include Hanami::Action
 
   before { ... } # do some authentication stuff
-  before { |params| @article = ArticleRepository.find params[:id] }
+  before { |params| @article = ArticleRepository.new.find(params[:id]) }
 
   def call(params)
   end
@@ -358,7 +358,7 @@ class Show
   handle_exception RecordNotFound => 404
 
   def call(params)
-    @article = ArticleRepository.find params[:id]
+    @article = ArticleRepository.new.find(params[:id])
   end
 end
 
@@ -399,7 +399,7 @@ class Show
   include Hanami::Action
 
   def call(params)
-    @article = ArticleRepository.find params[:id]
+    @article = ArticleRepository.new.find(params[:id])
   end
 end
 
@@ -425,7 +425,7 @@ module Articles
     end
 
     def call(params)
-      @article = ArticleRepository.find params[:id]
+      @article = ArticleRepository.new.find(params[:id])
     end
   end
 end
@@ -510,7 +510,7 @@ class Show
   include Hanami::Action
 
   def call(params)
-    DroidRepository.find(params[:id]) or not_found
+    DroidRepository.new.find(params[:id]) or not_found
   end
 
   private
@@ -993,10 +993,10 @@ The following examples are valid constructors:
 def initialize
 end
 
-def initialize(repository = ArticleRepository)
+def initialize(repository = ArticleRepository.new)
 end
 
-def initialize(repository: ArticleRepository)
+def initialize(repository: ArticleRepository.new)
 end
 
 def initialize(options = {})

data/lib/hanami/action/session.rb

@@ -26,7 +26,7 @@ module Hanami
       # @api private
       def self.included(action)
         action.class_eval do
-          _expose :session
+          _expose :session, :flash
         end
       end
 

data/lib/hanami/controller/configuration.rb

@@ -192,16 +192,7 @@ module Hanami
       #
       # @see Hanami::Controller::Configuration#handle_exception
       def exception_handler(exception)
-        handler = nil
-
-        @handled_exceptions.each do |exception_class, h|
-          if exception.kind_of?(exception_class)
-            handler = h
-            break
-          end
-        end
-
-        handler || DEFAULT_ERROR_CODE
+        exception_handler_for(exception) || DEFAULT_ERROR_CODE
       end
 
       # Check if the given exception is handled.
@@ -214,7 +205,23 @@ module Hanami
       # @see Hanami::Controller::Configuration#handle_exception
       def handled_exception?(exception)
         handled_exceptions &&
-          !!@handled_exceptions.fetch(exception.class) { false }
+          !exception_handler_for(exception).nil?
+      end
+
+      # Finds configured handler for given exception, or nil if not found.
+      #
+      # @param exception [Exception] an exception
+      #
+      # @since x.x.x
+      # @api private
+      #
+      # @see Hanami::Controller::Configuration#handle_exception
+      def exception_handler_for(exception)
+        @handled_exceptions.each do |exception_class, handler|
+          return handler if exception.kind_of?(exception_class)
+        end
+
+        nil
       end
 
       # Specify which is the default action module to be included when we use
@@ -318,7 +325,7 @@ module Hanami
       #
       #   Hanami::Controller.configure do
       #     prepare do
-      #       include Hanami::Action::Sessions
+      #       include Hanami::Action::Session
       #       include MyAuthentication
       #       use SomeMiddleWare
       #

data/lib/hanami/controller/version.rb

@@ -3,6 +3,6 @@ module Hanami
     # Defines the version
     #
     # @since 0.1.0
-    VERSION = '0.8.0'.freeze
+    VERSION = '0.8.1'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hanami-controller
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Luca Guidi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-15 00:00:00.000000000 Z
+date: 2016-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -154,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Complete, fast and testable actions for Rack and Hanami