hammer_cli_foreman 0.11.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5bbff81f4608f3747313bf8525acb14c1734db93
-  data.tar.gz: 9fe96408c5e413b1731c4196d1cb62c80895a20d
+  metadata.gz: d87fa149fc1614b767ea22dbb7035c5ce7885b8d
+  data.tar.gz: 95e857975d4178e6e75da2b50643f52b05ab3723
 SHA512:
-  metadata.gz: 080d7ba7ce6424c9bf4ff975e3d3bf63336cb565d96455fa4e07e317cc447eb52b8c5ede99de581c5026f259fb9e7f9943acc6dec41651137e732ae654639067
-  data.tar.gz: 94cbec39dca93447a6105586a948f2c5708b8dad4563731d5203ec303c579fa9612003d993eadc186a0e248e8976dae2b11cecc32ad83356339185ecec92fc25
+  metadata.gz: ebb86bc0b6cf8dfde731271567c1c6592fa4d37b59338e26e367bbb62b8ee60f091b2ba6fb1880721c4a5b0d3ce7382af210fe82ba57b94dc24ee2da4f13c6ff
+  data.tar.gz: 3249b9157df0f2f25417f62fb3268618edfbfdf4be50178675e70a16945f89dc255ffb8a4e4df144666a445eb74c8b1806379c8f3e2b1ffa67767f23a61bd3e3

data/doc/configuration.md

@@ -45,7 +45,7 @@ It's disabled by default. To turn it on, put following into your config file:
 :foreman:
   :use_sessions: true
 ```
-Unfortunately retry on session expiry is yet to be implemented. Therefore you'll observe first command to fail
-after the session expires.
+Please note that when you turn sessions on, the credentials stored in your config file will be ignored.
 
 The default session timeout is 1 hour. This can be changed in the Foreman: `Settings > Authentication > Idle timeout`
+When the session expires hammer will prompt for username and password again.

data/doc/name_id_resolution.md

@@ -15,6 +15,7 @@ ID resolution step by step
 
 `IdResolver` implements the method `<resource_name>_id(cli_options)` for each of the resources. Under the hood, the method:
 - returns `cli_options['option_id']` if it's not nil
+- returns HammerCLI::NilValue if the correspondent search option is set to HammerCLI::NilValue (i.e. NIL specified on CLI)
 - looks at `index` method's parameters, finds all required `*_id` params there and makes sure they're present (if not it tries to resolve them recursively)
 - extends the original options with a `search` field that searches for the name
 - calls the `index` method and returns the result
@@ -25,6 +26,15 @@ It can end up with an exception when:
 - the resource was not found
 - more resources were found
 
+Differences in resolution of list of id's
+-----------------------------------------
+
+the lookup method is called `<resource_name>_ids` and in addition:
+- returns `cli_options['option_ids']` if it's not nil
+- returns empty list (`[]`) when the search option is set to empty string or empty list 
+
+It also ends up with exception when any of the ids was not resolved.
+
 APIdoc requirements
 -------------------
 
@@ -46,5 +56,20 @@ Option builders should take care of all the requirements for you, but just for t
 Behaviour tuning
 ----------------
 
-Most of the resources are searchable by name. However there are exceptions that either don't have a name or offer more searchable fields. In such cases you have to update [the definition of searchable fields](https://github.com/theforeman/hammer-cli-foreman/blob/master/lib/hammer_cli_foreman/id_resolver.rb#L31).
+The resolution can be tuned at various levels.
+
+Most of the resources are searchable by name. However there are exceptions that either don't have a name 
+or offer more searchable fields. In such cases you have to update the definition 
+of searchable fields (SEARCHABLES) in [id_resolver](https://github.com/theforeman/hammer-cli-foreman/blob/master/lib/hammer_cli_foreman/id_resolver.rb).
+
+If you need to modify the lookup query (the `search` field) you can override the default one by adding a method 
+returning the correct lookup options to the resolver class.
+The method should be called according to the following schema: 
+- `create_<resource_name>_search_options(options)` for single id lookup (takes precedence over the next one for single id lookups) 
+- `create_<resource_plural_name>_search_options(options)` combine for single and/or multiple ids lookup 
+- `create_<resource_plural_name>_search_options(options, mode)` combined with extra parameter suggesting the lookup mode and being set to `:single`, `:multi` or `nil`
+
+For examples check the `id_resolver`.
 
+It is possible to completely override the resolution procedure by adding a method(s) called `<resource_name>_id` and/or `<resource_name>_ids` to the `id_resolver`.
+It will get the options hash as an input and expects `id` (list of `ids` respectively) or a `ResolverError` on its return.

data/doc/release_notes.md

@@ -1,6 +1,30 @@
 Release notes
 =============
 
+### 0.12.0 (2018-02-19)
+* Do not resolve already resolved id params ([#22517](http://projects.theforeman.org/issues/22517))
+* Generate --provision-method from apidoc ([#22552](http://projects.theforeman.org/issues/22552))
+* Review whitespace in extracted strings ([#7451](http://projects.theforeman.org/issues/7451))
+* Allow nil searchables ([#21768](http://projects.theforeman.org/issues/21768))
+* Fix typo for hostgroup in functional test ([#22094](http://projects.theforeman.org/issues/22094))
+* Rename add-override-value to add-matcher ([#12999](http://projects.theforeman.org/issues/12999))
+* Handle 400 bad request - concat response message ([#21627](http://projects.theforeman.org/issues/21627))
+* Make hammer host reports work ([#20742](http://projects.theforeman.org/issues/20742))
+* "unknown template kind" message translated ([#4573](http://projects.theforeman.org/issues/4573))
+* Add status for Void authenticator ([#20505](http://projects.theforeman.org/issues/20505))
+* Add show command for ssh-keys ([#20476](http://projects.theforeman.org/issues/20476))
+* Add org/loc in ptable info command ([#21264](http://projects.theforeman.org/issues/21264))
+* Create compute-resource VMware - URL optional ([#17568](http://projects.theforeman.org/issues/17568))
+* Test to expect integer params as a number ([#21013](http://projects.theforeman.org/issues/21013))
+* Add ssh-keys commands ([#20476](http://projects.theforeman.org/issues/20476))
+* Remove --include and --thin from host-hostgroup list ([#20754](http://projects.theforeman.org/issues/20754))
+* Added fields info to hostgroup/host info command ([#18750](http://projects.theforeman.org/issues/18750))
+* Don't store session_id for unauthorized responses ([#20575](http://projects.theforeman.org/issues/20575))
+* Owner Name is shown in hammer host info command ([#20709](http://projects.theforeman.org/issues/20709))
+* Show empty table field with ReferenceFormatter ([#20758](http://projects.theforeman.org/issues/20758))
+* Better logging of 403 responses ([#20120](http://projects.theforeman.org/issues/20120))
+* Update documentation for sessions ([#20315](http://projects.theforeman.org/issues/20315))
+
 ### 0.11.0 (2017-08-01)
 * Adding a list normalizer to override-value-order ([#17135](http://projects.theforeman.org/issues/17135))
 * Correctly reset taxonomies for overriding filters ([#20117](http://projects.theforeman.org/issues/20117))

data/lib/hammer_cli_foreman.rb

@@ -18,6 +18,7 @@ module HammerCLIForeman
   require 'hammer_cli_foreman/param_filters'
   require 'hammer_cli_foreman/id_resolver'
   require 'hammer_cli_foreman/dependency_resolver'
+  require 'hammer_cli_foreman/option_sources'
 
   begin
     require 'hammer_cli_foreman/commands'
@@ -27,119 +28,119 @@ module HammerCLIForeman
     require 'hammer_cli_foreman/common_parameter'
     require 'hammer_cli_foreman/defaults'
 
-    HammerCLI::MainCommand.lazy_subcommand('auth', _("Foreman connection login/logout."),
+    HammerCLI::MainCommand.lazy_subcommand('auth', _("Foreman connection login/logout"),
       'HammerCLIForeman::Auth', 'hammer_cli_foreman/auth'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('architecture', _("Manipulate architectures."),
+    HammerCLI::MainCommand.lazy_subcommand('architecture', _("Manipulate architectures"),
       'HammerCLIForeman::Architecture', 'hammer_cli_foreman/architecture'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('auth-source', _("Manipulate auth sources."),
+    HammerCLI::MainCommand.lazy_subcommand('auth-source', _("Manipulate auth sources"),
       'HammerCLIForeman::AuthSource', 'hammer_cli_foreman/auth_source'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('compute-resource', _("Manipulate compute resources."),
+    HammerCLI::MainCommand.lazy_subcommand('compute-resource', _("Manipulate compute resources"),
       'HammerCLIForeman::ComputeResource', 'hammer_cli_foreman/compute_resource'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('domain', _("Manipulate domains."),
+    HammerCLI::MainCommand.lazy_subcommand('domain', _("Manipulate domains"),
       'HammerCLIForeman::Domain', 'hammer_cli_foreman/domain'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('environment', _("Manipulate environments."),
+    HammerCLI::MainCommand.lazy_subcommand('environment', _("Manipulate environments"),
       'HammerCLIForeman::Environment', 'hammer_cli_foreman/environment'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('fact', _("Search facts."),
+    HammerCLI::MainCommand.lazy_subcommand('fact', _("Search facts"),
       'HammerCLIForeman::Fact', 'hammer_cli_foreman/fact'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('filter', _("Manage permission filters."),
+    HammerCLI::MainCommand.lazy_subcommand('filter', _("Manage permission filters"),
       'HammerCLIForeman::Filter', 'hammer_cli_foreman/filter'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('host', _("Manipulate hosts."),
+    HammerCLI::MainCommand.lazy_subcommand('host', _("Manipulate hosts"),
       'HammerCLIForeman::Host', 'hammer_cli_foreman/host'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('hostgroup', _("Manipulate hostgroups."),
+    HammerCLI::MainCommand.lazy_subcommand('hostgroup', _("Manipulate hostgroups"),
       'HammerCLIForeman::Hostgroup', 'hammer_cli_foreman/hostgroup'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('location', _("Manipulate locations."),
+    HammerCLI::MainCommand.lazy_subcommand('location', _("Manipulate locations"),
       'HammerCLIForeman::Location', 'hammer_cli_foreman/location'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('medium', _("Manipulate installation media."),
+    HammerCLI::MainCommand.lazy_subcommand('medium', _("Manipulate installation media"),
       'HammerCLIForeman::Medium', 'hammer_cli_foreman/media'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('model', _("Manipulate hardware models."),
+    HammerCLI::MainCommand.lazy_subcommand('model', _("Manipulate hardware models"),
       'HammerCLIForeman::Model', 'hammer_cli_foreman/model'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('os', _("Manipulate operating system."),
+    HammerCLI::MainCommand.lazy_subcommand('os', _("Manipulate operating system"),
       'HammerCLIForeman::OperatingSystem', 'hammer_cli_foreman/operating_system'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('organization', _("Manipulate organizations."),
+    HammerCLI::MainCommand.lazy_subcommand('organization', _("Manipulate organizations"),
       'HammerCLIForeman::Organization', 'hammer_cli_foreman/organization'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('partition-table', _("Manipulate partition tables."),
+    HammerCLI::MainCommand.lazy_subcommand('partition-table', _("Manipulate partition tables"),
       'HammerCLIForeman::PartitionTable', 'hammer_cli_foreman/partition_table'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('puppet-class', _("Search puppet modules."),
+    HammerCLI::MainCommand.lazy_subcommand('puppet-class', _("Search puppet modules"),
       'HammerCLIForeman::PuppetClass', 'hammer_cli_foreman/puppet_class'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('report', _("Browse and read reports."),
+    HammerCLI::MainCommand.lazy_subcommand('report', _("Browse and read reports"),
       'HammerCLIForeman::Report', 'hammer_cli_foreman/report'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('role', _("Manage user roles."),
+    HammerCLI::MainCommand.lazy_subcommand('role', _("Manage user roles"),
       'HammerCLIForeman::Role', 'hammer_cli_foreman/role'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('sc-param', _("Manipulate smart class parameters."),
+    HammerCLI::MainCommand.lazy_subcommand('sc-param', _("Manipulate smart class parameters"),
       'HammerCLIForeman::SmartClassParameter', 'hammer_cli_foreman/smart_class_parameter'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('smart-variable', _("Manipulate smart variables."),
+    HammerCLI::MainCommand.lazy_subcommand('smart-variable', _("Manipulate smart variables"),
       'HammerCLIForeman::SmartVariable', 'hammer_cli_foreman/smart_variable'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('proxy', _("Manipulate smart proxies."),
+    HammerCLI::MainCommand.lazy_subcommand('proxy', _("Manipulate smart proxies"),
       'HammerCLIForeman::SmartProxy', 'hammer_cli_foreman/smart_proxy'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('realm', _("Manipulate realms."),
+    HammerCLI::MainCommand.lazy_subcommand('realm', _("Manipulate realms"),
       'HammerCLIForeman::Realm', 'hammer_cli_foreman/realm'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('settings', _("Change server settings."),
+    HammerCLI::MainCommand.lazy_subcommand('settings', _("Change server settings"),
       'HammerCLIForeman::Settings', 'hammer_cli_foreman/settings'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('subnet', _("Manipulate subnets."),
+    HammerCLI::MainCommand.lazy_subcommand('subnet', _("Manipulate subnets"),
       'HammerCLIForeman::Subnet', 'hammer_cli_foreman/subnet'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('template', _("Manipulate config templates."),
+    HammerCLI::MainCommand.lazy_subcommand('template', _("Manipulate config templates"),
       'HammerCLIForeman::Template', 'hammer_cli_foreman/template'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('user', _("Manipulate users."),
+    HammerCLI::MainCommand.lazy_subcommand('user', _("Manipulate users"),
       'HammerCLIForeman::User', 'hammer_cli_foreman/user'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('user-group', _("Manage user groups."),
+    HammerCLI::MainCommand.lazy_subcommand('user-group', _("Manage user groups"),
       'HammerCLIForeman::Usergroup', 'hammer_cli_foreman/usergroup'
     )
 
-    HammerCLI::MainCommand.lazy_subcommand('config-group', _("Manipulate config groups."),
+    HammerCLI::MainCommand.lazy_subcommand('config-group', _("Manipulate config groups"),
       'HammerCLIForeman::ConfigGroup', 'hammer_cli_foreman/config_group'
     )
 

data/lib/hammer_cli_foreman/api/connection.rb

@@ -34,7 +34,7 @@ module HammerCLIForeman
         return @authenticator if @authenticator
 
         if ssl_cert_authentication?(settings) && !use_basic_auth?(settings)
-          @authenticator = VoidAuth.new
+          @authenticator = VoidAuth.new(_('Using certificate authentication.'))
         else
           if settings.get(:foreman, :use_sessions)
             @authenticator = InteractiveBasicAuth.new(

data/lib/hammer_cli_foreman/api/interactive_basic_auth.rb

@@ -14,7 +14,7 @@ module HammerCLIForeman
       def error(ex)
         if ex.is_a?(RestClient::Unauthorized)
           self.clear
-          return UnauthorizedError.new(_("Invalid username or password"))
+          return UnauthorizedError.new(_("Invalid username or password."))
         end
       end
 
@@ -42,11 +42,11 @@ module HammerCLIForeman
       private
 
       def get_user
-        @user ||= ask_user(_("[Foreman] Username: "))
+        @user ||= ask_user(_("[Foreman] Username:%s") % " ")
       end
 
       def get_password
-        @password ||= ask_user(_("[Foreman] Password for %s: ") % @user, true)
+        @password ||= ask_user(_("[Foreman] Password for %{user}:%{wsp}") % {:user => @user, :wsp => " "}, true)
       end
 
       def ask_user(prompt, silent=false)

data/lib/hammer_cli_foreman/api/session_authenticator_wrapper.rb

@@ -5,6 +5,8 @@ module HammerCLIForeman
     class SessionAuthenticatorWrapper < ApipieBindings::Authenticators::Base
       SESSION_STORAGE = '~/.hammer/sessions/'
 
+      attr_reader :session_id
+
       def initialize(authenticator, url, storage_dir = nil)
         @authenticator = authenticator
         @url = url
@@ -23,7 +25,7 @@ module HammerCLIForeman
 
       def status
         if load_session
-          _("Session exists, currently logged in as '%s'") % @user
+          _("Session exists, currently logged in as '%s'.") % @user
         else
           _("Using sessions, you are currently not logged in.")
         end
@@ -58,10 +60,10 @@ module HammerCLIForeman
         load_session
         if ex.is_a?(RestClient::Unauthorized) && !@session_id.nil?
           if @user_changed
-            return UnauthorizedError.new(_("Invalid username or password, continuing with session for '%s'") % @user)
+            return UnauthorizedError.new(_("Invalid username or password, continuing with session for '%s'.") % @user)
           else
             destroy_session
-            return SessionExpired.new(_("Session has expired"))
+            return SessionExpired.new(_("Session has expired."))
           end
         else
           return @authenticator.error(ex)
@@ -69,8 +71,8 @@ module HammerCLIForeman
       end
 
       def response(r)
-        @session_id = r.cookies['_session_id']
-        if (@session_id && r.code != 401)
+        if (r.cookies['_session_id'] && r.code != 401)
+          @session_id = r.cookies['_session_id']
           save_session(@session_id, @authenticator.user)
         end
         @authenticator.response(r)
@@ -102,7 +104,7 @@ module HammerCLIForeman
         end
       rescue JSON::ParserError
         destroy_session
-        warn _('Invalid session file format')
+        warn _('Invalid session file format.')
         nil
       end
 
@@ -130,7 +132,7 @@ module HammerCLIForeman
         return true unless File.exist?(file)
         mode = File.stat(file).mode.to_s(8)
         if mode != expected_mode
-          warn _("Invalid permissions for %{file}: %{mode}, expected %{expected_mode}") % {
+          warn _("Invalid permissions for %{file}: %{mode}, expected %{expected_mode}.") % {
             :mode => mode,
             :expected_mode => expected_mode,
             :file => file
@@ -144,4 +146,3 @@ module HammerCLIForeman
     end
   end
 end
-

data/lib/hammer_cli_foreman/api/void_auth.rb

@@ -3,6 +3,13 @@ require 'highline/import'
 module HammerCLIForeman
   module Api
     class VoidAuth < ApipieBindings::Authenticators::Base
+      def initialize(message)
+        @message = message
+      end
+
+      def status
+        @message
+      end
     end
   end
 end

data/lib/hammer_cli_foreman/architecture.rb

@@ -28,7 +28,7 @@ module HammerCLIForeman
 
 
     class CreateCommand < HammerCLIForeman::CreateCommand
-      success_message _("Architecture created")
+      success_message _("Architecture created.")
       failure_message _("Could not create the architecture")
 
       build_options
@@ -36,7 +36,7 @@ module HammerCLIForeman
 
 
     class DeleteCommand < HammerCLIForeman::DeleteCommand
-      success_message _("Architecture deleted")
+      success_message _("Architecture deleted.")
       failure_message _("Could not delete the architecture")
 
       build_options
@@ -44,7 +44,7 @@ module HammerCLIForeman
 
 
     class UpdateCommand < HammerCLIForeman::UpdateCommand
-      success_message _("Architecture updated")
+      success_message _("Architecture updated.")
       failure_message _("Could not update the architecture")
 
       build_options
@@ -56,5 +56,3 @@ module HammerCLIForeman
   end
 
 end
-
-

data/lib/hammer_cli_foreman/associating_commands.rb

@@ -40,7 +40,7 @@ module HammerCLIForeman
         associated_resource :hostgroups
         desc _("Associate a hostgroup")
 
-        success_message _("The hostgroup has been associated")
+        success_message _("The hostgroup has been associated.")
         failure_message _("Could not associate the hostgroup")
       end
 
@@ -48,7 +48,7 @@ module HammerCLIForeman
         associated_resource :hostgroups
         desc _("Disassociate a hostgroup")
 
-        success_message _("The hostgroup has been disassociated")
+        success_message _("The hostgroup has been disassociated.")
         failure_message _("Could not disassociate the hostgroup")
       end
     end
@@ -60,7 +60,7 @@ module HammerCLIForeman
         associated_resource :environments
         desc _("Associate an environment")
 
-        success_message _("The environment has been associated")
+        success_message _("The environment has been associated.")
         failure_message _("Could not associate the environment")
       end
 
@@ -68,7 +68,7 @@ module HammerCLIForeman
         associated_resource :environments
         desc _("Disassociate an environment")
 
-        success_message _("The environment has been disassociated")
+        success_message _("The environment has been disassociated.")
         failure_message _("Could not disassociate the environment")
       end
     end
@@ -80,7 +80,7 @@ module HammerCLIForeman
         associated_resource :domains
         desc _("Associate a domain")
 
-        success_message _("The domain has been associated")
+        success_message _("The domain has been associated.")
         failure_message _("Could not associate the domain")
       end
 
@@ -88,7 +88,7 @@ module HammerCLIForeman
         associated_resource :domains
         desc _("Disassociate a domain")
 
-        success_message _("The domain has been disassociated")
+        success_message _("The domain has been disassociated.")
         failure_message _("Could not disassociate the domain")
       end
     end
@@ -100,7 +100,7 @@ module HammerCLIForeman
         associated_resource :media
         desc _("Associate a medium")
 
-        success_message _("The medium has been associated")
+        success_message _("The medium has been associated.")
         failure_message _("Could not associate the medium")
       end
 
@@ -108,7 +108,7 @@ module HammerCLIForeman
         associated_resource :media
         desc _("Disassociate a medium")
 
-        success_message _("The medium has been disassociated")
+        success_message _("The medium has been disassociated.")
         failure_message _("Could not disassociate the medium")
       end
     end
@@ -120,7 +120,7 @@ module HammerCLIForeman
         associated_resource :subnets
         desc _("Associate a subnet")
 
-        success_message _("The subnet has been associated")
+        success_message _("The subnet has been associated.")
         failure_message _("Could not associate the subnet")
       end
 
@@ -128,7 +128,7 @@ module HammerCLIForeman
         associated_resource :subnets
         desc _("Disassociate a subnet")
 
-        success_message _("The subnet has been disassociated")
+        success_message _("The subnet has been disassociated.")
         failure_message _("Could not disassociate the subnet")
       end
     end
@@ -140,7 +140,7 @@ module HammerCLIForeman
         associated_resource :compute_resources
         desc _("Associate a compute resource")
 
-        success_message _("The compute resource has been associated")
+        success_message _("The compute resource has been associated.")
         failure_message _("Could not associate the compute resource")
       end
 
@@ -148,7 +148,7 @@ module HammerCLIForeman
         associated_resource :compute_resources
         desc _("Disassociate a compute resource")
 
-        success_message _("The compute resource has been disassociated")
+        success_message _("The compute resource has been disassociated.")
         failure_message _("Could not disassociate the compute resource")
       end
     end
@@ -160,7 +160,7 @@ module HammerCLIForeman
         associated_resource :smart_proxies
         desc _("Associate a smart proxy")
 
-        success_message _("The smart proxy has been associated")
+        success_message _("The smart proxy has been associated.")
         failure_message _("Could not associate the smart proxy")
 
         def associated_resource_name
@@ -172,7 +172,7 @@ module HammerCLIForeman
         associated_resource :smart_proxies
         desc _("Disassociate a smart proxy")
 
-        success_message _("The smart proxy has been disassociated")
+        success_message _("The smart proxy has been disassociated.")
         failure_message _("Could not disassociate the smart proxy")
 
         def associated_resource_name
@@ -188,7 +188,7 @@ module HammerCLIForeman
         associated_resource :users
         desc _("Associate an user")
 
-        success_message _("The user has been associated")
+        success_message _("The user has been associated.")
         failure_message _("Could not associate the user")
       end
 
@@ -196,7 +196,7 @@ module HammerCLIForeman
         associated_resource :users
         desc _("Disassociate an user")
 
-        success_message _("The user has been disassociated")
+        success_message _("The user has been disassociated.")
         failure_message _("Could not disassociate the user")
       end
     end
@@ -210,7 +210,7 @@ module HammerCLIForeman
 
         command_name 'add-user-group'
 
-        success_message _("The user group has been associated")
+        success_message _("The user group has been associated.")
         failure_message _("Could not associate the user group")
       end
 
@@ -220,7 +220,7 @@ module HammerCLIForeman
 
         command_name 'remove-user-group'
 
-        success_message _("The user group has been disassociated")
+        success_message _("The user group has been disassociated.")
         failure_message _("Could not disassociate the user group")
       end
     end
@@ -232,7 +232,7 @@ module HammerCLIForeman
         associated_resource :config_templates
         desc _("Associate a configuration template")
 
-        success_message _("The configuration template has been associated")
+        success_message _("The configuration template has been associated.")
         failure_message _("Could not associate the configuration template")
       end
 
@@ -240,7 +240,7 @@ module HammerCLIForeman
         associated_resource :config_templates
         desc _("Disassociate a configuration template")
 
-        success_message _("The configuration template has been disassociated")
+        success_message _("The configuration template has been disassociated.")
         failure_message _("Could not disassociate the configuration template")
       end
     end
@@ -252,7 +252,7 @@ module HammerCLIForeman
         associated_resource :organizations
         desc _("Associate an organization")
 
-        success_message _("The organization has been associated")
+        success_message _("The organization has been associated.")
         failure_message _("Could not associate the organization")
       end
 
@@ -260,7 +260,7 @@ module HammerCLIForeman
         associated_resource :organizations
         desc _("Disassociate an organization")
 
-        success_message _("The organization has been disassociated")
+        success_message _("The organization has been disassociated.")
         failure_message _("Could not disassociate the organization")
       end
     end
@@ -272,7 +272,7 @@ module HammerCLIForeman
         associated_resource :operatingsystems
         desc _("Associate an operating system")
 
-        success_message _("Operating system has been associated")
+        success_message _("Operating system has been associated.")
         failure_message _("Could not associate the operating system")
       end
 
@@ -281,7 +281,7 @@ module HammerCLIForeman
         associated_resource :operatingsystems
         desc _("Disassociate an operating system")
 
-        success_message _("Operating system has been disassociated")
+        success_message _("Operating system has been disassociated.")
         failure_message _("Could not disassociate the operating system")
       end
     end
@@ -293,7 +293,7 @@ module HammerCLIForeman
         associated_resource :architectures
         desc _("Associate an architecture")
 
-        success_message _("Architecture has been associated")
+        success_message _("Architecture has been associated.")
         failure_message _("Could not associate the architecture")
       end
 
@@ -302,7 +302,7 @@ module HammerCLIForeman
         associated_resource :architectures
         desc _("Disassociate an architecture")
 
-        success_message _("Architecture has been disassociated")
+        success_message _("Architecture has been disassociated.")
         failure_message _("Could not disassociate the architecture")
       end
     end
@@ -314,7 +314,7 @@ module HammerCLIForeman
         associated_resource :ptables
         desc _("Associate a partition table")
 
-        success_message _("Partition table has been associated")
+        success_message _("Partition table has been associated.")
         failure_message _("Could not associate the partition table")
       end
 
@@ -323,7 +323,7 @@ module HammerCLIForeman
         associated_resource :ptables
         desc _("Disassociate a partition table")
 
-        success_message _("Partition table has been disassociated")
+        success_message _("Partition table has been disassociated.")
         failure_message _("Could not disassociate the partition table")
       end
     end
@@ -335,7 +335,7 @@ module HammerCLIForeman
         associated_resource :roles
         desc _("Assign a user role")
 
-        success_message _("User role has been assigned")
+        success_message _("User role has been assigned.")
         failure_message _("Could not assign the user role")
       end
 
@@ -344,7 +344,7 @@ module HammerCLIForeman
         associated_resource :roles
         desc _("Remove a user role")
 
-        success_message _("User role has been removed")
+        success_message _("User role has been removed.")
         failure_message _("Could not remove the user role")
       end
     end
@@ -356,7 +356,7 @@ module HammerCLIForeman
         associated_resource :locations
         desc _("Associate a location")
 
-        success_message _("The location has been associated")
+        success_message _("The location has been associated.")
         failure_message _("Could not associate the location")
       end
 
@@ -364,7 +364,7 @@ module HammerCLIForeman
         associated_resource :locations
         desc _("Disassociate a location")
 
-        success_message _("The location has been disassociated")
+        success_message _("The location has been disassociated.")
         failure_message _("Could not disassociate the location")
       end
     end