haml_lint 0.61.1 → 0.62.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61b19bf998b26f91fc8ea0578a3e189b8edb1d3c31a942c873e1e895747bcd82
-  data.tar.gz: 66b19273123ec6618faade749c390ded3e5ccdb608e2f64b43a4def9f575a298
+  metadata.gz: 3754327462146047a8677d8e91b7d47e3d538f2459f2d3ebd583ad2dafc92c3b
+  data.tar.gz: 33ccb58e67c32798c90da242cc8708e763f93a1509c6083d54b351453f587a5f
 SHA512:
-  metadata.gz: c279dc5f30fa736cfac959aedfd8dec1bf7e5e25b1a0508989ce1276afa5d8b4ddd802f9a139ab48b773a1a0e4d9f9bd91e599cf63700e3eea383cbfa7407bc4
-  data.tar.gz: 88a18703c06bcc0b95e0072d3ca0e3970302d7807bba29bcb05d2ad8f43dcbf184d76015dc13924d41e7acfcd36762cd6c0eefe3e46d58eae4d26dd8ef2cae2a
+  metadata.gz: 8a9ece6eda4dac35772948661486fc6c4fada9d3071b8b4ff52d37bab8930d032d0138a95f59a1a54c760951001010102317965e11aea2fd6dec4a35c7528aac
+  data.tar.gz: 67d13e3d045dd804f7f93c662dd8dfb833ac8104a2c52bd1699ba9201861630e686228de725ede55d469a9b3c15a02fcf0b910b843c3d425314e59721ae01ba0

data/lib/haml_lint/linter/strict_locals.rb

@@ -14,12 +14,16 @@ module HamlLint
     def visit_root(root)
       return unless enabled?(root)
 
-      first_child = root.children.first
-      return if first_child.is_a?(HamlLint::Tree::HamlCommentNode) &&
-                    first_child.is_strict_locals?
+      # Rails technically allows the comment to be anywhere in the file,
+      # but as a best practice they should be at the top of the file.
+      # https://guides.rubyonrails.org/action_view_overview.html#strict-locals
+      # https://github.com/rails/rails/blob/v8.0.2/actionview/lib/action_view/template.rb#L368
+      found =
+        root.children
+            .take_while { |child| child.is_a?(HamlLint::Tree::HamlCommentNode) }
+            .any?(&:is_strict_locals?)
 
-      # Check whether this linter is disabled by a comment
-      return if first_child.disabled?(self)
+      return if found
 
       record_lint(DummyNode.new(1), failure_message)
     end
@@ -31,7 +35,11 @@ module HamlLint
     # @api private
     # @return [true, false]
     def enabled?(root)
-      matcher.match(File.basename(root.file)) ? true : false
+      return false unless matcher.match(File.basename(root.file))
+
+      # This linter can also be disabled by a comment at the top of the file
+      first_child = root.children.first
+      first_child.nil? || !first_child.disabled?(self)
     end
 
     # The type of files the linter is configured to check.

data/lib/haml_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module HamlLint
-  VERSION = '0.61.1'
+  VERSION = '0.62.0'
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: haml_lint
 version: !ruby/object:Gem::Version
-  version: 0.61.1
+  version: 0.62.0
 platform: ruby
 authors:
 - Shane da Silva
 bindir: bin
 cert_chain: []
-date: 2025-03-20 00:00:00.000000000 Z
+date: 2025-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: haml