haml_lint 0.28.0 → 0.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de1778be09762f2f6e9205045f63a6bfbc1966f1bc848e57c5bc22a52a8c0488
-  data.tar.gz: ecb4cc40e34424ba773dec9b252ef7618f60b9a14e63d7afba68164f41d49681
+  metadata.gz: a2b6e2913e09e73c44c78189a5766b3b30bb8999c010a61729843f038fdd6b72
+  data.tar.gz: 4b59c4427a7bf35b2f90eb03f4fe5c89fb4b6046cdedde5b2bc6137cca1b265d
 SHA512:
-  metadata.gz: 7cdf82866d301aa55ba5891d364030f6657dcd492118be4bc06933a3158c88bb45d088fcdc6a0e60e72a983271781f5c1ab515aef5e9eff2b2a82ea23ef16cc1
-  data.tar.gz: 68ae9a3bd3c9d7c2d3514577aae4513b755479b4c63c7fc08bfd5f45a8cbb1dd5495e4d2dd7f071988e3d8b84bb44959577786860b2f4c2eb5118f2e6257bd8b
+  metadata.gz: d1dc05e7ce0d8b5ad2cb268159ad51894f1bf17c883d3f23af222b8754f3d24fdbd73368466b55ceda9d587bf457b7961180818971d482110bbc0ad0cfb7f874
+  data.tar.gz: bc1553ea5bd67ee4d19e56ff7ed34fea91f4c286d2a8f09419ccae1ae19da7469c917d2a297e21b5b6e3bf8ad4457b3301c7c7282aca81c1a88102ff0c7fa931

data/bin/haml-lint

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'haml_lint'
 require 'haml_lint/cli'

data/config/default.yml

@@ -91,6 +91,7 @@ linters:
       - Lint/BlockAlignment
       - Lint/EndAlignment
       - Lint/Void
+      - Layout/AlignHash
       - Layout/AlignParameters
       - Layout/ElseAlignment
       - Layout/EndOfLine

data/lib/haml_lint/adapter/haml_4.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   class Adapter
     # Adapts the Haml::Parser from Haml 4 for use in HamlLint

data/lib/haml_lint/adapter/haml_5.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   class Adapter
     # Adapts the Haml::Parser from Haml 5 for use in HamlLint

data/lib/haml_lint/adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/adapter/haml_4'
 require 'haml_lint/adapter/haml_5'
 require 'haml_lint/exceptions'

data/lib/haml_lint/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint'
 require 'haml_lint/options'
 
@@ -21,8 +23,8 @@ module HamlLint
     def run(args)
       options = HamlLint::Options.new.parse(args)
       act_on_options(options)
-    rescue StandardError => exception
-      handle_exception(exception)
+    rescue StandardError => e
+      handle_exception(e)
     end
 
     private
@@ -92,7 +94,7 @@ module HamlLint
     # @return [HamlLint::Reporter]
     def reporter_from_options(options)
       if options[:auto_gen_config]
-        HamlLint::Reporter::DisabledConfigReporter.new(log)
+        HamlLint::Reporter::DisabledConfigReporter.new(log, limit: options[:auto_gen_exclude_limit] || 15) # rubocop:disable Metrics/LineLength
       else
         options.fetch(:reporter, HamlLint::Reporter::DefaultReporter).new(log)
       end

data/lib/haml_lint/comment_configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Determines what linters are enabled or disabled via comments.
   class CommentConfiguration

data/lib/haml_lint/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Stores runtime configuration for the application.
   #

data/lib/haml_lint/configuration_loader.rb

@@ -6,24 +6,34 @@ require 'yaml'
 module HamlLint
   # Manages configuration file loading.
   class ConfigurationLoader
-    AUTO_GENERATED_FILE = '.haml-lint_todo.yml'.freeze
+    AUTO_GENERATED_FILE = '.haml-lint_todo.yml'
     DEFAULT_CONFIG_PATH = File.join(HamlLint::HOME, 'config', 'default.yml').freeze
-    CONFIG_FILE_NAME = '.haml-lint.yml'.freeze
+    CONFIG_FILE_NAME = '.haml-lint.yml'
 
     class << self
       # Load configuration file given the current working directory the
       # application is running within.
-      def load_applicable_config
-        directory = File.expand_path(Dir.pwd)
-        config_file = possible_config_files(directory).find(&:file?)
-
+      # @param config_file [String] optional path to the config file to load
+      # @param options [Hash]
+      # @option options :exclude_files [Array<String>] files that should not
+      #   be loaded even if they're requested via inherits_from
+      # @return [HamlLint::Configuration]
+      def load_applicable_config(config_file = nil, options = {})
+        config_file ||= default_path_to_config
         if config_file
-          load_file(config_file.to_path)
+          load_file(config_file, options)
         else
           default_configuration
         end
       end
 
+      # Path to the default config file, if it exists
+      def default_path_to_config
+        directory = File.expand_path(Dir.pwd)
+        config_file = possible_config_files(directory).find(&:file?)
+        config_file ? config_file.to_path : nil
+      end
+
       # Loads the built-in default configuration.
       def default_configuration
         @default_configuration ||= load_from_file(DEFAULT_CONFIG_PATH)
@@ -32,18 +42,23 @@ module HamlLint
       # Loads a configuration, ensuring it extends the default configuration.
       #
       # @param file [String]
-      # @param loaded_files [Array<String>] any previously loaded files in an
-      #   inheritance chain
+      # @param context [Hash]
+      # @option context :loaded_files [Array<String>] any previously loaded
+      #   files in an inheritance chain
+      # @option context :exclude_files [Array<String>] files that should not
+      #   be loaded even if they're requested via inherits_from
       # @return [HamlLint::Configuration]
-      def load_file(file, loaded_files = [])
+      def load_file(file, context = {})
+        context[:loaded_files] ||= []
+        context[:exclude_files] ||= []
         config = load_from_file(file)
 
-        [default_configuration, resolve_inheritance(config, loaded_files), config]
+        [default_configuration, resolve_inheritance(config, context), config]
           .reduce { |acc, elem| acc.merge(elem) }
-      rescue Psych::SyntaxError, Errno::ENOENT => error
+      rescue Psych::SyntaxError, Errno::ENOENT => e
         raise HamlLint::Exceptions::ConfigurationError,
-              "Unable to load configuration from '#{file}': #{error}",
-              error.backtrace
+              "Unable to load configuration from '#{file}': #{e}",
+              e.backtrace
       end
 
       # Creates a configuration from the specified hash, ensuring it extends the
@@ -97,12 +112,13 @@ module HamlLint
       # @param loaded_files [Array<String>] previously loaded files in the
       #   inheritance chain
       # @return [HamlLint::Configuration, nil]
-      def resolve(file, loaded_files)
+      def resolve(file, context)
         return unless File.exist?(file)
-        return if loaded_files.include?(file)
+        return if context[:loaded_files].include?(file)
+        return if context[:exclude_files].include?(file)
 
-        loaded_files << file
-        load_file(file, loaded_files)
+        context[:loaded_files] << file
+        load_file(file, context)
       end
 
       # Resolves the chain of `inherits_from` directives in a configuration.
@@ -111,9 +127,9 @@ module HamlLint
       # @param loaded_files [Array<String>] any previously loaded files in an
       #   inheritance chain
       # @return [HamlLint::Configuration]
-      def resolve_inheritance(config, loaded_files)
+      def resolve_inheritance(config, context)
         Array(config['inherits_from'])
-          .map { |config_file| resolve(config_file, loaded_files) }
+          .map { |config_file| resolve(config_file, context) }
           .compact
           .reduce { |acc, elem| acc.merge(elem) } || config
       end

data/lib/haml_lint/constants.rb

@@ -3,8 +3,8 @@
 # Global application constants.
 module HamlLint
   HOME = File.expand_path(File.join(File.dirname(__FILE__), '..', '..')).freeze
-  APP_NAME = 'haml-lint'.freeze
+  APP_NAME = 'haml-lint'
 
-  REPO_URL = 'https://github.com/brigade/haml-lint'.freeze
-  BUG_REPORT_URL = "#{REPO_URL}/issues".freeze
+  REPO_URL = 'https://github.com/sds/haml-lint'
+  BUG_REPORT_URL = "#{REPO_URL}/issues"
 end

data/lib/haml_lint/directive.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Handles linter configuration transformation via Haml comments.
   class Directive
-    LINTER_REGEXP = /(?:[A-Z]\w+)/
+    LINTER_REGEXP = /(?:[A-Z]\w+)/.freeze
 
     DIRECTIVE_REGEXP = /
       # "haml-lint:" with optional spacing
@@ -12,7 +14,7 @@ module HamlLint
 
       # "all" or a comma-separated list (with optional spaces) of linters
       (?<linters>all | (?:#{LINTER_REGEXP}\s*,\s*)* #{LINTER_REGEXP})
-    /x
+    /x.freeze
 
     # Constructs a directive from source code as a given line.
     #

data/lib/haml_lint/document.rb

@@ -6,7 +6,7 @@ module HamlLint
   # Represents a parsed Haml document and its associated metadata.
   class Document
     # File name given to source code parsed from just a string.
-    STRING_SOURCE = '(string)'.freeze
+    STRING_SOURCE = '(string)'
 
     # @return [HamlLint::Configuration] Configuration used to parse template
     attr_reader :config
@@ -46,8 +46,8 @@ module HamlLint
       @source_lines = @source.split(/\r\n|\r|\n/)
 
       @tree = process_tree(HamlLint::Adapter.detect_class.new(@source).parse)
-    rescue Haml::Error => ex
-      error = HamlLint::Exceptions::ParseError.new(ex.message, ex.line)
+    rescue Haml::Error => e
+      error = HamlLint::Exceptions::ParseError.new(e.message, e.line)
       raise error
     end
 

data/lib/haml_lint/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Collection of exceptions that can be raised by the HAML Lint application.
 module HamlLint::Exceptions
   # Raised when a {Configuration} could not be loaded from a file.

data/lib/haml_lint/file_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'find'
 
 module HamlLint

data/lib/haml_lint/haml_visitor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Provides an interface which when included allows a class to visit nodes in
   # the parse tree of a HAML document.

data/lib/haml_lint/lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Contains information about a problem or issue with a HAML document.
   class Lint

data/lib/haml_lint/linter/alignment_tabs.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for tabs that are placed for alignment of tag content
   class Linter::AlignmentTabs < Linter
-    REGEX = /[^\s*]\t+/
+    REGEX = /[^\s*]\t+/.freeze
 
     def visit_tag(node)
-      if REGEX.match(node.source_code)
+      if REGEX.match?(node.source_code)
         record_lint(node, 'Avoid using tabs for alignment')
       end
     end

data/lib/haml_lint/linter/alt_text.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for missing `alt` attributes on `img` tags.
   class Linter::AltText < Linter

data/lib/haml_lint/linter/class_attribute_with_static_value.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for class attributes defined in tag attribute hash with static
   # values.
@@ -18,7 +20,7 @@ module HamlLint
 
     STATIC_TYPES = %i[str sym].freeze
 
-    VALID_CLASS_REGEX = /^-?[_a-zA-Z]+[_a-zA-Z0-9-]*$/
+    VALID_CLASS_REGEX = /^-?[_a-zA-Z]+[_a-zA-Z0-9-]*$/.freeze
 
     def visit_tag(node)
       return unless contains_class_attribute?(node.dynamic_attributes_sources)

data/lib/haml_lint/linter/classes_before_ids.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks that classes are listed before IDs in tags.
   class Linter::ClassesBeforeIds < Linter
@@ -9,7 +11,7 @@ module HamlLint
       '#' => :id,
     }.freeze
 
-    MSG = '%s should be listed before %s (%s should precede %s)'.freeze
+    MSG = '%s should be listed before %s (%s should precede %s)'
 
     def visit_tag(node)
       # Convert ".class#id" into [.class, #id] (preserving order)

data/lib/haml_lint/linter/consecutive_comments.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for multiple lines of code comments that can be condensed.
   class Linter::ConsecutiveComments < Linter

data/lib/haml_lint/linter/consecutive_silent_scripts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for multiple consecutive silent script markers that could be
   # condensed into a :ruby filter block.

data/lib/haml_lint/linter/empty_object_reference.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for empty object references (e.g. `%div[]`).
   class Linter::EmptyObjectReference < Linter

data/lib/haml_lint/linter/empty_script.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for empty scripts.
   class Linter::EmptyScript < Linter

data/lib/haml_lint/linter/final_newline.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for final newlines at the end of a file.
   class Linter::FinalNewline < Linter

data/lib/haml_lint/linter/html_attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for the setting of attributes via HTML shorthand syntax on elements
   # (e.g. `%tag(lang=en)`).

data/lib/haml_lint/linter/id_names.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for `id` attributes in specific cases on tags.
   class Linter::IdNames < Linter

data/lib/haml_lint/linter/implicit_div.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for unnecessary uses of the `%div` prefix where a class name or ID
   # already implies a div.

data/lib/haml_lint/linter/indentation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks the character used for indentation.
   class Linter::Indentation < Linter
@@ -9,7 +11,7 @@ module HamlLint
       tab: /^\t*(?![ ])/,
     }.freeze
 
-    LEADING_SPACES_REGEX = /^( +)(?! )/
+    LEADING_SPACES_REGEX = /^( +)(?! )/.freeze
 
     def visit_root(root)
       character = config['character'].to_sym

data/lib/haml_lint/linter/inline_styles.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Detects use of inline `style` attributes on any tag
   class Linter::InlineStyles < Linter
     include LinterRegistry
 
-    MESSAGE = 'Do not use inline style attributes'.freeze
+    MESSAGE = 'Do not use inline style attributes'
 
     def visit_tag(node)
       if node.has_hash_attribute?(:style)

data/lib/haml_lint/linter/instance_variables.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for the presence of instance variables
   class Linter::InstanceVariables < Linter

data/lib/haml_lint/linter/leading_comment_space.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for comments that don't have a leading space.
   class Linter::LeadingCommentSpace < Linter
@@ -6,7 +8,7 @@ module HamlLint
     def visit_haml_comment(node)
       # Skip if the node spans multiple lines starting on the second line,
       # or starts with a space
-      return if node.text =~ /\A(\s*|\s+\S.*)$/
+      return if node.text =~ /\A#*(\s*|\s+\S.*)$/
 
       record_lint(node, 'Comment should have a space after the `#`')
     end

data/lib/haml_lint/linter/line_length.rb

@@ -10,7 +10,7 @@ module HamlLint
     # @api private
     DummyNode = Struct.new(:line)
 
-    MSG = 'Line is too long. [%d/%d]'.freeze
+    MSG = 'Line is too long. [%d/%d]'
 
     def visit_root(root)
       max_length = config['max']

data/lib/haml_lint/linter/multiline_pipe.rb

@@ -6,7 +6,7 @@ module HamlLint
     include LinterRegistry
 
     MESSAGE = "Don't use the `|` character to split up lines. " \
-              'Wrap on commas or extract code into helper.'.freeze
+              'Wrap on commas or extract code into helper.'
 
     def visit_tag(node)
       check(node)
@@ -31,7 +31,7 @@ module HamlLint
 
     private
 
-    MULTILINE_PIPE_REGEX = /\s+\|\s*$/
+    MULTILINE_PIPE_REGEX = /\s+\|\s*$/.freeze
 
     def line_text_for_node(node)
       document.source_lines[node.line - 1]

data/lib/haml_lint/linter/multiline_script.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks scripts spread over multiple lines.
   class Linter::MultilineScript < Linter

data/lib/haml_lint/linter/object_reference_attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for uses of the object reference syntax for assigning the class and
   # ID attributes for an element (e.g. `%div[@user]`).

data/lib/haml_lint/linter/repeated_id.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Detects repeated instances of an element ID in a file
   class Linter::RepeatedId < Linter
     include LinterRegistry
 
-    MESSAGE_FORMAT = %{Do not repeat id "#%s" on the page}.freeze
+    MESSAGE_FORMAT = %{Do not repeat id "#%s" on the page}
 
     def visit_root(_node)
       @id_map = Hash.new { |hash, key| hash[key] = [] }

data/lib/haml_lint/linter/rubocop.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/ruby_extractor'
 require 'rubocop'
 

data/lib/haml_lint/linter/ruby_comments.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for Ruby comments that can be written as HAML comments.
   class Linter::RubyComments < Linter

data/lib/haml_lint/linter/space_before_script.rb

@@ -5,7 +5,7 @@ module HamlLint
   class Linter::SpaceBeforeScript < Linter
     include LinterRegistry
 
-    MESSAGE_FORMAT = 'The %s symbol should have one space separating it from code'.freeze
+    MESSAGE_FORMAT = 'The %s symbol should have one space separating it from code'
 
     ALLOWED_SEPARATORS = [' ', '#'].freeze
 

data/lib/haml_lint/linter/space_inside_hash_attributes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for spaces inside the braces of hash attributes
   # (e.g. `%tag{ lang: en }` vs `%tag{lang: en}`).

data/lib/haml_lint/linter/syntax.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # A catch-all linter for syntax violations raised by the Haml parser.
   class Linter::Syntax < Linter

data/lib/haml_lint/linter/tag_name.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for tag names with uppercase letters.
   class Linter::TagName < Linter

data/lib/haml_lint/linter/trailing_whitespace.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for trailing whitespace.
   class Linter::TrailingWhitespace < Linter

data/lib/haml_lint/linter/unnecessary_interpolation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Checks for unnecessary uses of string interpolation.
   #

data/lib/haml_lint/linter/unnecessary_string_output.rb

@@ -11,7 +11,7 @@ module HamlLint
   class Linter::UnnecessaryStringOutput < Linter
     include LinterRegistry
 
-    MESSAGE = '`= "..."` should be rewritten as `...`'.freeze
+    MESSAGE = '`= "..."` should be rewritten as `...`'
 
     def visit_tag(node)
       if tag_has_inline_script?(node) && inline_content_is_string?(node)

data/lib/haml_lint/linter/view_length.rb

@@ -1,17 +1,20 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Detects overly long views.
   class Linter::ViewLength < Linter
     include LinterRegistry
 
-    MSG = 'View template is too long [%d/%d]'.freeze
+    MSG = 'View template is too long [%d/%d]'
 
     DummyNode = Struct.new(:line)
 
-    def visit_root(_root)
+    def visit_root(root)
       max = config['max']
       line_count = document.source_lines.count
+      node = root.children.first
 
-      if line_count > max
+      if line_count > max && !node.disabled?(self)
         record_lint(DummyNode.new(0), format(MSG, line_count, max))
       end
     end

data/lib/haml_lint/linter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Base implementation for all lint checks.
   #
@@ -27,14 +29,14 @@ module HamlLint
       @lints = []
       visit(document.tree)
       @lints
-    rescue Parser::SyntaxError => ex
-      location = ex.diagnostic.location
+    rescue Parser::SyntaxError => e
+      location = e.diagnostic.location
       @lints <<
         HamlLint::Lint.new(
           HamlLint::Linter::Syntax.new(config),
           document.file,
           location.line,
-          ex.to_s,
+          e.to_s,
           :error
         )
     end

data/lib/haml_lint/linter_registry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   class NoSuchLinter < StandardError; end
 

data/lib/haml_lint/linter_selector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Chooses the appropriate linters to run given the specified configuration.
   class LinterSelector

data/lib/haml_lint/logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Encapsulates all communication to an output source.
   class Logger

data/lib/haml_lint/node_transformer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Responsible for transforming {Haml::Parser::ParseNode} objects into
   # corresponding {HamlLint::Tree::Node} objects.

data/lib/haml_lint/options.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'optparse'
 
 module HamlLint
@@ -24,10 +26,8 @@ module HamlLint
       @options[:files] = args.empty? ? ['.'] : args
 
       @options
-    rescue OptionParser::InvalidOption => ex
-      raise Exceptions::InvalidCLIOption,
-            ex.message,
-            ex.backtrace
+    rescue OptionParser::InvalidOption => e
+      raise Exceptions::InvalidCLIOption, e.message, e.backtrace
     end
 
     private
@@ -37,6 +37,11 @@ module HamlLint
         @options[:auto_gen_config] = true
       end
 
+      parser.on('--auto-gen-exclude-limit limit', Integer,
+                'Number of failures to allow in the TODO list before the entire rule is excluded') do |limit| # rubocop:disable Metrics/LineLength
+        @options[:auto_gen_exclude_limit] = limit
+      end
+
       parser.on('-i', '--include-linter linter,...', Array,
                 'Specify which linters you want to run') do |linters|
         @options[:included_linters] = linters

data/lib/haml_lint/parsed_ruby.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delegate'
 
 module HamlLint

data/lib/haml_lint/rake_task.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake'
 require 'rake/tasklib'
 require 'haml_lint/constants'
@@ -35,9 +37,18 @@ module HamlLint
     # @return [String]
     attr_accessor :name
 
-    # Configuration file to use.
+    # Set the configuration file or path.
+    #
+    # @param config [String,File]
+    def config=(config)
+      @config = config.is_a?(String) ? File.open(config, 'r') : config
+    end
+
+    # Return the configuration file path.
     # @return [String]
-    attr_accessor :config
+    def config
+      @config.path
+    end
 
     # List of files to lint (can contain shell globs).
     #
@@ -131,6 +142,7 @@ module HamlLint
     def parse_args
       cli_args = config ? ['--config', config] : []
       cli_args.concat(['--fail-level', fail_level]) if fail_level
+      cli_args
     end
   end
 end

data/lib/haml_lint/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Contains information about all lints detected during a scan.
   class Report

data/lib/haml_lint/reporter/checkstyle_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: false
+
 module HamlLint
   # Outputs report as an XML checkstyle document.
   class Reporter::CheckstyleReporter < Reporter

data/lib/haml_lint/reporter/default_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/reporter/utils'
 
 module HamlLint

data/lib/haml_lint/reporter/disabled_config_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/reporter/progress_reporter'
 
 module HamlLint
@@ -23,10 +25,11 @@ module HamlLint
     # Create the reporter that will display the report and write the config.
     #
     # @param _log [HamlLint::Logger]
-    def initialize(_log)
-      super
+    def initialize(log, limit: 15)
+      super(log)
       @linters_with_lints = Hash.new { |hash, key| hash[key] = [] }
       @linters_lint_count = Hash.new(0)
+      @exclude_limit = limit
     end
 
     # A hash of linters with the files that have that type of lint.
@@ -41,6 +44,11 @@ module HamlLint
     #   name list values
     attr_reader :linters_with_lints
 
+    # Number of offenses to allow before simply disabling the linter
+    #
+    # @return [Integer] file exclude limit
+    attr_reader :exclude_limit
+
     # Prints the standard progress reporter output and writes the new config file.
     #
     # @param report [HamlLint::Report]
@@ -97,7 +105,7 @@ module HamlLint
         output << "  #{linter}:"
         # disable the linter when there are many files with offenses.
         # exclude the affected files otherwise.
-        if files.count > 15
+        if files.count > exclude_limit
           output << '    enabled: false'
         else
           output << '    exclude:'

data/lib/haml_lint/reporter/hash_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Outputs report as a Ruby Hash for easy use by other tools.
   class Reporter::HashReporter < Reporter

data/lib/haml_lint/reporter/hooks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   class Reporter
     # A collection of hook methods for incremental processing.

data/lib/haml_lint/reporter/json_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/reporter/hash_reporter'
 
 module HamlLint

data/lib/haml_lint/reporter/progress_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rainbow'
 require 'haml_lint/reporter/utils'
 
@@ -7,7 +9,7 @@ module HamlLint
   class Reporter::ProgressReporter < Reporter
     include Reporter::Utils
 
-    DOT = '.'.freeze
+    DOT = '.'
 
     def display_report(report)
       lints = report.lints

data/lib/haml_lint/reporter/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   class Reporter
     # Formatting helpers for printing the default report format.

data/lib/haml_lint/reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/reporter/hooks'
 
 module HamlLint

data/lib/haml_lint/ruby_extractor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Utility class for extracting Ruby script from a HAML file that can then be
   # linted with a Ruby linter (i.e. is "legal" Ruby). The goal is to turn this:
@@ -122,7 +124,7 @@ module HamlLint
       visit_script(node, &block)
     end
 
-    def visit_filter(node) # rubocop:disable Metrics/AbcSize
+    def visit_filter(node)
       if node.filter_type == 'ruby'
         node.text.split("\n").each_with_index do |line, index|
           add_line(line, node.line + index + 1, false)

data/lib/haml_lint/ruby_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 require 'rubocop/ast/builder'
 require 'parser/current'

data/lib/haml_lint/runner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint
   # Responsible for running the applicable linters against the desired files.
   class Runner
@@ -57,12 +59,15 @@ module HamlLint
     # @param options [Hash]
     # @return [HamlLint::Configuration]
     def load_applicable_config(options)
-      if options[:config_file]
-        HamlLint::ConfigurationLoader.load_file(options[:config_file])
-      elsif options[:config]
+      if options[:config]
         options[:config]
+      elsif options[:auto_gen_config]
+        HamlLint::ConfigurationLoader.load_applicable_config(
+          options[:config_file],
+          exclude_files: [HamlLint::ConfigurationLoader::AUTO_GENERATED_FILE]
+        )
       else
-        HamlLint::ConfigurationLoader.load_applicable_config
+        HamlLint::ConfigurationLoader.load_applicable_config(options[:config_file])
       end
     end
 
@@ -75,9 +80,9 @@ module HamlLint
     def collect_lints(file, linter_selector, config)
       begin
         document = HamlLint::Document.new(File.read(file), file: file, config: config)
-      rescue HamlLint::Exceptions::ParseError => ex
+      rescue HamlLint::Exceptions::ParseError => e
         return [HamlLint::Lint.new(HamlLint::Linter::Syntax.new(config), file,
-                                   ex.line, ex.to_s, :error)]
+                                   e.line, e.to_s, :error)]
       end
 
       linter_selector.linters_for_file(file).map do |linter|

data/lib/haml_lint/severity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delegate'
 
 module HamlLint

data/lib/haml_lint/tree/comment_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # Represents a visible XHTML comment in a HAML document.
   class CommentNode < Node

data/lib/haml_lint/tree/doctype_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # Represents a doctype definition for a HAML document.
   class DoctypeNode < Node

data/lib/haml_lint/tree/filter_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # Represents a filter node which contains arbitrary code.
   class FilterNode < Node

data/lib/haml_lint/tree/haml_comment_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/directive'
 
 module HamlLint::Tree

data/lib/haml_lint/tree/node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/comment_configuration'
 
 module HamlLint::Tree
@@ -102,7 +104,10 @@ module HamlLint::Tree
     def line_numbers
       return (line..line) unless @value && text
 
-      (line..line + lines.count)
+      end_line = line + lines.count
+      end_line = nontrivial_end_line if line == end_line
+
+      (line..end_line)
     end
 
     # The previous node to be traversed in the tree.
@@ -124,7 +129,7 @@ module HamlLint::Tree
       next_sibling = siblings.next(self)
       return next_sibling if next_sibling
 
-      parent.successor if parent
+      parent&.successor
     end
 
     # Returns the next node that appears after this node in the document.
@@ -152,6 +157,19 @@ module HamlLint::Tree
 
     private
 
+    # Discovers the end line of the node when there are no lines.
+    #
+    # @return [Integer] the end line of the node
+    def nontrivial_end_line
+      if (last_child = children.last)
+        last_child.line_numbers.end - 1
+      elsif successor
+        successor.line_numbers.begin - 1
+      else
+        @document.source_lines.count
+      end
+    end
+
     # The siblings of this node within the tree.
     #
     # @api private

data/lib/haml_lint/tree/null_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # A null object version of a node that can be used as a safe default.
   class NullNode < Node

data/lib/haml_lint/tree/plain_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # Represents a node that contains plain text.
   class PlainNode < Node

data/lib/haml_lint/tree/root_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/tree/null_node'
 
 module HamlLint::Tree

data/lib/haml_lint/tree/script_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'haml_lint/parsed_ruby'
 
 module HamlLint::Tree

data/lib/haml_lint/tree/silent_script_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # Represents a HAML silent script node (`- some_expression`) which executes
   # code without producing output.

data/lib/haml_lint/tree/tag_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module HamlLint::Tree
   # Represents a tag node in a HAML document.
   class TagNode < Node # rubocop:disable ClassLength

data/lib/haml_lint/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pathname'
 
 module HamlLint

data/lib/haml_lint/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module HamlLint
-  VERSION = '0.28.0'.freeze
+  VERSION = '0.29.0'
 end

data/lib/haml_lint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Need to load haml before we can reference some Haml modules in our code
 require 'haml'
 

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: haml_lint
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.29.0
 platform: ruby
 authors:
-- Brigade Engineering
 - Shane da Silva
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-07 00:00:00.000000000 Z
+date: 2019-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: haml
@@ -95,7 +94,6 @@ dependencies:
         version: '1.1'
 description: Configurable tool for writing clean and consistent HAML
 email:
-- eng@brigade.com
 - shane@dasilva.io
 executables:
 - haml-lint
@@ -185,7 +183,7 @@ files:
 - lib/haml_lint/tree/tag_node.rb
 - lib/haml_lint/utils.rb
 - lib/haml_lint/version.rb
-homepage: https://github.com/brigade/haml-lint
+homepage: https://github.com/sds/haml-lint
 licenses:
 - MIT
 metadata: {}
@@ -197,15 +195,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: HAML lint tool