hamidashi 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4854e83ea5eda5c7c11a93809d4e29b629341ef2
-  data.tar.gz: 6c9c29df89bdbb83d1d87431c99545a927a8ede1
+  metadata.gz: 0a767e6d490ad96dfc9c40f3f89686dfd9e52361
+  data.tar.gz: 444bec65a0b05297c2faddf32175cef233c9e265
 SHA512:
-  metadata.gz: aa4fd40cf1fd8e55b47ebd7cb59a8b7343a06e651d8c36f5362c0093513aa8d77206d57c1de96b7d42161192bb07e66ca67b162e8da63b122c97a72da770062b
-  data.tar.gz: 35c8af4e294f9abaf05540cccab31161cc7d34a737e4d398c558ada7c0897ab3c9be87352d55fcedf2d3970f044d71d3671c0764223498ae4ceb1871e384c794
+  metadata.gz: 5e6c06b86b4e4cd05ae2f2e9325103061645671594a1ce3e2a482b1d7d137b861b54ac067523c6a27ff9b423006bfc15a9fa43be67bd4b2ef0f17fa71b5147f7
+  data.tar.gz: 209c92e74c6fe93a428377f7641ce7c35ccd0e6d7da5da153c42b5844c692544529f449e1cbdf8b9b1ee41a596bac7b68410c3553057c0992a24c983baec3c2b

data/.gitignore

@@ -8,3 +8,7 @@
 /spec/reports/
 /tmp/
 /vendor/bundle/
+
+test/fixtures/pdf-src/catalog.yml
+
+hamidashi-*/

data/.travis.yml

@@ -2,3 +2,7 @@ language: ruby
 rvm:
   - 2.2.2
 before_install: gem install bundler -v 1.10.3
+addons:
+  code_climate:
+    repo_token:
+      secure: "GrIzKIN/64aHJLjdD97p+iWYspGCAzGmIqqNmpxV+EUZLXxNFO/90Six8wT/T1wvWvIlhpjg9ive1mKjFuITqbiJZLmUxqvrXJcHqTWMDvdDKHpfB7ZL5FFcVXcAE0BfI6kn4/hBOOQ0QxkZUU+7oP7JxWueuFQenWlRi4F401kLN/wp+dxwT3SsyTNA9h+WI3+NaZx8WnJ9S4IP1ls0jYojdgIypFocSZnbW4Bq/oWg7HyckfyofEukBKFP7KeCNLvczr9spEqLb0x/HP+mIHo1mFREW+szsJQN4tIltTAstdBfb4hIgAZXCvI9Bg8QCLaDuo1dVG5a85Ozy0H1CLniK19KSghrMpq+FI2yA5R0uB8e8dNOwz8gYr3Sl0PRVvCWrzmVPSgZg9E3OXbz8UcKqGN/54qtxLQjeVFR8AIKPcwPP2FAkASGYl+Gq+0SBP1nN6JxQkKOom+UzQ9PxglLpV5X5+ysEgzEmAMz3+OpHF0zlMGRs+WE9RPplHiTYR31RsIo1Hn+TyMmz2apWUmeg5uoE/d9XSOVqKO4D4AUVczfgewJC82mMjKk9ggt9sX2sQd9KwUe11Jkh93ZbbhftjlUmBhAqUmkGe6Z5dZJ3ziSTdwOkGMfs3QV9ABMHTfJpWy4sLtXlW17IeCWcPN396v0uBL/FPb82Yb10Fs="

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in hamidashi.gemspec
 gemspec
+
+gem 'codeclimate-test-reporter', group: :test, require: nil

data/{LICENSE.txt → LICENSE.md}

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015 Seiei Miyagi
+Copyright © 2015 [YassLab](http://yasslab.jp)
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,4 +1,7 @@
 # Hamidashi
+[![Build Status](https://travis-ci.org/yasslab/hamidashi.svg?branch=master)](https://travis-ci.org/yasslab/hamidashi)
+[![Code Climate](https://codeclimate.com/github/yasslab/hamidashi/badges/gpa.svg)](https://codeclimate.com/github/yasslab/hamidashi)
+[![Test Coverage](https://codeclimate.com/github/yasslab/hamidashi/badges/coverage.svg)](https://codeclimate.com/github/yasslab/hamidashi/coverage)
 
 Detect PDF text overflow.
 
@@ -49,9 +52,11 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/hamidashi. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/yasslab/hamidashi. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](contributor-covenant.org) code of conduct.
 
 
 ## License
 
+Copyright © 2015 [YassLab](http://yasslab.jp)
+
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/Rakefile

@@ -1 +1,6 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
+
+Rake::TestTask.new
+
+task default: :test

data/exe/hamidashi

@@ -2,7 +2,6 @@
 require 'docopt'
 require 'fileutils'
 require 'hamidashi'
-require 'pdf/reader'
 require 'tmpdir'
 
 doc = <<DOCOPT
@@ -40,21 +39,21 @@ if opt['--version']
 end
 
 pdf_path  = File.expand_path(opt['<name>'])
-hamidashi = Hamidashi.new(Rational(opt['--margin']))
+hamidashi = Hamidashi.new(Rational(opt['--margin']), pdf_path)
 
 if opt['preview']
   preview_path = File.expand_path("hamidashi-preview-#{Time.now.strftime("%Y%m%d%H%M%S")}-" + File.basename(pdf_path, '.pdf') + "-#{opt['--page']}.png")
-  hamidashi.save_preview_page(pdf_path, opt['--page'], preview_path)
+  hamidashi.save_preview_page(Integer(opt['--page']), preview_path)
   exit
 end
 
 output_dir = File.expand_path("hamidashi-#{Time.now.strftime("%Y%m%d%H%M%S")}")
 
 Dir.mktmpdir('hamidashi') do |temp_dir|
-  (0...PDF::Reader.new(pdf_path).page_count).each do |page|
-    if hamidashi.overflow?(pdf_path, page)
+  (0...hamidashi.pdf_page_count).each do |page|
+    if hamidashi.overflow?(page)
       puts page
-      hamidashi.save_page(pdf_path, page, "#{temp_dir}/#{page}.png")
+      hamidashi.save_page(page, "#{temp_dir}/#{page}.png")
     end
   end
 

data/hamidashi.gemspec

@@ -26,9 +26,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "pdf-reader"
   spec.add_dependency "docopt"
+  spec.add_dependency "rmagick"
   spec.add_development_dependency "bundler", "~> 1.10"
+  spec.add_development_dependency "cucumber"
+  spec.add_development_dependency "minitest"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "review"
 end

data/lib/hamidashi.rb

@@ -1,46 +1,70 @@
 require "hamidashi/version"
-require "shellwords"
+require "RMagick"
 
 class Hamidashi
-  def initialize(percentage)
-    @crop_width = (width * percentage / 100).to_i
+  attr_reader :percentage
+
+  def initialize(percentage, pdf_path)
+    @percentage = percentage / 100r
+    @pdf_path   = pdf_path
+  end
+
+  def overflow?(page)
+    cropped_page_img = cropped_img(page)
+    colornum         = cropped_page_img.color_histogram.count
+
+    cropped_page_img.destroy!
+
+    expected_colornum != colornum
   end
 
-  def overflow?(pdf_path, page)
-    colornum=`convert -density 92 -geometry #{width} -crop #{crop} "#{pdf_path.shellescape}[#{page.to_s.shellescape}]" -format %c histogram:info: | wc -l`.to_i
-    colornum != expected_colornum
+  def save_page(page, path)
+    pdf_image_list[page].write(path)
   end
 
-  def save_page(pdf_path, page, path)
-    `convert -density 92 -geometry #{width} "#{pdf_path.shellescape}[#{page.to_s.shellescape}]" #{path.shellescape}`
+  def save_preview_page(page, path)
+    page_img = pdf_image_list[page].dup
+
+    draw_preview_frame(page).draw(page_img)
+
+    page_img.write(path)
+
+    page_img.destroy!
   end
 
-  def save_preview_page(pdf_path, page, path)
-    `convert -density 92 -geometry #{width} -fill "rgba(0, 255, 0, 50%)" -strokewidth 0 -draw "rectangle #{width - crop_width},#{height},#{width},0" "#{pdf_path.shellescape}[#{page.to_s.shellescape}]" #{path.shellescape}`
+  def pdf_page_count
+    pdf_image_list.count
   end
 
   private
 
   # TODO provide a way to set these config values
 
-  def crop
-    "#{crop_width}x+#{width - crop_width}+0"
+  def cropped_img(page)
+    page_img = pdf_image_list[page]
+    x        = right_margin_width(page)
+    page_img.crop(page_img.columns - x, 0, x, page_img.rows)
   end
 
-  def crop_width
-    @crop_width
+  def draw_preview_frame(page)
+    Magick::Draw.new.tap {|draw|
+      page_img = pdf_image_list[page]
+      draw.fill = 'rgba(0, 255, 0, 50%)'
+      draw.stroke_width(0)
+      draw.rectangle(page_img.columns - right_margin_width(page), 0, page_img.columns, page_img.rows)
+    }
   end
 
   def expected_colornum
     1
   end
 
-  # FIXME
-  def height
-    10000
+  def pdf_image_list
+    @pdf_image_list ||= Magick::ImageList.new(@pdf_path)
   end
 
-  def width
-    640
+  def right_margin_width(page)
+    page_img = pdf_image_list[page]
+    (page_img.columns * percentage).to_i
   end
 end

data/lib/hamidashi/version.rb

@@ -1,3 +1,3 @@
 class Hamidashi
-  VERSION = "0.1.4"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: hamidashi
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - Seiei Miyagi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-06-15 00:00:00.000000000 Z
+date: 2015-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: pdf-reader
+  name: docopt
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: docopt
+  name: rmagick
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -52,6 +52,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
+- !ruby/object:Gem::Dependency
+  name: cucumber
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: review
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - hanachin@gmail.com
@@ -92,7 +134,7 @@ files:
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
-- LICENSE.txt
+- LICENSE.md
 - README.md
 - Rakefile
 - bin/console