hamburglar 0.1.3 → 0.1.4

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 258377c2c9186334f0110e0568eb1e05068c4bbd
+  data.tar.gz: 9ee62c41ee572421a46c829c144f2e6e5757bc68
+SHA512:
+  metadata.gz: e70ff22a7b8c6846a0d8bb4a9e0348659447d18fae4175f89035f54fecbedd88f96542ebda3351aa78531122a792a36bd152a898286f55225c163df752d8c0cb
+  data.tar.gz: 9150c6a7b8e1341177d24744f75674267fa70c38b6500a4c9b61f4257706c3977c5429068eeb0ddb9fddaafc694c4fa9c3aaaa72c2d3d7352bcb23aa9bedea56

data/lib/hamburglar/gateways/base.rb

@@ -1,17 +1,9 @@
-require 'net/https'
-require 'cgi'
-
 module Hamburglar
   module Gateways
     # Hamburglar::Gateways::Base is the main class that handles sending API
     # requests to upstream providers. All other gateways should inherit from
     # this class
     class Base
-
-      # A regex for matching URLs with http or https
-      # This will be used to verify API urls
-      URL_REGEX = /https?:\/\/[\S]+/
-
       # The parameters for the API request
       attr_reader :params
 
@@ -32,15 +24,6 @@ module Hamburglar
         @response = {}
       end
 
-      # Get or set the API URL for the gateway
-      def self.set_api_url(url = '')
-        if url.match URL_REGEX
-          @api_url = url
-        else
-          raise Hamburglar::InvalidURL, url
-        end
-      end
-
       # Set required parameters for an API call
       def self.set_required_params(*params)
         @required_params = params
@@ -76,51 +59,10 @@ module Hamburglar
         validate || raise(Hamburglar::InvalidRequest)
       end
 
-      # Submit a request upstream to generate a fraud report
+      # Subclasses need to implement this.
       def submit
-        return false unless valid?
-        url = "#{self.class.api_url}?#{query_string}"
-        if res = fetch(url)
-          @response = parse_response(res.body)
-        end
-      end
-
-      private
-
-      # Formats @params into a query string for an HTTP GET request
-      def query_string
-        @params.map { |key, val| "#{key}=#{CGI.escape(val.to_s)}" }.join('&')
+        raise NotImplementedError
       end
-
-      # Parses raw data returned from an API call
-      #
-      # This method should be overwritten by any API subclasses that
-      # return data in a different format
-      #
-      # Returns [Hash]
-      def parse_response(raw = '')
-        data = raw.to_s.split(';').map do |line|
-          key, val = line.split('=')
-          if key.to_s != "" && val.to_s != ""
-            [key.to_sym, val]
-          else
-            next
-          end
-        end
-        Hash[data]
-      end
-
-      # Performs a GET request on the given URI, redirects if needed
-      def fetch(uri_str, limit = 10)
-        # You should choose better exception.
-        raise ArgumentError, 'HTTP redirect too deep' if limit == 0
-        Faraday.new(:url => uri_str, :ssl => {:verify => true, :ca_file => File.expand_path('../../../cacert.pem', __FILE__)}) do |c|
-          c.response :raise_error
-          c.response :follow_redirects, :limit => limit
-          c.adapter :net_http
-        end.get
-      end
-
     end
   end
 end

data/lib/hamburglar/gateways/max_mind.rb

@@ -1,15 +1,57 @@
+require 'faraday_middleware/response_middleware'
+
 module Hamburglar
   module Gateways
     # The MaxMind module contains classes for working
     # with MaxMind's minFraud and Telephone Verification APIs
     module MaxMind
+      class Base < ::Hamburglar::Gateways::Base
+        # Parses a MaxMind text response to a hash.
+        class ResponseParser < ::FaradayMiddleware::ResponseMiddleware
+          define_parser do |body|
+            unless body.strip.empty?
+              # MaxMind returns the response encoded with ISO-8859-1, so we normalize
+              # it to UTF-8.
+              # http://dev.maxmind.com/minfraud/#Output
+              body = body.force_encoding("ISO-8859-1").encode("UTF-8").split(';')
+
+              body.each_with_object({}) do |line, hash|
+                key, val = line.split('=')
+
+                if key.to_s != "" && val.to_s != ""
+                  hash[key.to_sym] = val
+                end
+              end
+            end
+          end
+        end
+
+        Faraday.register_middleware :response,
+          maxmind: ::Hamburglar::Gateways::MaxMind::Base::ResponseParser
+
+        # Submit a request upstream to generate a fraud report
+        def submit
+          if valid?
+            @response = Faraday.new(:url => self.class::API_URL, ssl: {
+              verify: true, ca_file: File.expand_path('../../../cacert.pem', __FILE__)
+            }) do |c|
+              c.request  :url_encoded
+              c.response :raise_error
+              c.response :follow_redirects, :limit => 10
+              c.response :maxmind
+              c.adapter :net_http
+            end.post(self.class::API_PATH, @params).body
+          end
+        end
+      end
+
       # The MinFraud class handles fraud verification
       # through MaxMind's minFraud API.
       #
       # See: http://www.maxmind.com/app/ccv
       class MinFraud < Base
-        # The MaxMind API URL
-        set_api_url "https://minfraud2.maxmind.com/app/ccv2r"
+        API_URL  = "https://minfraud2.maxmind.com"
+        API_PATH = "/app/ccv2r"
 
         # Required parameters for a minFraud API call
         set_required_params :i, :city, :region, :postal, :country, :license_key
@@ -25,8 +67,8 @@ module Hamburglar
       #
       # See: http://www.maxmind.com/app/telephone_api
       class TelephoneVerification < Base
-        # The MaxMind Telephone Verification API URL
-        set_api_url "https://www.maxmind.com/app/telephone_http"
+        API_URL  = "https://www.maxmind.com"
+        API_PATH = "/app/telephone_http"
 
         # Required parameters for a Telephone Verification API call
         set_required_params :l, :phone
@@ -36,7 +78,6 @@ module Hamburglar
           self.params[:l] = self.params.delete(:license_key) if self.params[:license_key]
         end
       end
-
     end
   end
 end

data/lib/hamburglar/version.rb

@@ -1,3 +1,3 @@
 module Hamburglar
-  VERSION = Version = '0.1.3'
+  VERSION = Version = '0.1.4'
 end

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: hamburglar
 version: !ruby/object:Gem::Version
-  version: 0.1.3
-  prerelease: 
+  version: 0.1.4
 platform: ruby
 authors:
 - Joshua Priddle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-08 00:00:00.000000000 Z
+date: 2013-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -117,37 +104,38 @@ files:
 - Rakefile
 - README.markdown
 - lib/cacert.pem
-- lib/hamburglar/config.rb
-- lib/hamburglar/errors.rb
+- lib/hamburglar/gateways.rb
 - lib/hamburglar/gateways/base.rb
 - lib/hamburglar/gateways/max_mind.rb
-- lib/hamburglar/gateways.rb
+- lib/hamburglar/errors.rb
 - lib/hamburglar/report.rb
+- lib/hamburglar/config.rb
 - lib/hamburglar/version.rb
 - lib/hamburglar.rb
 homepage: https://github.com/site5/hamburglar
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options:
 - --charset=UTF-8
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Hamburglar helps you prevent fraudulent orders
 test_files: []
+has_rdoc: