hal-client 3.17.0 → 3.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c738c6f35a8c627363d55bde0e10116bf46eb1b
-  data.tar.gz: 32b562905f475064e94fbf2128222292dc44bc4c
+  metadata.gz: 5d2c194b53f031309d1fa2380dddfd3496543ae0
+  data.tar.gz: de974dcd0f45301ad37dda8122dac62a1321628f
 SHA512:
-  metadata.gz: cf65e375001c9c167d557fe6345c58cdb07d5d70d63da052d7ce82392f9805002cbe6e91c703879fbe3f3c7cede65a2c88a74cf0943fa7fd4e825ad52541a263
-  data.tar.gz: 6749283d49cc6f3aa0ae7f37e5aeda09c08ad875d4206a8250fbac21200ca7afc09e42a6388bdd392bb8e667b88b574751771f1d6275e92892d725a663b9a9c9
+  metadata.gz: c0aba01ccd2098a6f324c6054645a8af63555ed468f12c428e4a9da09e9b4c48956c4006828869deda0083a513c531579a6d3c0dab9b9ce061f1c541b71dd060
+  data.tar.gz: b43cd1474e4121bb48eeda832b3c8cd54c2f4d5b1049510cb758298d410457f616715879b0f94d44cfc4474cfee3a360ac9d1fe6f9dec2f13705c67ad8097192

data/lib/hal_client/link.rb

@@ -56,6 +56,7 @@ class HalClient
 
       rel = hash_entry[:rel]
       hash_data = hash_entry[:data]
+      return nil unless hash_data['href']
       href = (base_url + hash_data['href']).to_s
 
       if hash_data['templated']

data/lib/hal_client/links_section.rb

@@ -50,6 +50,7 @@ class HalClient
     def resolve_to_url(link)
       (fail HalClient::InvalidRepresentationError) unless link.respond_to? :fetch
 
+      return nil unless link.fetch("href")
       url = base_url + link.fetch("href")
       is_templated = link.fetch("templated", false)
 

data/lib/hal_client/representation.rb

@@ -367,7 +367,7 @@ class HalClient
       default_proc ||= NO_LINK_FOUND
 
       relations = links.hrefs(link_rel) { MISSING }
-      return default_proc.call(link_rel, options) if relations == MISSING
+      return default_proc.call(link_rel, options) if relations == MISSING || relations.compact.empty?
 
       relations
         .map {|url_or_tmpl|

data/lib/hal_client/version.rb

@@ -1,3 +1,3 @@
 class HalClient
-  VERSION = "3.17.0"
+  VERSION = "3.17.1"
 end

data/spec/hal_client/link_spec.rb

@@ -49,6 +49,18 @@ RSpec.describe HalClient::Link do
                                                     base_url: base_url)
       expect(my_link.raw_href).to eq((base_url + relative_href_1).to_s)
     end
+
+    it "handles hrefs with a nil value" do
+      input_hash = link_entry_hash(href: nil)
+      base_url = Addressable::URI.parse(href_1)
+
+      my_link = described_class.new_from_link_entry(hash_entry: input_hash,
+                                                    hal_client: a_client,
+                                                    curie_resolver: curie_resolver,
+                                                    base_url: base_url)
+
+      expect(my_link.raw_href).to eq(base_url.to_s)
+    end
   end
 
   describe ".new_from_embedded_entry" do

data/spec/hal_client/links_section_spec.rb

@@ -30,6 +30,9 @@ RSpec.describe HalClient::LinksSection, "namespaces embedded" do
 
   specify { expect{section.hrefs("nonexistent")}.to raise_error KeyError }
 
+  specify { expect(section.hrefs("nil_href"))
+    .to contain_exactly nil }
+
   let(:fully_qualified_first_rel) { "http://rels.example.com/first" }
   let(:fully_qualified_second_rel) { "http://rels.example.com/2/second" }
 
@@ -45,6 +48,7 @@ RSpec.describe HalClient::LinksSection, "namespaces embedded" do
       "ns1:first" => {"href" => "http://example.com/foo"},
       "ns2:second" => [{"href" => "http://example.com/bar"},
                        {"href" => "http://example.com/baz"}],
+      "nil_href" => {"href" => nil},
       "next" => {"href" =>  "/foo?p=2"}
     } }
 

data/spec/hal_client/representation_spec.rb

@@ -11,6 +11,7 @@ RSpec.describe HalClient::Representation do
                 ,"templated": true }
     ,"link3": [{ "href": "http://example.com/link3-a" }
                ,{ "href": "http://example.com/link3-b" }]
+    ,"nil_link": { "href": null }
     ,"dup": { "href": "http://example.com/dup" }
   }
   ,"_embedded": {
@@ -301,6 +302,7 @@ HAL
 
   specify { expect(subject.has_related? "no-such-link-or-embed").to be false }
   specify { expect(subject.related? "no-such-link-or-embed").to be false }
+  specify { expect(subject.related? "nil_link").to be false }
 
   specify { expect(subject.to_json).to be_equivalent_json_to raw_repr }
   specify { expect(subject.to_hal).to be_equivalent_json_to raw_repr }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hal-client
 version: !ruby/object:Gem::Version
-  version: 3.17.0
+  version: 3.17.1
 platform: ruby
 authors:
 - Peter Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-08 00:00:00.000000000 Z
+date: 2016-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http