hal-client 3.14.0 → 3.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 19eeb7d4e250354bcc747d7c65e66540d9bd2461
-  data.tar.gz: 6623c0304f0bc356a99ce59e88f976e5564d8e43
+  metadata.gz: a02928e0fcb08ea201d51a1b76e3db118ea2efde
+  data.tar.gz: 51cf12b4ac3d35e742322d75ae86ca4a16f0f114
 SHA512:
-  metadata.gz: 4a125acaab0e6eb493977b9f916d6b4246ac590bc80f59a3e2867d34666b9b4d8d4722aad7909e6f1d5a42c6f67799c7af2db0df092601c55f3d5d8003374686
-  data.tar.gz: 504e9b1eb3a3b8e74ec0e956ff47b6803aadcf0520d42e268a782b6c3ed24c69dc558ae4ab69d8ca73de4163e3012349195761781a3ea73182b6dd6f5a85e898
+  metadata.gz: 72e1e77e6fdc336f0d66755aa598a66213f021cfca90554b98cba699b63a83dd9eb82fb267a906c5e00c55f35953491e8aee3be8bc934c11e79f1e5617d7c63d
+  data.tar.gz: 92fb2baaacfeca8b492e9c842a8cf5f9b9e77f29c76983918809895249a289058583b7cdece571d37fb5a054b0b09721315770b5d73f5c7c7a2ea01afc7f9580

data/lib/hal_client/link.rb

@@ -87,8 +87,8 @@ class HalClient
       rel = hash_entry[:rel]
       hash_data = hash_entry[:data]
 
-      absolute_href = (base_url + hash_data['_links']['self']['href']).to_s
-      hash_data['_links']['self']['href'] = absolute_href
+      explicit_url = self_href(hash_data)
+      hash_data['_links']['self']['href'] = (base_url + explicit_url).to_s if explicit_url
 
       Link.new(rel: rel,
                target: Representation.new(hal_client: hal_client, parsed_json: hash_data),
@@ -133,5 +133,14 @@ class HalClient
       [fully_qualified_rel, raw_href, templated?].hash
     end
 
+
+    protected
+
+    def self.self_href(embedded_repr)
+      embedded_repr
+        .fetch('_links', {})
+        .fetch('self', {})
+        .fetch('href', nil)
+    end
   end
 end

data/lib/hal_client/representation_editor.rb

@@ -29,6 +29,18 @@ class HalClient
       @orig_repr = a_representation
       @raw = raw
     end
+    protected :initialize
+
+    attr_reader :raw
+
+    # Returns true if this, or any previous, editor actually changed the hal
+    # representation.
+    def dirty?
+      new_repr = Representation.new(parsed_json: raw)
+
+      orig_repr.properties != new_repr.properties ||
+        orig_repr.all_links != new_repr.all_links
+    end
 
     # Returns the raw json representation of this representation
     def to_json
@@ -126,7 +138,7 @@ class HalClient
 
     protected
 
-    attr_reader :orig_repr, :raw
+    attr_reader :orig_repr
 
     def Array(thing)
       if Hash === thing

data/lib/hal_client/version.rb

@@ -1,3 +1,3 @@
 class HalClient
-  VERSION = "3.14.0"
+  VERSION = "3.15.0"
 end

data/spec/hal_client/representation_editor_spec.rb

@@ -13,6 +13,12 @@ RSpec.describe HalClient::RepresentationEditor do
   specify { expect(subject.to_hal).to be_equivalent_json_to raw_hal }
   specify { expect(subject.to_json).to be_equivalent_json_to raw_hal }
 
+  describe "#raw" do
+    it "returns parsed json representation of the altered HAL document" do
+      expect( subject.raw ).to eq a_repr.raw
+    end
+  end
+
   describe "#reject_links" do
     specify { expect(subject.reject_links("up")).not_to have_link "up" }
 
@@ -124,6 +130,52 @@ RSpec.describe HalClient::RepresentationEditor do
     end
   end
 
+  describe "#dirty?" do
+    specify "unchanged editors are clean" do
+      expect(subject.dirty?).to be false
+    end
+
+    specify "changing a property makes it dirty" do
+      expect(
+        subject.set_property("age", 11).dirty?
+      ).to be true
+    end
+
+    specify "setting a property to the existing value leaves it clean" do
+      expect(
+        subject.set_property("age", 10).dirty?
+      ).to be false
+    end
+
+    specify "removing a link makes it dirty" do
+      expect(
+        subject.reject_links("up").dirty?
+      ).to be true
+    end
+
+    specify "adding a link makes it dirty" do
+      expect(
+        subject.add_link("up", "http://example.com/new").dirty?
+      ).to be true
+    end
+
+    specify "removing and readding an existing link leaves it clean" do
+      expect(
+        subject
+          .reject_links("about")
+          .add_link("about", "http://example.com/another")
+          .dirty?
+      ).to be false
+    end
+
+    specify "removing a embedded makes it dirty" do
+      expect(
+        subject.reject_related("replies").dirty?
+      ).to be true
+    end
+
+  end
+
   # Background
 
   let(:hal_client) { HalClient.new }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hal-client
 version: !ruby/object:Gem::Version
-  version: 3.14.0
+  version: 3.15.0
 platform: ruby
 authors:
 - Peter Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-18 00:00:00.000000000 Z
+date: 2016-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -198,3 +198,4 @@ test_files:
 - spec/hal_client_spec.rb
 - spec/spec_helper.rb
 - spec/support/custom_matchers.rb
+has_rdoc: