hackernews 0.1.0 → 0.2.0

data/README.rdoc

@@ -10,16 +10,16 @@ This is a fairly simple Ruby class for accessing certain parts of Hacker News (h
 
 * Handles Hacker News session cookie and login.
 * Can retreive user page, along with karma and average karma values.
+* Can vote on posts and comments.
+* Can comment on posts and other comments.
 
 == To Do
 
-* Add ability to vote.
 * Add ability to post news.
-* Add ability to post comments.
 
 == Source Code
 
-    http://github.com/seven1m/hackernews
+http://github.com/seven1m/hackernews
 
 == Installation
 
@@ -32,6 +32,8 @@ This is a fairly simple Ruby class for accessing certain parts of Hacker News (h
     hn = HackerNews.new(USERNAME, PASSWORD)
     hn.karma # => '62'
     hn.average_karma # => '1.87'
+    hn.vote(123)
+    hn.comment(123, 'my comment')
     
 == Feedback
 

data/lib/hackernews.rb

@@ -4,34 +4,33 @@ require 'open-uri'
 
 class HackerNews
 
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 
   # Returns the version string for the library.
   def self.version
     VERSION
   end
 
-  BASE_URL = 'http://news.ycombinator.com'
-  USER_URL = 'http://news.ycombinator.com/user?id=%s'
+  BASE_URL           = "http://news.ycombinator.com"
+  ITEM_URL           = "#{BASE_URL}/item?id=%s"
+  USER_URL           = "#{BASE_URL}/user?id=%s"
+  LOGIN_SUBMIT_URL   = "#{BASE_URL}/y"
+  COMMENT_SUBMIT_URL = "#{BASE_URL}/r"
+  
+  class LoginError < RuntimeError; end
   
   # Creates a new HackerNews object.
   # Specify your username and password.
   def initialize(username, password)
-    login_url = open(BASE_URL).read.match(/href="([^"]+)">login<\/a>/)[1]
-    form_html = open(BASE_URL + login_url).read
-    submit_url = URI.parse(BASE_URL)
-    response = Net::HTTP.new(submit_url.host, submit_url.port).start do |http|
-      req = Net::HTTP::Post.new('/y')
-      req.set_form_data(
-        'fnid' => form_html.match(/<input type=hidden name="fnid" value="([^"]+)"/)[1],
-        'u'    => username,
-        'p'    => password
-      )
-      http.request(req)
-    end
-    @cookie = response.header['set-cookie']
+    login_url = get(BASE_URL).match(/href="([^"]+)">login<\/a>/)[1]
+    form_html = get(BASE_URL + login_url)
+    fnid = form_html.match(/<input type=hidden name="fnid" value="([^"]+)"/)[1]
+    response = post(LOGIN_SUBMIT_URL, 'fnid' => fnid, 'u' => username, 'p' => password)
     @username = username
     @password = password
+    unless @cookie = response.header['set-cookie']
+      raise LoginError, "Login credentials did not work."
+    end
   end
   
   # Retrieves the karma for the logged in user, or for the specified username (if given).
@@ -49,13 +48,53 @@ class HackerNews
     username ||= @username
     @user_pages ||= {}
     @user_pages[username] ||= begin
-      url = URI.parse(USER_URL % username)
+      get(USER_URL % username)
+    end
+  end
+  
+  # Up-vote on a post or on a comment by passing in the id number.
+  def vote(id)
+    url = get(ITEM_URL % id).match(/<a id=up_\d+ onclick="return vote\(this\)" href="(vote\?[^"]+)">/)[1]
+    get(BASE_URL + '/' + url)
+  end
+  
+  # Post a comment on a posted item or on another comment.
+  def comment(id, text)
+    fnid = get(ITEM_URL % id).match(/<input type=hidden name="fnid" value="([^"]+)"/)[1]
+    post(COMMENT_SUBMIT_URL, 'fnid' => fnid, 'text' => text)
+  end
+  
+  private
+  
+    def url_path_and_query(url)
+      if url.path and url.query
+        "#{url.path}?#{url.query}"
+      elsif url.path.to_s.any?
+        url.path
+      else
+        '/'
+      end
+    end
+  
+    def get(url)
+      url = URI.parse(url)
       response = Net::HTTP.start(url.host, url.port) do |http|
-        header = {'Cookie' => @cookie}
-        http.get(url.path + '?' + url.query, header)
+        http.get(url_path_and_query(url), build_header)
       end
       response.body
     end
-  end
+    
+    def post(url, data)
+      url = URI.parse(url)
+      Net::HTTP.new(url.host, url.port).start do |http|
+        req = Net::HTTP::Post.new(url.path, build_header)
+        req.set_form_data(data)
+        http.request(req)
+      end
+    end
+    
+    def build_header
+      @cookie && {'Cookie' => @cookie}
+    end
 
 end

data/test/hackernews_test.rb

@@ -12,10 +12,16 @@ class HackerNewsTest < Test::Unit::TestCase
     end
   end
 
-  def test_login
+  def test_session_cookie
     assert @hn.instance_eval('@cookie') =~ /user=[a-z0-9]+;/i
   end
   
+  def test_login_failure
+    assert_raise HackerNews::LoginError do
+      HackerNews.new('foobar00000', 'baz')
+    end
+  end
+  
   def test_karma
     assert @hn.karma.to_s != ''
     assert @hn.karma('pg').to_i > 59000

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: hackernews
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  prerelease: false
+  segments: 
+  - 0
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Tim Morgan
@@ -38,18 +43,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Ruby gem to login and interact with the Hacker News website.