hacker_term 0.0.3 → 0.0.4

data/data/data.json

@@ -299,6 +299,16 @@
          "title":"NextId",
          "url":"/news2",
          "description":"hn next id news2 "
-      }
+      },
+      {
+         "title": "Ask HN: Who is hiring? (January 2013)",
+         "url": "item?id=4992617",
+         "score": "175 points",
+         "user": "whoishiring",
+         "comments": "140 comments",
+         "time": "11 hours ago",
+         "item_id": "4992617",
+         "description": "175 points points by whoishiring 11 hours ago | 140 comments"
+       }
    ]
 }

data/lib/hacker_term/page_data.rb

@@ -16,6 +16,7 @@ module HackerTerm
       
       add_missing_keys!
       format_numbers!
+      format_urls!
       
       calculate_mean_score
       calculate_median_score
@@ -55,6 +56,10 @@ module HackerTerm
     def selected_url
       @data[@line_pos - 1]['url']
     end
+    
+    def selected_comments_url
+      "http://news.ycombinator.com/item?id=" + @data[@line_pos - 1]['item_id']
+    end
 
     private
 
@@ -108,5 +113,13 @@ module HackerTerm
         item['score'] = '0' unless item['score'].is_num?
       end
     end
+
+    def format_urls!
+      # Add HN domain for posts without an external link
+      @data.each do |item|
+        item['url'] = "http://news.ycombinator.com/#{item['url']}" if item['url'] =~ /^item\?id=[0-9]+/
+      end
+    end
+
   end
 end

data/lib/hacker_term/ui.rb

@@ -52,7 +52,8 @@ module HackerTerm
       output_divider(next_line_num) 
       attrset color_pair(1)
       output_line(next_line_num, "HACKER NEWS TERMINAL - thanks to http://hndroidapi.appspot.com") 
-      output_line(next_line_num, "COMMANDS: Select (Arrows), Open (O), Refresh (A) | Sort by Rank (R), Score (S), Comments (C), Title (T) | Quit (Q)")
+      output_line(next_line_num, "CMDS: Select (Arrows), Open Item (O), Open Item Discussion (D), Refresh (A)")
+      output_line(next_line_num, "CMDS CONT: Sort by Rank (R), Score (S), Comments (C), Title (T) | Quit (Q)")
       output_divider(next_line_num) 
 
       # Get width_excl_title, i.e. width of all columns + some extra for |'s and spacing.

data/lib/hacker_term/version.rb

@@ -1,3 +1,3 @@
 module HackerTerm
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/hacker_term.rb

@@ -35,7 +35,10 @@ module HackerTerm
           @page.change_line_pos :up
 
         when "O"
-          launch
+          open_link(@page.selected_url)
+          
+        when "D"
+          open_link(@page.selected_comments_url)
         
         when "A"
           load
@@ -63,13 +66,13 @@ module HackerTerm
 
     private
 
-    def launch
+    def open_link(url)
       # Attempts to launch a browser; writes URL to clipboard in any case
       begin
-        Launchy.open @page.selected_url # May not work in some Linux flavors
+        Launchy.open url # May not work in some Linux flavors
       rescue
       ensure
-        Clipboard.copy @page.selected_url
+        Clipboard.copy url
       end
     end
 

data/spec/page_data_spec.rb

@@ -57,17 +57,35 @@ module HackerTerm
       end
 
       it 'provides a mean' do
-        @page_data.mean_score.should == 194.19354838709677
+        @page_data.mean_score.should == 193.59375
       end
 
       it 'provides a median' do
-        @page_data.median_score.should == 131
+        @page_data.median_score.should == 135.0
       end
 
       it 'provides a mode' do
         @page_data.mode_score.should == 0
       end
     end
+    
+    describe 'formatting URLs' do
+      before(:each) do
+        @pg = HackerTerm::PageData.new File.read './data/data.json'
+      end
+      
+      it 'provides a URL for actual article' do
+        @pg.selected_url.should == "http://powwow.cc/"
+      end
+      
+      it 'provides a URL for article comments' do
+        @pg.selected_comments_url.should == "http://news.ycombinator.com/item?id=4924763"
+      end
+
+      it 'links to HN directly if URL is not absolute' do
+        @pg.data.last['url'].should == 'http://news.ycombinator.com/item?id=4992617'
+      end
+    end
 
     describe 'sorting' do
       before(:each) do

metadata

@@ -2,7 +2,7 @@
 name: hacker_term
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors: 
 - Ciaran Archer
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-01-01 00:00:00 Z
+date: 2013-01-03 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rest-client