h8 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ee6c0b2e2d9f2e6ee7c1baba1d2e5d5ff4bb82c
-  data.tar.gz: 1ce87dddfef9bc287f235c0bb31a69a03d32363c
+  metadata.gz: 7384caa28f422353e348519ea0f56f9869f8243f
+  data.tar.gz: ef389e8693081cf4c7173bbffd31e2127bcf978e
 SHA512:
-  metadata.gz: 511f1e2854ffccb6cb1d42b0ab7789bbd9173c31cf05a7d3fe24aba192d4fb2ad4dba6ba8039fc1b642312d2c138cbb8835bf47c2e36a1b3e736550771c470dd
-  data.tar.gz: 474499e5c938efd557c39de0383bbbc8d01b9b5a4eefe04fe86b66621b74de2edf6e41a6da96cdb551f083066f0fe355bebd0885d991ae9d6668320b59ec08b6
+  metadata.gz: ef76e195a1db60ca07987b46e5060830a73221c7e45daaf8e4fa8b8a8ab7540a25ed1f65740421cddeb19936d3abf8cd24f1a5ea5911292402c1f7b90b366875
+  data.tar.gz: 171b71959ebba1159e62c771a8f529d648307667770dbda0c03bfdaa106abb45c293bd5b7781ff9258abf286886d4e300ae20cc09bb875c6001861a033a784bc

data/README.md

@@ -38,19 +38,9 @@ uncaught javascript exceptions raise ruby error in ruby code.
 
 ## Main difference from therubyracer/features not ready
 
-The pity thing is, if we will Lock() the context on each call to it, the performance degradation
-will be notable and no matter whether you need threading with it. So, if you really need it, you
-wrap it with Mutex or whatever you want, without slowing down all the rest of us.
-
-- H8 is thread safe (users Lockers) but script is executed in the calling ruby thread without
-releasing gvl (other ruby threads can not perform on this core while javascript code runs).
-
-The same performance reason. If we release gvl on script start and reacquire it every time the ruby
-object, callback, class, whatever is referenced from JS, the execution will considerably degrade. As
-this gem is intended to let javascript/coffescript tightly integrate with ruby objects we have
-decided to not to slow down everything. If it is a problem, lets discuss it.
-
-- correct and accurate object tracking in both JS and Ruby VMs, GC aware.
+- H8 is thread safe (uses Lockers) but script is executed in the calling ruby thread without
+releasing gvl (other ruby threads can not perform on this core while javascript code runs). We are
+working on it, as simply releasing GVL and reacquring it may degrade performance.
 
 - labmda/proc passed as var to the context **does not receives first (this) argument
 automatically!**
@@ -76,7 +66,7 @@ when such a lambda needs javascript's this - but, no problem, pass it this, or w
 you need ;)
 
 - there is no 'Context object initialization' - it does not work well in rubyracer so it is not
-likely used widely. We can add it later, though.
+likely used widely. We can add it later, though - if you need it, add an issue.
 
 
 

data/ext/h8/h8.cpp

@@ -105,8 +105,7 @@ h8::H8::~H8() {
 			// this should also remove it from the list:
 			resources.peek_first<AllocatedResource>()->free();
 		}
+		persistent_context.Reset();
 	}
-
-	persistent_context.Reset();
 	isolate->Dispose();
 }

data/ext/h8/js_gate.h

@@ -184,6 +184,11 @@ public:
 	virtual void free() {
 		persistent_value.Reset();
 		AllocatedResource::free();
+		h8 = 0;
+	}
+
+	virtual void rb_mark_gc() {
+		rb_gc_mark(h8->ruby_context());
 	}
 
 	virtual Local<Value> value() const {
@@ -195,7 +200,13 @@ public:
 	}
 
 	virtual ~JsGate() {
-		persistent_value.Reset();
+		if( h8 ) {
+			Locker l(h8->getIsolate());
+			persistent_value.Reset();
+		}
+		else {
+			persistent_value.Reset();
+		}
 	}
 
 private:

data/ext/h8/main.cpp

@@ -34,7 +34,7 @@ static void rvalue_free(void* ptr) {
 
 static void rvalue_mark(void* ptr) {
 	JsGate *gate = (JsGate*) ptr;
-	rb_gc_mark(gate->ruby_context());
+	gate->rb_mark_gc();
 }
 
 VALUE rvalue_alloc(VALUE klass) {

data/lib/h8/version.rb

@@ -1,3 +1,3 @@
 module H8
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: h8
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - sergeych
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-29 00:00:00.000000000 Z
+date: 2014-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler